Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote: /trunk/main/rtp_engine.c, line 2193 https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193 Yeah, put this in the 96-127 rang instead. Wouldn't that cause ast_rtp_engine_load_format() to fail because no dynamic rtp mapping is available? - Scott --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14028 --- On Dec. 19, 2014, 2:24 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 19, 2014, 2:24 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
On Dec. 23, 2014, 1:41 p.m., Joshua Colp wrote: /trunk/main/rtp_engine.c, line 2193 https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193 Yeah, put this in the 96-127 rang instead. Scott Griepentrog wrote: Wouldn't that cause ast_rtp_engine_load_format() to fail because no dynamic rtp mapping is available? I don't understand the question? There are unused payloads in the 96-127 range, I'd stick to that range for the reason oej provided as well as because I would not be surprised for implementations to consider that THE dynamic range and potentially have trouble outside of it. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14028 --- On Dec. 19, 2014, 8:24 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 19, 2014, 8:24 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 12:06 p.m.) Review request for Asterisk Developers. Changes --- Addressed Josh's findings. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs (updated) - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote: /trunk/main/rtp_engine.c, line 2193 https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193 Yeah, put this in the 96-127 rang instead. Scott Griepentrog wrote: Wouldn't that cause ast_rtp_engine_load_format() to fail because no dynamic rtp mapping is available? Joshua Colp wrote: I don't understand the question? There are unused payloads in the 96-127 range, I'd stick to that range for the reason oej provided as well as because I would not be surprised for implementations to consider that THE dynamic range and potentially have trouble outside of it. I was incorrect. There are other available payload numbers in the range. - Scott --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14028 --- On Dec. 31, 2014, 12:06 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 12:06 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14061 --- Ship it! Ship It! - Joshua Colp On Dec. 31, 2014, 6:06 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 6:06 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 12:54 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 430164 Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14028 --- /trunk/main/rtp_engine.c https://reviewboard.asterisk.org/r/4286/#comment24538 Yeah, put this in the 96-127 rang instead. - Joshua Colp On Dec. 19, 2014, 8:24 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 19, 2014, 8:24 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14021 --- You may want to consider fixing RFC 5761 restrictions while you are in there... This prepares for RTP/RTCP muxing in WebRTC Given these constraints, it is RECOMMENDED to follow the guidelines in the RTP/AVP profile [7] for the choice of RTP payload type values, with the additional restriction that payload type values in the range 64-95 MUST NOT be used. Specifically, dynamic RTP payload types SHOULD be chosen in the range 96-127 where possible. Values below 64 MAY be used if that is insufficient, in which case it is RECOMMENDED that payload type numbers that are not statically assigned by [7] be used first. - Olle E Johansson On Dec. 19, 2014, 9:24 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 19, 2014, 9:24 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24367 https://issues.asterisk.org/jira/browse/ASTERISK-24367 Repository: Asterisk Description --- Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits. During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c). This assert will be hit if a call is placed to a pjsip endpoint with allow=all set. To avoid this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
