Re: [asterisk-dev] [Code Review] 4595: Voicemail API: fix handling of mailbox full condition
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4595/#review15101 --- Ship it! Ship It! - Mark Michelson On April 6, 2015, 8:20 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4595/ --- (Updated April 6, 2015, 8:20 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24942 https://issues.asterisk.org/jira/browse/ASTERISK-24942 Repository: Asterisk Description --- In r115582 (2008), the ERROR_MAILBOX_FULL flag was removed, and a check of the save_to_folder result no longer handled the mailbox full condition. This lead to the deletion of a new Inbox message, once played, that could not be relocated to the Old mailbox because of the maxmsg limit. This patch restores the original functionality lost, which is to leave the message in the Inbox without deleting it. Diffs - /branches/11/apps/app_voicemail.c 434135 Diff: https://reviewboard.asterisk.org/r/4595/diff/ Testing --- Tested manually on my system under Asterisk 13. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4595: Voicemail API: fix handling of mailbox full condition
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4595/ --- (Updated April 7, 2015, 2:34 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 434260 Bugs: ASTERISK-24942 https://issues.asterisk.org/jira/browse/ASTERISK-24942 Repository: Asterisk Description --- In r115582 (2008), the ERROR_MAILBOX_FULL flag was removed, and a check of the save_to_folder result no longer handled the mailbox full condition. This lead to the deletion of a new Inbox message, once played, that could not be relocated to the Old mailbox because of the maxmsg limit. This patch restores the original functionality lost, which is to leave the message in the Inbox without deleting it. Diffs - /branches/11/apps/app_voicemail.c 434135 Diff: https://reviewboard.asterisk.org/r/4595/diff/ Testing --- Tested manually on my system under Asterisk 13. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
