Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 10, 2015, 1:11 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and mattjordan. Changes --- Committed in revision 432695 Bugs: ASTERISK-24786 https://issues.asterisk.org/jira/browse/ASTERISK-24786 Repository: Asterisk Description --- Asterisk terminates when playing a voicemail stored in LDAP Diffs - http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 Diff: https://reviewboard.asterisk.org/r/4459/diff/ Testing --- Tested against Microsoft Exchange 2007 Thanks, Graham Barnett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/#review14609 --- Ship it! Ship It! - Mark Michelson On March 4, 2015, 9:07 p.m., Graham Barnett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 4, 2015, 9:07 p.m.) Review request for Asterisk Developers and mattjordan. Bugs: ASTERISK-24786 https://issues.asterisk.org/jira/browse/ASTERISK-24786 Repository: Asterisk Description --- Asterisk terminates when playing a voicemail stored in LDAP Diffs - http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 Diff: https://reviewboard.asterisk.org/r/4459/diff/ Testing --- Tested against Microsoft Exchange 2007 Thanks, Graham Barnett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/#review14589 --- http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25137 guidelines: C++ comments are not allowed http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25138 guidelines: Curly needs to be on same line as the if. http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25139 guidelines: C++ comment - rmudgett On March 4, 2015, 2:51 a.m., Graham Barnett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 4, 2015, 2:51 a.m.) Review request for Asterisk Developers and mattjordan. Bugs: ASTERISK-24786 https://issues.asterisk.org/jira/browse/ASTERISK-24786 Repository: Asterisk Description --- Asterisk terminates when playing a voicemail stored in LDAP Diffs - http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 Diff: https://reviewboard.asterisk.org/r/4459/diff/ Testing --- Tested against Microsoft Exchange 2007 Thanks, Graham Barnett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/#review14588 --- http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25134 Shouldn't mix declaration and code. Move the declaration to the top of the function. Also, whitespace issue before and after. http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25135 Whitespace http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25136 Shouldn't mix declaration and code. - George Joseph On March 4, 2015, 1:51 a.m., Graham Barnett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 4, 2015, 1:51 a.m.) Review request for Asterisk Developers and mattjordan. Bugs: ASTERISK-24786 https://issues.asterisk.org/jira/browse/ASTERISK-24786 Repository: Asterisk Description --- Asterisk terminates when playing a voicemail stored in LDAP Diffs - http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 Diff: https://reviewboard.asterisk.org/r/4459/diff/ Testing --- Tested against Microsoft Exchange 2007 Thanks, Graham Barnett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 4, 2015, 8:20 p.m.) Review request for Asterisk Developers and mattjordan. Changes --- Fixed whitespace, use of C++ style comments, curly brace on same line as if Bugs: ASTERISK-24786 https://issues.asterisk.org/jira/browse/ASTERISK-24786 Repository: Asterisk Description --- Asterisk terminates when playing a voicemail stored in LDAP Diffs (updated) - http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 Diff: https://reviewboard.asterisk.org/r/4459/diff/ Testing --- Tested against Microsoft Exchange 2007 Thanks, Graham Barnett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/#review14592 --- You should compile in dev mode to catch all code warnings: ./configure --enable-dev-mode Developer mode will not compile if there are any code warnings. This would have caught the declarations within code. http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25142 Didn't get all the red blobs. http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25143 guidelines: Declarations only at beginning of code blocks. - rmudgett On March 4, 2015, 2:20 p.m., Graham Barnett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 4, 2015, 2:20 p.m.) Review request for Asterisk Developers and mattjordan. Bugs: ASTERISK-24786 https://issues.asterisk.org/jira/browse/ASTERISK-24786 Repository: Asterisk Description --- Asterisk terminates when playing a voicemail stored in LDAP Diffs - http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 Diff: https://reviewboard.asterisk.org/r/4459/diff/ Testing --- Tested against Microsoft Exchange 2007 Thanks, Graham Barnett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 4, 2015, 9:07 p.m.) Review request for Asterisk Developers and mattjordan. Changes --- Move another defn to start of file and remove another tab .. curiously the diff shows me removing a pre-existing tab/ whitespace Bugs: ASTERISK-24786 https://issues.asterisk.org/jira/browse/ASTERISK-24786 Repository: Asterisk Description --- Asterisk terminates when playing a voicemail stored in LDAP Diffs (updated) - http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 Diff: https://reviewboard.asterisk.org/r/4459/diff/ Testing --- Tested against Microsoft Exchange 2007 Thanks, Graham Barnett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
