Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Leif Neland wrote: I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. Forgive me for the question, but /why/ do you want this behaviour? Isn't the whole point of dialling multiple extensions so that a call has a greater chance of being answered? ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Hi! Would be a very nice feature for example the following scenario: Me has 2 phones, one ordinary SIP phone attached to the SIP server and one Cell phone. If someone calls my extension it will ring in both, but if I talk in for example the SIP phone I dont want it to ring on my cell phone. I sure hope it will be implementet. On Tue, 01 Dec 2009 21:35:11 +1100, Rob Hillis wrote: Leif Neland wrote: I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. Forgive me for the question, but /why/ do you want this behaviour? Isn't the whole point of dialling multiple extensions so that a call has a greater chance of being answered? ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. Forgive me for the question, but /why/ do you want this behaviour? Isn't the whole point of dialling multiple extensions so that a call has a greater chance of being answered? Yes, but I think it's still a valuable option. Suppose the idea isn't to reach one of a number of people, but to reach one PERSON, who may have multiple extensions (e.g., home and office). If his home number is busy, that means he's at home, so there's no point in ringing phones looking for him elsewhere since you won't get him (and maay disturb others around his other extensions). ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Rob Hillis wrote: Leif Neland wrote: I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. Forgive me for the question, but /why/ do you want this behaviour? Isn't the whole point of dialling multiple extensions so that a call has a greater chance of being answered? Because I might have more phones than mouths :-) If I'm busy with one conversation, I don't want to hear another phone ring. I might have a desktop and a portable phone. There were a similar wish for queues a month ago or so: Given an office/warehouse/home with several phones, but fewer persons. Queue should only have so many active calls at the same time; eg two persons in the office, 5 phones. two calls come in, ringing every phone, two calls gets picked up. Third incomming call stays in queue until one conversation is terminated. Leif ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Magnus Benngård wrote: Hi! Would be a very nice feature for example the following scenario: Me has 2 phones, one ordinary SIP phone attached to the SIP server and one Cell phone. If someone calls my extension it will ring in both, but if I talk in for example the SIP phone I dont want it to ring on my cell phone. On Tue, 01 Dec 2009 21:35:11 +1100, Rob Hillis r...@hillis.dyndns.org wrote: Leif Neland wrote: I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. Forgive me for the question, but /why/ do you want this behaviour? Isn't the whole point of dialling multiple extensions so that a call has a greater chance of being answered? ___ I sure hope it will be implementet. Just need somebody a little more fluent in C than me, to fix the parameter-stuff :-) Leif -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Leif Neland wrote: I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. In order to have your patch considered at all, you will need to file an issue in the issue tracker and attach your file to it after signing the license agreement. Otherwise, the developers (at least at Digium) won't look at the code or be able to offer any feedback. Thanks! Leif Madsen. ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Leif Neland le...@neland.dk writes: Because I might have more phones than mouths :-) If I'm busy with one conversation, I don't want to hear another phone ring. I might have a desktop and a portable phone. This use case is indeed very difficult to implement in Asterisk dial plans today. Especially if you add the phones to queues. The only way is through Local(), but Local() in a queue has nasty side effects which I have expounded on in other threads... I hope you have luck in getting the patch fixed and accepted. With that done there are only a few more things to fix before we can do away with Local() in Queue(). /Benny ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Leif Madsen wrote: Leif Neland wrote: I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. In order to have your patch considered at all, you will need to file an issue in the issue tracker and attach your file to it after signing the license agreement. Otherwise, the developers (at least at Digium) won't look at the code or be able to offer any feedback. I didn't think the patch was ready to submit to the issue tracker, before it was working... And right now, I don't understand how to read an option flag, it seems. Leif ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Patch for app_dial.c: exit when just one ext is busy.
Leif Neland wrote: Leif Madsen wrote: Leif Neland wrote: I made a patch to app_dial.c to make Dial(ext1ext2ext3,tumeout,B) return busy when just one extension is busy. In order to have your patch considered at all, you will need to file an issue in the issue tracker and attach your file to it after signing the license agreement. Otherwise, the developers (at least at Digium) won't look at the code or be able to offer any feedback. I didn't think the patch was ready to submit to the issue tracker, before it was working... And right now, I don't understand how to read an option flag, it seems. No, go ahead and submit it to the issue tracker and it will have the status set to Confirmed which means there is a patch, but that it still required work before it can be moved to the Ready for Testing status. As soon as you have a patch that you are continuing to work on, but which needs feedback, you should submit it to the issue tracker so that it can be looked at by the community and feedback on the patch directly be put into the tracker. Thanks! Leif Madsen. ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
