Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: modify TT_RESPONSE-full-table format

2011-06-01 Thread Antonio Quartulli 
On mer, giu 01, 2011 at 07:34:25 +0200, Andrew Lunn wrote:
  +   ssize_t tt_query_size = sizeof(struct tt_query_packet);
  +   int i;
  +
  +   if (sizeof(struct tt_query_packet) + tt_len 
  +   primary_if-soft_iface-mtu) {
  +   tt_len = primary_if-soft_iface-mtu - tt_query_size;
  +   tt_len -= tt_len % sizeof(struct tt_change);
  +   }
 
 Hi Antonio
 
 This first struck me as being asymmetric. Then i say that
 tt_query_size is sizeof(struct tt_query_packet). So use it in the if
 statement, and then symmetry is restored and probably the indentation
 looks better.

Oh, thanks Andrew! I'm going to fix it

 
   Andrew

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto Che Guevara

Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: modify TT_RESPONSE-full-table format

2011-05-31 Thread Andrew Lunn 
 + ssize_t tt_query_size = sizeof(struct tt_query_packet);
 + int i;
 +
 + if (sizeof(struct tt_query_packet) + tt_len 
 + primary_if-soft_iface-mtu) {
 + tt_len = primary_if-soft_iface-mtu - tt_query_size;
 + tt_len -= tt_len % sizeof(struct tt_change);
 + }

Hi Antonio

This first struck me as being asymmetric. Then i say that
tt_query_size is sizeof(struct tt_query_packet). So use it in the if
statement, and then symmetry is restored and probably the indentation
looks better.

  Andrew