Re: [BBDB] ChangeLog 2014-05-06

2014-06-12 Thread Roland Winkler
On Thu Jun 12 2014 Barak A. Pearlmutter wrote:
> I'd check for the function. Seems more robust.

Agreed.

--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: [BBDB] ChangeLog 2014-05-06

2014-06-12 Thread Eric Abrahamsen
Eric Abrahamsen  writes:

> "Barak A. Pearlmutter"  writes:
>
>> I'd check for the function. Seems more robust. (E.g., if someone forks
>> an older version and updates the date string, or if the function is
>> renamed or removed in the future.) If there's a bug you need to check
>> for you can always complicate the guard later.
>>
>> --Barak.
>
> Fair enough! I'll give it a crack that way for now.

Just FYI, here's what I made on top of the new allowance for lisp forms
in xfields: a custom field that stores links to recent messages from the
contact. This is a first draft and likely buggy, but I'm pretty pleased
with how well it works out of the box.

https://github.com/girzel/gnorb/commit/a083a9996e88d5c2378f25cb0b4185e55b2ee84a


--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: [BBDB] ChangeLog 2014-05-06

2014-06-12 Thread Eric Abrahamsen
"Barak A. Pearlmutter"  writes:

> I'd check for the function. Seems more robust. (E.g., if someone forks
> an older version and updates the date string, or if the function is
> renamed or removed in the future.) If there's a bug you need to check
> for you can always complicate the guard later.
>
> --Barak.

Fair enough! I'll give it a crack that way for now.

Thanks,
Eric


--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: [BBDB] ChangeLog 2014-05-06

2014-06-12 Thread Barak A. Pearlmutter
I'd check for the function. Seems more robust. (E.g., if someone forks
an older version and updates the date string, or if the function is
renamed or removed in the future.) If there's a bug you need to check
for you can always complicate the guard later.

--Barak.

--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: [BBDB] ChangeLog 2014-05-06

2014-06-11 Thread Eric Abrahamsen
"Roland Winkler"  writes:

> (1) BBDB now allows arbitrary lisp expressions as values of
> xfields.  Interactively, you can call bbdb-insert-field or
> bbdb-edit-field with a prefix arg for this.  If the value of an
> xfield is not a string, it is displayed using the same
> pretty-printer used by describe-variable.
>
> There might still be some rough edges with this new feature that
> I have overlooked.  Please report them here.

The functionality I wanted this for is pretty much done -- it all works
nicely, thank you! Now I need to shield some stuff from users who don't
aren't using the git version of BBDB. Is there a best practice in this
case? The options I can think of are:

1. check if the new function `bbdb-record-xfield-string' is bound, since
that's new here
2. check if `bbdb-version-date' is after May 6, 2014.

I'm leaning towards the date check, since that will give finer control
if some bugs are discovered and fixed later.

Thanks,
Eric


--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: [BBDB] ChangeLog 2014-05-06

2014-05-06 Thread Eric Abrahamsen
"Roland Winkler"  writes:

> (1) BBDB now allows arbitrary lisp expressions as values of
> xfields.  Interactively, you can call bbdb-insert-field or
> bbdb-edit-field with a prefix arg for this.  If the value of an
> xfield is not a string, it is displayed using the same
> pretty-printer used by describe-variable.
>
> There might still be some rough edges with this new feature that
> I have overlooked.  Please report them here.

Very cool! Thanks!

> (2) Do not treat bbdb-change-hook special when inside
> bbdb-notice-mail-hook or bbdb-notice-record-hook.
>
>
> 2014-05-06  Roland Winkler  
>   Do not treat bbdb-change-hook special when inside
>   bbdb-notice-mail-hook or bbdb-notice-record-hook.
>   * lisp/bbdb.el (bbdb-notice-mail-hook, bbdb-notice-record-hook):
>   Update docstring.
>   (bbdb-notice-hook-pending): Remove.
>   (bbdb-change-record): Always call bbdb-change-hook if a record was
>   changed.
>   * lisp/bbdb-mua.el (bbdb-update-records, bbdb-annotate-message):
>   Change accordingly.
>
> 2014-05-06  Roland Winkler  
>   Allow arbitrary lisp expressions as values of xfields.
>   * lisp/bbdb.el (bbdb-record-type): Update accordingly.
>   (bbdb-string-trim): New optional arg null.
>   (bbdb-record-xfield-intern): Return xfield value unmodified if it
>   is not a string.
>   (bbdb-record-xfield-string): New function.
>   (bbdb-record-xfield-split): Throw error if xfield value is not a
>   string.
>   (bbdb-record-set-xfield, bbdb-record-set-field)
>   (bbdb-merge-xfield, bbdb-display-record-one-line)
>   (bbdb-display-record-multi-line)
>   * lisp/bbdb-com.el (bbdb-search, bbdb-read-field)
>   (bbdb-edit-field, bbdb-read-xfield): Allow xfield values that are
>   not a string.
>   (bbdb-add-mail-alias): Simplify.
>
> 2014-05-06  Roland Winkler  
>   * lisp/bbdb.el (bbdb-parse-postcode): Finish immediately if one
>   test succeeds.
>
>
> BBDB is available at
> http://savannah.nongnu.org/projects/bbdb/
>
> --
> Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
> • 3 signs your SCM is hindering your productivity
> • Requirements for releasing software faster
> • Expert tips and advice for migrating your SCM now
> http://p.sf.net/sfu/perforce
> ___
> bbdb-info@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bbdb-info
> BBDB Home Page: http://bbdb.sourceforge.net/


--
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for releasing software faster
• Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


[BBDB] ChangeLog 2014-05-06

2014-05-06 Thread Roland Winkler
(1) BBDB now allows arbitrary lisp expressions as values of
xfields.  Interactively, you can call bbdb-insert-field or
bbdb-edit-field with a prefix arg for this.  If the value of an
xfield is not a string, it is displayed using the same
pretty-printer used by describe-variable.

There might still be some rough edges with this new feature that
I have overlooked.  Please report them here.

(2) Do not treat bbdb-change-hook special when inside
bbdb-notice-mail-hook or bbdb-notice-record-hook.


2014-05-06  Roland Winkler  
Do not treat bbdb-change-hook special when inside
bbdb-notice-mail-hook or bbdb-notice-record-hook.
* lisp/bbdb.el (bbdb-notice-mail-hook, bbdb-notice-record-hook):
Update docstring.
(bbdb-notice-hook-pending): Remove.
(bbdb-change-record): Always call bbdb-change-hook if a record was
changed.
* lisp/bbdb-mua.el (bbdb-update-records, bbdb-annotate-message):
Change accordingly.

2014-05-06  Roland Winkler  
Allow arbitrary lisp expressions as values of xfields.
* lisp/bbdb.el (bbdb-record-type): Update accordingly.
(bbdb-string-trim): New optional arg null.
(bbdb-record-xfield-intern): Return xfield value unmodified if it
is not a string.
(bbdb-record-xfield-string): New function.
(bbdb-record-xfield-split): Throw error if xfield value is not a
string.
(bbdb-record-set-xfield, bbdb-record-set-field)
(bbdb-merge-xfield, bbdb-display-record-one-line)
(bbdb-display-record-multi-line)
* lisp/bbdb-com.el (bbdb-search, bbdb-read-field)
(bbdb-edit-field, bbdb-read-xfield): Allow xfield values that are
not a string.
(bbdb-add-mail-alias): Simplify.

2014-05-06  Roland Winkler  
* lisp/bbdb.el (bbdb-parse-postcode): Finish immediately if one
test succeeds.


BBDB is available at
http://savannah.nongnu.org/projects/bbdb/

--
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for releasing software faster
• Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/