svn commit: r897671 - /jakarta/bcel/trunk/pom.xml
Author: tcurdt Date: Sun Jan 10 18:01:06 2010 New Revision: 897671 URL: http://svn.apache.org/viewvc?rev=897671view=rev Log: fixed up the plugins Modified: jakarta/bcel/trunk/pom.xml Modified: jakarta/bcel/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/pom.xml?rev=897671r1=897670r2=897671view=diff == --- jakarta/bcel/trunk/pom.xml (original) +++ jakarta/bcel/trunk/pom.xml Sun Jan 10 18:01:06 2010 @@ -138,7 +138,6 @@ /snapshotRepository site idwebsite/id -!-- urlscpexe://people.apache.org/www/jakarta.apache.org/bcel/url -- urlscpexe://people.apache.org/home/${USER}/public_html/websites/bcel/url /site /distributionManagement @@ -207,64 +206,36 @@ /reportSet /reportSets /plugin -!-- + plugin +groupIdorg.apache.maven.plugins/groupId artifactIdmaven-javadoc-plugin/artifactId +version2.6.1/version /plugin plugin -artifactIdmaven-pmd-plugin/artifactId -/plugin -plugin +groupIdorg.apache.maven.plugins/groupId artifactIdmaven-surefire-report-plugin/artifactId -version2.0/version -/plugin -plugin -groupIdorg.codehaus.mojo/groupId -artifactIdjxr-maven-plugin/artifactId -/plugin -plugin -groupIdorg.codehaus.mojo/groupId -artifactIdtaglist-maven-plugin/artifactId -version2.0/version -configuration -tags -tagTODO/tag -tag@todo/tag -tagFIXME/tag -tag@deprecated/tag -/tags -/configuration -/plugin -plugin -groupIdorg.codehaus.mojo/groupId -artifactIdfindbugs-maven-plugin/artifactId -version1.1.1/version +version2.4.3/version /plugin plugin groupIdorg.apache.maven.plugins/groupId -artifactIdmaven-changes-plugin/artifactId -version2.0-beta-3/version -reportSets -reportSet -reports -reportchanges-report/report -/reports -/reportSet -/reportSets +artifactIdmaven-jxr-plugin/artifactId +version2.1/version /plugin +!-- plugin groupIdorg.codehaus.mojo/groupId artifactIdjardiff-maven-plugin/artifactId configuration - diffs -diff + artifacts +artifact version5.2/version -/diff -diff +/artifact +artifact groupIdbcel/groupId version5.1/version -/diff - /diffs +/artifact + /artifacts /configuration /plugin -- - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
svn commit: r897686 - /jakarta/bcel/trunk/RELEASE-NOTES.txt
Author: tcurdt Date: Sun Jan 10 19:22:40 2010 New Revision: 897686 URL: http://svn.apache.org/viewvc?rev=897686view=rev Log: prepare for 5.3 Modified: jakarta/bcel/trunk/RELEASE-NOTES.txt Modified: jakarta/bcel/trunk/RELEASE-NOTES.txt URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/RELEASE-NOTES.txt?rev=897686r1=897685r2=897686view=diff == --- jakarta/bcel/trunk/RELEASE-NOTES.txt (original) +++ jakarta/bcel/trunk/RELEASE-NOTES.txt Sun Jan 10 19:22:40 2010 @@ -1,8 +1,8 @@ -BCEL 5.2 RELEASE NOTES +BCEL 5.3 RELEASE NOTES = -Compatibility with 5.1 +Compatibility with 5.2 -- Binary compatible - Yes @@ -11,76 +11,21 @@ Semantic compatible - Yes -Deprecations from 5.1 +Deprecations from 5.2 - -public final org.apache.bcel.classfile.LocalVariable getLocalVariable(int) -public java.lang.String getClassName(org.apache.bcel.generic.ConstantPoolGen) -public org.apache.bcel.generic.ObjectType getClassType(org.apache.bcel.generic.ConstantPoolGen) -public boolean referencesClass() -public boolean referencesInterface() public org.apache.bcel.util.ClassVector implements java.io.Serializable -Bug fixes from 5.1 +Bug fixes from 5.2 -- 32664 Examples with enum breaks Gump (JDK1.5) -32901 Truncated class string in returned class name -32980 Simple Javadoc cleanup -33018 Fix hashCode methods -34318 JavaClass.dump(OutputStream/DataOutputStream) shouldnt ca... -34449 InnerClass doesn't implement Serializable -35991 Unable to generate method that returns an array of integers -36110 A bug in LocalVariableGen -37648 JasminVisitor is outdated -37666 BCEL depends on AWT -38377 BCEL cannot be used as java.system.class.loader -38834 nullpointer exception in InstructionHandle -12568 Typo in javadocs -18031 ConstantPoolGen.lookupClass(String) finds LAST entry rath... -18323 Size of LDC_W's operand can be incorrect -18731 InstructionList.copy() fails with Select instruction. -19014 annoying print statement in org.apache.bcel.classfile.Sig... -19068 JavaClass.getAllInterfaces() can throw NullPointerExcepti... -19122 Repository ignores classes that have been added to it -19352 ANEWARRAY does not implement StackConsumer -19476 Repository.instanceOf() can throw NullPointerException -19784 StackMapType.printIndex fails if index is -1 -24274 ReturnaddressType.equals() fails with NullPointerException -24315 Verification failure when nested finally blocks -24350 PUTFIELD error msg wrong -24766 Suggestion to solve the Problem with generic.Instruction ... -26049 Incorrect verification of class files -26087 OutOfRange exception in Pass2Verifier.validJavaIdentifier -26179 Code attribute set for native (and abstract?) methods. -26532 InstructionList.move is broken when target == il.getEnd() -26533 bad iinc behavior with large local variable index -27855 StructuralVerifier can't find protected fields of ... -28329 BCEL does not compile with JDK 1.5.0-beta-b32c -29275 Corrupted instruction list created on valid class file -29903 LDC_W emits output with only one parameter byte -31604 Build problems against jdk1.5 -31630 ClassPath.getClassPath() does not handle multiple java.ex... -27646 Public modifier for OperandStack.size() -17753 Version information missing from MANIFEST.MF file. -33822 Wrong word in manual: use 'factorial', not 'faculty' -32205 A security issue with public mutable static fields in BECL -33513 Unnecessary string object allocation in ConstantPoolGen -34418 ClassCastException on justice -38787 XSLT transforms broken in Turkish Locale. -35405 Branch target offset too large for short -33235 Illegal Opcode Detected exception thrown in new Method... -35610 Source downloads are broken -38424 LineNumberTable toString method uses jdk 1.4 StringBuffer... -Enhancements from 5.1 + +Enhancements from 5.2 - -32077 LocalVariableTable.getLocalVariable isn't good en... -20465 Verifer does not report the signature of methods not found -27854 Allow to get the InFrame of the ControlFlowGraph -33302 Add support for new Jdk5.0 access flags 32945 Wrap JavaClass repository class (map values) with... - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
svn commit: r897687 - in /jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile: AnnotationEntry.java Annotations.java
Author: tcurdt Date: Sun Jan 10 19:26:09 2010 New Revision: 897687 URL: http://svn.apache.org/viewvc?rev=897687view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=41660 Expose annotations to subclasses Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/AnnotationEntry.java jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Annotations.java Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/AnnotationEntry.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/AnnotationEntry.java?rev=897687r1=897686r2=897687view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/AnnotationEntry.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/AnnotationEntry.java Sun Jan 10 19:26:09 2010 @@ -29,124 +29,129 @@ * represents one annotation in the annotation table * * @version $Id: AnnotationEntry - * @author A HREF=mailto:dbros...@mebigfatguy.com;D. Brosius/A + * @author A HREF=mailto:dbros...@mebigfatguy.com;D. Brosius/A * @since 5.3 */ public class AnnotationEntry implements Node, Constants, Serializable { -private int type_index; -private int num_element_value_pairs; +private static final long serialVersionUID = 1L; + +private final int type_index; +private final ConstantPool constant_pool; +private final boolean isRuntimeVisible; + private List element_value_pairs; -private ConstantPool constant_pool; -private boolean isRuntimeVisible; +/** + * Factory method to create an AnnotionEntry from a DataInputStream + * + * @param file + * @param constant_pool + * @param isRuntimeVisible + * @return + * @throws IOException + */ +public static AnnotationEntry read(DataInputStream file, ConstantPool constant_pool, boolean isRuntimeVisible) throws IOException { + +final AnnotationEntry annotationEntry = new AnnotationEntry(file.readUnsignedShort(), constant_pool, isRuntimeVisible); +final int num_element_value_pairs = (file.readUnsignedShort()); +annotationEntry.element_value_pairs = new ArrayList(); +for (int i = 0; i num_element_value_pairs; i++) { +annotationEntry.element_value_pairs.add(new ElementValuePair(file.readUnsignedShort(), ElementValue.readElementValue(file, constant_pool), +constant_pool)); +} +return annotationEntry; +} /** * Construct object from file stream. + * * @param file Input stream */ public AnnotationEntry(int type_index, ConstantPool constant_pool, boolean isRuntimeVisible) { this.type_index = type_index; - this.constant_pool = constant_pool; this.isRuntimeVisible = isRuntimeVisible; } - -public static AnnotationEntry read(DataInputStream file, ConstantPool constant_pool, boolean isRuntimeVisible) throws IOException -{ - AnnotationEntry annotationEntry = new AnnotationEntry(file.readUnsignedShort(), constant_pool, isRuntimeVisible); - annotationEntry.num_element_value_pairs = (file.readUnsignedShort()); - annotationEntry.element_value_pairs = new ArrayList(); -for (int i = 0; i annotationEntry.num_element_value_pairs; i++) { - annotationEntry.element_value_pairs.add(new ElementValuePair(file.readUnsignedShort(), ElementValue.readElementValue(file, constant_pool), constant_pool)); -} -return annotationEntry; + +public int getTypeIndex() { +return type_index; +} + +public ConstantPool getConstantPool() { +return constant_pool; } +public boolean isRuntimeVisible() { +return isRuntimeVisible; +} /** - * Called by objects that are traversing the nodes of the tree implicitely - * defined by the contents of a Java class. I.e., the hierarchy of methods, - * fields, attributes, etc. spawns a tree of objects. - * + * Called by objects that are traversing the nodes of the tree implicitely defined by the contents of a Java class. + * I.e., the hierarchy of methods, fields, attributes, etc. spawns a tree of objects. + * * @param v Visitor object */ -public void accept( Visitor v ) { -// v.visitAnnotationEntry(this); +public void accept(Visitor v) { +// v.visitAnnotationEntry(this); } - /** * @return the annotation type name */ public String getAnnotationType() { -ConstantUtf8 c; -c = (ConstantUtf8) constant_pool.getConstant(type_index, CONSTANT_Utf8); +final ConstantUtf8 c = (ConstantUtf8) constant_pool.getConstant(type_index, CONSTANT_Utf8); return c.getBytes(); } - + /** * @return the annotation type index */ -public int
svn commit: r897695 - /jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java
Author: tcurdt Date: Sun Jan 10 20:06:47 2010 New Revision: 897695 URL: http://svn.apache.org/viewvc?rev=897695view=rev Log: hierarchical ClassPath support https://issues.apache.org/bugzilla/show_bug.cgi?id=38426 Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java?rev=897695r1=897694r2=897695view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java Sun Jan 10 20:06:47 2010 @@ -47,7 +47,12 @@ public static final ClassPath SYSTEM_CLASS_PATH = new ClassPath(); private PathEntry[] paths; private String class_path; +private ClassPath parent; +public ClassPath(ClassPath parent, String class_path) { +this(class_path); +this.parent = parent; +} /** * Search for classes in given path. @@ -90,18 +95,24 @@ /** @return used class path string */ public String toString() { +if (parent != null) { +return parent.toString() + File.pathSeparator + class_path; +} return class_path; } - public int hashCode() { +if (parent != null) { +return class_path.hashCode() + parent.hashCode(); +} return class_path.hashCode(); } public boolean equals( Object o ) { if (o instanceof ClassPath) { -return class_path.equals(((ClassPath) o).class_path); +ClassPath cp = (ClassPath)o; +return class_path.toString().equals(cp.toString()); } return false; } @@ -240,14 +251,37 @@ */ public ClassFile getClassFile( String name, String suffix ) throws IOException { for (int i = 0; i paths.length; i++) { -ClassFile cf; -if ((cf = paths[i].getClassFile(name, suffix)) != null) { +ClassFile cf = null; + +if(parent != null) { +cf = parent.getClassFileInternal(name, suffix); +} + +if(cf == null) { +cf = getClassFileInternal(name,suffix); +} + +if(cf != null) { return cf; } } + throw new IOException(Couldn't find: + name + suffix); } +private ClassFile getClassFileInternal(String name, String suffix) throws IOException { + + for(int i=0; i paths.length; i++) { + ClassFile cf = paths[i].getClassFile(name, suffix); + + if(cf != null) { + return cf; + } + } + + return null; + } + /** * @param name fully qualified class name, e.g. java.lang.String - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 48279] Invalid method signature: TT; when using MethodGen for a method having a generic parameter
https://issues.apache.org/bugzilla/show_bug.cgi?id=48279 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Torsten Curdt tcu...@apache.org 2010-01-10 12:21:59 UTC --- Thx! Applied. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
svn commit: r897701 - in /jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic: FieldInstruction.java Type.java
Author: tcurdt Date: Sun Jan 10 20:32:51 2010 New Revision: 897701 URL: http://svn.apache.org/viewvc?rev=897701view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=48280 by Enrico Gueli fixed FieldInstruction.getFieldSize() Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldInstruction.java jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldInstruction.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldInstruction.java?rev=897701r1=897700r2=897701view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldInstruction.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldInstruction.java Sun Jan 10 20:32:51 2010 @@ -54,7 +54,7 @@ /** @return size of field (1 or 2) */ protected int getFieldSize( ConstantPoolGen cpg ) { - return Type.getTypeSize(getSignature(cpg)); + return Type.size(Type.getTypeSize(getSignature(cpg))); } Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java?rev=897701r1=897700r2=897701view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java Sun Jan 10 20:32:51 2010 @@ -18,6 +18,7 @@ import java.util.ArrayList; import java.util.List; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.ClassFormatException; import org.apache.bcel.classfile.Utility; @@ -308,15 +309,15 @@ return sb.toString(); } -private static int size(int coded) { +static int size(int coded) { return coded 3; } -private static int consumed(int coded) { +static int consumed(int coded) { return coded 2; } -private static int encode(int size, int consumed) { +static int encode(int size, int consumed) { return consumed 2 | size; } - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 48280] FieldInstruction.getFieldSize() doesn't decode Type.getTypeSize() output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48280 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Torsten Curdt tcu...@apache.org 2010-01-10 12:33:00 UTC --- Thx! Applied. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
svn commit: r897702 - /jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/StackMapTableEntry.java
Author: tcurdt Date: Sun Jan 10 20:41:44 2010 New Revision: 897702 URL: http://svn.apache.org/viewvc?rev=897702view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=47073 by Mattias Ulbrich fixed dump of StackMapTable Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/StackMapTableEntry.java Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/StackMapTableEntry.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/StackMapTableEntry.java?rev=897702r1=897701r2=897702view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/StackMapTableEntry.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/StackMapTableEntry.java Sun Jan 10 20:41:44 2010 @@ -114,17 +114,19 @@ */ public final void dump( DataOutputStream file ) throws IOException { file.write(frame_type); - if (frame_type = Constants.SAME_LOCALS_1_STACK_ITEM_FRAME frame_type = Constants.SAME_LOCALS_1_STACK_ITEM_FRAME_MAX) { - types_of_stack_items[0].dump(file); + if (frame_type = Constants.SAME_FRAME frame_type = Constants.SAME_FRAME_MAX) { + // nothing to be done + } else if (frame_type = Constants.SAME_LOCALS_1_STACK_ITEM_FRAME frame_type = Constants.SAME_LOCALS_1_STACK_ITEM_FRAME_MAX) { + types_of_stack_items[0].dump(file); } else if (frame_type == Constants.SAME_LOCALS_1_STACK_ITEM_FRAME_EXTENDED) { - file.write(byte_code_offset_delta); +file.writeShort(byte_code_offset_delta); types_of_stack_items[0].dump(file); } else if (frame_type = Constants.CHOP_FRAME frame_type = Constants.CHOP_FRAME_MAX) { - file.write(byte_code_offset_delta); +file.writeShort(byte_code_offset_delta); } else if (frame_type == Constants.SAME_FRAME_EXTENDED) { - file.write(byte_code_offset_delta); +file.writeShort(byte_code_offset_delta); } else if (frame_type = Constants.APPEND_FRAME frame_type = Constants.APPEND_FRAME_MAX) { - file.write(byte_code_offset_delta); +file.writeShort(byte_code_offset_delta); for (int i = 0; i number_of_locals; i++) { types_of_locals[i].dump(file); } - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 47072] Class files containing ParameterAnnotations are dumped incorrectly
https://issues.apache.org/bugzilla/show_bug.cgi?id=47072 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Torsten Curdt tcu...@apache.org 2010-01-10 12:48:09 UTC --- Thx. Applied. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 46722] problem using bcel in jdk15
https://issues.apache.org/bugzilla/show_bug.cgi?id=46722 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Torsten Curdt tcu...@apache.org 2010-01-10 12:50:46 UTC --- Please re-test against trunk. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 42552] Thread safety + unbuffered writes
https://issues.apache.org/bugzilla/show_bug.cgi?id=42552 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|ASSIGNED|NEEDINFO --- Comment #3 from Torsten Curdt tcu...@apache.org 2010-01-10 13:06:07 UTC --- Just got back to this patch. BCEL is never meant to be theadsafe. What am I missing? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 42655] ParameterAnnotationEntries are read not dumped
https://issues.apache.org/bugzilla/show_bug.cgi?id=42655 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #2 from Torsten Curdt tcu...@apache.org 2010-01-10 13:06:49 UTC --- Fixed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 45897] org.apache.bcel.classfile.ClassFormatException
https://issues.apache.org/bugzilla/show_bug.cgi?id=45897 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
svn commit: r897708 - in /jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic: GOTO.java JSR.java
Author: tcurdt Date: Sun Jan 10 21:22:16 2010 New Revision: 897708 URL: http://svn.apache.org/viewvc?rev=897708view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=45230 by Timothy Alper fixed alignment of operands Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/GOTO.java jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/JSR.java Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/GOTO.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/GOTO.java?rev=897708r1=897707r2=897708view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/GOTO.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/GOTO.java Sun Jan 10 21:22:16 2010 @@ -64,8 +64,9 @@ position += offset; // Position may be shifted by preceding expansions if (Math.abs(i) = (32767 - max_offset)) { // to large for short (estimate) opcode = org.apache.bcel.Constants.GOTO_W; +short old_length = length; length = 5; -return 2; // 5 - 3 +return length - old_length; } return 0; } Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/JSR.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/JSR.java?rev=897708r1=897707r2=897708view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/JSR.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/JSR.java Sun Jan 10 21:22:16 2010 @@ -61,8 +61,9 @@ position += offset; // Position may be shifted by preceding expansions if (Math.abs(i) = (32767 - max_offset)) { // to large for short (estimate) opcode = org.apache.bcel.Constants.JSR_W; +short old_length = length; length = 5; -return 2; // 5 - 3 +return length - old_length; } return 0; } - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 45230] tableswitch/lookupswitch invalid alignment of 4-byte operands
https://issues.apache.org/bugzilla/show_bug.cgi?id=45230 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Torsten Curdt tcu...@apache.org 2010-01-10 13:22:30 UTC --- Thx. Applied. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
svn commit: r897709 - /jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/TABLESWITCH.java
Author: tcurdt Date: Sun Jan 10 21:27:48 2010 New Revision: 897709 URL: http://svn.apache.org/viewvc?rev=897709view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=44876 by Timothy Alper fixed out of bounds exception Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/TABLESWITCH.java Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/TABLESWITCH.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/TABLESWITCH.java?rev=897709r1=897708r2=897709view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/TABLESWITCH.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/TABLESWITCH.java Sun Jan 10 21:27:48 2010 @@ -80,10 +80,8 @@ match = new int[match_length]; indices = new int[match_length]; targets = new InstructionHandle[match_length]; -for (int i = low; i = high; i++) { -match[i - low] = i; -} for (int i = 0; i match_length; i++) { +match[i] = low + i; indices[i] = bytes.readInt(); } } - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
DO NOT REPLY [Bug 44876] ArrayIndexOutOfBoundsException thrown from TABLESWITCH.initFromFile
https://issues.apache.org/bugzilla/show_bug.cgi?id=44876 Torsten Curdt tcu...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Torsten Curdt tcu...@apache.org 2010-01-10 13:27:51 UTC --- Fixed. Thx. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
Re: svn commit: r897686 - /jakarta/bcel/trunk/RELEASE-NOTES.txt
We are still building with 1.4 (only tests need 1.5) But we do need to discuss how to deal with those changes. cheers -- Torsten On Sun, Jan 10, 2010 at 21:20, Dave Brosius dbros...@apache.org wrote: Just some notes for 5.3 -we are currently building with java 1.5 which is new -we are not backward compatible with annotation attribute support (old code expects unknown attributes to come thru, but they don't now). I'm fine with those changes, just wanted to remind everyone. tcu...@apache.org wrote: Author: tcurdt Date: Sun Jan 10 19:22:40 2010 New Revision: 897686 URL: http://svn.apache.org/viewvc?rev=897686view=rev Log: prepare for 5.3 - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org
svn commit: r897711 - /jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java
Author: dbrosius Date: Sun Jan 10 21:39:38 2010 New Revision: 897711 URL: http://svn.apache.org/viewvc?rev=897711view=rev Log: no need to call toString on a string Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java?rev=897711r1=897710r2=897711view=diff == --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java (original) +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java Sun Jan 10 21:39:38 2010 @@ -56,6 +56,8 @@ /** * Search for classes in given path. + * + * @param class_path */ public ClassPath(String class_path) { this.class_path = class_path; @@ -112,7 +114,7 @@ public boolean equals( Object o ) { if (o instanceof ClassPath) { ClassPath cp = (ClassPath)o; -return class_path.toString().equals(cp.toString()); +return class_path.equals(cp.toString()); } return false; } - To unsubscribe, e-mail: bcel-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bcel-dev-h...@jakarta.apache.org