Re: totem and startup-notification
On Mon, Jan 21, 2008 at 07:23:23PM -0800, Dan Nicholson wrote: Looks like it got fixed upstream now. http://svn.gnome.org/viewvc/totem?view=revisionrevision=4977 I'm still guessing, but the reason it worked for me was because EXTRA_GNOME uses gnome-desktop, which was pulling in startup-notification. $ grep Requires: /usr/lib/pkgconfig/gnome-desktop-2.0.pc Requires: gtk+-2.0 libgnomeui-2.0 libstartup-notification-1.0 Maybe you're not getting that? I think startup-notification is an optional dep for gnome-desktop. Thanks, Dan. Looks as if that will be the reason (don't have time to test it yet, will do so later). For some reason, I was building startup-notification late in the process, much later than gnome-desktop. Oh, I see - I only put sn in because yelp requires it. I already had g-d for eel. And now that I build totem, it highlights this. Oh well, looks as if I ought to review my build order again. Many thanks for clearing this up. ĸen -- das eine Mal als Tragödie, das andere Mal als Farce -- http://linuxfromscratch.org/mailman/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: totem and startup-notification
On Jan 21, 2008 4:40 PM, Ken Moffat [EMAIL PROTECTED] wrote: On Sun, Jan 20, 2008 at 11:01:29PM +, Ken Moffat wrote: Thanks for this, and your other response - I'll play with the patches once I'm back on LFS-6.3 x86. After I looked at the patch, I started to think it might be trying to fix a different problem. The MOZILLA_NOT_LINKED_CFLAGS doesn't sound like what I think I'm building. To clarify, at the end of configure I get the following report: configure: Totem was configured with the following options: configure: ** Using the GStreamer-0.10 backend configure: ** Easy codec installation support enabled configure:nvtv support disabled configure:vanity compilation disabled configure: ** GNOME version enabled configure: ** Browser plugin enabled (using firefox) configure: ** Basic browser plugin enabled configure: ** GMP (Windows Media) plugin enabled configure: ** Complex (Real) plugin enabled configure: ** NarrowSpace (QuickTime) plugin enabled configure: ** MullY (DivX) plugin enabled configure: ** Nautilus properties page enabled configure:Media player keys support disabled configure:LIRC support disabled configure:HAL support disabled configure: ** XTest (legacy screensaver) support enabled configure: ** D-Bus (gnome-screensaver) support enabled configure: ** XVidmode support enabled configure: ** XFree86 multimedia keys support enabled configure: End options I'm surprised by 'Nautilus properties page enabled', and also by 'legacy screensaver', but that's what it finds. I don't know what Nautilus properties page is, but I think legacy screensaver just means it will fall back to using libXScrnSaver if it doesn't find the DBus interface to gnome-screensaver at runtime. FWIW, I couldn't persuade 'patch' to apply your patch to 2.18.2, which is what is in blfs-svn, even after I sorted out the line-wrap at the end - the hunk is at line 379 instead of 466, but even after editing that it still wouldn't apply for reasons that escape me. Yeah, that was against 2.20.3, which I thought you mentioned you were using. Maybe the variables are named something different in 2.18.x. The quick and dirty fix needs cat browser-plugin/Makefile.in instead of cat ..., I think. Anyway, it still doesn't help, the error messages with fresh source still begin totem-plugin-viewer.c:38:22: error: libsn/sn.h: No such file or directory totem-plugin-viewer.c:587: error: expected ')' before '*' token totem-plugin-viewer.c:594: error: expected ')' before '*' token totem-plugin-viewer.c:601: error: expected ')' before '*' token totem-plugin-viewer.c: In function 'free_startup_timeout': totem-plugin-viewer.c:662: error: 'sn_launcher_context_unref' undeclared (first use in this function) totem-plugin-viewer.c:662: error: (Each undeclared identifier is reported only once totem-plugin-viewer.c:662: error: for each function it appears in.) totem-plugin-viewer.c: In function 'startup_timeout': totem-plugin-viewer.c:690: error: 'SnLauncherContext' undeclared (first use in this function) totem-plugin-viewer.c:690: error: 'sn_context' undeclared (first use in this function) So, clearly it's not picking up the startup-notification CFLAGS. So, take a look at browser-plugin/Makefile.am. Look for totem_plugin_viewer_CFLAGS. In 2.20.3, it was using $(BROWSER_PLUGIN_CFLAGS), which gets generated using the pkg-config check in configure.ac. So, the hack is to find some variable it's using for totem_plugin_viewer_CFLAGS and tack on your extra information onto the end of browser-plugin/Makefile.in (not Makefile.am unless you want to regenerate the autotools). You could probably even just use `echo totem_plugin_viewer_CFLAGS += $(pkg-config --cflags libstartup-notification-1.0) browser-plugin/Makefile.in'. And the libraries into totem_plugin_viewer_LDADD. Or, you can just kludge the whole thing in through configure. export CPPFLAGS=$(pkg-config --cflags libstartup-notification-1.0) export LIBS=$(pkg-config --libs libstartup-notification-1.0) ./configure ... -- Dan -- http://linuxfromscratch.org/mailman/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: totem and startup-notification
On Jan 21, 2008 5:56 PM, Ken Moffat [EMAIL PROTECTED] wrote: On Mon, Jan 21, 2008 at 04:59:49PM -0800, Dan Nicholson wrote: So, clearly it's not picking up the startup-notification CFLAGS. So, take a look at browser-plugin/Makefile.am. Look for totem_plugin_viewer_CFLAGS. In 2.20.3, it was using $(BROWSER_PLUGIN_CFLAGS), which gets generated using the pkg-config check in configure.ac. FWIW, I don't see that (this is 2.20.3, 2.18.2 looks the same) - totem_plugin_viewer_CFLAGS = \ $(EXTRA_GNOME_CFLAGS) \ $(WARN_CFLAGS) \ $(DBUS_CFLAGS) \ $(NVTV_CFLAGS) \ $(AM_CFLAGS) Maybe EXTRA_GNOME_CFLAGS could be used, but I went with one of your later alternatives... Looks like it got fixed upstream now. http://svn.gnome.org/viewvc/totem?view=revisionrevision=4977 I'm still guessing, but the reason it worked for me was because EXTRA_GNOME uses gnome-desktop, which was pulling in startup-notification. $ grep Requires: /usr/lib/pkgconfig/gnome-desktop-2.0.pc Requires: gtk+-2.0 libgnomeui-2.0 libstartup-notification-1.0 Maybe you're not getting that? I think startup-notification is an optional dep for gnome-desktop. -- Dan -- http://linuxfromscratch.org/mailman/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
totem and startup-notification
I've got an odd one here, and I suspect it's down to something I'm doing or omitting, but for the life of me I can't see what. My current builds include totem, mainly because I'm building gstreamer as a dependency for gnash (so, this is totem with the gst backend). If I don't patch totem, both the 2.18.2 and 2.20.1 versions bomb out in the build when they try to reference libsn/sn.h totem-plugin-viewer.c:37:22: error: libsn/sn.h: No such file or directory and then the usual mass of errors. When I first met this, the main result for sn_display_new (one of the functions reporting an error) on google was http://www.redhat.com/archives/fedora-extras-commits/2007-June/msg03254.html which removes the references to libsn and quite a large chunk of code. With that, both 2.18.2 and 2.20.1 build for me, and seem to work. The oddity is that fedora dropped this for 2.18.2 because of upstream fixes. I'm using startup-notification-0.9, but so are they. I can't see anybody else needing to work around this (e.g. ubuntu, gentoo) so I guess it's something wrong with my builds, but I'm out of ideas. As far as I can see, fedora don't do anything interesting when they install startup-notification, so libsn/sn.h is still in /usr/include/startup-notification-1.0/libsn/sn.h. If it makes a difference, this is a minimal gnome, just enough to build a couple of applications and some utilities, but not e.g. nautilus (so, only about 50 to 60 packages specific to gnome). ĸen -- das eine Mal als Tragödie, das andere Mal als Farce -- http://linuxfromscratch.org/mailman/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: totem and startup-notification
On Jan 20, 2008 7:30 AM, Ken Moffat [EMAIL PROTECTED] wrote: I've got an odd one here, and I suspect it's down to something I'm doing or omitting, but for the life of me I can't see what. My current builds include totem, mainly because I'm building gstreamer as a dependency for gnash (so, this is totem with the gst backend). If I don't patch totem, both the 2.18.2 and 2.20.1 versions bomb out in the build when they try to reference libsn/sn.h totem-plugin-viewer.c:37:22: error: libsn/sn.h: No such file or directory and then the usual mass of errors. From my quick check, it seems that totem is only pulling in startup-notification indirectly through gnome-desktop. And that only happens on a non-GTK-only build. totem-plugin-viewer.c seems to require startup-notification unconditionally, though. So, I would say that if you're using --enable-gtk, there's definitely a path to build breakage. The right solution is that the enabling the browser plugin needs to check for startup-notification instead of relying on something else pulling it in. This could probably go upstream (discounting gmail breaking formatting): --- configure.in.orig 2008-01-20 12:52:35.0 -0800 +++ configure.in2008-01-20 12:53:30.0 -0800 @@ -466,7 +466,8 @@ if test $enable_browser_plugins = yes [glib-2.0 gnome-vfs-2.0 = $GNOMEVFS_REQS gnome-vfs-module-2.0 = $GNOMEVFS_REQS -gthread-2.0], +gthread-2.0 +libstartup-notification-1.0], [],[enable_browser_plugins=no]) BROWSER_PLUGIN_CFLAGS=$MOZILLA_NOT_LINKED_CFLAGS $BROWSER_PLUGIN_CFLAGS which removes the references to libsn and quite a large chunk of code. With that, both 2.18.2 and 2.20.1 build for me, and seem to work. The oddity is that fedora dropped this for 2.18.2 because of upstream fixes. I'm using startup-notification-0.9, but so are they. I can't see anybody else needing to work around this (e.g. ubuntu, gentoo) so I guess it's something wrong with my builds, but I'm out of ideas. Are you using --enable-gtk? I just built it all fine a couple days ago, but I pulled in all the optional dependencies. -- Dan -- http://linuxfromscratch.org/mailman/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: totem and startup-notification
On Jan 20, 2008 12:56 PM, Dan Nicholson [EMAIL PROTECTED] wrote: --- configure.in.orig 2008-01-20 12:52:35.0 -0800 +++ configure.in2008-01-20 12:53:30.0 -0800 @@ -466,7 +466,8 @@ if test $enable_browser_plugins = yes [glib-2.0 gnome-vfs-2.0 = $GNOMEVFS_REQS gnome-vfs-module-2.0 = $GNOMEVFS_REQS -gthread-2.0], +gthread-2.0 +libstartup-notification-1.0], [],[enable_browser_plugins=no]) BROWSER_PLUGIN_CFLAGS=$MOZILLA_NOT_LINKED_CFLAGS $BROWSER_PLUGIN_CFLAGS The quick and dirty fix being: cat browser-plugin/Makefile.in EOF BROWSER_PLUGIN_CFLAGS += $(pkg-config --cflags libstartup-notification-1.0) BROWSER_PLUGIN_LIBS += $(pkg-config --libs libstartup-notification-1.0) EOF -- Dan -- http://linuxfromscratch.org/mailman/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: totem and startup-notification
On Sun, Jan 20, 2008 at 12:56:05PM -0800, Dan Nicholson wrote: The right solution is that the enabling the browser plugin needs to check for startup-notification instead of relying on something else pulling it in. This could probably go upstream (discounting gmail breaking formatting): --- configure.in.orig 2008-01-20 12:52:35.0 -0800 +++ configure.in2008-01-20 12:53:30.0 -0800 @@ -466,7 +466,8 @@ if test $enable_browser_plugins = yes [glib-2.0 gnome-vfs-2.0 = $GNOMEVFS_REQS gnome-vfs-module-2.0 = $GNOMEVFS_REQS -gthread-2.0], +gthread-2.0 +libstartup-notification-1.0], [],[enable_browser_plugins=no]) BROWSER_PLUGIN_CFLAGS=$MOZILLA_NOT_LINKED_CFLAGS $BROWSER_PLUGIN_CFLAGS So, when fedora say it was fixed by upstream, they mean for people with a full gnome build ? which removes the references to libsn and quite a large chunk of code. With that, both 2.18.2 and 2.20.1 build for me, and seem to work. The oddity is that fedora dropped this for 2.18.2 because of upstream fixes. I'm using startup-notification-0.9, but so are they. I can't see anybody else needing to work around this (e.g. ubuntu, gentoo) so I guess it's something wrong with my builds, but I'm out of ideas. Are you using --enable-gtk? I just built it all fine a couple days ago, but I pulled in all the optional dependencies. Nope, just --prefix=/usr - that probably marks me down as a heathen. I'm not especially concerned about where it scatters its files in my own builds, although now that you've got me looking I guess I ought to at least address /usr/etc for the schemas ;) Of the listed optional dependencies, I've got intltool and firefox, but not nautilus, hal, libirman, LIRC, Gromit, NvTv. Thanks for this, and your other response - I'll play with the patches once I'm back on LFS-6.3 x86. ĸen -- das eine Mal als Tragödie, das andere Mal als Farce -- http://linuxfromscratch.org/mailman/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page