Re: typo in getaddrinfo.c

[Simon Josefsson]

Mark D. Baushke [EMAIL PROTECTED] writes:

 Fixed in CVS sources.

Installed, thanks!


   -- Mark

 2006-06-30  Jim Hyslop [EMAIL PROTECTED]

   * getaddrinfo.c: fixed typo

 Index: getaddrinfo.c
 ===
 RCS file: /sources/gnulib/gnulib/lib/getaddrinfo.c,v
 retrieving revision 1.10
 diff -u -p -u -p -r1.10 getaddrinfo.c
 --- getaddrinfo.c 29 Jun 2006 15:16:56 -  1.10
 +++ getaddrinfo.c 1 Jul 2006 00:37:49 -
 @@ -167,7 +167,7 @@ getaddrinfo (const char *restrict nodena
if (!se)
   {
 char *c;
 -   if (!(*servname = '0'  *servname = '9))
 +   if (!(*servname = '0'  *servname = '9'))
   return EAI_NONAME;
 port = strtoul (servname, c, 10);
 if (*c || port  0x)

Re: OS/2 and stdarg module

[Eric Blake]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

According to Paul Eggert on 7/1/2006 3:27 PM:
 [EMAIL PROTECTED] (Eric Blake) writes:
 
 +#define gl_va_copy(a,b) (a) = (b)])
 
 I'm not familiar with this package, but surely that should be ((a) =
 (b)), not (a) = (b).

In the case of va_copy, POSIX defines it to have void value, so trying to
use va_copy for its result is invalid, and the missing parenthesis can't
affect a compliant program.  But to avoid potential confusion, I checked
in a followup patch that added the parentheses.

- --
Eric Blake
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEpwM984KuGfSFAYARAgt7AKDQHnRHzpZdinn1C3qfFm1+W7Ho7gCcCeG5
lhthAVJtkUdwMTNI+82C89s=
=Vq9t
-END PGP SIGNATURE-

Re: OS/2 and stdarg module

[Paul Eggert]

Eric Blake [EMAIL PROTECTED] writes:

 In the case of va_copy, POSIX defines it to have void value, so trying to
 use va_copy for its result is invalid, and the missing parenthesis can't
 affect a compliant program.

(void) va_copy (foo, bar) is a counterexample to that claim.
(Never underestimate the complexity of the C language.  :-)

But the point is moot now since you fixed it; thanks.