Re: bug#41982: [PATCH v2] grub-core: Build fixes for i386

2020-07-13 Thread Jan Nieuwenhuizen 
Ludovic Courtès writes:

Hi!

> Jan Nieuwenhuizen  skribis:
>
>> Jan Nieuwenhuizen writes:
>>
>> lib/i386/relocator64.S:97: Error: bad register name `%rsp'
>>
>> The attached v2 fixes that.
>
> On the Guix side I guess you can go ahead and apply it.
>
> Well done!

Thanks!  Ah, I already done in 54e70a70f2cb6336b02ed3ac4256f6b44da5c769
after discussing with Mathieu on IRC.  I wanted to keep a line to
upstream, being cautious for continuing to carry a diff here.

Janneke

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Re: bug#41982: [PATCH v2] grub-core: Build fixes for i386

2020-07-13 Thread Ludovic Courtès 
Hi!

Jan Nieuwenhuizen  skribis:

> Jan Nieuwenhuizen writes:
>
> Hello!
>
>> When cross-compiling Grub-2.04 from i386-linux-gnu to i586-pc-hurd on
>> GNU Guix, I got this error
>
> Today, we found* that my patch introduced a regression: a native, EFI
> build on i686-linux-gnu failed with
>
> lib/i386/relocator64.S:97: Error: bad register name `%rsp'
>
> The attached v2 fixes that.

On the Guix side I guess you can go ahead and apply it.

Well done!

Ludo’.