Re: pedantic stuff: C++ comments in 1.8.0

2006-03-04 Thread Kevin Ryde 
Mike Gran [EMAIL PROTECTED] writes:

 There are some C++-style comments in 1.8.0.

Thanks, I applied that fix.


___
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: pedantic stuff: C++ comments in 1.8.0

2006-03-04 Thread Ludovic Courtès 
Hi,

Mike Gran [EMAIL PROTECTED] writes:

 There are some C++-style comments in 1.8.0.

Good catch (but note that it's also allowed by C99).  But after all,
it's not so pedantic: GCC  3 uses C89 by default and does not recognize
such comments, and some proprietary compilers certainly don't recognize
it either ``out of the box''.

Could you resend your patch as a unified diff, i.e., using `diff -u'?
Also, make sure the original file (e.g., `posix.c.0') appears first on
the command line.

Thanks,
Ludovic.


___
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

pedantic stuff: C++ comments in 1.8.0

2006-03-02 Thread Mike Gran 
There are some C++-style comments in 1.8.0.

*** posix.c Mon Feb 27 18:38:55 2006
--- posix.c.0   Mon Feb 27 18:29:56 2006
***
*** 1877,1883 
  {
const int save_errno = errno;
  
!   /* No guile exceptions can occur before we have freed p's
memory. */
scm_dynwind_end ();
free (p);
  
--- 1877,1883 
  {
const int save_errno = errno;
  
!   // No guile exceptions can occur before we have freed p's
memory.
scm_dynwind_end ();
free (p);
  
***
*** 1889,1895 
/* scm_from_locale_string may throw an exception.  */
const SCM name = scm_from_locale_string (p);
  
!   /* No guile exceptions can occur before we have freed p's
memory. */
scm_dynwind_end ();
free (p);
  
--- 1889,1895 
/* scm_from_locale_string may throw an exception.  */
const SCM name = scm_from_locale_string (p);
  
!   // No guile exceptions can occur before we have freed p's
memory.
scm_dynwind_end ();
free (p);

*** eval.c  Mon Feb 27 16:26:17 2006
--- eval.c.0Mon Feb 27 16:24:57 2006
***
*** 5695,5702 
   * hare-and-tortoise implementation, found several times in guile. 
*/
  
  struct t_trace {
!   struct t_trace *trace;  /* These pointers form a trace along the
stack. */
!   SCM obj;/* The object handled at the respective
stack frame.*/
  };
  
  static SCM
--- 5695,5702 
   * hare-and-tortoise implementation, found several times in guile. 
*/
  
  struct t_trace {
!   struct t_trace *trace;  // These pointers form a trace along the
stack.
!   SCM obj;// The object handled at the respective
stack frame.
  };
  
  static SCM
***
*** 5751,5757 
  
return new_vector;
  }
!   else /* scm_is_pair (hare-obj) */
  {
SCM result;
SCM tail;
--- 5751,5757 
  
return new_vector;
  }
!   else // scm_is_pair (hare-obj)
  {
SCM result;
SCM tail;
  


__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 


___
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile