Re: DynamicTextSpanner is not fully contained in parent spanner

2010-09-13 Thread Jay Anderson 
On Sun, Sep 12, 2010 at 12:55 PM, Neil Puttock n.putt...@gmail.com wrote:
 You can still use the old method for hiding lines:

 \override DynamicTextSpanner #'dash-period = #-1

Yeah, it looks like this is the preferred method since it doesn't have
this line break problem.

___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: DynamicTextSpanner is not fully contained in parent spanner

2010-09-12 Thread Neil Puttock 
On 11 September 2010 06:47, Jay Anderson horndud...@gmail.com wrote:

 This is definitely a hack, but it works for me:

 diff --git a/lily/spanner.cc b/lily/spanner.cc
 index 32e0d21..827f5d6 100644
 --- a/lily/spanner.cc
 +++ b/lily/spanner.cc
 @@ -112,6 +112,8 @@ Spanner::do_break_processing ()

          bool ok = parent_rank_slice.contains
 (bounds[LEFT]-get_column ()-get_rank ());
          ok = ok  parent_rank_slice.contains
 (bounds[RIGHT]-get_column ()-get_rank ());
 +
 +          ok = ok || ly_symbol2scm(none) == get_property (style);

          if (!ok)
            {


I initially thought the same, but there are two problems with this approach:

-) It ignores dynamic spanners which have been ended early due to
\breakDynamicSpan.

-) Not all spanners support the 'style property, so there would need
to be an interface check first (otherwise we'd get lots of warnings in
regression tests).

 I haven't spent the time to understand how things work yet, but this
 at least gets me past this problem for now.

You can still use the old method for hiding lines:

\override DynamicTextSpanner #'dash-period = #-1

Cheers,
Neil

___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: DynamicTextSpanner is not fully contained in parent spanner

2010-09-10 Thread Urs Liska 

Am 10.09.2010 06:33, schrieb Jay Anderson:

\version 2.13.32

\score
{
   \new Staff \relative c'
   {
 %Works fine over break:
 c1\cresc
 \break
 c1\f

 \override DynamicTextSpanner #'style = #'none
 c1\cresc
 \break
 c1\f
   }
}

dts.ly:13:6: programming error: Spanner `DynamicTextSpanner' is not
fully contained in parent spanner. Ignoring orphaned part
 c1
   \cresc

As a result the 'cresc' is not printed. The closest issue I could find
is 1089 (http://code.google.com/p/lilypond/issues/detail?id=1089).

-Jay

___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
   

I can't tell if there is some valid reason that this shouldn't be allowed.
So I added is as http://code.google.com/p/lilypond/issues/detail?id=1259

Best
Urs

___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: DynamicTextSpanner is not fully contained in parent spanner

2010-09-10 Thread Jay Anderson 
On Fri, Sep 10, 2010 at 12:52 AM, Urs Liska lilyli...@googlemail.com wrote:
 Am 10.09.2010 06:33, schrieb Jay Anderson:

 \version 2.13.32

 \score
 {
   \new Staff \relative c'
   {
     %Works fine over break:
     c1\cresc
     \break
     c1\f

     \override DynamicTextSpanner #'style = #'none
     c1\cresc
     \break
     c1\f
   }
 }

 dts.ly:13:6: programming error: Spanner `DynamicTextSpanner' is not
 fully contained in parent spanner. Ignoring orphaned part
     c1
       \cresc


 I can't tell if there is some valid reason that this shouldn't be allowed.
 So I added is as http://code.google.com/p/lilypond/issues/detail?id=1259

This is definitely a hack, but it works for me:

diff --git a/lily/spanner.cc b/lily/spanner.cc
index 32e0d21..827f5d6 100644
--- a/lily/spanner.cc
+++ b/lily/spanner.cc
@@ -112,6 +112,8 @@ Spanner::do_break_processing ()

  bool ok = parent_rank_slice.contains
(bounds[LEFT]-get_column ()-get_rank ());
  ok = ok  parent_rank_slice.contains
(bounds[RIGHT]-get_column ()-get_rank ());
+
+  ok = ok || ly_symbol2scm(none) == get_property (style);

  if (!ok)
{

I haven't spent the time to understand how things work yet, but this
at least gets me past this problem for now.

-Jay

___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

DynamicTextSpanner is not fully contained in parent spanner

2010-09-09 Thread Jay Anderson 
\version 2.13.32

\score
{
  \new Staff \relative c'
  {
%Works fine over break:
c1\cresc
\break
c1\f

\override DynamicTextSpanner #'style = #'none
c1\cresc
\break
c1\f
  }
}

dts.ly:13:6: programming error: Spanner `DynamicTextSpanner' is not
fully contained in parent spanner. Ignoring orphaned part
c1
  \cresc

As a result the 'cresc' is not printed. The closest issue I could find
is 1089 (http://code.google.com/p/lilypond/issues/detail?id=1089).

-Jay

___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond