[bug #63333] Keep running w/o output sync on temp file failure.

[Paul D. Smith]

Update of bug #6 (project make):

  Status:None => Fixed  
 Open/Closed:Open => Closed 
   Component Version: SCM => 4.4
   Fixed Release:None => SCM
   Triage Status:None => Medium Effort  

___

Follow-up Comment #4:

I see you worked on a different thing than I did (I did the jobserver).  I
applied this with some minor changes.

Thanks!


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63333] Keep running w/o output sync on temp file failure.

[Dmitry Goncharov]

URL:
  

 Summary: Keep running w/o output sync on temp file failure.
 Project: make
   Submitter: dgoncharov
   Submitted: Mon 07 Nov 2022 10:49:05 PM UTC
Severity: 3 - Normal
  Item Group: Bug
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: SCM
Operating System: POSIX-Based
   Fixed Release: None
   Triage Status: None


___

Follow-up Comments:


---
Date: Mon 07 Nov 2022 10:49:05 PM UTC By: Dmitry Goncharov 
.







___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63333] Keep running w/o output sync on temp file failure.

[Paul D. Smith]

Follow-up Comment #3, bug #6 (project make):

Thanks Dmitry.  I already implemented a change and a test for this but I'll
check and see what you've got here too.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63333] Keep running w/o output sync on temp file failure.

[Dmitry Goncharov]

Follow-up Comment #2, bug #6 (project make):

This patch causes make to print an error message and keep running without
output sync on a temp file failure.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63333] Keep running w/o output sync on temp file failure.

[Dmitry Goncharov]

Additional Item Attachment, bug #6 (project make):

File name: sv6_test.diff  Size:2 KB


File name: sv6_fix.diff   Size:5 KB




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63333] Keep running w/o output sync on temp file failure.

[Dmitry Goncharov]

Follow-up Comment #1, bug #6 (project make):

Make treats inability to create a temporary file for output sync as fatal and
aborts the build.


$ cat makefile
all:; $(info hello, world)
$ mkdir temp
$ chmod -w temp
$ # this is make from master
$ TMPDIR=temp ~/src/make/m64/make -Orecurse -j2
make: jobserver mkfifo: temp/GMfifo4536: Permission denied
make: *** create temporary file temp/Gmt5Kg2v: Permission denied.  Stop.
$
$
$ # this is make-4.3
$ TMPDIR=temp ~/src/make/4.3/make -Orecurse -j2
hello, world
make: 'all' is up to date.
$
$ # this is make with this patch
$ TMPDIR=temp ~/src/make/l64/make -Orecurse -j2
make: jobserver mkfifo: temp/GMfifo4577: Permission denied
make: Cannot create temporary file temp/Gm7G9ZwF: Permission denied
make: Cannot open output-sync lock file, suppressing output-sync.
hello, world
make: 'all' is up to date.






___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/