Re: RFR: 8331952: --enable-compatible-cds-alignment should be enabled by default

2024-05-10 Thread Jaikiran Pai
On Fri, 10 May 2024 01:08:29 GMT, xiaotaonan  wrote:

>> --enable-compatible-cds-alignment should be enabled by default
>
> @lgxbslgx

Hello @xiaotaonan, the JBS issue against which this PR has been opened has 
already been closed as a duplicate of 
https://bugs.openjdk.org/browse/JDK-8331942, which itself has already been 
resolved.

-

PR Comment: https://git.openjdk.org/jdk/pull/19150#issuecomment-2103921218


Re: RFR: 8331952: --enable-compatible-cds-alignment should be enabled by default

2024-05-09 Thread xiaotaonan
On Thu, 9 May 2024 01:07:26 GMT, xiaotaonan  wrote:

> --enable-compatible-cds-alignment should be enabled by default

@lgxbslgx

-

PR Comment: https://git.openjdk.org/jdk/pull/19150#issuecomment-2103672340


Re: RFR: 8331952: --enable-compatible-cds-alignment should be enabled by default

2024-05-09 Thread Erik Joelsson
On Thu, 9 May 2024 01:07:26 GMT, xiaotaonan  wrote:

> --enable-compatible-cds-alignment should be enabled by default

Build change looks ok. I think this should be approved by someone from hotspot 
as well.

-

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19150#pullrequestreview-2047945852


RFR: 8331952: --enable-compatible-cds-alignment should be enabled by default

2024-05-08 Thread xiaotaonan
--enable-compatible-cds-alignment should be enabled by default

-

Commit messages:
 - --enable-compatible-cds-alignment should be enabled by default

Changes: https://git.openjdk.org/jdk/pull/19150/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19150=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331952
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19150.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19150/head:pull/19150

PR: https://git.openjdk.org/jdk/pull/19150