Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
On Mon, 05 Mar 2012 15:42:27 -0500 Mario Domenech Goulart mario.goul...@gmail.com wrote: Something changed in the core that makes ugarit and tuples break on 2012/03/04. They were not breaking the day before. You can see the salmonella diff here: http://tests.call-cc.org/master/linux/x86/2012/03/04/yesterday-diff/ The installation error messages for ugarit and tuples are here: http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/tuples.html http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/ugarit.html The core commits range in which the cause of the problems may be is b7f7e36 - b8363cb. Regarding the other eggs that can be seen in the diff: skiplists breaks because it depends on tuples. Hmmm. Not really. skiplists does not depend on tuples (http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/dep-graphs/skiplists.html). It also breaks because of `assert'. Best wishes. Mario -- http://parenteses.org/mario ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
* Mario Domenech Goulart mario.goul...@gmail.com [120312 17:35]: Regarding the other eggs that can be seen in the diff: skiplists breaks because it depends on tuples. Hmmm. Not really. skiplists does not depend on tuples (http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/dep-graphs/skiplists.html). It also breaks because of `assert'. I have opened a ticket for this, it's: http://bugs.call-cc.org/ticket/797 Kind regards, Christian -- Who can (make) the muddy water (clear)? Let it be still, and it will gradually become clear. Who can secure the condition of rest? Let movement go on, and the condition of rest will gradually arise. -- Lao Tse. ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
On Tue, Mar 06, 2012 at 08:23:17AM +0100, Felix wrote: Hi, Something changed in the core that makes ugarit and tuples break on 2012/03/04. They were not breaking the day before. You can see the salmonella diff here: http://tests.call-cc.org/master/linux/x86/2012/03/04/yesterday-diff/ The installation error messages for ugarit and tuples are here: http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/tuples.html http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/ugarit.html The core commits range in which the cause of the problems may be is b7f7e36 - b8363cb. Some use of the assert macro now has line-number information and tries to string-append the msg argument to the file/lineno info string. Apparently assert is called with a non-string msg argument, but I can't disentangle the complex macros used in contracts. Possibly the simplest fix is to use conc instead? Cheers, Peter -- http://sjamaan.ath.cx -- The process of preparing programs for a digital computer is especially attractive, not only because it can be economically and scientifically rewarding, but also because it can be an aesthetic experience much like composing poetry or music. -- Donald Knuth ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
From: Peter Bex peter@xs4all.nl Subject: Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03 Date: Tue, 6 Mar 2012 11:17:11 +0100 On Tue, Mar 06, 2012 at 08:23:17AM +0100, Felix wrote: Hi, Something changed in the core that makes ugarit and tuples break on 2012/03/04. They were not breaking the day before. You can see the salmonella diff here: http://tests.call-cc.org/master/linux/x86/2012/03/04/yesterday-diff/ The installation error messages for ugarit and tuples are here: http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/tuples.html http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/ugarit.html The core commits range in which the cause of the problems may be is b7f7e36 - b8363cb. Some use of the assert macro now has line-number information and tries to string-append the msg argument to the file/lineno info string. Apparently assert is called with a non-string msg argument, but I can't disentangle the complex macros used in contracts. Possibly the simplest fix is to use conc instead? Well, this simply seems to be an incorrect use of assert. It should check the second argument for being a string. It happens to work because error accepts an optional location as initial argument. cheers, felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
* felix winkelmann fe...@call-with-current-continuation.org [120306 12:16]: From: Peter Bex peter@xs4all.nl Subject: Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03 Date: Tue, 6 Mar 2012 11:17:11 +0100 On Tue, Mar 06, 2012 at 08:23:17AM +0100, Felix wrote: Hi, Something changed in the core that makes ugarit and tuples break on 2012/03/04. They were not breaking the day before. You can see the salmonella diff here: http://tests.call-cc.org/master/linux/x86/2012/03/04/yesterday-diff/ The installation error messages for ugarit and tuples are here: http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/tuples.html http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/ugarit.html The core commits range in which the cause of the problems may be is b7f7e36 - b8363cb. Some use of the assert macro now has line-number information and tries to string-append the msg argument to the file/lineno info string. Apparently assert is called with a non-string msg argument, but I can't disentangle the complex macros used in contracts. Possibly the simplest fix is to use conc instead? Well, this simply seems to be an incorrect use of assert. It should check the second argument for being a string. It happens to work because error accepts an optional location as initial argument. I agree and have attached a patch. Cheers, Christian -- Who can (make) the muddy water (clear)? Let it be still, and it will gradually become clear. Who can secure the condition of rest? Let movement go on, and the condition of rest will gradually arise. -- Lao Tse. From 1a2dc5afc24d8318813d5bfdf7932d20b85ec26f Mon Sep 17 00:00:00 2001 From: Christian Kellermann ck...@pestilenz.org Date: Tue, 6 Mar 2012 12:31:40 +0100 Subject: [PATCH] Check assert's msg argument for being a string. --- chicken-syntax.scm |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/chicken-syntax.scm b/chicken-syntax.scm index bed542e..71576b2 100644 --- a/chicken-syntax.scm +++ b/chicken-syntax.scm @@ -175,8 +175,10 @@ (ln (get-line-number form)) (msg-and-args (cddr form)) (msg (if (null? msg-and-args) - assertion failed - (car msg-and-args))) + assertion failed + (let ((msg-str (car msg-and-args))) + (##sys#check-string msg-str 'assert) + msg-str))) (msg (if ln (string-append ( ln ) msg) msg))) -- 1.7.4.1 ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
From: Christian Kellermann ck...@pestilenz.org Subject: Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03 Date: Tue, 6 Mar 2012 12:38:21 +0100 * felix winkelmann fe...@call-with-current-continuation.org [120306 12:16]: From: Peter Bex peter@xs4all.nl Subject: Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03 Date: Tue, 6 Mar 2012 11:17:11 +0100 On Tue, Mar 06, 2012 at 08:23:17AM +0100, Felix wrote: Hi, Something changed in the core that makes ugarit and tuples break on 2012/03/04. They were not breaking the day before. You can see the salmonella diff here: http://tests.call-cc.org/master/linux/x86/2012/03/04/yesterday-diff/ The installation error messages for ugarit and tuples are here: http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/tuples.html http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/ugarit.html The core commits range in which the cause of the problems may be is b7f7e36 - b8363cb. Some use of the assert macro now has line-number information and tries to string-append the msg argument to the file/lineno info string. Apparently assert is called with a non-string msg argument, but I can't disentangle the complex macros used in contracts. Possibly the simplest fix is to use conc instead? Well, this simply seems to be an incorrect use of assert. It should check the second argument for being a string. It happens to work because error accepts an optional location as initial argument. I agree and have attached a patch. Thanks, signed off, pushed and untested. cheers, felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
* felix winkelmann fe...@call-with-current-continuation.org [120306 13:04]: I agree and have attached a patch. Thanks, signed off, pushed and untested. Works for me[tm] -- Who can (make) the muddy water (clear)? Let it be still, and it will gradually become clear. Who can secure the condition of rest? Let movement go on, and the condition of rest will gradually arise. -- Lao Tse. ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
Hi Mario! * Mario Domenech Goulart mario.goul...@gmail.com [120305 21:43]: Regarding the other eggs that can be seen in the diff: skiplists breaks because it depends on tuples. endian-port failed because of some chicken-install failure, it seems (it's been happening frequently lately). The last sentence worries me a bit, can you give me more details? Is it always the same egg, mirror, error? Does it only happen since a specific time? Maybe another bug... Cheers, Christian -- Who can (make) the muddy water (clear)? Let it be still, and it will gradually become clear. Who can secure the condition of rest? Let movement go on, and the condition of rest will gradually arise. -- Lao Tse. ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
Hi Christian, On Tue, 6 Mar 2012 17:50:42 +0100 Christian Kellermann ck...@pestilenz.org wrote: * Mario Domenech Goulart mario.goul...@gmail.com [120305 21:43]: Regarding the other eggs that can be seen in the diff: skiplists breaks because it depends on tuples. endian-port failed because of some chicken-install failure, it seems (it's been happening frequently lately). The last sentence worries me a bit, can you give me more details? Is it always the same egg, mirror, error? Does it only happen since a specific time? I couldn't detect any pattern. Here are some logs that show the chicken-install error: http://tests.call-cc.org/master/linux/x86/2012/02/23/salmonella-report/install/foreigners.html http://tests.call-cc.org/master/linux/x86/2012/02/25/salmonella-report/install/http-client.html http://tests.call-cc.org/master/linux/x86/2012/02/28/salmonella-report/install/nomads.html http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/endian-port.html http://tests.call-cc.org/master/linux/x86/2012/03/05/salmonella-report/install/chickumber.html http://tests.call-cc.org/master/linux/x86/2012/03/06/salmonella-report/install/pastiche.html Best wishes. Mario -- http://parenteses.org/mario ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03
From: Mario Domenech Goulart mario.goul...@gmail.com Subject: [Chicken-hackers] ugarit and tuples start breaking on 2012/03/03 Date: Mon, 05 Mar 2012 15:42:27 -0500 Hi, Something changed in the core that makes ugarit and tuples break on 2012/03/04. They were not breaking the day before. You can see the salmonella diff here: http://tests.call-cc.org/master/linux/x86/2012/03/04/yesterday-diff/ The installation error messages for ugarit and tuples are here: http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/tuples.html http://tests.call-cc.org/master/linux/x86/2012/03/04/salmonella-report/install/ugarit.html The core commits range in which the cause of the problems may be is b7f7e36 - b8363cb. Some use of the assert macro now has line-number information and tries to string-append the msg argument to the file/lineno info string. Apparently assert is called with a non-string msg argument, but I can't disentangle the complex macros used in contracts. Regarding the other eggs that can be seen in the diff: skiplists breaks because it depends on tuples. endian-port failed because of some chicken-install failure, it seems (it's been happening frequently lately). Might be caused by setup-download.scm:408, but that is just a guess. That diff is cool, Mario. Salmonella is getting better every day. cheers, felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
