[chromium-dev] Re: Use of User Macros for RelativePath in vcproj files
I figured it out and thought I'd share with others. Turns out that you have to restart Visual Studio and reload the whole solution for it to pickup the correct paths when you're using a macro. Cheers, Daniel On Jun 9, 10:58 pm, Daniel Cowx daniel.c...@gmail.com wrote: I notice that some of our projects (e.g. chrome_resources) reference GRIT generated files via the RelativePath entry in the *.vcproj file via the user macro $(OutDir). Can someone please provide insight into how this was made to work? I've tried this quite a few times to no avail. Whenever I try to add a user macro (even copy and pasting what's in chrome_resources.vcproj) into my own project, Visual Studio complains that it can't resolve the path. What gives? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is there any way to change the default (i.e. default.dll) theme DLL?
On Tue, Jun 9, 2009 at 9:51 PM, Daniel Cowx daniel.c...@gmail.com wrote: Question: Does anyone have objections to including a default param in the call to ResourceBundle::LoadThemeResources() that causes default.dll to be loaded by default? Default params are forbidden by the Google style guide (as you seem to allude to below). Alternatively, since default params are frowned upon, I could provide a wrapper function in ResourceBundle to accomplish the same end. I suspect the Chromium developers in general are fairly opposed to adding more flexibility (and complexity) to the theme system underpinnings, as (as Mohamed mentioned previously on this thread) official support for theming is mostly in-place and presumably will cover most needs here. Glen Murphy is the best person to ask if you have specific theme questions. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: chrome always break in debugger when run under XCode
Hi,
You should check the code just before logging::LogMessage::~LogMessage().
In this case, you hit DCHECK(!update_in_progress_) in
safe_browing_service.cc at line 466, so that DCHECK breaks here. Because of
DCHECK, I think SafeBrowsingService::UpdateStarted() expects it never called
when update_in_progress_ is true, but the assumption is failed.
--
Fumitoshi Ukai
On Sun, Jun 7, 2009 at 11:48 AM, Nathan Summer
nathan.charles.sum...@gmail.com wrote:
Hi,
I compile chrome and run under XCode.
But it breaks here, can you please tell me why? And what does BreakDebugger
do?
// static
void DebugUtil::BreakDebugger() {
#if defined(ARCH_CPU_ARM_FAMILY)
asm(bkpt 0);
#else
asm(int3);
#endif
}
Here is the stack trace:
#0 0x0058c43f in DebugUtil::BreakDebugger at debug_util_posix.cc:116
#1 0x005ad984 in logging::LogMessage::~LogMessage at logging.cc:545
#2 0x0040e751 in SafeBrowsingService::UpdateStarted at
safe_browsing_service.cc:466
#3 0x003e7c4a in SafeBrowsingProtocolManager::IssueUpdateRequest at
protocol_manager.cc:486
#4 0x003e7cc9 in SafeBrowsingProtocolManager::GetNextUpdate at
protocol_manager.cc:157
#5 0x003ed24a in DispatchToMethodSafeBrowsingProtocolManager, void
(SafeBrowsingProtocolManager::*)() at tuple.h:412
#6 0x003ed28d in base::BaseTimerSafeBrowsingProtocolManager,
false::TimerTask::Run at timer.h:160
#7 0x005b07c3 in MessageLoop::RunTask at message_loop.cc:309
#8 0x005b0b87 in MessageLoop::DeferOrRunPendingTask at message_loop.cc:317
#9 0x005b0d0a in MessageLoop::DoDelayedWork at message_loop.cc:450
#10 0x005bb154 in base::MessagePumpLibevent::Run at
message_pump_libevent.cc:228
#11 0x005b18bb in MessageLoop::RunInternal at message_loop.cc:198
#12 0x005b18d7 in MessageLoop::RunHandler at message_loop.cc:181
#13 0x005b1962 in MessageLoop::Run at message_loop.cc:155
#14 0x005f30a9 in base::Thread::ThreadMain at thread.cc:156
#15 0x005c72c4 in ThreadFunc at platform_thread_posix.cc:26
#16 0x92129155 in _pthread_start
#17 0x92129012 in thread_start
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Bookmark system not reliable enough for user preferences
Sorry Topic is a bit old. I think that including folders in bookmark search API makes sense. For example, I'm just finishing a little extension that creates loads rss feeds into a bookmark folder on the bookmark bar to simulate the feature that is available in firefox and IE8. To keep track of what folder I'm modifying, I want to search for the folder title. It seems to make sense that if people are creating, moving or removing folders using the bookmark api, they might want to search for folders too. Granted, my issue is overcome by having local storage for extensions... but thats not the point. I understand that chrome wants to be as nimble as possible, but given the way bookmarks work and are stored, don't you actually have to filter folders from the search? The data structure is the same for both a folder and a bookmark. So why not make the API fully featured? Isn't one point of such an API that 3rd parties can do things the original dev's didn't think of? -Peter On May 20, 5:54 pm, Aaron Boodman a...@chromium.org wrote: On Tue, May 19, 2009 at 11:35 AM, jack js2...@gmail.com wrote: Sorry for this late response. I was piled up in the past days. I did some additional trials. It's quite random and it is hard to get unique results. But let's handle it one by one. I am attaching a sample toolstrip.html file. For a clean test make sure your bookmark list is empty. When the page is loaded it will check the existence of a folder and create it (together w/ an item) if needed. In my test, the item will never be created in the folder. It will be either created in the bookmark bar, or under the root folder, or not at all. You can also click on the icon in the toolstrip to manually check the folder. In this case, I got correct result in one machine, but random (as aforementioned) in another machine (note this another machine is using a different language version). Also, a folder is never found by chrome.bookmarks.search(). It is easy for you to test it so I didn't include it in the html file. Hi Jack, I can repro this. The problem is a race at startup. If you delay calling the APIs awhile, it would work correctly. I've created a bug for this, if you're interested:http://code.google.com/p/chromium/issues/detail?id=12353 As for searching for bookmark folders, I'm not sure we want to add it. If it wasn't for this weird use case of using the bookmark system as storage, I don't know if anybody would ever need that. Hopefully real storage appears soon, and we can use that instead. - a --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] 2 problems with extension development
I am on Vista 64, Chrome dev ver. 3.0.183.1
I am building simple continuous build extension (fetches last status
from the server, as text file, parses result, and sets toolstrip
button).
Problems:
1. My javascript console is blank. Even simple javascript: console.log
(1); doesn't do anything. In fact there was a bug filed, but it seems
it was closed in April (I can look up exact bug number).
2. In my background page when I iterate over views I get back 1
element, backend page itself. Code looks like:
...
var views = chrome.self.getViews();
for (var i in views) {
if (views[i].toggleStripStatus)
views[i].toggleStripStatus(status);
}
...
It's pretty hard to debug this (since console is out, and this is
backend page so alerts don't work), but I managed to inspect views
variable, and it has only 1 element, and that element is backend page
itself.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: No symbols for Google Chrome 2.0.172.30
Hey Nicolas,
Did these symbols ever get uploaded?
Thanks
On Sun, Jun 7, 2009 at 2:55 AM, yuhongyuhongbao_...@hotmail.com wrote:
SYMSRV:
http://build.chromium.org/buildbot/symsrv/chrome_exe.pdb/0C57BF1B1D3D48
49B3037D4FE9424CCC2/chrome_exe.pdb not found
DBGHELP: chrome - no symbols loaded
[SYMCHK] MODULE64 Info --
[SYMCHK] Struct size: 1672 bytes
[SYMCHK] Base: 0x0040
[SYMCHK] Image size: 782336 bytes
[SYMCHK] Date: 0x4a128615
[SYMCHK] Checksum: 0x000c0d3d
[SYMCHK] NumSyms: 0
[SYMCHK] SymType: SymNone
[SYMCHK] ModName: chrome
[SYMCHK] ImageName: C:\Users\bob\AppData\Local\Google\Chrome
\Application\chrome.
exe
[SYMCHK] LoadedImage: C:\Users\bob\AppData\Local\Google\Chrome
\Application\chrom
e.exe
[SYMCHK] PDB:
[SYMCHK] CV: RSDS
[SYMCHK] CV DWORD: 0x53445352
[SYMCHK] CV Data: C:\b\slave\chrome-official-2\build\src\chrome
\Release\chrome_
exe.pdb
[SYMCHK] PDB Sig: 0
[SYMCHK] PDB7 Sig: {----}
[SYMCHK] Age: 0
[SYMCHK] PDB Matched: TRUE
[SYMCHK] DBG Matched: TRUE
[SYMCHK] Line nubmers: FALSE
[SYMCHK] Global syms: FALSE
[SYMCHK] Type Info:FALSE
[SYMCHK]
SymbolCheckVersion 0x0002
Result 0x00010001
DbgFilename chrome.dbg
DbgTimeDateStamp0x
DbgSizeOfImage 0x
DbgChecksum 0x
PdbFilename C:\b\slave\chrome-official-2\build\src\chrome
\Release\chrome
_exe.pdb
PdbSignature{0C57BF1B-1D3D-4849-B303-7D4FE9424CCC}
PdbDbiAge 0x0002
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: No symbols for Google Chrome 2.0.172.30
Looks like it did not.
I'll investigate why.
thanks
Nicolas
On Wed, Jun 10, 2009 at 1:00 AM, Dean McNamee de...@chromium.org wrote:
Hey Nicolas,
Did these symbols ever get uploaded?
Thanks
On Sun, Jun 7, 2009 at 2:55 AM, yuhongyuhongbao_...@hotmail.com wrote:
SYMSRV:
http://build.chromium.org/buildbot/symsrv/chrome_exe.pdb/0C57BF1B1D3D48
49B3037D4FE9424CCC2/chrome_exe.pdb not found
DBGHELP: chrome - no symbols loaded
[SYMCHK] MODULE64 Info --
[SYMCHK] Struct size: 1672 bytes
[SYMCHK] Base: 0x0040
[SYMCHK] Image size: 782336 bytes
[SYMCHK] Date: 0x4a128615
[SYMCHK] Checksum: 0x000c0d3d
[SYMCHK] NumSyms: 0
[SYMCHK] SymType: SymNone
[SYMCHK] ModName: chrome
[SYMCHK] ImageName: C:\Users\bob\AppData\Local\Google\Chrome
\Application\chrome.
exe
[SYMCHK] LoadedImage: C:\Users\bob\AppData\Local\Google\Chrome
\Application\chrom
e.exe
[SYMCHK] PDB:
[SYMCHK] CV: RSDS
[SYMCHK] CV DWORD: 0x53445352
[SYMCHK] CV Data: C:\b\slave\chrome-official-2\build\src\chrome
\Release\chrome_
exe.pdb
[SYMCHK] PDB Sig: 0
[SYMCHK] PDB7 Sig: {----}
[SYMCHK] Age: 0
[SYMCHK] PDB Matched: TRUE
[SYMCHK] DBG Matched: TRUE
[SYMCHK] Line nubmers: FALSE
[SYMCHK] Global syms: FALSE
[SYMCHK] Type Info:FALSE
[SYMCHK]
SymbolCheckVersion 0x0002
Result 0x00010001
DbgFilename chrome.dbg
DbgTimeDateStamp0x
DbgSizeOfImage 0x
DbgChecksum 0x
PdbFilename C:\b\slave\chrome-official-2\build\src\chrome
\Release\chrome
_exe.pdb
PdbSignature{0C57BF1B-1D3D-4849-B303-7D4FE9424CCC}
PdbDbiAge 0x0002
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: No symbols for Google Chrome 2.0.172.30
And same problem for Stable 2.0.172.31 released June 9.
On Jun 10, 6:19 am, Nicolas Sylvain nsylv...@chromium.org wrote:
Looks like it did not.
I'll investigate why.
thanks
Nicolas
On Wed, Jun 10, 2009 at 1:00 AM, Dean McNamee de...@chromium.org wrote:
Hey Nicolas,
Did these symbols ever get uploaded?
Thanks
On Sun, Jun 7, 2009 at 2:55 AM, yuhongyuhongbao_...@hotmail.com wrote:
SYMSRV:
http://build.chromium.org/buildbot/symsrv/chrome_exe.pdb/0C57BF1B1D3D48
49B3037D4FE9424CCC2/chrome_exe.pdb not found
DBGHELP: chrome - no symbols loaded
[SYMCHK] MODULE64 Info --
[SYMCHK] Struct size: 1672 bytes
[SYMCHK] Base: 0x0040
[SYMCHK] Image size: 782336 bytes
[SYMCHK] Date: 0x4a128615
[SYMCHK] Checksum: 0x000c0d3d
[SYMCHK] NumSyms: 0
[SYMCHK] SymType: SymNone
[SYMCHK] ModName: chrome
[SYMCHK] ImageName: C:\Users\bob\AppData\Local\Google\Chrome
\Application\chrome.
exe
[SYMCHK] LoadedImage: C:\Users\bob\AppData\Local\Google\Chrome
\Application\chrom
e.exe
[SYMCHK] PDB:
[SYMCHK] CV: RSDS
[SYMCHK] CV DWORD: 0x53445352
[SYMCHK] CV Data: C:\b\slave\chrome-official-2\build\src\chrome
\Release\chrome_
exe.pdb
[SYMCHK] PDB Sig: 0
[SYMCHK] PDB7 Sig: {----}
[SYMCHK] Age: 0
[SYMCHK] PDB Matched: TRUE
[SYMCHK] DBG Matched: TRUE
[SYMCHK] Line nubmers: FALSE
[SYMCHK] Global syms: FALSE
[SYMCHK] Type Info: FALSE
[SYMCHK]
SymbolCheckVersion 0x0002
Result 0x00010001
DbgFilename chrome.dbg
DbgTimeDateStamp 0x
DbgSizeOfImage 0x
DbgChecksum 0x
PdbFilename C:\b\slave\chrome-official-2\build\src\chrome
\Release\chrome
_exe.pdb
PdbSignature {0C57BF1B-1D3D-4849-B303-7D4FE9424CCC}
PdbDbiAge 0x0002
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: confused with chrome's version control
For Continous builds, from http://dev.chromium.org/developers/how-tos/get-the-code in the section Staying Green More Of The Time, it says regarding the LATEST Continuous build that http://build.chromium.org/buildbot/ continuous/LATEST/REVISION - This corresponds to the most recent revision that passed both unit tests and layout tests. My inference from that is the LATEST Continuous build passed [all of] both unit tests and layout tests, as opposed to most of the tests. And further, this applies to all Continuous builds, including the LATEST one. On Jun 10, 1:14 am, Jickae Davis jick...@gmail.com wrote: Well, maybe I should rectify it a little after I took a glance athttp://build.chromium.org/buildbot/waterfall/console Snapshot : only builded successfully Continuous : builded successfully, be tested(not every test is gonna be successful. It seems no revision will pass all the tests even only on Windows.) tarball : the latest version that is builded sucessfully, tested and has passed the most tests, while a day ends. Is that right? 2009/6/9 dhhwai dhh...@gmail.com Hi Jickae, Your summary is all correct, with the addition of Thomas' note: the source tarball is raw source code. This is useful if you want to see the actual C++ source used to program Chromium. So as Thomas said, gclient sync --revision s...@ will get you the source code of a specific revision number, or just gclient sync will get you the latest source code. If you just want to test run specific revisions of Chromium, you can download the executable binaries from these directories: http://build.chromium.org/buildbot/snapshots/chromium-rel-xp/?C=N;O=D http://build.chromium.org/buildbot/continuous/win/?C=N;O=D These are URLs to the Windows builds sorted most recent first. There are other directory names (below snapshots and below continuous) for the Linux and Mac versions. On Jun 9, 6:40 am, Thomas Van Lenten thoma...@chromium.org wrote: From the very end ofhttp:// dev.chromium.org/developers/how-tos/get-the-code gclient sync --revision s...@ TVL On Tue, Jun 9, 2009 at 9:27 AM, Jickae Davis jick...@gmail.com wrote: And I also encountered a new question. How to update to certain revision of different kinds(snapshot/continuous/tarball). For example, I want chrome r17830 of snapshot/continuous/tarball. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Chromium-dev group. To post to this group, send email to chromium-dev@googlegroups.com To unsubscribe from this group, send email to chromium-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~--~~~~--~~--~--~---
[chromium-dev] Re: sqlite3 usage in chromium
FYI, the url to search chromium sources is http://www.google.com/codesearch?q=package:src.chromium.org/svn/trunk; On Tue, Jun 9, 2009 at 10:44 PM, Jeremy Orlowjor...@google.com wrote: It is used for other stuff. It shouldn't be too hard to search the code base to find out specifically where. On Tue, Jun 9, 2009 at 7:23 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: Hi, I see chromium uses sqlite3. Does it use it for Google Gear only? or it uses it for other stuff, e.g. cookies, bookmark, history, user settings Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Extension API for Find Bar
I have not seen any mention of an API to interact with the Find in Page bar or it's results/actions. This would be useful for a number of reasons, but I'm specifically thinking of an extension implementing find-as-you-type. (seeing as Issue 150 is closed with will not fix.) If this is available or planned for a separate API or incorporation into the window or tab api please point in the right direction. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: if you get gcl error ['svn', 'cat', somefile]
No, Marc-Antoine will enable a presubmit check today (tentative) so it won't happen anymore. And if you are a git user, ya better not break anything. M-A On Wed, Jun 10, 2009 at 12:32 PM, cpuc...@chromium.org wrote: I spent a ton of time tracking this so for the record: If you made a change to some files and gcl change works but when you try to do gcl upload you get this error: Got error status from ['svn', 'cat', 'somefile'] // Copyright (c) 2006-2009 The Chromim authors .. partial dump of the file here Then there are two likely possibilities: 1) the file somefile has inconsistent line endings in your copy 2) the file somefile has a problem as it exists in the svn server For #1 you can fix in your copy (not my case), for #2 you need to contact Marc-Antoine :) Actually Marc-Antoine will post the magic trick here so he would not get pestered again. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] throwError() in V8 bindings
I've seen quite a few instances of these idioms: 1) if (ec) throwError(ec); 2) if (ec) throwError(ec); return v8::Undefined() It's not obvious from the documentation, but throwError() always returns v8::Undefined(), and it does nothing if ec == 0. So the code above could be rewritten as: 1) throwError(ec); 2) return throwError(ec); Something to keep in mind/clean up as people work on the bindings - there's already a bunch of boilerplate idioms in the binding so every little bit helps :) -atw --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Renderer Process and Browser Process
From this document, it talks about Messaging between
http://dev.chromium.org/developers/design-documents/displaying-a-web-page-in-chrome
Can you please help me understand what is the Message Flow for an Alert Dialog?
like in this case:
htmlscript function f1() { var a = 1; alert(hello); a = 2;};
f1(); /script/html
I assume it is like this, please correct me if i am wrong:
1. Browser Process downloads the test page
2. Renderer Process gets the html source, parses the html and have v8
executes script node
3. v8 pauses at 'alert' call, sends a message to Browser Process to
pop up the alert dialog and Render Process blocked till it receives
message from Browser.
4. Browser Process shows the alert dialog with the right message (in
this case 'hello')
5. When user clicks 'Okay', browser process sends a message back to
Renderer Process and v8 continues execute the rest of the Script node.
Is this correct?
Thank you for any clarificaiton.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Adding Mac OS X Spellchecker to Chromium
I believe that's what we're talking about here. (the other) Jeremy's been talking about the OSX spellchecker. The one issue is that the default checker doesn't handle all the languages Chrome supports, hence If the need arises,wrapping hunspell as an Apple Spelling service and provide it as a separate project users can install. So I think we're all on the same page here. On Wed, Jun 10, 2009 at 11:38 AM, p_W paulwoolcoc...@gmail.com wrote: Forgive my (possibly) stupid concern here, but a few months ago there was some talk about this, and about how integrating with the OS's spellchecker was the preferred route as it allowed users to use their dictionary customizations over all their applications. Here is link to the discussion: http://groups.google.com/group/chromium-dev/browse_thread/thread/31832b99aeb953d7/d722d0f183a0b35f?hl=enlnk=gstq=OSX+spell#d722d0f183a0b35f Any thoughts about this? On Jun 9, 9:00 pm, Jeremy Moskovich jer...@chromium.org wrote: A couple more things: * I think ultimately we should support the grammar checker, but at first just getting spellchecking to work would be great! * +1 for supporting the Cocoa gui for spellchecking paragraphs, see the 2nd paragraph bellow for more thoughts on this. Matching Linux Windows functionality is a non-goal IMHO, to reiterate we want to behave like a native Cocoa application. WebKit/Safari already support these features so the issue is to get the plumbing working right in our multiprocess model (which may be non-trivial). IMHO the correct route here is to look at how this is done in WebKit and match the behavior there as much as possible, that's what I'm doing with the keyboard events at the moment and it's proving pretty fruitful. It's really exciting you're working on this!! Best regards, Jeremy On Tue, Jun 9, 2009 at 5:50 PM, Jeremy Moskovich jer...@chromium.org wrote: IMHO there is no need to maintain dual hunspell/OSX spellchecker backends. There are addon OSX spellcheckers for other languages e.g. http://www.mitzpettel.com/software/hspell.php . Writing additional spelling servers is pretty simple so I think the correct approach would be: 1. Getting OSX spelling/grammar checking support working well. 2. If the need arises, wrapping hunspell as an Apple Spelling service and provide it as a separate project users can install. Best regards, Jeremy On Tue, Jun 9, 2009 at 5:32 PM, Paul Wicks pwick...@gmail.com wrote: Crap, sorry to post an incomplete version of this post earlier. Accidentally hit send before I finished it. Argh... Anyway, I've been looking at implementing support for the OS X spellchecker on the Mac build as part of my SoC project and I thought I'd run some thoughts I had today by the list. For the basic design, both hunspell and the os x spellchecker need to be usable, since hunspell supports more languages than OS X does. The public interface of the Spellchecker class is fairly small (mainly 2 methods: SpellCheckWord, AddWord). It seems that mapping these onto the OS X spellchecker shouldn't be too hard. I originally thought to do something more elaborate and create seperate spellchecker classes for each platform, but then realized that I could do it more simply as follows: -leave the majority of spellchecker.cc as is. It works and I don't see any reason to mess with what works. -for SpellCheckWord, change the call to hunspell_-spell(...) to call a (new) private method in the SpellChecker class. In this method, add some code at the beginning that will check if we are on the mac and if the built-in spellchecker supports the current language and if so checks the word using it, other wise using hunspell as before. This way, we can leave the rest of the code alone and still use the SpellCheckWordIterator to grab individual words out of the string. As for getting the suggestions for a word, it might make sense to do things a little differently, since there is no need to create and manage the char** suggestions variable to pass to hunspell, as NSSpellChecker can give us an easy-to-iterate-through NSArray. Probably just an #if defined(OS_MACOSX) would suffice here, since the code here will be wholly different. -for AddWord, their probably isn't as much of a need to abstract the hunspell specific code (it's all hunspell code), so just an #if defined( OS_MACOSX)+language support check would suffice. -The other public methods all deal with language selection and querying, which should remain the same, since the OS X spellchecker only supports a subset of the languages supported by hunspell. (there may need to be a little bit of code to translate between the codes for supported languages so that the built-in spellchecker always gets used when it should, but this should be a relatively simple
[chromium-dev] Re: Adding Mac OS X Spellchecker to Chromium
On Wed, Jun 10, 2009 at 2:38 PM, p_W paulwoolcoc...@gmail.com wrote: Forgive my (possibly) stupid concern here, but a few months ago there was some talk about this, and about how integrating with the OS's spellchecker was the preferred route as it allowed users to use their dictionary customizations over all their applications. Here is link to the discussion: http://groups.google.com/group/chromium-dev/browse_thread/thread/31832b99aeb953d7/d722d0f183a0b35f?hl=enlnk=gstq=OSX+spell#d722d0f183a0b35f Any thoughts about this? Uh, that's what this thread is about, his project is to switch to using the os one instead. And Jeremy was commenting that he doesn't need to support both, just switch to the native. Or am I reading this differently? TVL On Jun 9, 9:00 pm, Jeremy Moskovich jer...@chromium.org wrote: A couple more things: * I think ultimately we should support the grammar checker, but at first just getting spellchecking to work would be great! * +1 for supporting the Cocoa gui for spellchecking paragraphs, see the 2nd paragraph bellow for more thoughts on this. Matching Linux Windows functionality is a non-goal IMHO, to reiterate we want to behave like a native Cocoa application. WebKit/Safari already support these features so the issue is to get the plumbing working right in our multiprocess model (which may be non-trivial). IMHO the correct route here is to look at how this is done in WebKit and match the behavior there as much as possible, that's what I'm doing with the keyboard events at the moment and it's proving pretty fruitful. It's really exciting you're working on this!! Best regards, Jeremy On Tue, Jun 9, 2009 at 5:50 PM, Jeremy Moskovich jer...@chromium.org wrote: IMHO there is no need to maintain dual hunspell/OSX spellchecker backends. There are addon OSX spellcheckers for other languages e.g. http://www.mitzpettel.com/software/hspell.php . Writing additional spelling servers is pretty simple so I think the correct approach would be: 1. Getting OSX spelling/grammar checking support working well. 2. If the need arises, wrapping hunspell as an Apple Spelling service and provide it as a separate project users can install. Best regards, Jeremy On Tue, Jun 9, 2009 at 5:32 PM, Paul Wicks pwick...@gmail.com wrote: Crap, sorry to post an incomplete version of this post earlier. Accidentally hit send before I finished it. Argh... Anyway, I've been looking at implementing support for the OS X spellchecker on the Mac build as part of my SoC project and I thought I'd run some thoughts I had today by the list. For the basic design, both hunspell and the os x spellchecker need to be usable, since hunspell supports more languages than OS X does. The public interface of the Spellchecker class is fairly small (mainly 2 methods: SpellCheckWord, AddWord). It seems that mapping these onto the OS X spellchecker shouldn't be too hard. I originally thought to do something more elaborate and create seperate spellchecker classes for each platform, but then realized that I could do it more simply as follows: -leave the majority of spellchecker.cc as is. It works and I don't see any reason to mess with what works. -for SpellCheckWord, change the call to hunspell_-spell(...) to call a (new) private method in the SpellChecker class. In this method, add some code at the beginning that will check if we are on the mac and if the built-in spellchecker supports the current language and if so checks the word using it, other wise using hunspell as before. This way, we can leave the rest of the code alone and still use the SpellCheckWordIterator to grab individual words out of the string. As for getting the suggestions for a word, it might make sense to do things a little differently, since there is no need to create and manage the char** suggestions variable to pass to hunspell, as NSSpellChecker can give us an easy-to-iterate-through NSArray. Probably just an #if defined(OS_MACOSX) would suffice here, since the code here will be wholly different. -for AddWord, their probably isn't as much of a need to abstract the hunspell specific code (it's all hunspell code), so just an #if defined( OS_MACOSX)+language support check would suffice. -The other public methods all deal with language selection and querying, which should remain the same, since the OS X spellchecker only supports a subset of the languages supported by hunspell. (there may need to be a little bit of code to translate between the codes for supported languages so that the built-in spellchecker always gets used when it should, but this should be a relatively simple matter. -The private method IsValidContraction could call the same new private method as defined above. -This way, the public interface stays the
[chromium-dev] How do you create a frameless window via views?
I need to create a frameless window using views, but I've hit a bit of a roadblock that I'm hoping someone can help me out with. Using the documentation http://dev.chromium.org/developers/design-documents/views-windowing, I can create a window (mods required though as this is out of date with Ben's changes to views...btw, way to go Benmuch appreciated!), but I dont want the frame. How can I remove it? I tried subclass WindowWin and setting: In ctor: ... set_window_style(WS_POPUP | WS_CLIPCHILDREN | WS_CLIPSIBLINGS | WS_VISIBLE); set_window_ex_style(WS_EX_TOOLWINDOW); Init(NULL, view_-bounds()); ... But I get an assertion in the call to Init() b/c a non client view is expected. How do I solve this? Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do you create a frameless window via views?
On Wed, Jun 10, 2009 at 12:17 PM, Daniel Cowx daniel.c...@gmail.com wrote: I tried subclass WindowWin and setting: You're subclassing the wrong class. WindowWin is for windows with a frame. Use WidgetWin instead. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do you create a frameless window via views?
On Wed, Jun 10, 2009 at 12:30 PM, Ben Goodger (Google) b...@chromium.orgwrote: Not technically... Window is for things that have Window semantics and want to use the delegate. Widget is for things that don't. Right now the comments say that WindowWin is for things that have a caption and a frame border. If that's not the distinction you want to make, the comments should probably be changed. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: throwError() in V8 bindings
Maybe it would be worth sweeping through the whole bindings and fixing all obvious instances of this. Otherwise the bad idiom will continue to spread like moss. I'm happy to review the change (either @chromium.org or @webkit.org). Adam On Wed, Jun 10, 2009 at 10:20 AM, Drew Wilsonatwil...@chromium.org wrote: I've seen quite a few instances of these idioms: 1) if (ec) throwError(ec); 2) if (ec) throwError(ec); return v8::Undefined() It's not obvious from the documentation, but throwError() always returns v8::Undefined(), and it does nothing if ec == 0. So the code above could be rewritten as: 1) throwError(ec); 2) return throwError(ec); Something to keep in mind/clean up as people work on the bindings - there's already a bunch of boilerplate idioms in the binding so every little bit helps :) -atw --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: throwError() in V8 bindings
No wonder it is used this way. Am I the only one who think the name is bad? It is called 'throw' although it doesn't throw and there is no indication that it may do nothing. On Wed, Jun 10, 2009 at 10:35 PM, Adam Barth aba...@chromium.org wrote: Maybe it would be worth sweeping through the whole bindings and fixing all obvious instances of this. Otherwise the bad idiom will continue to spread like moss. I'm happy to review the change (either @chromium.org or @webkit.org). Adam On Wed, Jun 10, 2009 at 10:20 AM, Drew Wilsonatwil...@chromium.org wrote: I've seen quite a few instances of these idioms: 1) if (ec) throwError(ec); 2) if (ec) throwError(ec); return v8::Undefined() It's not obvious from the documentation, but throwError() always returns v8::Undefined(), and it does nothing if ec == 0. So the code above could be rewritten as: 1) throwError(ec); 2) return throwError(ec); Something to keep in mind/clean up as people work on the bindings - there's already a bunch of boilerplate idioms in the binding so every little bit helps :) -atw --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 problems with extension development
I tried that too, but as I said, tools are broken for me. JavaScript console
window looks badly rendered (has frame, you can click on a button that shows
command line, but that's about it). See bug
http://code.google.com/p/chromium/issues/detail?id=7800
Cira
On Wed, Jun 10, 2009 at 1:21 AM, Guria guria...@gmail.com wrote:
Have you tried to right click on toolstrip.
As I know that should bring up devtools running in yurs toolstrip
envionronment.
On 10 июн, 03:53, Nebojša Ćirić nci...@gmail.com wrote:
I am on Vista 64, Chrome dev ver. 3.0.183.1
I am building simple continuous build extension (fetches last status
from the server, as text file, parses result, and sets toolstrip
button).
Problems:
1. My javascript console is blank. Even simple javascript: console.log
(1); doesn't do anything. In fact there was a bug filed, but it seems
it was closed in April (I can look up exact bug number).
2. In my background page when I iterate over views I get back 1
element, backend page itself. Code looks like:
...
var views = chrome.self.getViews();
for (var i in views) {
if (views[i].toggleStripStatus)
views[i].toggleStripStatus(status);
}
...
It's pretty hard to debug this (since console is out, and this is
backend page so alerts don't work), but I managed to inspect views
variable, and it has only 1 element, and that element is backend page
itself.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: 2 problems with extension development
This is a known issue: the inspector is busted in the current dev
build. It should be fixed in the next dev release.
-a
On Wed, Jun 10, 2009 at 2:00 PM, Nebojša Ćirićnci...@gmail.com wrote:
I tried that too, but as I said, tools are broken for me. JavaScript console
window looks badly rendered (has frame, you can click on a button that shows
command line, but that's about it). See bug
http://code.google.com/p/chromium/issues/detail?id=7800
Cira
On Wed, Jun 10, 2009 at 1:21 AM, Guria guria...@gmail.com wrote:
Have you tried to right click on toolstrip.
As I know that should bring up devtools running in yurs toolstrip
envionronment.
On 10 июн, 03:53, Nebojša Ćirić nci...@gmail.com wrote:
I am on Vista 64, Chrome dev ver. 3.0.183.1
I am building simple continuous build extension (fetches last status
from the server, as text file, parses result, and sets toolstrip
button).
Problems:
1. My javascript console is blank. Even simple javascript: console.log
(1); doesn't do anything. In fact there was a bug filed, but it seems
it was closed in April (I can look up exact bug number).
2. In my background page when I iterate over views I get back 1
element, backend page itself. Code looks like:
...
var views = chrome.self.getViews();
for (var i in views) {
if (views[i].toggleStripStatus)
views[i].toggleStripStatus(status);
}
...
It's pretty hard to debug this (since console is out, and this is
backend page so alerts don't work), but I managed to inspect views
variable, and it has only 1 element, and that element is backend page
itself.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Any way to compile webkit faster
Hello, Ever since webkit converted to GYP, the time, chromium compilation went from 25 minutes to literally 1 hour and 20+ minutes. (that is by just doing a gclient sync every day) Are there any suggestions on how to make it quicker? (yes I followed the dev documentation) and I have applied the following /MP tags, http://codereview.chromium.org/115603 http://codereview.chromium.org/115603But I don't understand why my CPU is set to 20-25% active for webkit compilation and chromium uses 100%. It is really getting annoying for any gclient sync, I have to wait roughly 1hr + for me to use the code again. Out of my two to three hours a day working on chromium (about), two thirds of it goes on compiling. I would rather be productive and land couple of patches. Any suggestions is highly appreciated. -- Mohamed Mansour --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Is there any logging to print out messaging between Browser and Renderer
Hi, Is there any logging to print out messaging between Browser and Renderer processes? If yes, can you please tell me how to enable it? And where does the log go? Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Any way to compile webkit faster
Most of the losses were regained for me about 2 weeks ago... I am somewhat surprised to hear that you're still getting bad performance. Are you re-running gyp after you apply the /MP patch? -Ben On Wed, Jun 10, 2009 at 7:19 PM, Mohamed Mansourm0.interact...@gmail.com wrote: Hello, Ever since webkit converted to GYP, the time, chromium compilation went from 25 minutes to literally 1 hour and 20+ minutes. (that is by just doing a gclient sync every day) Are there any suggestions on how to make it quicker? (yes I followed the dev documentation) and I have applied the following /MP tags, http://codereview.chromium.org/115603 But I don't understand why my CPU is set to 20-25% active for webkit compilation and chromium uses 100%. It is really getting annoying for any gclient sync, I have to wait roughly 1hr + for me to use the code again. Out of my two to three hours a day working on chromium (about), two thirds of it goes on compiling. I would rather be productive and land couple of patches. Any suggestions is highly appreciated. -- Mohamed Mansour --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is there any logging to print out messaging between Browser and Renderer
You can pass in --log-level=N to the command line, where N is 0 = INFO 1 = WARNING 2 = ERROR 3 = FATAL The default login level is set to 1 which is WARNING. -- Mohamed Mansour On Wed, Jun 10, 2009 at 10:24 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: Hi, Is there any logging to print out messaging between Browser and Renderer processes? If yes, can you please tell me how to enable it? And where does the log go? Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Any way to compile webkit faster
What does your NUMBER_OF_PROCESSORS environment variable have set?What happens if you set it explicitly to 4? -BradN On Wed, Jun 10, 2009 at 7:43 PM, Mohamed Mansour m0.interact...@gmail.comwrote: +dev -- Forwarded message -- From: Mohamed Mansour m0.interact...@gmail.com Date: Wed, Jun 10, 2009 at 10:43 PM Subject: Re: [chromium-dev] Any way to compile webkit faster To: Ben Goodger (Google) b...@chromium.org Yes, I do this all the time after every gclient sync --force, gclient runhooks --force Does your webkit use all 4 CPU's while compiling? Mine just uses 1 CPU at 100% the others nothing. While chromium just uses all 4 at 100%. -- Mohamed Mansour On Wed, Jun 10, 2009 at 10:38 PM, Ben Goodger (Google) b...@chromium.orgwrote: Most of the losses were regained for me about 2 weeks ago... I am somewhat surprised to hear that you're still getting bad performance. Are you re-running gyp after you apply the /MP patch? -Ben On Wed, Jun 10, 2009 at 7:19 PM, Mohamed Mansourm0.interact...@gmail.com wrote: Hello, Ever since webkit converted to GYP, the time, chromium compilation went from 25 minutes to literally 1 hour and 20+ minutes. (that is by just doing a gclient sync every day) Are there any suggestions on how to make it quicker? (yes I followed the dev documentation) and I have applied the following /MP tags, http://codereview.chromium.org/115603 But I don't understand why my CPU is set to 20-25% active for webkit compilation and chromium uses 100%. It is really getting annoying for any gclient sync, I have to wait roughly 1hr + for me to use the code again. Out of my two to three hours a day working on chromium (about), two thirds of it goes on compiling. I would rather be productive and land couple of patches. Any suggestions is highly appreciated. -- Mohamed Mansour --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Any way to compile webkit faster
FWIW - There also is a setting in Developer Studio that specifies how many projects Visual Studio can build simultaneously. Maybe it is unrelated but I wonder if that is set to 1 or something for you? Tools \ Options \ Projects and Solutions \ Build and Run. I have a Quad Core and have this set to 4. PS. Why don't you just use gclient sync and build solution/F5? I never use the --force param when sync'ing and haven't needed to use runhooks yet. Yet I have no problems with my build... On Wed, Jun 10, 2009 at 19:43, Mohamed Mansour m0.interact...@gmail.comwrote: +dev -- Forwarded message -- From: Mohamed Mansour m0.interact...@gmail.com Date: Wed, Jun 10, 2009 at 10:43 PM Subject: Re: [chromium-dev] Any way to compile webkit faster To: Ben Goodger (Google) b...@chromium.org Yes, I do this all the time after every gclient sync --force, gclient runhooks --force Does your webkit use all 4 CPU's while compiling? Mine just uses 1 CPU at 100% the others nothing. While chromium just uses all 4 at 100%. -- Mohamed Mansour On Wed, Jun 10, 2009 at 10:38 PM, Ben Goodger (Google) b...@chromium.orgwrote: Most of the losses were regained for me about 2 weeks ago... I am somewhat surprised to hear that you're still getting bad performance. Are you re-running gyp after you apply the /MP patch? -Ben On Wed, Jun 10, 2009 at 7:19 PM, Mohamed Mansourm0.interact...@gmail.com wrote: Hello, Ever since webkit converted to GYP, the time, chromium compilation went from 25 minutes to literally 1 hour and 20+ minutes. (that is by just doing a gclient sync every day) Are there any suggestions on how to make it quicker? (yes I followed the dev documentation) and I have applied the following /MP tags, http://codereview.chromium.org/115603 But I don't understand why my CPU is set to 20-25% active for webkit compilation and chromium uses 100%. It is really getting annoying for any gclient sync, I have to wait roughly 1hr + for me to use the code again. Out of my two to three hours a day working on chromium (about), two thirds of it goes on compiling. I would rather be productive and land couple of patches. Any suggestions is highly appreciated. -- Mohamed Mansour --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Adding Mac OS X Spellchecker to Chromium
I think platform integration is far more important than feature parity, to be honest. Linux user here, but I'd much rather see libenchant used like the rest of GNOME today instead of some other spelling library I haven't heard of. If OS X users want hunspell I think it would be better to wrap it in a spelling server and allow all OS X applications to use it instead of having chrome be the odd duck. On Wed, Jun 10, 2009 at 9:14 PM, Nick Baumnickb...@chromium.org wrote: In particular, Ben is referring to the automatic spelling correction that Sid is implementing. Off the top of my head, I can think of a few different ways this could fit in: We can implement Sid's auto-correction on top of native spellcheck, just like today it's implemented on top of Hunspell. OS X will provide similar (though not identical) functionality, and we deem this good enough. We decide native integration is more important than feature parity. As we add more smarts to the spellchecker, we'd need to keep re-evaluating. Thoughts? -Nick On Wed, Jun 10, 2009 at 2:38 PM, Ben Goodger (Google) b...@chromium.org wrote: For whoever is coordinating this effort, please sync up with Nick Baum on spell checking. He has some additional considerations in mind we should make sure we understand what's possible here. -Ben On Wed, Jun 10, 2009 at 2:36 PM, Mike Pinkertonpinker...@chromium.org wrote: I think we're all on the same page. I pushed Paul to consider having both in his initial design since I forgot about the ability to add additional dictionaries. I'm glad others are in support of that as the way to get additional language support as opposed to trying to shim both implementations together. I agree with Jeremy, let's focus on the OSX spellchecker and ignore hunspell for now. Additionally, let's aim for the OS X spelling dialog if we can do it, regardless of whether or not win/linux can do it. On Wed, Jun 10, 2009 at 11:59 AM, Thomas Van Lententhoma...@chromium.org wrote: On Wed, Jun 10, 2009 at 2:38 PM, p_W paulwoolcoc...@gmail.com wrote: Forgive my (possibly) stupid concern here, but a few months ago there was some talk about this, and about how integrating with the OS's spellchecker was the preferred route as it allowed users to use their dictionary customizations over all their applications. Here is link to the discussion: http://groups.google.com/group/chromium-dev/browse_thread/thread/31832b99aeb953d7/d722d0f183a0b35f?hl=enlnk=gstq=OSX+spell#d722d0f183a0b35f Any thoughts about this? Uh, that's what this thread is about, his project is to switch to using the os one instead. And Jeremy was commenting that he doesn't need to support both, just switch to the native. Or am I reading this differently? TVL On Jun 9, 9:00 pm, Jeremy Moskovich jer...@chromium.org wrote: A couple more things: * I think ultimately we should support the grammar checker, but at first just getting spellchecking to work would be great! * +1 for supporting the Cocoa gui for spellchecking paragraphs, see the 2nd paragraph bellow for more thoughts on this. Matching Linux Windows functionality is a non-goal IMHO, to reiterate we want to behave like a native Cocoa application. WebKit/Safari already support these features so the issue is to get the plumbing working right in our multiprocess model (which may be non-trivial). IMHO the correct route here is to look at how this is done in WebKit and match the behavior there as much as possible, that's what I'm doing with the keyboard events at the moment and it's proving pretty fruitful. It's really exciting you're working on this!! Best regards, Jeremy On Tue, Jun 9, 2009 at 5:50 PM, Jeremy Moskovich jer...@chromium.orgwrote: IMHO there is no need to maintain dual hunspell/OSX spellchecker backends. There are addon OSX spellcheckers for other languages e.g. http://www.mitzpettel.com/software/hspell.php . Writing additional spelling servers is pretty simple so I think the correct approach would be: 1. Getting OSX spelling/grammar checking support working well. 2. If the need arises, wrapping hunspell as an Apple Spelling service and provide it as a separate project users can install. Best regards, Jeremy On Tue, Jun 9, 2009 at 5:32 PM, Paul Wicks pwick...@gmail.com wrote: Crap, sorry to post an incomplete version of this post earlier. Accidentally hit send before I finished it. Argh... Anyway, I've been looking at implementing support for the OS X spellchecker on the Mac build as part of my SoC project and I thought I'd run some thoughts I had today by the list. For the basic design, both hunspell and the os x spellchecker need to be usable, since hunspell supports more languages
[chromium-dev] Re: Adding Mac OS X Spellchecker to Chromium
+Sid I think it's worth understanding the API requirements of the new features. I know nothing about Spellchecking though. Maybe Sid can add more? -Ben On Wed, Jun 10, 2009 at 8:14 PM, Nick Baumnickb...@chromium.org wrote: In particular, Ben is referring to the automatic spelling correction that Sid is implementing. Off the top of my head, I can think of a few different ways this could fit in: We can implement Sid's auto-correction on top of native spellcheck, just like today it's implemented on top of Hunspell. OS X will provide similar (though not identical) functionality, and we deem this good enough. We decide native integration is more important than feature parity. As we add more smarts to the spellchecker, we'd need to keep re-evaluating. Thoughts? -Nick On Wed, Jun 10, 2009 at 2:38 PM, Ben Goodger (Google) b...@chromium.org wrote: For whoever is coordinating this effort, please sync up with Nick Baum on spell checking. He has some additional considerations in mind we should make sure we understand what's possible here. -Ben On Wed, Jun 10, 2009 at 2:36 PM, Mike Pinkertonpinker...@chromium.org wrote: I think we're all on the same page. I pushed Paul to consider having both in his initial design since I forgot about the ability to add additional dictionaries. I'm glad others are in support of that as the way to get additional language support as opposed to trying to shim both implementations together. I agree with Jeremy, let's focus on the OSX spellchecker and ignore hunspell for now. Additionally, let's aim for the OS X spelling dialog if we can do it, regardless of whether or not win/linux can do it. On Wed, Jun 10, 2009 at 11:59 AM, Thomas Van Lententhoma...@chromium.org wrote: On Wed, Jun 10, 2009 at 2:38 PM, p_W paulwoolcoc...@gmail.com wrote: Forgive my (possibly) stupid concern here, but a few months ago there was some talk about this, and about how integrating with the OS's spellchecker was the preferred route as it allowed users to use their dictionary customizations over all their applications. Here is link to the discussion: http://groups.google.com/group/chromium-dev/browse_thread/thread/31832b99aeb953d7/d722d0f183a0b35f?hl=enlnk=gstq=OSX+spell#d722d0f183a0b35f Any thoughts about this? Uh, that's what this thread is about, his project is to switch to using the os one instead. And Jeremy was commenting that he doesn't need to support both, just switch to the native. Or am I reading this differently? TVL On Jun 9, 9:00 pm, Jeremy Moskovich jer...@chromium.org wrote: A couple more things: * I think ultimately we should support the grammar checker, but at first just getting spellchecking to work would be great! * +1 for supporting the Cocoa gui for spellchecking paragraphs, see the 2nd paragraph bellow for more thoughts on this. Matching Linux Windows functionality is a non-goal IMHO, to reiterate we want to behave like a native Cocoa application. WebKit/Safari already support these features so the issue is to get the plumbing working right in our multiprocess model (which may be non-trivial). IMHO the correct route here is to look at how this is done in WebKit and match the behavior there as much as possible, that's what I'm doing with the keyboard events at the moment and it's proving pretty fruitful. It's really exciting you're working on this!! Best regards, Jeremy On Tue, Jun 9, 2009 at 5:50 PM, Jeremy Moskovich jer...@chromium.orgwrote: IMHO there is no need to maintain dual hunspell/OSX spellchecker backends. There are addon OSX spellcheckers for other languages e.g. http://www.mitzpettel.com/software/hspell.php . Writing additional spelling servers is pretty simple so I think the correct approach would be: 1. Getting OSX spelling/grammar checking support working well. 2. If the need arises, wrapping hunspell as an Apple Spelling service and provide it as a separate project users can install. Best regards, Jeremy On Tue, Jun 9, 2009 at 5:32 PM, Paul Wicks pwick...@gmail.com wrote: Crap, sorry to post an incomplete version of this post earlier. Accidentally hit send before I finished it. Argh... Anyway, I've been looking at implementing support for the OS X spellchecker on the Mac build as part of my SoC project and I thought I'd run some thoughts I had today by the list. For the basic design, both hunspell and the os x spellchecker need to be usable, since hunspell supports more languages than OS X does. The public interface of the Spellchecker class is fairly small (mainly 2 methods: SpellCheckWord, AddWord). It seems that mapping these onto the OS X spellchecker shouldn't be too hard. I originally thought to
[chromium-dev] How to change the cursor smoothly for a view
I've got a composite view that consists of a SkBitmap and views::Label. I'd like to use IDC_HAND (hand cursor) for this composite view so I've overridden view::GetCursorForPoint(...) Though this kinda works, it causes the cursor to jitter/flicker as it calls this function repeatedly based on the current cursor coordinates within the view. How can I implement the desired functionality without this flickering? I've also tried overriding view::OnMouseEntered() and view::OnMouseExited() and manually calling ::SetCursor() to no avail. Can someone please shed some light. Thanks, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is there any logging to print out messaging between Browser and Renderer
about:ipc is only implemented on Windows. For Mac/Linux, you need to set the CHROME_IPC_LOGGING environment variable. All the messages will be dumped to stderr. On Wed, Jun 10, 2009 at 8:34 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: Thank you. I try and successfully build chromium on MacOS using XCode. Then I do a 'build and Go (debug)'. In one tab , I load www.google.com and then do a search for 'test'. In another tab, I enter 'about:ipc' but it shows nothing. Am I missing something? Thank you. On Wed, Jun 10, 2009 at 8:02 PM, Eric Romanero...@chromium.org wrote: Even better, use a DEBUG build of chromium and navigate to about:ipc. This opens a window that logs all of the IPC messages being made. On Wed, Jun 10, 2009 at 7:34 PM, Mohamed Mansourm...@chromium.org wrote: You can pass in --log-level=N to the command line, where N is 0 = INFO 1 = WARNING 2 = ERROR 3 = FATAL The default login level is set to 1 which is WARNING. -- Mohamed Mansour On Wed, Jun 10, 2009 at 10:24 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: Hi, Is there any logging to print out messaging between Browser and Renderer processes? If yes, can you please tell me how to enable it? And where does the log go? Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 problems with extension development
I agree the background page should load first. What's happening right now is that ExtensionProcessManager monitors EXTENSIONS_LOADED, just like everyone else (including Browser) so they get loaded about the same time. It looks like currently the background page starts first, because it was registered first, but it's basically a race. - a 2009/6/10 Nick Baum nickb...@chromium.org: This might be the same problem I ran into when writing my extension: because the bg page and toolstrips don't load in a predictable order, you're not guaranteed to catch all views if you do getViews() right as the page loads. If the background page was guaranteed to load first, the toolstrips could all make sure to find it when they loaded. -Nick 2009/6/10 Aaron Boodman a...@chromium.org On Wed, Jun 10, 2009 at 3:17 PM, Nebojša Ćirićnci...@gmail.com wrote: What about the second issue? Shouldn't iterating over background page views return toolstrip views, instead of background page itself (and no toolstrip views)? I'll try it again just to make sure I didn't make an obvious mistake... This method should return all running HTML pages in your extension -- this includes the background page, any toolstrips, and any tabs that are showing HTML from the extension. If it's not doing that, it's a bug. - a --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to change the cursor smoothly for a view
Hi Ben, I'm getting the flickering even when I dont have any children in my view. I tried overridding GetViewForPoint for my view class and returning this, but I still get this flicker (with or without the label and bitmap being present). According to MSDN @ http://msdn.microsoft.com/en-us/library/ms648393(VS.85).aspx snip make sure the class cursor for the specified window's class is set to NULL. If the class cursor is not NULL, the system restores the class cursor each time the mouse is moved. /snip Could this be the culprit? On Jun 10, 9:05 pm, Ben Goodger (Google) b...@chromium.org wrote: You want to override GetViewForPoint on the container view and return this, rather than allowing the default implementation of the function to propagate into the base class impl. The reason you're getting flicker is that the default impl of RootView::UpdateCursor calls GetViewForPoint which ends up asking both the label and the text and the container view for the cursor, so its constantly getting reset as you move your mouse over it. -Ben On Wed, Jun 10, 2009 at 8:55 PM, Daniel Cowxdaniel.c...@gmail.com wrote: I've got a composite view that consists of a SkBitmap and views::Label. I'd like to use IDC_HAND (hand cursor) for this composite view so I've overridden view::GetCursorForPoint(...) Though this kinda works, it causes the cursor to jitter/flicker as it calls this function repeatedly based on the current cursor coordinates within the view. How can I implement the desired functionality without this flickering? I've also tried overriding view::OnMouseEntered() and view::OnMouseExited() and manually calling ::SetCursor() to no avail. Can someone please shed some light. Thanks, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to change the cursor smoothly for a view
I don't know, check WidgetWin. I would be slightly surprised though... we use GetCursorForPoint in a couple of places and haven't had issues... -Ben On Wed, Jun 10, 2009 at 9:39 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Hi Ben, I'm getting the flickering even when I dont have any children in my view. I tried overridding GetViewForPoint for my view class and returning this, but I still get this flicker (with or without the label and bitmap being present). According to MSDN @ http://msdn.microsoft.com/en-us/library/ms648393(VS.85).aspx snip make sure the class cursor for the specified window's class is set to NULL. If the class cursor is not NULL, the system restores the class cursor each time the mouse is moved. /snip Could this be the culprit? On Jun 10, 9:05 pm, Ben Goodger (Google) b...@chromium.org wrote: You want to override GetViewForPoint on the container view and return this, rather than allowing the default implementation of the function to propagate into the base class impl. The reason you're getting flicker is that the default impl of RootView::UpdateCursor calls GetViewForPoint which ends up asking both the label and the text and the container view for the cursor, so its constantly getting reset as you move your mouse over it. -Ben On Wed, Jun 10, 2009 at 8:55 PM, Daniel Cowxdaniel.c...@gmail.com wrote: I've got a composite view that consists of a SkBitmap and views::Label. I'd like to use IDC_HAND (hand cursor) for this composite view so I've overridden view::GetCursorForPoint(...) Though this kinda works, it causes the cursor to jitter/flicker as it calls this function repeatedly based on the current cursor coordinates within the view. How can I implement the desired functionality without this flickering? I've also tried overriding view::OnMouseEntered() and view::OnMouseExited() and manually calling ::SetCursor() to no avail. Can someone please shed some light. Thanks, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to change the cursor smoothly for a view
Actually, I see this flickering on a plain old view::Link as well. You can see it if you move the cursor back and forth on say the open source software link on the Chromium About dialog. On Jun 10, 9:42 pm, Ben Goodger (Google) b...@chromium.org wrote: I don't know, check WidgetWin. I would be slightly surprised though... we use GetCursorForPoint in a couple of places and haven't had issues... -Ben On Wed, Jun 10, 2009 at 9:39 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Hi Ben, I'm getting the flickering even when I dont have any children in my view. I tried overridding GetViewForPoint for my view class and returning this, but I still get this flicker (with or without the label and bitmap being present). According to MSDN @http://msdn.microsoft.com/en-us/library/ms648393(VS.85).aspx snip make sure the class cursor for the specified window's class is set to NULL. If the class cursor is not NULL, the system restores the class cursor each time the mouse is moved. /snip Could this be the culprit? On Jun 10, 9:05 pm, Ben Goodger (Google) b...@chromium.org wrote: You want to override GetViewForPoint on the container view and return this, rather than allowing the default implementation of the function to propagate into the base class impl. The reason you're getting flicker is that the default impl of RootView::UpdateCursor calls GetViewForPoint which ends up asking both the label and the text and the container view for the cursor, so its constantly getting reset as you move your mouse over it. -Ben On Wed, Jun 10, 2009 at 8:55 PM, Daniel Cowxdaniel.c...@gmail.com wrote: I've got a composite view that consists of a SkBitmap and views::Label. I'd like to use IDC_HAND (hand cursor) for this composite view so I've overridden view::GetCursorForPoint(...) Though this kinda works, it causes the cursor to jitter/flicker as it calls this function repeatedly based on the current cursor coordinates within the view. How can I implement the desired functionality without this flickering? I've also tried overriding view::OnMouseEntered() and view::OnMouseExited() and manually calling ::SetCursor() to no avail. Can someone please shed some light. Thanks, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Renderer Process and Browser Process
On Wed, Jun 10, 2009 at 12:18 PM, John Abd-El-Malekj...@chromium.org wrote:
On Wed, Jun 10, 2009 at 11:48 AM, Meryl Silverburgh
silverburgh.me...@gmail.com wrote:
From this document, it talks about Messaging between
http://dev.chromium.org/developers/design-documents/displaying-a-web-page-in-chrome
Can you please help me understand what is the Message Flow for an Alert
Dialog?
like in this case:
htmlscript function f1() { var a = 1; alert(hello); a = 2;};
f1(); /script/html
I assume it is like this, please correct me if i am wrong:
1. Browser Process downloads the test page
2. Renderer Process gets the html source, parses the html and have v8
executes script node
3. v8 pauses at 'alert' call, sends a message to Browser Process to
pop up the alert dialog and Render Process blocked till it receives
message from Browser.
4. Browser Process shows the alert dialog with the right message (in
this case 'hello')
5. When user clicks 'Okay', browser process sends a message back to
Renderer Process and v8 continues execute the rest of the Script node.
Is this correct?
Yep this is pretty much what happens. For more details, search
for ViewHostMsg_RunJavaScriptMessage
Thank you. John.
I think this method is Render process to send a message to Browser
process to pop up an alert dialog.
bool RenderView::RunJavaScriptMessage(int type,
const std::wstring message,
const std::wstring default_value,
const GURL frame_url,
std::wstring* result)
that calls:
bool Channel::Send(Message* message);
and then
bool Channel::ChannelImpl::ProcessOutgoingMessages()
My question is how the Render process being blocked after it sends the
message to Browser process, which one is a blocking calls or which one
calls a blocking method?
And how it will resume when Browser process replys a message? How
Render is being resumed (which method does that)?
Thank you.
Thank you for any clarificaiton.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Is there any logging to print out messaging between Browser and Renderer
On Wed, Jun 10, 2009 at 8:56 PM, John Abd-El-Malekj...@chromium.org wrote: about:ipc is only implemented on Windows. For Mac/Linux, you need to set the CHROME_IPC_LOGGING environment variable. All the messages will be dumped to stderr. I have added 'export CHROME_IPC_LOGGING=1' in my .profile on Macos. Reboot my machine. And 'build and debug' my chrome xocde project under Xcode. Load Google.com But I only see the following in my XCode Console View: [366:17667:919320584122:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:919332572808:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:919406692781:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:919545318766:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:919545477665:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:2067:1055305882028:ERROR:/Users/samuel/chromium/src/chrome/browser/tab_contents/tab_contents_view_mac.mm(117)] Not implemented reached in virtual void TabContentsViewMac::SizeContents(const gfx::Size) [366:17667:1056204955438:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:1056365389566:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:1056370011421:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:1056456409105:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:17667:1056456929069:WARNING:/Users/samuel/chromium/src/chrome/browser/renderer_host/resource_dispatcher_host.cc(608)] Canceling a request that wasn't found [366:2067:1060039015993:ERROR:/Users/samuel/chromium/src/chrome/common/temp_scaffolding_stubs.cc(277)] Not implemented reached in static void HungRendererDialog::HideForTabContents(TabContents*) LEAK: 5 CachedResource LEAK: 166 WebCoreNode Leak 1 JS wrappers. On Wed, Jun 10, 2009 at 8:34 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: Thank you. I try and successfully build chromium on MacOS using XCode. Then I do a 'build and Go (debug)'. In one tab , I load www.google.com and then do a search for 'test'. In another tab, I enter 'about:ipc' but it shows nothing. Am I missing something? Thank you. On Wed, Jun 10, 2009 at 8:02 PM, Eric Romanero...@chromium.org wrote: Even better, use a DEBUG build of chromium and navigate to about:ipc. This opens a window that logs all of the IPC messages being made. On Wed, Jun 10, 2009 at 7:34 PM, Mohamed Mansourm...@chromium.org wrote: You can pass in --log-level=N to the command line, where N is 0 = INFO 1 = WARNING 2 = ERROR 3 = FATAL The default login level is set to 1 which is WARNING. -- Mohamed Mansour On Wed, Jun 10, 2009 at 10:24 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: Hi, Is there any logging to print out messaging between Browser and Renderer processes? If yes, can you please tell me how to enable it? And where does the log go? Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
