[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
Pi, If you've tested this on a Vista lemme know.Plz check on WinRC6 coz
there might be
changes in the latest Vista RC; not to mention chrome version changes.
This looks like a k00l bug :P
On Thu, Jun 18, 2009 at 1:53 PM, pi zhu.she...@gmail.com wrote:
Thank Nicolas for your clarify.
Today I find the exception in
AutocompleteEditViewWin::EraseTopOfSelection is caused by the rong
compiler option of 2.0.172.28 official build.
autocomplete_edit_view_win.cc:
HDC BeginPaintIntercept(HWND hWnd, LPPAINTSTRUCT lpPaint) {
BOOL EndPaintIntercept(HWND hWnd, const PAINTSTRUCT* lpPaint) {
These two intercepting win32 API are not explicitly defined as
__stdcall, and are wrongly compiled as __cdecl:
chrome_1c3!`anonymous namespace'::BeginPaintIntercept:
021ea88f
021ea8b5 c3 ret
021ea8c4 c3 ret
chrome_1c3!`anonymous namespace'::EndPaintIntercept:
021ea8c5
021ea8d7 c3 ret
021ea8e6 c3 ret
This is harmless on windows XP, because the corrupted esp is restored
by riched20!RichEditWndProc's leave instruction, and the corrupted esi/
edi/ebx are restored by USER32!InternalCallWinProc.
But it's a disaster on windows 2000, because the corrupted ebx (which
keeps the AutocompleteEditViewWin this point in
AutocompleteEditViewWin::OnPaint) is not restored by USER32!
UserCallWinProc or by USER32!CallWindowProcAorW.
Nicolas Sylvain wrote:
I filed this bug with this comment:--
TabRestoreUITest.RestoreToDifferentWindow fails on win2k debug. I
disabled
it.
This is not reproducible outside the buildbot environment.
The problem seems to be that chrome cannot access a font. I was not able
to
determine what the font was.
---
Later on I fixed it, but forgot to remove the comment.
This bug was only for debug mode, it should not matter for release mode.
Nicolas
--
take the red pill.
Akhil Wali
# http://code.google.com/
# http://aebpy.blogspot.com/
# http://twitter.com/darth10
# http://facebook.com/darth10
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
Thank Nicolas for your clarify.
Today I find the exception in
AutocompleteEditViewWin::EraseTopOfSelection is caused by the rong
compiler option of 2.0.172.28 official build.
autocomplete_edit_view_win.cc:
HDC BeginPaintIntercept(HWND hWnd, LPPAINTSTRUCT lpPaint) {
BOOL EndPaintIntercept(HWND hWnd, const PAINTSTRUCT* lpPaint) {
These two intercepting win32 API are not explicitly defined as
__stdcall, and are wrongly compiled as __cdecl:
chrome_1c3!`anonymous namespace'::BeginPaintIntercept:
021ea88f
021ea8b5 c3 ret
021ea8c4 c3 ret
chrome_1c3!`anonymous namespace'::EndPaintIntercept:
021ea8c5
021ea8d7 c3 ret
021ea8e6 c3 ret
This is harmless on windows XP, because the corrupted esp is restored
by riched20!RichEditWndProc's leave instruction, and the corrupted esi/
edi/ebx are restored by USER32!InternalCallWinProc.
But it's a disaster on windows 2000, because the corrupted ebx (which
keeps the AutocompleteEditViewWin this point in
AutocompleteEditViewWin::OnPaint) is not restored by USER32!
UserCallWinProc or by USER32!CallWindowProcAorW.
Nicolas Sylvain wrote:
I filed this bug with this comment:--
TabRestoreUITest.RestoreToDifferentWindow fails on win2k debug. I disabled
it.
This is not reproducible outside the buildbot environment.
The problem seems to be that chrome cannot access a font. I was not able to
determine what the font was.
---
Later on I fixed it, but forgot to remove the comment.
This bug was only for debug mode, it should not matter for release mode.
Nicolas
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
On Thu, Jun 18, 2009 at 1:53 PM, pi zhu.she...@gmail.com wrote:
Today I find the exception in
AutocompleteEditViewWin::EraseTopOfSelection is caused by the rong
compiler option of 2.0.172.28 official build.
autocomplete_edit_view_win.cc:
HDC BeginPaintIntercept(HWND hWnd, LPPAINTSTRUCT lpPaint) {
BOOL EndPaintIntercept(HWND hWnd, const PAINTSTRUCT* lpPaint) {
These two intercepting win32 API are not explicitly defined as
__stdcall, and are wrongly compiled as __cdecl:
chrome_1c3!`anonymous namespace'::BeginPaintIntercept:
021ea88f
021ea8b5 c3 ret
021ea8c4 c3 ret
chrome_1c3!`anonymous namespace'::EndPaintIntercept:
021ea8c5
021ea8d7 c3 ret
021ea8e6 c3 ret
This should be fixed regardless of win2k support. You should file a bug for
this. Feel free to attach a patch that adds stdcall declarations.
PK
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
filed the bug: http://code.google.com/p/chromium/issues/detail?id=14631 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
On Tue, Jun 16, 2009 at 12:04 PM, pizhu.she...@gmail.com wrote:
tab_restore_uitest.cc:
TEST_F(TabRestoreUITest, RestoreToDifferentWindow) {
// This test is disabled on win2k. See bug 1215881.
I cant find anything about bug 1215881 on
http://code.google.com/p/chromium/issues/list,
where to find it?
That's an internal bug tracker, mostly for really old bugs.
Since we don't support win2k, that comment can probably be deleted.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
That comment was removed 4 weeks ago in revision 16206. In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Huan Ren wrote: Are you looking at the latest version of file tab_restore_uitest.cc? That comment was long gone. Huan On Wed, Jun 17, 2009 at 9:37 AM, Dan Kegel daniel.r.ke...@gmail.com wrote: That's an internal bug tracker, mostly for really old bugs. Since we don't support win2k, that comment can probably be deleted. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote: In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Not directly. What are you trying to do? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
I'm trying to find out if it's possible to patch chrome to run on my old windows 2000 machine. When I debugging chrome 2.0.172.28, the Browser::CreateTabContentsForURL sometimes will raise exception. According to those comments in the source files, the TabUI indeed has some incompatibility on windows 2000. What's it? Can it be overcomed? The internal bug reports may be helpful. Dan Kegel wrote: On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote: In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Not directly. What are you trying to do? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?
I filed this bug with this comment:-- TabRestoreUITest.RestoreToDifferentWindow fails on win2k debug. I disabled it. This is not reproducible outside the buildbot environment. The problem seems to be that chrome cannot access a font. I was not able to determine what the font was. --- Later on I fixed it, but forgot to remove the comment. This bug was only for debug mode, it should not matter for release mode. Nicolas On Wed, Jun 17, 2009 at 2:31 PM, pi zhu.she...@gmail.com wrote: I'm trying to find out if it's possible to patch chrome to run on my old windows 2000 machine. When I debugging chrome 2.0.172.28, the Browser::CreateTabContentsForURL sometimes will raise exception. According to those comments in the source files, the TabUI indeed has some incompatibility on windows 2000. What's it? Can it be overcomed? The internal bug reports may be helpful. Dan Kegel wrote: On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote: In the latest revision 18442, there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Not directly. What are you trying to do? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
