[chromium-dev] Embedding chrome.pak in the chrome binary for Linux?
The chrome binary for Linux seems to load resource bundles from a file named chrome.pak, while the resource booundles are embedded in the chrome DLL in other platforms (correct me if I'm wrong). This makes me wonder if it's a good idea to embed chrome.pak in the chrome binary for Linux. This would save open+mmap cost (probably negligible though), and would make the package a bit simpler. I guess it can be done with objcopy, without too much work. Any thoughts? Satoru -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?
Thank you for the feedback. I was thinking about embedding only chrome.pak, not language pak files, just like Windows has a DLL for each language. Satoru On Sun, Dec 13, 2009 at 8:56 AM, Rahul Kuchhal kuch...@chromium.org wrote: There are not embedded even on Windows (see 52 dlls under Google\Chrome\Application\version\Locales folder). On Sat, Dec 12, 2009 at 4:52 AM, Satoru Takabayashi sato...@chromium.orgwrote: The chrome binary for Linux seems to load resource bundles from a file named chrome.pak, while the resource booundles are embedded in the chrome DLL in other platforms (correct me if I'm wrong). This makes me wonder if it's a good idea to embed chrome.pak in the chrome binary for Linux. This would save open+mmap cost (probably negligible though), and would make the package a bit simpler. I guess it can be done with objcopy, without too much work. Any thoughts? Satoru -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] buildbot failure in Chromium on Linux Builder (ChromiumOS), revision 36512
The SConstruct file seemed to be changed locally on the build bot machine, that is preventing gclient sync from updating the file. I'll ask the build bot maintainers to fix this. Thanks, Satoru On Tue, Jan 19, 2010 at 3:42 PM, Yusuke Sato yusu...@google.com wrote: FYI, Satoru: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/2411/steps/gclient/logs/stdio _ src/third_party/cros at e196be04 Updating origin cannot rebase: you have unstaged changes M SConstruct Checked out revision b4ce165dfdf395202f1582d553c1ce3688d135b2. --Yusuke On Tue, Jan 19, 2010 at 3:21 PM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for compile on Linux Builder (ChromiumOS) http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410 Revision: 36512 Blame list: sato...@chromium.org Linux Builder (ChromiumOS) Build 2410http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410 update scripts stdiohttp://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410/steps/shell/logs/stdio update stdiohttp://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410/steps/gclient/logs/stdio compile failed stdiohttp://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410/steps/compile/logs/stdio Changed by: *sato...@chromium.org* Changed at: *Mon 18 Jan 2010 22:17:37* Branch: *src* Revision: *36512*http://src.chromium.org/viewvc/chrome?view=revrevision=36512 Changed files: - *chrome/browser/chromeos/language_library.cc* - *chrome/browser/chromeos/language_library.h* Comments: Add GetSupportedLanguages(), ActiveLanguage(), and DeactivateLanguage(). These are wrappers for functions added in libcros http://git.chromium.org/cgi-bin/gitweb.cgi?p=cros.git;a=commit;h=adc84eae83d75cc6c2a59c89e5276d072ca69c8d TEST=none BUG=none Review URL: http://codereview.chromium.org/542108 Properties: -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] buildbot failure in Chromium on Linux Builder (ChromiumOS), revision 36512
Thanks to tc, the build is now green, and the tree is reopened. The problem was that the original SConstruct file in the cros directory was overwritten by gclient when it generated SConstruct files for hammer. For now, we reverted the generated SConstruct file on the machine to get gclient sync to work. I'll talk to the build bot maintainers for the right fix. Satoru On Tue, Jan 19, 2010 at 3:52 PM, Satoru Takabayashi sato...@chromium.orgwrote: The SConstruct file seemed to be changed locally on the build bot machine, that is preventing gclient sync from updating the file. I'll ask the build bot maintainers to fix this. Thanks, Satoru On Tue, Jan 19, 2010 at 3:42 PM, Yusuke Sato yusu...@google.com wrote: FYI, Satoru: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS)/builds/2411/steps/gclient/logs/stdio _ src/third_party/cros at e196be04 Updating origin cannot rebase: you have unstaged changes M SConstruct Checked out revision b4ce165dfdf395202f1582d553c1ce3688d135b2. --Yusuke On Tue, Jan 19, 2010 at 3:21 PM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for compile on Linux Builder (ChromiumOS) http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410 Revision: 36512 Blame list: sato...@chromium.org Linux Builder (ChromiumOS) Build 2410http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410 update scripts stdiohttp://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410/steps/shell/logs/stdio update stdiohttp://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410/steps/gclient/logs/stdio compile failed stdiohttp://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2410/steps/compile/logs/stdio Changed by: *sato...@chromium.org* Changed at: *Mon 18 Jan 2010 22:17:37* Branch: *src* Revision: *36512*http://src.chromium.org/viewvc/chrome?view=revrevision=36512 Changed files: - *chrome/browser/chromeos/language_library.cc* - *chrome/browser/chromeos/language_library.h* Comments: Add GetSupportedLanguages(), ActiveLanguage(), and DeactivateLanguage(). These are wrappers for functions added in libcros http://git.chromium.org/cgi-bin/gitweb.cgi?p=cros.git;a=commit;h=adc84eae83d75cc6c2a59c89e5276d072ca69c8d TEST=none BUG=none Review URL: http://codereview.chromium.org/542108 Properties: -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
