Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some for Japanese), but > looks good overall. > It's great to see diffs in native languages, rather than those cryptic > `\u` notation! An interesting note after looking at Phil's comment on the serviceui.properties change is that there is no Japanese update for that file. The translations on [here](https://github.com/openjdk/jdk/commit/c7d2a5c1c4e86955100f4c40170dc25222abd07f#diff-38c26a463e174224c6b9fc5007f3058482e533dc0f60f3275e21f9f2fc9acf8e) from the output bins update look good to me but maybe @naotoj should double check in case? - PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161748245
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert updated translation LGTM - Marked as reviewed by achung (Committer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2111576337
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties >> line 32: >> >>> 30: border.jobattributes=作业属性 >>> 31: border.media=介质 >>> 32: border.output=出纸 >> >> What triggered this ? Just someone noticing it and deciding there's a better >> translation ? >> What does it say ? > > In the past, it was brought up in review that some of the words were > translated to localized words that didn't exactly mean what the original > English word meant. I believe Weijun Wang caught some of these in Chinese > files in the past. I'm assuming these are cases where the go team is > improving the translation, but I also can't exactly tell. We do suggest > changes to the go team, so maybe this is evidence of them improving their > tool. It was changed from "paper output" to just "output". Since the original English doesn't specify anything about paper, I guess the new translation is more general and fitting in this case. The original inclusion of the border.output field was actually part of the output bin update on [JDK-8314070](https://bugs.openjdk.org/browse/JDK-8314070) so it was actually not initially translated by the translation team. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635559474
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v8]
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: fix jtreg summary, group volatile vars together - Changes: - all: https://git.openjdk.org/jdk/pull/19569/files - new: https://git.openjdk.org/jdk/pull/19569/files/06a7c212..c24a6429 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19569=07 - incr: https://webrevs.openjdk.org/?repo=jdk=19569=06-07 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active [v2]
On Tue, 11 Jun 2024 11:24:13 GMT, Tejesh R wrote: > What happens when we introduce another component in-between, say for example > in the test we add one more Frame in-between printDailogButton and mainFrame. > Which frame does get activated on close of print dialog? The intermediate one > or mainFrame? If the owner of the dialog was focused last, then it will be refocused. If the new frame is focused while the dialog is still open, then the dialog is closed, then nothing will be focused. So the owner of the dialog will refocus if it was last focused, otherwise no behavior is changed. I'm not sure if in this case the new intermediate frame should be focused if it's unrelated to the dialog and was last focused. Maybe @mrserb has an input? - PR Comment: https://git.openjdk.org/jdk/pull/19588#issuecomment-2161562728
RFR: 8291472: [macos] jawt 1.4 lock/unlock not supported
Removing if check for unsupported jawt versions - Commit messages: - update copyright year - remove if check for awt version >= 1.4 Changes: https://git.openjdk.org/jdk/pull/19639/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19639=00 Issue: https://bugs.openjdk.org/browse/JDK-8291472 Stats: 10 lines in 1 file changed: 0 ins; 1 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/19639.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19639/head:pull/19639 PR: https://git.openjdk.org/jdk/pull/19639
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. small typo and typing change, LGTM - Marked as reviewed by achung (Committer). PR Review: https://git.openjdk.org/jdk/pull/19540#pullrequestreview-2108713479
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. Maybe outside the scope of this issue, but could this test be automated? - PR Review: https://git.openjdk.org/jdk/pull/19540#pullrequestreview-2108672182
Re: RFR: 8333403: Write a test to check various components events are triggered properly [v2]
On Wed, 5 Jun 2024 08:29:11 GMT, Ravi Gupta wrote: >> This testcase checks for the following assertions for Component events: >> >> 1. When components are resized, moved, hidden and shown the respective >> events are triggered. >> 2. When the components are hidden/disabled also,the component events like >> resized/moved are triggered. >> 3. When a hidden component is hidden again, or a visible component is shown >> again, the events should not be fired. >> 4. When a window is minimized/restored then hidden and shown component >> events should be triggered. >> >> Testing: >> Tested using Mach5(20 times per platform) in macos,linux and windows and got >> all pass. > > Ravi Gupta has updated the pull request incrementally with one additional > commit since the last revision: > > 8333403: Copyright Header added test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 134: > 132: > 133: EventQueue.invokeAndWait(ComponentEventTest::initializeGUI); > 134: robot.waitForIdle(); I was notified robot.delay(1000); is more standard here test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 137: > 135: > 136: robot.mouseMove( > 137: components[0].getLocationOnScreen().x getLocationOnScreen needs to be accessed on EDT test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 237: > 235: } > 236: > 237: // Disable the components and do the same set of > operations if you're doing the same operations, you should write a helper function and call that function instead - PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1633765852 PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1633766751 PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1633769934
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using John > Gibbon's diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Just a question about the reverted translations, otherwise LGTM > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. Any particular reason you know that the tool had the definitions adjusted? I see some of the changes look like like command line options not being translated, but it's a bit hard to tell. Do you know if the reverted words should be translated (and possibly will be re-translated in future drops?) or should they be left untranslated? - PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2105526180 PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2155723513
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v7]
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: updated test, removed robot waitForIdles, jtreg summary, release in finally - Changes: - all: https://git.openjdk.org/jdk/pull/19569/files - new: https://git.openjdk.org/jdk/pull/19569/files/452dcac9..06a7c212 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19569=06 - incr: https://webrevs.openjdk.org/?repo=jdk=19569=05-06 Stats: 16 lines in 1 file changed: 3 ins; 9 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v6]
On Fri, 7 Jun 2024 23:14:47 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test based on feedback
>
> test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 59:
>
>> 57: });
>> 58: robot.waitForIdle();
>> 59: robot.delay(1000);
>
> Suggestion:
>
> robot.setAutoDelay(100);
> robot.setAutoWaitForIdle(true);
>
> SwingUtilities.invokeAndWait(() -> {
> createAndShowGUI();
> });
> robot.delay(1000);
>
>
> I was able to remove all the individual `waitForIdle()` calls and replaced it
> with `setAutoWaitForIdle()`. Still seemed to work fine on macOS.
Most tests i've looked at aren't using setAutoWaitForIdle(). Are there any
issues with test stability?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1631797841
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v5]
On Fri, 7 Jun 2024 07:35:19 GMT, Prasanta Sadhukhan wrote: >> Alisen Chung has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update copyright years >> - automated test >> - changed test to automatic > > test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 39: > >> 37: * @test >> 38: * @bug 8315655 >> 39: * @requires (os.family == "mac") > > Also, is there any need to restrict it to mac as I guess in other platforms, > this test should anyway pass...Did you check? I've removed the restriction, the test passes on all platforms - PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1631752491
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v6]
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: update test based on feedback - Changes: - all: https://git.openjdk.org/jdk/pull/19569/files - new: https://git.openjdk.org/jdk/pull/19569/files/ed5d5393..452dcac9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19569=05 - incr: https://webrevs.openjdk.org/?repo=jdk=19569=04-05 Stats: 52 lines in 1 file changed: 21 ins; 9 del; 22 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]
On Fri, 7 Jun 2024 21:03:58 GMT, Alisen Chung wrote: >> Although there's one more issue it seems where in native, after popup is >> shown when right mouse button (or CTRL+left mouse button) is pressed, if you >> release the mouse the popup vanishes which I noticed in Notes, Mail but it >> does not happen in JDK and popup remains open...but it seems not related to >> this...did you notice? > > Hmm, not sure why. I doubt it's related to this since both MOUSE_PRESSED and > MOUSE_RELEASED are still popuptriggers before and after the fix. I can make a > new issue for this to match native behavior. I've tested that interaction before and after the fix and it's the same behavior. The initial MOUSE_PRESSED will open a popup, then the subsequent MOUSE_RELEASED will do nothing. When the popup is already open, the MOUSE_PRESSED will close the popup, but the MOUSE_RELEASED will do nothing. So it's unrelated to this fix but it might be something to do with MOUSE_RELEASED or maybe MOUSE_DRAGGED/MOUSE_CLICKED cancelling the popup behavior. I can look to make a fix separate from this issue. - PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1631694648
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]
On Fri, 7 Jun 2024 07:40:01 GMT, Prasanta Sadhukhan wrote: >> looks good.. > > Although there's one more issue it seems where in native, after popup is > shown when right mouse button (or CTRL+left mouse button) is pressed, if you > release the mouse the popup vanishes which I noticed in Notes, Mail but it > does not happen in JDK and popup remains open...but it seems not related to > this...did you notice? Hmm, not sure why. I doubt it's related to this since both MOUSE_PRESSED and MOUSE_RELEASED are still popuptriggers before and after the fix. I can make a new issue for this to match native behavior. - PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1631688661
Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active [v2]
> Add a check for previous focused window on modal unblocking. If the owner of > a closing dialog was the last focused window, then the owner of the dialog > should regain focus. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: use == over .equals - Changes: - all: https://git.openjdk.org/jdk/pull/19588/files - new: https://git.openjdk.org/jdk/pull/19588/files/ff754beb..310af4b6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19588=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19588=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19588.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19588/head:pull/19588 PR: https://git.openjdk.org/jdk/pull/19588
RFR: 8185429: [macos] After the dialog is closed, there is no window become active
Add a check for previous focused window on modal unblocking. If the owner of a closing dialog was the last focused window, then the owner of the dialog should regain focus. - Commit messages: - update copyright years - init commit Changes: https://git.openjdk.org/jdk/pull/19588/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19588=00 Issue: https://bugs.openjdk.org/browse/JDK-8185429 Stats: 8 lines in 2 files changed: 6 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19588.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19588/head:pull/19588 PR: https://git.openjdk.org/jdk/pull/19588
Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v11]
On Sun, 5 May 2024 10:17:40 GMT, 柳鲲鹏 wrote: >> Candidat box can moving with caret on windows version. Someone must wrote >> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. >> Why it doesn't work, is the key problem. >> >> 1, I wrote a example for linux: >> https://github.com/quantum6/X11InputMethod >> >> I tried all parameters to test and as my research: >> If you use XIMPreeditCallbacks to initiate, the box can't be moved with >> caret. >> If you use XIMPreeditNothing, it works. >> All examples use XIMPreeditCallbacks to initiate input method and candidate >> box can't moving. So I understand why he didn't commit the codes. >> >> 2, I traced the route of transfering caret coordites on windows version, >> then add codes for linux. >> 3, Taishan Office(like Microsoft Office Word) is running on jdk, we tested >> for a long time, it works OK. >> 4, I am not sure for AIX( no environment). >> >> >> JDK-8264728 : When use chinese IME, the candidate box isn't moved with caret >> of JTextArea >> Type: Bug >> Component: client-libs >> Sub-Component: java.awt:i18n >> Affected Version: 8,9,15,16 >> Priority: P3 >> Status: Open >> Resolution: Unresolved >> OS: linux >> CPU: x86_64 > > 柳鲲鹏 has updated the pull request with a new target base due to a merge or a > rebase. The incremental webrev excludes the unrelated changes brought in by > the merge/rebase. The pull request contains 10 additional commits since the > last revision: > > - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 > - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 > - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 > - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 > - Update to lastest > - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 > - Remove tab > - Update to latest and make code safer > - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 > - 8264728: When use chinese IME, the candidate box isn't moved with caret of > JTextArea src/java.desktop/unix/classes/sun/awt/X11/XInputMethod.java line 61: > 59: } > 60: > 61: @Override why do these functions need the override tag now? - PR Review Comment: https://git.openjdk.org/jdk/pull/13055#discussion_r1630286038
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]
On Thu, 6 Jun 2024 18:18:14 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add event check in popup trigger
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/NSEvent.java line 276:
>
>> 274: && jeventType != MouseEvent.MOUSE_RELEASED) {
>> 275: return false;
>> 276: }
>
> Just to double check, are the only jeventTypes to trigger popups using mouse?
> Could there be other event types, maybe using keyboard for example with
> tab/arrows & enter?
I believe only MouseEvents can be popup triggers. I checked in MouseEvent that
there is a field for popup triggers and no such field in KeyEvent.
The isPopupTrigger method here also previously checked button down masks
already, so adding a check for the correct mouse events shouldn't be an issue
even if there was a way to show a popup menu with a different event type.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1630039417
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v5]
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request incrementally with three additional commits since the last revision: - update copyright years - automated test - changed test to automatic - Changes: - all: https://git.openjdk.org/jdk/pull/19569/files - new: https://git.openjdk.org/jdk/pull/19569/files/fb89d2f7..ed5d5393 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19569=04 - incr: https://webrevs.openjdk.org/?repo=jdk=19569=03-04 Stats: 68 lines in 3 files changed: 41 ins; 2 del; 25 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]
On Thu, 6 Jun 2024 16:08:31 GMT, Alisen Chung wrote: >> Issue is a mouse drag will trigger a popup in macos, but not in linux or >> windows. >> The solution is to add a check for a mouse pressed event to show popup and >> prevent mouse entered events from triggering the popup > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > add event check in popup trigger I've automated the test and confirmed that it fails before the fix and passes after the fix. - PR Comment: https://git.openjdk.org/jdk/pull/19569#issuecomment-2153140229
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v2]
On Thu, 6 Jun 2024 07:16:42 GMT, Prasanta Sadhukhan wrote: >> Alisen Chung has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge branch 'master' of github.com:openjdk/jdk into 8315655 >> - fix trailing whitespace in instructions string >> - fix line ender >> - fix whitespaces and newline >> - fix whitespaces and newline >> - init commit > > I guess it needs to be understood why it is not failing in windows and linux > and only reproducible in macos. The fix in BasicLookAndFeel is not > appropriate in my opinion as that shared code will be exercised in windows > and linux too.. > > I guess we need to find out why `BasicLookAndFeel.evenDIspatched` is called > for MOUSE_PRESSED in macos and not in windows/linux (ie only called for > MOUSE_RELEASED event), maybe something needs to be done in macos JDK native > event processing to ensure it is only called for "mouse release" event for > showing popup. > > Also, the test can be automated as it is about popup being shown or not which > can be easily checked by `isPopupMenuVIsible/isVisible` method @prsadhuk I've updated the fix to only affect macOS code. I changed NSEvent isPopupTrigger to check for MOUSE_PRESSED or MOUSE_RELEASED java events. Please take a look - PR Comment: https://git.openjdk.org/jdk/pull/19569#issuecomment-2152906675
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: add event check in popup trigger - Changes: - all: https://git.openjdk.org/jdk/pull/19569/files - new: https://git.openjdk.org/jdk/pull/19569/files/ab7e71fe..fb89d2f7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19569=03 - incr: https://webrevs.openjdk.org/?repo=jdk=19569=02-03 Stats: 11 lines in 4 files changed: 5 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location [v4]
On Thu, 6 Jun 2024 09:17:13 GMT, Abhishek Kumar wrote: >> "java.awt.IllegalComponentStateException: component must be showing on the >> screen to determine its location" is thrown when getLocationOnScreen method >> is invoked for JTableHeader while testing JFileChooser demo. It seems that >> in getLocationOfScreen method we are trying to access the parent location >> but that is not visible and ICSE is thrown. >> >> Fix is to handle the exception and can be verified using the steps mentioned >> in [JDK-8332550](https://bugs.openjdk.org/browse/JDK-8332550). >> CI testing is green and link is mentioned in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Remove unused import and added null check LGTM - Marked as reviewed by achung (Committer). PR Review: https://git.openjdk.org/jdk/pull/19391#pullrequestreview-2102360969
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v2]
On Thu, 6 Jun 2024 07:16:42 GMT, Prasanta Sadhukhan wrote: > I guess it needs to be understood why it is not failing in windows and linux > and only reproducible in macos. The fix in BasicLookAndFeel is not > appropriate in my opinion as that shared code will be exercised in windows > and linux too.. > > I guess we need to find out why `BasicLookAndFeel.evenDIspatched` is called > for MOUSE_PRESSED in macos and not in windows/linux (ie only called for > MOUSE_RELEASED event), maybe something needs to be done in macos JDK native > event processing to ensure it is only called for "mouse release" event for > showing popup. > > Also, the test can be automated as it is about popup being shown or not which > can be easily checked by `isPopupMenuVIsible/isVisible` method I guess the root of the issue is that MOUSE_ENTERED is a popup trigger in macos only. I can look into NSEvent isPopupTrigger and change the code to require the event to be MOUSE_PRESSED/MOUSE_RELEASED - PR Comment: https://git.openjdk.org/jdk/pull/19569#issuecomment-2152817659
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v3]
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request incrementally with two additional commits since the last revision: - Merge branch '8315655' of github.com:alisenchung/jdk into 8315655 - fix broken test, add MOUSE_RELEASED - Changes: - all: https://git.openjdk.org/jdk/pull/19569/files - new: https://git.openjdk.org/jdk/pull/19569/files/bf890aa9..ab7e71fe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19569=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19569=01-02 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v2]
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' of github.com:openjdk/jdk into 8315655 - fix trailing whitespace in instructions string - fix line ender - fix whitespaces and newline - fix whitespaces and newline - init commit - Changes: - all: https://git.openjdk.org/jdk/pull/19569/files - new: https://git.openjdk.org/jdk/pull/19569/files/d8758e03..bf890aa9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19569=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19569=00-01 Stats: 589 lines in 11 files changed: 487 ins; 2 del; 100 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup
Issue is a mouse drag will trigger a popup in macos, but not in linux or windows. The solution is to add a check for a mouse pressed event to show popup and prevent mouse entered events from triggering the popup - Commit messages: - fix trailing whitespace in instructions string - fix line ender - fix whitespaces and newline - fix whitespaces and newline - init commit Changes: https://git.openjdk.org/jdk/pull/19569/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19569=00 Issue: https://bugs.openjdk.org/browse/JDK-8315655 Stats: 85 lines in 2 files changed: 84 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19569/head:pull/19569 PR: https://git.openjdk.org/jdk/pull/19569
Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v5]
On Fri, 31 May 2024 08:49:17 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit**), the menu >> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially >> and then toggles between show/hide on `ALT` press. >> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the >> native behavior. Fix is similar to the `ALT` key processing in Windows LAF. >> Automated test case is added to verify the fix and tested in Ubuntu and >> Oracle linux. >> >> CI testing is green and link attached in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment fix Marked as reviewed by achung (Committer). - PR Review: https://git.openjdk.org/jdk/pull/18992#pullrequestreview-2100484965
Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location [v2]
On Wed, 5 Jun 2024 16:14:11 GMT, Abhishek Kumar wrote:
>> "java.awt.IllegalComponentStateException: component must be showing on the
>> screen to determine its location" is thrown when getLocationOnScreen method
>> is invoked for JTableHeader while testing JFileChooser demo. It seems that
>> in getLocationOfScreen method we are trying to access the parent location
>> but that is not visible and ICSE is thrown.
>>
>> Fix is to handle the exception and can be verified using the steps mentioned
>> in [JDK-8332550](https://bugs.openjdk.org/browse/JDK-8332550).
>> CI testing is green and link is mentioned in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> copyright year update
src/java.desktop/share/classes/javax/swing/table/JTableHeader.java line 1368:
> 1366: try {
> 1367: parentLocation = parent.getLocationOnScreen();
> 1368: } catch (IllegalComponentStateException icse) {
should we be preventing the exception by checking if the JTableHeader is
visible or not instead?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19391#discussion_r1628508394
Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v2]
On Fri, 10 May 2024 05:48:35 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
>> line 1085:
>>
>>> 1083: if (UIManager.getBoolean("Button.showMnemonics")) {
>>> 1084: // Do not hide mnemonics if the UI defaults do not
>>> support this
>>> 1085: isMnemonicHidden = false;
>>
>> why does the get method also set the `isMnemonicHidden` flag? Shouldn't this
>> only be done on the set method?
>
>> why does the get method also set the `isMnemonicHidden` flag? Shouldn't this
>> only be done on the set method?
>
> `isMnemonicHidden` is set to false to make sure if the UI defaults don't
> support to hide mnemonics, then don't hide it.
if the UI defaults don't support hiding mnemonics, should a warning be given to
the user?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621383788
Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v4]
On Fri, 24 May 2024 06:29:23 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit**), the menu >> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially >> and then toggles between show/hide on `ALT` press. >> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the >> native behavior. Fix is similar to the `ALT` key processing in Windows LAF. >> Automated test case is added to verify the fix and tested in Ubuntu and >> Oracle linux. >> >> CI testing is green and link attached in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > condition check update test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 66: > 64: robot.keyPress(KeyEvent.VK_ALT); > 65: robot.waitForIdle(); > 66: robot.delay(100); would it be better to set a longer autodelay if needed and remove the extra manual delays? - PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621387034
Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v4]
On Fri, 24 May 2024 06:29:23 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>> and then toggles between show/hide on `ALT` press.
>> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the
>> native behavior. Fix is similar to the `ALT` key processing in Windows LAF.
>> Automated test case is added to verify the fix and tested in Ubuntu and
>> Oracle linux.
>>
>> CI testing is green and link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> condition check update
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
line 769:
> 767: */
> 768: static void repaintMnemonicsInContainer(final Container cont) {
> 769: for (int i = 0; i < cont.getComponentCount(); i++) {
i think you can use `final Component c : cont.getComponents()` here the same
way you did in the repaintMnemonicsInWindow method
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621372299
Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]
On Thu, 30 May 2024 07:33:31 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>> [JDK-8287051](https://bugs.openjdk.org/browse/JDK-8287051) this test was
>> problem listed as it always
>> failed which is captured in the JBS.
>> The reason of failure is the pixel color mismatch between JEditorPane and
>> JTextArea/JTextPane which is caused by the JEditorPane's default opaque
>> value which is false for GTK3 at
>> [L767](https://github.com/kumarabhi006/jdk/blob/c642f44bbe1e4cdbc23496a34ddaae30990ce7c0/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L767).
>> In initial load JEditorPane, JTextArea and JTextPane components are opaque
>> at
>> [L718](https://github.com/kumarabhi006/jdk/blame/6c7656678916ff3f5c9fc70efcbb69ce76801458/jdk/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L718)
>> but after the fix for
>> [JDK-8145547](https://bugs.openjdk.org/browse/JDK-8145547) the
>> implementation was changed to provide conditional support for GTK3 on linux
>> where few components like Editor Pane, Formatted text Field, Password Field
>> etc are opaque only if the [GTK version is not
>> 3](https://github.com/kumarabhi006/jdk/blame/73d2181d56063f6015e4fc42e130591bee39bc36/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L746C21-L746C21).
>> JTextPane's issue was observed by
>> [JDK-8218479](https://bugs.openjdk.org/browse/JDK-8218479) and then the
>> default opacity is set to true for JTextPane [irrespective of GTK
>> version](https://github.com/kumarabhi006/jdk/blame/c642f44bbe1e4cdbc23496a34ddaae30990ce7c0/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L750C16-L750C16).
>> Extending the fix in isOpaque() method in GTKStyle.java for JEditorPane
>> similar to JTextPane resolves the issue.
>>
>> Test verified in both single and dual screen linux machines.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> background method removed
test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 61:
> 59: "com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
> 60: } catch (Exception e) {
> 61: System.out.println("GTK LAF is not supported on this system;
> test passes");
should this be jtreg.testSkipped exception?
test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 70:
> 68: Class type)
> 69: throws Throwable
> 70: {
I think formatting here looks a little odd, could probably move the bracket
onto the same line as `throws Throwable` and shift it over to the right to
match `Class type)`
test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 110:
> 108: }
> 109:
> 110: private void onEDT10() {
is this method required? can it be rewritten to not use onEDT10 and
onBackgroundThread20?
test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 136:
> 134: if (refimg.getWidth() != testimg.getWidth() ||
> 135: refimg.getHeight() != testimg.getHeight())
> 136: {
move bracket to previous line to be consistent
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1621332748
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1621363444
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1621361476
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1621364434
Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v12]
On Wed, 22 May 2024 19:18:18 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `OutputBin` class are based on [Internet Printing >> Protocol (IPP): “output-bin” attribute >> extension](https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf) >> document. >> - `CUPSPrinter.getOutputBins(String printer)` method uses PPD >> `ppdFindOption(..., "OutputBin")` function to get supported output bins for >> the given printer on native level. >> - The fix propagates the `OutputBin` attribute from the printer job >> attributes to `NSPrintInfo` print settings with `OutputBin` key on macOS. >> >> The fix was tested on `Kyocera ECOSYS M8130cidn` printer where >> `ppdFindOption(..., "OutputBin")` call returns 4 output bins (text, choice): >> - Printer settings, None >> - Inner tray, INNERTRAY >> - Separator tray, SEPARATORTRAY >> - Finisher (face-down), Main >> >> if `Printer settings`, `Inner tray`, or `Finisher (face-down)` >> CustomOutputBins is set to `PrinterJob.print(...)` attributes a test page is >> printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If >> `Separator tray` is used a page is printed to the Separator tray. This is >> consistent with the printer behavior when a native print dialog is used from >> a native Preview app to print a document on macOS. > > Alexander Scherbatiy has updated the pull request incrementally with one > additional commit since the last revision: > > Print skip message in tests if number of output bin tests is less than 2 or > type print dialog is the same If output bins are not supported, should the output bin combobox still show up with a single output bin as the only option? test/jdk/javax/print/attribute/OutputBinAttributePrintDialogTest.java line 25: > 23: */ > 24: > 25: /* jtreg test tags should go below the imports - PR Review: https://git.openjdk.org/jdk/pull/16166#pullrequestreview-2072573416 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1610782463
Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]
On Sat, 11 May 2024 17:32:37 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `OutputBin` class are based on [Internet Printing >> Protocol (IPP): “output-bin” attribute >> extension](https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf) >> document. >> - `CUPSPrinter.getOutputBins(String printer)` method uses PPD >> `ppdFindOption(..., "OutputBin")` function to get supported output bins for >> the given printer on native level. >> - The fix propagates the `OutputBin` attribute from the printer job >> attributes to `NSPrintInfo` print settings with `OutputBin` key on macOS. >> >> The fix was tested on `Kyocera ECOSYS M8130cidn` printer where >> `ppdFindOption(..., "OutputBin")` call returns 4 output bins (text, choice): >> - Printer settings, None >> - Inner tray, INNERTRAY >> - Separator tray, SEPARATORTRAY >> - Finisher (face-down), Main >> >> if `Printer settings`, `Inner tray`, or `Finisher (face-down)` >> CustomOutputBins is set to `PrinterJob.print(...)` attributes a test page is >> printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If >> `Separator tray` is used a page is printed to the Separator tray. This is >> consistent with the printer behavior when a native print dialog is used from >> a native Preview app to print a document on macOS. > > Alexander Scherbatiy has updated the pull request incrementally with one > additional commit since the last revision: > > Make OutputBin class sealed Are the tests added supposed to be manual tests? I’m not seeing any dialogs pop up when i run the test on jtreg. Maybe I missed a config setting? I'm running the tests on mac. - PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2121392000
Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]
On Sat, 11 May 2024 12:44:47 GMT, Alexander Scherbatiy wrote: >> I will look how to translate the `Output` and `Output Trays` into languages >> used in the serviceui properties. > > The translation for the `border.output` and `label.outputbins` properties are > added to the fix. These translations will be updated in the next translation drop - PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1607092686
Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]
On Sat, 11 May 2024 17:32:37 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `OutputBin` class are based on [Internet Printing >> Protocol (IPP): “output-bin” attribute >> extension](https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf) >> document. >> - `CUPSPrinter.getOutputBins(String printer)` method uses PPD >> `ppdFindOption(..., "OutputBin")` function to get supported output bins for >> the given printer on native level. >> - The fix propagates the `OutputBin` attribute from the printer job >> attributes to `NSPrintInfo` print settings with `OutputBin` key on macOS. >> >> The fix was tested on `Kyocera ECOSYS M8130cidn` printer where >> `ppdFindOption(..., "OutputBin")` call returns 4 output bins (text, choice): >> - Printer settings, None >> - Inner tray, INNERTRAY >> - Separator tray, SEPARATORTRAY >> - Finisher (face-down), Main >> >> if `Printer settings`, `Inner tray`, or `Finisher (face-down)` >> CustomOutputBins is set to `PrinterJob.print(...)` attributes a test page is >> printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If >> `Separator tray` is used a page is printed to the Separator tray. This is >> consistent with the printer behavior when a native print dialog is used from >> a native Preview app to print a document on macOS. > > Alexander Scherbatiy has updated the pull request incrementally with one > additional commit since the last revision: > > Make OutputBin class sealed test/jdk/javax/print/attribute/OutputBinAttributePrintDialogTest.java line 42: > 40: import javax.print.attribute.standard.MediaSizeName; > 41: import javax.print.attribute.standard.OutputBin; > 42: import javax.swing.*; expand wildcard imports test/jdk/javax/print/attribute/OutputBinAttributeTest.java line 40: > 38: import javax.print.attribute.standard.MediaSizeName; > 39: import javax.print.attribute.standard.OutputBin; > 40: import javax.swing.*; expand wildcard imports - PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1607093187 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1607094475
Integrated: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote: > Opening closed dnd test > Test is green on all platforms This pull request has now been integrated. Changeset: 6f7ddbec Author:Alisen Chung URL: https://git.openjdk.org/jdk/commit/6f7ddbec7d0bc459d44b6518fe1d982eaba7f37b Stats: 214 lines in 1 file changed: 214 ins; 0 del; 0 mod 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed Reviewed-by: serb, dnguyen, tr - PR: https://git.openjdk.org/jdk/pull/19128
Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF
On Tue, 14 May 2024 23:57:20 GMT, Damon Nguyen wrote:
>> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in
>> Aqua L JTabbedPane's content area and tab background color are not as
>> expected when tabbedpane opacity is set to true or false. Fix is to handle
>> the opacity behavior correctly and inline with other LAF as well.
>>
>> Existing test `TestBackgroundScrollPolicy.java` failed with the proposed fix
>> and it is updated to run only for linux and windows platform because the
>> content area for tabbedpane is rendered to the width and height of
>> tabbedpane starting from (0, 0) position
>> (https://github.com/openjdk/jdk/blob/cf7c97732320d70de5f5725c920d5c3861a2c9c8/src/java.desktop/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java#L684C16-L684C16)
>> and that leaves no place for tab area behind tabs.
>>
>> CI testing is green after this test update and link posted in JBS.
>
> test/jdk/javax/swing/JTabbedPane/TestBackgroundScrollPolicy.java line 51:
>
>> 49: for (UIManager.LookAndFeelInfo laf :
>> UIManager.getInstalledLookAndFeels()) {
>> 50: System.out.println("Testing L: " + laf.getClassName());
>> 51: if (!laf.getClassName().contains("Aqua")) {
>
> Why can't this test be set to require windows or linux OS's in the test tags
> rather than use this if-statement?
We could probably just exclude macos in the jtreg tags instead. But that would
also mean that we can't run the test on macos on a different L Should this
test be run on, for example, metal on macos?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19170#discussion_r1600885145
Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote:
> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua
> L JTabbedPane's content area and tab background color are not as expected
> when tabbedpane opacity is set to true or false. Fix is to handle the opacity
> behavior correctly and inline with other LAF as well.
>
> Existing test `TestBackgroundScrollPolicy.java` failed with the proposed fix
> and it is updated to run only for linux and windows platform because the
> content area for tabbedpane is rendered to the width and height of tabbedpane
> starting from (0, 0) position
> (https://github.com/openjdk/jdk/blob/cf7c97732320d70de5f5725c920d5c3861a2c9c8/src/java.desktop/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java#L684C16-L684C16)
> and that leaves no place for tab area behind tabs.
>
> CI testing is green after this test update and link posted in JBS.
src/java.desktop/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java line 694:
> 692: }
> 693:
> 694: if ((tabPane.isOpaque() || contentOpaque) &&
> tabPane.getTabCount() > 0) {
what is the difference between tabPane.isOpaque() and contentOpaque? Should
isOpaque be set when contentOpaque is set?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19170#discussion_r1600883486
Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed [v2]
On Thu, 9 May 2024 19:56:40 GMT, Phil Race wrote: > You are opening the test, but the bug ID is about the test failing. Why > specifically did the test fail before and what about this version fixes that ? The test needed some delays between mouse moves for stability. I accidentally deleted a delay when I moved the test but I've readded it now. - PR Comment: https://git.openjdk.org/jdk/pull/19128#issuecomment-2106629654
Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed [v3]
> Opening closed dnd test > Test is green on all platforms Alisen Chung has updated the pull request incrementally with two additional commits since the last revision: - extra newline after jtreg tags - re-added delay - Changes: - all: https://git.openjdk.org/jdk/pull/19128/files - new: https://git.openjdk.org/jdk/pull/19128/files/fb1d2e9b..dc676f0a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19128=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19128=01-02 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/19128.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19128/head:pull/19128 PR: https://git.openjdk.org/jdk/pull/19128
Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v2]
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>> and then toggles between show/hide on `ALT` press.
>> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the
>> native behavior. Fix is similar to the `ALT` key processing in Windows LAF.
>> Automated test case is added to verify the fix and tested in Ubuntu and
>> Oracle linux.
>>
>> CI testing is green and link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Var moved to local scope
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
line 1085:
> 1083: if (UIManager.getBoolean("Button.showMnemonics")) {
> 1084: // Do not hide mnemonics if the UI defaults do not support
> this
> 1085: isMnemonicHidden = false;
why does the get method also set the `isMnemonicHidden` flag? Shouldn't this
only be done on the set method?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1595973841
Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed [v2]
On Wed, 8 May 2024 19:17:05 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> button1_down_mask, dispose on edt, replace system err with out, frame
>> srcpoint and dimension access on edt
>
> test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
> line 53:
>
>> 51: * @run main MouseEventAfterStartDragTest
>> 52: */
>> 53: public final class MouseEventAfterStartDragTest implements
>> AWTEventListener {
>
> Suggestion:
>
> */
>
> public final class MouseEventAfterStartDragTest implements AWTEventListener {
i thought the standard was to have no newline between the test tags and the
class declaration?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19128#discussion_r1594526757
Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed [v2]
> Opening closed dnd test > Test is green on all platforms Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: button1_down_mask, dispose on edt, replace system err with out, frame srcpoint and dimension access on edt - Changes: - all: https://git.openjdk.org/jdk/pull/19128/files - new: https://git.openjdk.org/jdk/pull/19128/files/8d63997e..fb1d2e9b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19128=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19128=00-01 Stats: 24 lines in 1 file changed: 8 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/19128.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19128/head:pull/19128 PR: https://git.openjdk.org/jdk/pull/19128
RFR: 8331870: open java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
Opening closed dnd test Test is green on all platforms - Commit messages: - init commit Changes: https://git.openjdk.org/jdk/pull/19128/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19128=00 Issue: https://bugs.openjdk.org/browse/JDK-8331870 Stats: 204 lines in 1 file changed: 204 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19128.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19128/head:pull/19128 PR: https://git.openjdk.org/jdk/pull/19128
Integrated: 8328999: Update GIFlib to 5.2.2
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote: > Updating giflib, clientlibs tests are green on all platforms This pull request has now been integrated. Changeset: 6969a9e0 Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/6969a9e0b2143eee5a7cfa02460a8ab6dfa08cda Stats: 846 lines in 8 files changed: 179 ins; 105 del; 562 mod 8328999: Update GIFlib to 5.2.2 Reviewed-by: tr, dnguyen, prr - PR: https://git.openjdk.org/jdk/pull/18985
Re: RFR: 8328999: Update GIFlib to 5.2.2
On Wed, 1 May 2024 16:40:21 GMT, Phil Race wrote: > So it sounds like the JDK mods are no longer needed, at least for current > mainline compilers, and I assume you verified that all those formatting > changes are from upstream, not your IDE ? > > If yes, approved, but it needs a 2nd reviewer approval still. I verified the formatting changes are from upstream - PR Comment: https://git.openjdk.org/jdk/pull/18985#issuecomment-2088922934
Re: RFR: 8328999: Update GIFlib to 5.2.2
On Tue, 30 Apr 2024 21:33:41 GMT, Alexander Zvegintsev wrote: >> does this also apply for the other JDK modification for old compilers as >> well? > > Regarding the `JDK modifications to support building using old compilers` > from `gif_lib.h`: > > I found my old [review > request](https://mail.openjdk.org/pipermail/awt-dev/2015-April/009269.html), > that mentioned > [why](https://stackoverflow.com/questions/8548521/trying-to-use-include-stdbool-h-in-vs-2010/8549206) > these changes were added (because of the issue with VS 2010). > > However, this issue [should be fixed as of VS 2013]( > https://devblogs.microsoft.com/cppblog/c99-library-support-in-visual-studio-2013/). > > So you should probably check the build without these changes, and if it works > fine, remove them. > > The only concern is if some of the JDKs we are going to backport this upgrade > use VS below 2013 (I am not sure if we have any), but I think we can bring > our fix back to the specific backport. The current version doesn't have these changes and clientlibs tests are green - PR Review Comment: https://git.openjdk.org/jdk/pull/18985#discussion_r1586647585
Re: RFR: 8328999: Update GIFlib to 5.2.2
On Mon, 29 Apr 2024 21:05:34 GMT, Alexander Zvegintsev wrote: >> src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h line 40: >> >>> 38: #include >>> 39: #endif >>> 40: /** End JDK modifications to support building on Windows **/ >> >> Do we still need this ? > > The GIFLIB version 5.2.2 adds the `ifndef` wrap, and it is no longer the "JDK > modification", so it looks like our comment can be removed does this also apply for the other JDK modification for old compilers as well? - PR Review Comment: https://git.openjdk.org/jdk/pull/18985#discussion_r1585334886
Re: RFR: 8328999: Update GIFlib to 5.2.2
On Tue, 30 Apr 2024 07:58:25 GMT, Tejesh R wrote: > here There are no changes to the COPYING file in the newest version of giblib so there weren't any changes here either - PR Comment: https://git.openjdk.org/jdk/pull/18985#issuecomment-2086543204
RFR: 8328999: Update GIFlib to 5.2.2
Updating giflib, clientlibs tests are green on all platforms - Commit messages: - update md - revert tab spacing to spaces - init commit Changes: https://git.openjdk.org/jdk/pull/18985/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18985=00 Issue: https://bugs.openjdk.org/browse/JDK-8328999 Stats: 846 lines in 8 files changed: 179 ins; 105 del; 562 mod Patch: https://git.openjdk.org/jdk/pull/18985.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18985/head:pull/18985 PR: https://git.openjdk.org/jdk/pull/18985
Withdrawn: 8328999: Update GIFlib to 5.2.2
On Thu, 25 Apr 2024 16:26:49 GMT, Alisen Chung wrote: > Updating giflib, clientlibs tests are green on all platforms This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/18956
Re: RFR: 8328999: Update GIFlib to 5.2.2
On Fri, 26 Apr 2024 19:30:25 GMT, Phil Race wrote: > Why don't I see an updated giflib.md ? The md file is still in the process of being approved by legal - PR Comment: https://git.openjdk.org/jdk/pull/18956#issuecomment-2080072668
RFR: 8328999: Update GIFlib to 5.2.2
Updating giflib, clientlibs tests are green on all platforms - Commit messages: - revert tab spacing to spaces - init commit Changes: https://git.openjdk.org/jdk/pull/18956/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18956=00 Issue: https://bugs.openjdk.org/browse/JDK-8328999 Stats: 823 lines in 7 files changed: 159 ins; 105 del; 559 mod Patch: https://git.openjdk.org/jdk/pull/18956.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18956/head:pull/18956 PR: https://git.openjdk.org/jdk/pull/18956
Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote: > Instructions set has been updated as per OS specific. JTable keyboard > navigation is tested in each OS and according it's current implementation the > instructions has been updated (Few has been removed and few has been > updated). > PassFailJFrame.builder is used. Changes requested by achung (Committer). test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 102: > 100: colorColumn.setCellRenderer(colorColumnRenderer); > 101: > 102: // Set a tooltip for the header of the color's column. I think `Set a tooltip for the header of the color column` would be technically correct? test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 130: > 128: frame.add(scrollPane); > 129: frame.pack(); > 130: frame.setVisible(true); no need for frame.setVisible since PassFailJFrame will do that - PR Review: https://git.openjdk.org/jdk/pull/18855#pullrequestreview-2015214194 PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1575014694 PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1575012265
Integrated: 8328648: Remove applet usage from JFileChooser tests bug4150029
On Wed, 20 Mar 2024 22:48:46 GMT, Alisen Chung wrote: > Removing applet usage from manual JFileChooser tests This pull request has now been integrated. Changeset: 021ed6ae Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/021ed6aea92f770ebeae65175d94797f7c418c82 Stats: 150 lines in 2 files changed: 55 ins; 54 del; 41 mod 8328648: Remove applet usage from JFileChooser tests bug4150029 Reviewed-by: dnguyen, abhiscxk, honkar - PR: https://git.openjdk.org/jdk/pull/18415
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v9]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: equals modifier - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/ed8ed220..358da224 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=08 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=07-08 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Integrated: 8328403: Remove applet usage from JColorChooser tests Test6977726
On Tue, 19 Mar 2024 01:47:01 GMT, Alisen Chung wrote: > Removing applet usage from manual JColorChooser tests This pull request has now been integrated. Changeset: 1e76e1fd Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/1e76e1fdfa67c28ce20b0dc7fb0253670be54554 Stats: 63 lines in 2 files changed: 21 ins; 32 del; 10 mod 8328403: Remove applet usage from JColorChooser tests Test6977726 Reviewed-by: tr, honkar - PR: https://git.openjdk.org/jdk/pull/18369
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v8]
On Fri, 29 Mar 2024 16:43:53 GMT, Abhishek Kumar wrote: > Looks good now. Only point is "should we move this test outside folder as > html file is deleted now?". Hope you have tested in CI for all platform. Clientlibs is green, also I'll keep this inside the folder for bookkeeping - PR Comment: https://git.openjdk.org/jdk/pull/18415#issuecomment-2029234162
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v8]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: move var into local, simplified condition check, spacing - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/29486a10..ed8ed220 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=07 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=06-07 Stats: 8 lines in 1 file changed: 1 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v7]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: added headful tag, remove pass boolean var and directly evaluate pass condition - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/0de40f87..29486a10 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=06 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=05-06 Stats: 6 lines in 1 file changed: 1 ins; 4 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v6]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'master' of https://github.com/openjdk/jdk into 2024_spring_testsprint_8 - removed second pass check - moved create ui code to helper, change test pass check, add mouse release, remove getContentPane - change to automatic test - force fail - remove extra dialog - init commit - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/eb58531e..0de40f87 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=05 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=04-05 Stats: 353493 lines in 2818 files changed: 17195 ins; 12263 del; 324035 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Re: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v6]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: update test from feedback - Changes: - all: https://git.openjdk.org/jdk/pull/18369/files - new: https://git.openjdk.org/jdk/pull/18369/files/ff6f5e51..dad92188 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18369=05 - incr: https://webrevs.openjdk.org/?repo=jdk=18369=04-05 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18369.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369 PR: https://git.openjdk.org/jdk/pull/18369
Re: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v4]
On Tue, 26 Mar 2024 21:16:39 GMT, Phil Race wrote: > are you going to reduce the timeout as Alexander suggested ? I've lowered the timeout to 2 minutes - PR Comment: https://git.openjdk.org/jdk/pull/18369#issuecomment-2024149068
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v5]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed second pass check - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/5a05f64b..eb58531e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=04 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=03-04 Stats: 17 lines in 1 file changed: 1 ins; 12 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Integrated: 8328819: Remove applet usage from JFileChooser tests bug6698013
On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung wrote: > Removing applet usage from manual JFileChooser tests > The original test is failing (nothing shows up in the JFileChooser), but this > change does replace the applet usage with PassFailJFrame This pull request has now been integrated. Changeset: e3588bba Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/e3588bba0451d7d505b0e22d014842110677041b Stats: 77 lines in 2 files changed: 20 ins; 39 del; 18 mod 8328819: Remove applet usage from JFileChooser tests bug6698013 Reviewed-by: honkar, tr, dnguyen - PR: https://git.openjdk.org/jdk/pull/18456
Integrated: 8328227: Remove applet usage from JColorChooser tests Test4887836
On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung wrote: > Removing applet usage from manual JColorChooser tests This pull request has now been integrated. Changeset: cc5b9c63 Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/cc5b9c63cbc1743e22f80dce51d803e267c60317 Stats: 66 lines in 2 files changed: 21 ins; 34 del; 11 mod 8328227: Remove applet usage from JColorChooser tests Test4887836 Reviewed-by: honkar, prr - PR: https://git.openjdk.org/jdk/pull/18316
Re: RFR: 8328819: Remove applet usage from JFileChooser tests bug6698013 [v3]
> Removing applet usage from manual JFileChooser tests > The original test is failing (nothing shows up in the JFileChooser), but this > change does replace the applet usage with PassFailJFrame Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: update test instructions, move vars into subclass - Changes: - all: https://git.openjdk.org/jdk/pull/18456/files - new: https://git.openjdk.org/jdk/pull/18456/files/e43d8b1e..5cd07d36 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18456=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18456=01-02 Stats: 14 lines in 1 file changed: 4 ins; 6 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/18456.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18456/head:pull/18456 PR: https://git.openjdk.org/jdk/pull/18456
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v4]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: moved create ui code to helper, change test pass check, add mouse release, remove getContentPane - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/0126af35..5a05f64b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=03 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=02-03 Stats: 36 lines in 1 file changed: 16 ins; 12 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Re: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v5]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: instruction string change - Changes: - all: https://git.openjdk.org/jdk/pull/18369/files - new: https://git.openjdk.org/jdk/pull/18369/files/8f03f04c..ff6f5e51 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18369=04 - incr: https://webrevs.openjdk.org/?repo=jdk=18369=03-04 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18369.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369 PR: https://git.openjdk.org/jdk/pull/18369
Re: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v3]
On Mon, 25 Mar 2024 18:43:44 GMT, Alexander Zvegintsev
wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test instructions
>
> test/jdk/javax/swing/JColorChooser/Test6977726.java line 43:
>
>> 41: .title("Test6977726")
>> 42: .instructions("Check that there is a panel with white
>> text " +
>> 43: "titled \"Preview\" in the JColorChooser.")
>
>> Check that there is a panel with white text titled "Preview" in the
>> JColorChooser.
>
> I read it as if the text should be titled "Preview", although it should
> actually refer to the panel(maybe I'm wrong).
>
> Since you modified the original "If you don't see the preview panel" by
> adding the "white text" check, you should check it on all platforms/LaFs that
> this text is really white and distinguishable from the background, otherwise
> it might come back to us one day with a failure of this test.
When I wrote it I meant to say "Check that there is a panel (with white text)
titled 'Preview'", but now that I read it again it is pretty unclear..
Does
`Check that there is a panel with "Text Preview Panel" text and with title
"Preview" in the JColorChooser.`
make more sense?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1540098175
Re: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v4]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: instruction string change - Changes: - all: https://git.openjdk.org/jdk/pull/18369/files - new: https://git.openjdk.org/jdk/pull/18369/files/39b41d55..8f03f04c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18369=03 - incr: https://webrevs.openjdk.org/?repo=jdk=18369=02-03 Stats: 7 lines in 1 file changed: 4 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18369.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369 PR: https://git.openjdk.org/jdk/pull/18369
Re: RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 [v5]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: instruction string change - Changes: - all: https://git.openjdk.org/jdk/pull/18316/files - new: https://git.openjdk.org/jdk/pull/18316/files/6ff8dfa4..3b75b6ad Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18316=04 - incr: https://webrevs.openjdk.org/?repo=jdk=18316=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18316.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316 PR: https://git.openjdk.org/jdk/pull/18316
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v3]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: change to automatic test - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/630d78c9..0126af35 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=01-02 Stats: 95 lines in 1 file changed: 53 ins; 19 del; 23 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Integrated: 8328380: Remove applet usage from JColorChooser tests Test6348456
On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung wrote: > Removing applet usage from manual JColorChooser tests This pull request has now been integrated. Changeset: 78d1b904 Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/78d1b9046830198cd61c505f04f245a430878a5b Stats: 93 lines in 2 files changed: 37 ins; 45 del; 11 mod 8328380: Remove applet usage from JColorChooser tests Test6348456 Reviewed-by: honkar - PR: https://git.openjdk.org/jdk/pull/18359
Re: RFR: 8328819: Remove applet usage from JFileChooser tests bug6698013 [v2]
> Removing applet usage from manual JFileChooser tests > The original test is failing (nothing shows up in the JFileChooser), but this > change does replace the applet usage with PassFailJFrame Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: increase rows to show second window - Changes: - all: https://git.openjdk.org/jdk/pull/18456/files - new: https://git.openjdk.org/jdk/pull/18456/files/9ca90cb9..e43d8b1e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18456=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18456=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18456.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18456/head:pull/18456 PR: https://git.openjdk.org/jdk/pull/18456
Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v2]
> Removing applet usage from manual JFileChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: force fail - Changes: - all: https://git.openjdk.org/jdk/pull/18415/files - new: https://git.openjdk.org/jdk/pull/18415/files/4ed3d97e..630d78c9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18415=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18415=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Re: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v3]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: test instructions - Changes: - all: https://git.openjdk.org/jdk/pull/18369/files - new: https://git.openjdk.org/jdk/pull/18369/files/d0818756..39b41d55 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18369=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18369=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18369.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369 PR: https://git.openjdk.org/jdk/pull/18369
Re: RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456 [v2]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: fix line length and frame title - Changes: - all: https://git.openjdk.org/jdk/pull/18359/files - new: https://git.openjdk.org/jdk/pull/18359/files/c6e99a27..ff633d32 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18359=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18359=00-01 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/18359.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18359/head:pull/18359 PR: https://git.openjdk.org/jdk/pull/18359
Re: RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 [v4]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: change font - Changes: - all: https://git.openjdk.org/jdk/pull/18316/files - new: https://git.openjdk.org/jdk/pull/18316/files/00bf78b2..6ff8dfa4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18316=03 - incr: https://webrevs.openjdk.org/?repo=jdk=18316=02-03 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18316.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316 PR: https://git.openjdk.org/jdk/pull/18316
Re: RFR: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to
>> main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year
Changes requested by achung (Committer).
test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 34:
> 32: * between two JVM instances
> 33: */
> 34: public class JColorChooserDnDTest {
Missing @test and @run tags?
-
PR Review: https://git.openjdk.org/jdk/pull/18436#pullrequestreview-1955698065
PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1536138393
Re: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main [v4]
On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen wrote: >> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using >> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is >> no longer an applet. Added test instructions related to the linked JBS issue. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix main/manual Changes requested by achung (Committer). test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 43: > 41: > 42: import javax.swing.JButton; > 43: i think the order should be imports then jtreg tags - PR Review: https://git.openjdk.org/jdk/pull/18362#pullrequestreview-1955695843 PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1536136404
RFR: 8328819: Remove applet usage from JFileChooser tests bug6698013
Removing applet usage from manual JFileChooser tests The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame - Commit messages: - init commit Changes: https://git.openjdk.org/jdk/pull/18456/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18456=00 Issue: https://bugs.openjdk.org/browse/JDK-8328819 Stats: 70 lines in 2 files changed: 22 ins; 39 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/18456.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18456/head:pull/18456 PR: https://git.openjdk.org/jdk/pull/18456
Re: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html applet test to main [v6]
On Thu, 21 Mar 2024 20:17:46 GMT, Harshitha Onkar wrote: >> Following test is converted from applet to main using PassFailJFrame. >> >> The original test had ignore tag - **The fix for this problem was backed out >> for 5057184. Remove this "ignore" tag when it is fixed again.** >> I believe this was fixed and the test works correctly on Linux platforms, >> hence ignore tag has been removed. >> >> This is a semi-automated test, the first check is manual and the 2nd one is >> automated. Details in the test instructions. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > re-added @requires tag Marked as reviewed by achung (Committer). - PR Review: https://git.openjdk.org/jdk/pull/18402#pullrequestreview-1953428980
Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]
On Thu, 21 Mar 2024 18:15:23 GMT, Alisen Chung wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove .html from the @test clause > > test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 142: > >> 140: .awaitAndCheck(); >> 141: } >> 142: } > > extra newline oops, got confused with github formatting, everything else looks good - PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1534684467
Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote: >> Convert test to a main method based; >> Move test to an apropriate location; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove .html from the @test clause Marked as reviewed by achung (Committer). - PR Review: https://git.openjdk.org/jdk/pull/18363#pullrequestreview-1953428533
Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote: >> Convert test to a main method based; >> Move test to an apropriate location; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove .html from the @test clause Changes requested by achung (Committer). test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 142: > 140: .awaitAndCheck(); > 141: } > 142: } extra newline - PR Review: https://git.openjdk.org/jdk/pull/18363#pullrequestreview-1953063205 PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1534416751
Re: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html applet test to main [v4]
On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar wrote: >> Following test is converted from applet to main using PassFailJFrame. >> >> The original test had ignore tag - **The fix for this problem was backed out >> for 5057184. Remove this "ignore" tag when it is fixed again.** >> I believe this was fixed and the test works correctly on Linux platforms, >> hence ignore tag has been removed. >> >> This is a semi-automated test, the first check is manual and the 2nd one is >> automated. Details in the test instructions. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > minor jtreg tag change Changes requested by achung (Committer). test/jdk/java/awt/im/bug4490692.java line 115: > 113: return panel; > 114: } > 115: } extra newline - PR Review: https://git.openjdk.org/jdk/pull/18402#pullrequestreview-1953060038 PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534414016
RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029
Removing applet usage from manual JFileChooser tests - Commit messages: - remove extra dialog - init commit Changes: https://git.openjdk.org/jdk/pull/18415/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18415=00 Issue: https://bugs.openjdk.org/browse/JDK-8328648 Stats: 116 lines in 2 files changed: 25 ins; 46 del; 45 mod Patch: https://git.openjdk.org/jdk/pull/18415.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415 PR: https://git.openjdk.org/jdk/pull/18415
Re: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v2]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: spacing - Changes: - all: https://git.openjdk.org/jdk/pull/18369/files - new: https://git.openjdk.org/jdk/pull/18369/files/19fa62e8..d0818756 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18369=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18369=00-01 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18369.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369 PR: https://git.openjdk.org/jdk/pull/18369
Re: RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 [v3]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: text block instructions - Changes: - all: https://git.openjdk.org/jdk/pull/18316/files - new: https://git.openjdk.org/jdk/pull/18316/files/9652def1..00bf78b2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18316=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18316=01-02 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18316.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316 PR: https://git.openjdk.org/jdk/pull/18316
RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726
Removing applet usage from manual JColorChooser tests - Commit messages: - init commit Changes: https://git.openjdk.org/jdk/pull/18369/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18369=00 Issue: https://bugs.openjdk.org/browse/JDK-8328403 Stats: 57 lines in 2 files changed: 15 ins; 32 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/18369.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369 PR: https://git.openjdk.org/jdk/pull/18369
RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456
Removing applet usage from manual JColorChooser tests - Commit messages: - remove html - init commit Changes: https://git.openjdk.org/jdk/pull/18359/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18359=00 Issue: https://bugs.openjdk.org/browse/JDK-8328380 Stats: 86 lines in 2 files changed: 32 ins; 42 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/18359.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18359/head:pull/18359 PR: https://git.openjdk.org/jdk/pull/18359
Integrated: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."
On Fri, 1 Mar 2024 22:49:25 GMT, Alisen Chung wrote: > Introduce delays in test to stabilize. Test passes 50x after fix. This pull request has now been integrated. Changeset: 3f2e849c Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3 Stats: 44 lines in 2 files changed: 29 ins; 13 del; 2 mod 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed." Reviewed-by: tr, aivanov, prr - PR: https://git.openjdk.org/jdk/pull/18091
Re: RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 [v2]
On Fri, 15 Mar 2024 00:41:21 GMT, Harshitha Onkar wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove middle copyright year, update spacings and jtreg summary
>
> test/jdk/javax/swing/JColorChooser/Test4887836.java line 41:
>
>> 39: public static void main(String[] args) throws Exception {
>> 40: String instructions = "If you do not see white area under the
>> \"Swatches\" tab,\n" +
>> 41: "then test passed, otherwise it failed.";
>
> The original instructions seem a bit vague and the test window has a lot
> going on so probably more details here would add clarity.
The original test [JDK-4887836](https://bugs.openjdk.org/browse/JDK-4887836) is
quite vague so I'm not sure how to add more details other than "white area
under 'Swatches' tab"
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1529184482
Re: RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 [v2]
> Removing applet usage from manual JColorChooser tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: remove middle copyright year, update spacings and jtreg summary - Changes: - all: https://git.openjdk.org/jdk/pull/18316/files - new: https://git.openjdk.org/jdk/pull/18316/files/b5b6e0c1..9652def1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18316=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18316=00-01 Stats: 8 lines in 1 file changed: 3 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/18316.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316 PR: https://git.openjdk.org/jdk/pull/18316
Integrated: 8328228: Missing comma in copyright year for a few JColorChooser tests
On Thu, 14 Mar 2024 23:36:13 GMT, Alisen Chung wrote: > Adding comma to copyright years This pull request has now been integrated. Changeset: e8d1ba33 Author: Alisen Chung URL: https://git.openjdk.org/jdk/commit/e8d1ba33b48dc8e6b937258c3765b91426c5b6f1 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod 8328228: Missing comma in copyright year for a few JColorChooser tests Reviewed-by: jpai - PR: https://git.openjdk.org/jdk/pull/18317
