Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v4]
On Thu, 18 Jan 2024 22:54:57 GMT, Phil Race wrote: > I suppose you can't know exactly how much space you need since the dialog > size is out of your control. Yes, I've fixed screen center position - 200 based on my test runs with multiple screen size. - PR Comment: https://git.openjdk.org/jdk/pull/17364#issuecomment-1899768927
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v4]
On Tue, 16 Jan 2024 05:58:45 GMT, Tejesh R wrote: >> The issue is that the doc area (in respect to the screen height which is >> 768px) which is at the bottom was causing the `JFileChooser `to be placed >> slightly above the set location. Was able to reproduce in local machine with >> reference to the failure image provided in the CI logs. The suggested fix is >> to place the main Frame slightly above the center of the screen than setting >> at the center of the screen. Several CI runs were made and no issue found. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17364#pullrequestreview-1830878417
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v4]
On Tue, 16 Jan 2024 05:58:45 GMT, Tejesh R wrote: >> The issue is that the doc area (in respect to the screen height which is >> 768px) which is at the bottom was causing the `JFileChooser `to be placed >> slightly above the set location. Was able to reproduce in local machine with >> reference to the failure image provided in the CI logs. The suggested fix is >> to place the main Frame slightly above the center of the screen than setting >> at the center of the screen. Several CI runs were made and no issue found. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix I suppose you can't know exactly how much space you need since the dialog size is out of your control. - Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17364#pullrequestreview-1830687939
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v3]
On Sat, 13 Jan 2024 05:06:10 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 216: > >> 214: >> 215: int width = (int) screenSize.getWidth() / 2; >> 216: int height = (int) screenSize.getHeight() / 2; > > This is not the width and height, this is the kind of point(x,y) where the > frame will be located. Yeah, I got it now. Updated. - PR Review Comment: https://git.openjdk.org/jdk/pull/17364#discussion_r1452956890
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v4]
> The issue is that the doc area (in respect to the screen height which is > 768px) which is at the bottom was causing the `JFileChooser `to be placed > slightly above the set location. Was able to reproduce in local machine with > reference to the failure image provided in the CI logs. The suggested fix is > to place the main Frame slightly above the center of the screen than setting > at the center of the screen. Several CI runs were made and no issue found. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Review fix - Changes: - all: https://git.openjdk.org/jdk/pull/17364/files - new: https://git.openjdk.org/jdk/pull/17364/files/e8dfd6b7..06188daa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17364=03 - incr: https://webrevs.openjdk.org/?repo=jdk=17364=02-03 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/17364.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17364/head:pull/17364 PR: https://git.openjdk.org/jdk/pull/17364
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v3]
On Fri, 12 Jan 2024 05:12:40 GMT, Tejesh R wrote: >> The issue is that the doc area (in respect to the screen height which is >> 768px) which is at the bottom was causing the `JFileChooser `to be placed >> slightly above the set location. Was able to reproduce in local machine with >> reference to the failure image provided in the CI logs. The suggested fix is >> to place the main Frame slightly above the center of the screen than setting >> at the center of the screen. Several CI runs were made and no issue found. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 216: > 214: > 215: int width = (int) screenSize.getWidth() / 2; > 216: int height = (int) screenSize.getHeight() / 2; This is not the width and height, this is the kind of point(x,y) where the frame will be located. - PR Review Comment: https://git.openjdk.org/jdk/pull/17364#discussion_r1451242135
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v3]
> The issue is that the doc area (in respect to the screen height which is > 768px) which is at the bottom was causing the `JFileChooser `to be placed > slightly above the set location. Was able to reproduce in local machine with > reference to the failure image provided in the CI logs. The suggested fix is > to place the main Frame slightly above the center of the screen than setting > at the center of the screen. Several CI runs were made and no issue found. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Review fix - Changes: - all: https://git.openjdk.org/jdk/pull/17364/files - new: https://git.openjdk.org/jdk/pull/17364/files/b6a099e9..e8dfd6b7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17364=02 - incr: https://webrevs.openjdk.org/?repo=jdk=17364=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/17364.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17364/head:pull/17364 PR: https://git.openjdk.org/jdk/pull/17364
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v2]
On Thu, 11 Jan 2024 06:46:43 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 217: > >> 215: int screenWidth = (int) screenSize.getWidth() / 2; >> 216: int screenHeight = (int) screenSize.getHeight() / 2; >> 217: frame = new JFrame(); > > Frame should have title. "screenWidth" and "screenHeight" seems not the width and height, it is better to use some other name. - PR Review Comment: https://git.openjdk.org/jdk/pull/17364#discussion_r1449629687
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v2]
> The issue is that the doc area (in respect to the screen height which is > 768px) which is at the bottom was causing the `JFileChooser `to be placed > slightly above the set location. Was able to reproduce in local machine with > reference to the failure image provided in the CI logs. The suggested fix is > to place the main Frame slightly above the center of the screen than setting > at the center of the screen. Several CI runs were made and no issue found. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Review fix - Changes: - all: https://git.openjdk.org/jdk/pull/17364/files - new: https://git.openjdk.org/jdk/pull/17364/files/77926ea3..b6a099e9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17364=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17364=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17364.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17364/head:pull/17364 PR: https://git.openjdk.org/jdk/pull/17364
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
On Thu, 11 Jan 2024 04:48:23 GMT, Tejesh R wrote: > The issue is that the doc area (in respect to the screen height which is > 768px) which is at the bottom was causing the `JFileChooser `to be placed > slightly above the set location. Was able to reproduce in local machine with > reference to the failure image provided in the CI logs. The suggested fix is > to place the main Frame slightly above the center of the screen than setting > at the center of the screen. Several CI runs were made and no issue found. test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 217: > 215: int screenWidth = (int) screenSize.getWidth() / 2; > 216: int screenHeight = (int) screenSize.getHeight() / 2; > 217: frame = new JFrame(); Frame should have title. - PR Review Comment: https://git.openjdk.org/jdk/pull/17364#discussion_r1448363735
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
On Thu, 11 Jan 2024 06:14:48 GMT, Abhishek Kumar wrote: > Does the test fails only on the system which is 768px in height or in any > other screen size also? Not only on 768, whichever size isn't enough for the FileChooser to show up fully it'll fail. I was able to check till 720px in local machine where it fails. After fix I tested in all C machines and it is green. - PR Comment: https://git.openjdk.org/jdk/pull/17364#issuecomment-1886373685
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
On Thu, 11 Jan 2024 04:48:23 GMT, Tejesh R wrote: > The issue is that the doc area (in respect to the screen height which is > 768px) which is at the bottom was causing the `JFileChooser `to be placed > slightly above the set location. Was able to reproduce in local machine with > reference to the failure image provided in the CI logs. The suggested fix is > to place the main Frame slightly above the center of the screen than setting > at the center of the screen. Several CI runs were made and no issue found. Does the test fails only on the system which is 768px in height or in any other screen size also? - PR Comment: https://git.openjdk.org/jdk/pull/17364#issuecomment-1886362201
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
On Thu, 11 Jan 2024 05:31:50 GMT, Abhishek Kumar wrote: > > The issue is that the doc area (`in respect to the screen width which is > > 768px`) which is at the bottom was causing the JFileChooser to be placed > > slightly above the set location. > > Is it with respect to height ? Yeah, corrected now. - PR Comment: https://git.openjdk.org/jdk/pull/17364#issuecomment-1886326932
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
On Thu, 11 Jan 2024 04:48:23 GMT, Tejesh R wrote: > The issue is that the doc area (`in respect to the screen width which is > 768px`) which is at the bottom was causing the JFileChooser to be placed > slightly above the set location. Is it with respect to height ? - PR Comment: https://git.openjdk.org/jdk/pull/17364#issuecomment-1886273346
RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
The issue is that the doc area (in respect to the screen width which is 768px) which is at the bottom was causing the `JFileChooser `to be placed slightly above the set location. Was able to reproduce in local machine with reference to the failure image provided in the CI logs. The suggested fix is to place the main Frame slightly above the center of the screen than setting at the center of the screen. Several CI runs were made and no issue found. - Commit messages: - Fix Changes: https://git.openjdk.org/jdk/pull/17364/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17364=00 Issue: https://bugs.openjdk.org/browse/JDK-8295804 Stats: 9 lines in 1 file changed: 6 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17364.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17364/head:pull/17364 PR: https://git.openjdk.org/jdk/pull/17364
