Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v2]
On Thu, 11 Jan 2024 06:46:43 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 217: > >> 215: int screenWidth = (int) screenSize.getWidth() / 2; >> 216: int screenHeight = (int) screenSize.getHeight() / 2; >> 217: frame = new JFrame(); > > Frame should have title. "screenWidth" and "screenHeight" seems not the width and height, it is better to use some other name. - PR Review Comment: https://git.openjdk.org/jdk/pull/17364#discussion_r1449629687
Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v2]
> The issue is that the doc area (in respect to the screen height which is > 768px) which is at the bottom was causing the `JFileChooser `to be placed > slightly above the set location. Was able to reproduce in local machine with > reference to the failure image provided in the CI logs. The suggested fix is > to place the main Frame slightly above the center of the screen than setting > at the center of the screen. Several CI runs were made and no issue found. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Review fix - Changes: - all: https://git.openjdk.org/jdk/pull/17364/files - new: https://git.openjdk.org/jdk/pull/17364/files/77926ea3..b6a099e9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17364=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17364=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17364.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17364/head:pull/17364 PR: https://git.openjdk.org/jdk/pull/17364
