Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/#review13691 --- plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java https://reviews.apache.org/r/8186/#comment29341 Can you release the connection here and still call the getStatusCode() below? plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java https://reviews.apache.org/r/8186/#comment29342 Same here, the connnections is release before the statusCode is read. - Hugo Trippaers On Nov. 22, 2012, 8:42 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 22, 2012, 8:42 a.m.) Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
SystemVM issues
Issue: cloud-passwd-server and (the default) iptables have the same run level in /etc/rcS.d (S13xxx). By default port 8080 is not opened, and cloud-passwd-server checks and enables port such that it accepts traffic from the guest cidr only. The issue is sometimes, the default iptables rules are applied after the password server has been started which causes the port 8080 related rules to be flushed. How is systemvm template created? How do we set run level for a service, how to change sequence of services to start in a defined way? Regards.
Re: SystemVM issues
On 22-Nov-2012, at 4:43 PM, Rohit Yadav rohit.ya...@citrix.com wrote: Issue: cloud-passwd-server and (the default) iptables have the same run level in /etc/rcS.d (S13xxx). By default port 8080 is not opened, and cloud-passwd-server checks and enables port such that it accepts traffic from the guest cidr only. The issue is sometimes, the default iptables rules are applied after the password server has been started which causes the port 8080 related rules to be flushed. How is systemvm template created? Found a partial answer by reading the code, still if anyone wants to discuss. How do we set run level for a service, how to change sequence of services to start in a defined way? Okay got the fix, you're supposed to fix them in a comment block for all init.d scripts and specify required processes and run levels; --- a/patches/systemvm/debian/config/etc/init.d/cloud-passwd-srvr +++ b/patches/systemvm/debian/config/etc/init.d/cloud-passwd-srvr @@ -1,7 +1,7 @@ #!/bin/bash ### BEGIN INIT INFO # Provides: cloud-passwd-srvr -# Required-Start:mountkernfs $local_fs cloud-early-config +# Required-Start:mountkernfs $local_fs cloud-early-config iptables-persistent # Required-Stop: $local_fs # Should-Start: # Should-Stop: Pl. check, if what I found is correct? Thanks. Regards.
RE: Integrating autoscale branch to master?
Please use the link provided to download the NetScaler java API SDKs to build non-oss NetScaler version of CloudStack. http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip This is made available temporarily and would be deleted once the java APIs become OSS. Also, with this upload the other repositories become obsolete. Please upload this zip file to remain up to date. Thanks, Vijay V. -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, November 21, 2012 11:24 PM To: cloudstack-dev@incubator.apache.org Subject: Re: Integrating autoscale branch to master? It does look like Wido is hosting the jars here: http://zooi.widodh.nl/cloudstack/build-dep/ I found that link on this wiki page: https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+o n+master+branch On Wed, Nov 21, 2012 at 12:35 PM, Vijay Venkatachalam vijay.venkatacha...@citrix.com wrote: Is someone hosting the non-oss jars in a single place, I can share the latest NetScaler jar file and we can update the repository(ies). Thanks, Vijay. -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, November 21, 2012 10:13 PM To: cloudstack-dev@incubator.apache.org Subject: Re: Integrating autoscale branch to master? Where can I access the appropriate Netscaler jar? I'd like to test the module with the new additions, and the jar that I have from prior to the 4.0 release doesn't have several of the referenced classes. On Thu, Nov 15, 2012 at 11:44 AM, Ram Ganesh ram.gan...@citrix.com wrote: Any thoughts? Unless we hear otherwise would like to push the patches. This feature had been code complete for a very long time. If there are still concerns/opinions let us know and we can take steps to correct them. Thanks, Ram -Original Message- From: Ram Ganesh [mailto:ram.gan...@citrix.com] Sent: 15 November 2012 07:09 To: cloudstack-dev@incubator.apache.org Subject: RE: Integrating autoscale branch to master? David, Can we go ahead with merge of AutoScale code into master? Are there any more open questions? Thanks, Ram -Original Message- From: Vijay Venkatachalam [mailto:vijay.venkatacha...@citrix.com] Sent: 13 November 2012 12:34 To: cloudstack-dev@incubator.apache.org Subject: RE: Integrating autoscale branch to master? My replies inline Thanks, Vijay V. -Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Monday, October 15, 2012 7:42 PM To: cloudstack-dev@incubator.apache.org Subject: Re: Integrating autoscale branch to master? On Fri, Oct 12, 2012 at 11:54 AM, Vijay Venkatachalam vijay.venkatacha...@citrix.com wrote: Ok I will keep changes ready, and will merge once 4.0's news is declared. -Vijay V. Vijay, I haven't kept up with this recently so a couple of questions/assumptions: 1. Autoscale code will require NetScaler libraries right? There are 2 parts to autoscale code. A. AutoScale Manager and its services, This is part of the core. And has no No Netscaler jar dependency; This part is coded like any other NetworkServiceManager, meaning any network element can provide autoscale service. So this part does not have compile time dependency with NetScaler jar. If an autoscale provider (which is most likely already an LB provider) does not exist in that network an error is thrown at run time. So for all oss builds (where Netscaler is not packaged and cannot be added to the infrastructure) we should get a run-time error when configuring autoscale. B. NetScaler Element and Netscaler Resource (which is part of non-oss build today) has been enhanced to provide autoscale capability. Today only NetScaler does this, in future any network element can he enhanced to provide autoscale. This part already has NetScaler jar dependency (and is considered non-oss today) and will continue to have NetScaler jar dependency. 2. Is autoscale functionality modular enough that we can turn building it on/off at will? Short Answer, No. Since AutoScale is like an addon to LB there are touch- points. For example, when a LoadBalancerRule is deleted the AutoScale entities created for it also should be deleted, hence the dependency. Basically there is code in LB core to delete autoscale entities on the loadbalancer rule's delete path. Hence Part (A.) could not be modularized. Is there an alternative here? Also, in the UI autoscale will appear as part of LB to the user and if he
Re: SystemVM issues
That looks right to me, at least to fix the issue as you described. How often does the issue occur? I have had issues with flakiness of the password server in the past but it has been a few months since I have seen an issue, last one was well before I started looking at code. If it fixes your problem we should submit it for 4.0.1 as well. On Nov 22, 2012 5:11 AM, Rohit Yadav rohit.ya...@citrix.com wrote: On 22-Nov-2012, at 4:43 PM, Rohit Yadav rohit.ya...@citrix.com wrote: Issue: cloud-passwd-server and (the default) iptables have the same run level in /etc/rcS.d (S13xxx). By default port 8080 is not opened, and cloud-passwd-server checks and enables port such that it accepts traffic from the guest cidr only. The issue is sometimes, the default iptables rules are applied after the password server has been started which causes the port 8080 related rules to be flushed. How is systemvm template created? Found a partial answer by reading the code, still if anyone wants to discuss. How do we set run level for a service, how to change sequence of services to start in a defined way? Okay got the fix, you're supposed to fix them in a comment block for all init.d scripts and specify required processes and run levels; --- a/patches/systemvm/debian/config/etc/init.d/cloud-passwd-srvr +++ b/patches/systemvm/debian/config/etc/init.d/cloud-passwd-srvr @@ -1,7 +1,7 @@ #!/bin/bash ### BEGIN INIT INFO # Provides: cloud-passwd-srvr -# Required-Start:mountkernfs $local_fs cloud-early-config +# Required-Start:mountkernfs $local_fs cloud-early-config iptables-persistent # Required-Stop: $local_fs # Should-Start: # Should-Stop: Pl. check, if what I found is correct? Thanks. Regards.
[jira] [Commented] (CLOUDSTACK-490) Multiple disks on templates
[ https://issues.apache.org/jira/browse/CLOUDSTACK-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503022#comment-13503022 ] Choonho Son commented on CLOUDSTACK-490: It's good feature for template. For example, Oracle VM Template consists of two or three disk, for example root disk and oracle db disk. In a previous version, after deploying VM with root disk, data disk is attached using upload volume api. Multiple disks on templates --- Key: CLOUDSTACK-490 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-490 Project: CloudStack Issue Type: Improvement Components: Template Reporter: Clayton Weise Priority: Minor After some discussion in IRC today the thought came up that it would be nice for the ability to create a template that has not only a root drive but multiple data drives attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
