Re: Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9786/#review17581 --- Tested the patch, but it is not working, exception is thrown from parsing the cookie. I have committed to master a fix eca1a7089ab422d3e673c14ba6af52d137d7f5a7, so you can close this patch request. - Min Chen On March 6, 2013, 11:28 p.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9786/ --- (Updated March 6, 2013, 11:28 p.m.) Review request for cloudstack and Min Chen. Description --- I'm sorry this is a bug I put before in the patch of CLOUDSTACK-1529 ( https://reviews.apache.org/r/9768/ ) . The bug is that cookie header value assigned was a single value from cookie key value pair. Correct value is a serialized format of key value pairs which can be get by CookieSpec#formatCookies. This addresses bug CLOUDSTACK-1558. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a9 Diff: https://reviews.apache.org/r/9786/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9786/ --- Review request for cloudstack and Min Chen. Description --- I'm sorry this is a bug I put before in the patch of CLOUDSTACK-1529 ( https://reviews.apache.org/r/9768/ ) . The bug is that cookie header value assigned was a single value from cookie key value pair. Correct value is a serialized format of key value pairs which can be get by CookieSpec#formatCookies. This addresses bug CLOUDSTACK-1558. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a9 Diff: https://reviews.apache.org/r/9786/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9786/ --- (Updated March 6, 2013, 11:28 p.m.) Review request for cloudstack and Min Chen. Description --- I'm sorry this is a bug I put before in the patch of CLOUDSTACK-1529 ( https://reviews.apache.org/r/9768/ ) . The bug is that cookie header value assigned was a single value from cookie key value pair. Correct value is a serialized format of key value pairs which can be get by CookieSpec#formatCookies. This addresses bug CLOUDSTACK-1558. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a9 Diff: https://reviews.apache.org/r/9786/diff/ Testing --- Thanks, Hiroaki Kawai
