Review Request: CLOUDSTACK-423 : During VM migration on KVM, VifDriver.unplug is not called.

2012-10-29 Thread Hiroaki Kawai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7761/
---

Review request for cloudstack.


Description
---

VifDriver.unplug must be called in MigrateCommand which hooks VM migration in 
source host, because plug will be called in PrepareForMigration in destination 
host. But that operation is missing in current LibvirtComputingResources.


This addresses bug CLOUDSTACK-423.


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 1bc70fa 

Diff: https://reviews.apache.org/r/7761/diff/


Testing
---


Thanks,

Hiroaki Kawai

Re: Review Request: CLOUDSTACK-423 : During VM migration on KVM, VifDriver.unplug is not called.

2012-10-29 Thread edison su 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7761/#review12875
---

Ship it!


Ship It!

- edison su


On Oct. 29, 2012, 12:51 p.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/7761/
 ---
 
 (Updated Oct. 29, 2012, 12:51 p.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 VifDriver.unplug must be called in MigrateCommand which hooks VM migration in 
 source host, because plug will be called in PrepareForMigration in 
 destination host. But that operation is missing in current 
 LibvirtComputingResources.
 
 
 This addresses bug CLOUDSTACK-423.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
  1bc70fa 
 
 Diff: https://reviews.apache.org/r/7761/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Hiroaki Kawai