Review Request: CentOS rpm build fix

2012-11-21 Thread Hiroaki Kawai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8166/
---

Review request for cloudstack.


Description
---

The jenkins build http://jenkins.cloudstack.org/job/build-master-rhel63/ 
stopped for long time, and I want to bring it back working.

I see there are two cloud.spec files, one in packaging/centos63 is being 
refactoring, and the other one is at top directory which looks more maintained. 
In the patch, I used the top one just because it was easy.

The patch also includes a tiny fix about cloud-bridge init script.


Diffs
-

  build/build-aws-api.xml 40ad22c 
  cloud.spec 9f46dd6 
  packaging/centos63/package.sh 83c0e5e 

Diff: https://reviews.apache.org/r/8166/diff/


Testing
---

bash packaging/centos63/package.sh


Thanks,

Hiroaki Kawai



Re: Review Request: CentOS rpm build fix

2012-11-21 Thread Hugo Trippaers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8166/#review13665
---


The spec file in the top directory still depends on the old ant build, this one 
is deprecated and should no longer be used. Actually that spec file and the ant 
build are nominated to be removed soon.

Packaging is still being worked on at the moment, if you have any ideas about 
this please see my email to the dev list and give your feedback. 

Not merging this as it depends on a deprecated build system.

- Hugo Trippaers


On Nov. 21, 2012, 10:53 a.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/8166/
 ---
 
 (Updated Nov. 21, 2012, 10:53 a.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 The jenkins build http://jenkins.cloudstack.org/job/build-master-rhel63/ 
 stopped for long time, and I want to bring it back working.
 
 I see there are two cloud.spec files, one in packaging/centos63 is being 
 refactoring, and the other one is at top directory which looks more 
 maintained. In the patch, I used the top one just because it was easy.
 
 The patch also includes a tiny fix about cloud-bridge init script.
 
 
 Diffs
 -
 
   build/build-aws-api.xml 40ad22c 
   cloud.spec 9f46dd6 
   packaging/centos63/package.sh 83c0e5e 
 
 Diff: https://reviews.apache.org/r/8166/diff/
 
 
 Testing
 ---
 
 bash packaging/centos63/package.sh
 
 
 Thanks,
 
 Hiroaki Kawai