Re: Review Request: Fedora 17 openjdk 1.7 support

2012-10-24 Thread David Nalley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6941/#review12716
---


I've committed this change 

commit 1deb31a97ecea0dd8aa6a45514563c922e71d03e
Author: Hiroaki Kawai ka...@stratosphere.co.jp
Date:   Wed Oct 24 14:29:19 2012 -0400

https://reviews.apache.org/r/6941/ - fix openjdk build requirement in spec 
file


Please close this request as submitted. 

- David Nalley


On Sept. 6, 2012, 7:17 a.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/6941/
 ---
 
 (Updated Sept. 6, 2012, 7:17 a.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 In fedora 17 package, openjdk 1.6 package was marked as deprecated, and only 
 openjdk 1.7 is available for general.
 https://admin.fedoraproject.org/pkgdb/acls/name/java-1.6.0-openjdk
 
 
 Diffs
 -
 
   cloud.spec b22bd8c 
 
 Diff: https://reviews.apache.org/r/6941/diff/
 
 
 Testing
 ---
 
 mvn  mvn test
 
 
 Thanks,
 
 Hiroaki Kawai
 




Review Request: Fedora 17 openjdk 1.7 support

2012-09-06 Thread Hiroaki Kawai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6941/
---

Review request for cloudstack.


Description
---

In fedora 17 package, openjdk 1.6 package was marked as deprecated, and only 
openjdk 1.7 is available for general.
https://admin.fedoraproject.org/pkgdb/acls/name/java-1.6.0-openjdk


Diffs
-

  cloud.spec b22bd8c 

Diff: https://reviews.apache.org/r/6941/diff/


Testing
---

mvn  mvn test


Thanks,

Hiroaki Kawai



Re: Review Request: Fedora 17 openjdk 1.7 support

2012-09-06 Thread Hugo Trippaers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6941/#review11106
---


Is it alright if i come back to this a little later? The current release 
targets platforms with java 1.6 and tomcat6.

- Hugo Trippaers


On Sept. 6, 2012, 7:17 a.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/6941/
 ---
 
 (Updated Sept. 6, 2012, 7:17 a.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 In fedora 17 package, openjdk 1.6 package was marked as deprecated, and only 
 openjdk 1.7 is available for general.
 https://admin.fedoraproject.org/pkgdb/acls/name/java-1.6.0-openjdk
 
 
 Diffs
 -
 
   cloud.spec b22bd8c 
 
 Diff: https://reviews.apache.org/r/6941/diff/
 
 
 Testing
 ---
 
 mvn  mvn test
 
 
 Thanks,
 
 Hiroaki Kawai
 




RE: Review Request: Fedora 17 openjdk 1.7 support

2012-09-06 Thread Edison Su


 -Original Message-
 From: Hugo Trippaers [mailto:nore...@reviews.apache.org] On Behalf Of
 Hugo Trippaers
 Sent: Thursday, September 06, 2012 11:24 AM
 To: cloudstack; David Nalley; Hiroaki Kawai; Hugo Trippaers
 Subject: Re: Review Request: Fedora 17 openjdk 1.7 support
 
 
 
  On Sept. 6, 2012, 5:16 p.m., David Nalley wrote:
   I don't see a problem with this specific change - the if statement
 is pretty limited and leaves things alone for everything that isn't f17
 or later. Hugo: Any objection if I commit this?
  
  
 
 The statement is ok, but Edison and myself are doing a lot of
 conflicting commits on cloud.spec already. I'm afraid it gets lots if
 we are not carefull. By leaving this open using we have solved the
 maven/ant thing we can be sure it gets in the build.
 
 Or just commit it to both the maven-waf and master branch

Easier to commit it to both branch.

 
 
 - Hugo
 
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/6941/#review11107
 ---
 
 
 On Sept. 6, 2012, 7:17 a.m., Hiroaki Kawai wrote:
 
  ---
  This is an automatically generated e-mail. To reply, visit:
  https://reviews.apache.org/r/6941/
  ---
 
  (Updated Sept. 6, 2012, 7:17 a.m.)
 
 
  Review request for cloudstack.
 
 
  Description
  ---
 
  In fedora 17 package, openjdk 1.6 package was marked as deprecated,
 and only openjdk 1.7 is available for general.
  https://admin.fedoraproject.org/pkgdb/acls/name/java-1.6.0-openjdk
 
 
  Diffs
  -
 
cloud.spec b22bd8c
 
  Diff: https://reviews.apache.org/r/6941/diff/
 
 
  Testing
  ---
 
  mvn  mvn test
 
 
  Thanks,
 
  Hiroaki Kawai