Re: Review Request: Fix for NPE while adding firewall rule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5742/#review9600 --- Jayapal: Can you close this request as 'submitted'? - John Kinsella On July 4, 2012, 12:17 p.m., Jayapal Reddy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5742/ --- (Updated July 4, 2012, 12:17 p.m.) Review request for cloudstack and Abhinandan Prateek. Description --- Fixed NPE, assertion Exception while adding Firewall Rule. Bug# CS-15443 This addresses bug CS-15443. Diffs - api/src/com/cloud/api/commands/CreateFirewallRuleCmd.java 81817dc api/src/com/cloud/api/commands/DeleteFirewallRuleCmd.java 36ae4aa Diff: https://reviews.apache.org/r/5742/diff/ Testing --- Yes Thanks, Jayapal Reddy
Re: Review Request: Fix for NPE while adding firewall rule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5742/ --- (Updated July 4, 2012, 12:17 p.m.) Review request for cloudstack and Abhinandan Prateek. Description --- Fixed NPE, assertion Exception while adding Firewall Rule. Bug# CS-15443 This addresses bug CS-15443. Diffs (updated) - api/src/com/cloud/api/commands/CreateFirewallRuleCmd.java 81817dc api/src/com/cloud/api/commands/DeleteFirewallRuleCmd.java 36ae4aa Diff: https://reviews.apache.org/r/5742/diff/ Testing --- Yes Thanks, Jayapal Reddy
Re: Review Request: Fix for NPE while adding firewall rule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5742/#review8878 --- Ship it! Ship It! - Abhinandan Prateek On July 4, 2012, 12:17 p.m., Jayapal Reddy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5742/ --- (Updated July 4, 2012, 12:17 p.m.) Review request for cloudstack and Abhinandan Prateek. Description --- Fixed NPE, assertion Exception while adding Firewall Rule. Bug# CS-15443 This addresses bug CS-15443. Diffs - api/src/com/cloud/api/commands/CreateFirewallRuleCmd.java 81817dc api/src/com/cloud/api/commands/DeleteFirewallRuleCmd.java 36ae4aa Diff: https://reviews.apache.org/r/5742/diff/ Testing --- Yes Thanks, Jayapal Reddy
