Re: Review Request: HttpClient needs releaseConnection method call
On Nov. 29, 2012, 7:25 p.m., Hugo Trippaers wrote: Ship It! Commit: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=a28f4cac3c6e98439d92d72ed6a29f89ecc2c7b5 - Hugo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/#review13865 --- On Nov. 27, 2012, 2:03 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 27, 2012, 2:03 a.m.) Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/#review13803 --- looks good, i'll do some testing with this before committing. - Hugo Trippaers On Nov. 27, 2012, 2:03 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 27, 2012, 2:03 a.m.) Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: HttpClient needs releaseConnection method call
On Nov. 22, 2012, 9:39 a.m., Hugo Trippaers wrote: plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java, line 123 https://reviews.apache.org/r/8186/diff/1/?file=222930#file222930line123 Can you release the connection here and still call the getStatusCode() below? Yes, we can release the connection and still get the status code. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/#review13691 --- On Nov. 22, 2012, 8:42 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 22, 2012, 8:42 a.m.) Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 27, 2012, 2:03 a.m.) Review request for cloudstack. Changes --- In NiciraNvpApi.java, previous patch called releaseConnection before reading http response body. Fixed in this patch. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs (updated) - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/#review13691 --- plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java https://reviews.apache.org/r/8186/#comment29341 Can you release the connection here and still call the getStatusCode() below? plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java https://reviews.apache.org/r/8186/#comment29342 Same here, the connnections is release before the statusCode is read. - Hugo Trippaers On Nov. 22, 2012, 8:42 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 22, 2012, 8:42 a.m.) Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
