Re: Review Request: STT isolation support for KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/#review11960 --- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java https://reviews.apache.org/r/7165/#comment25495 Sorry for the late about reviewing your code. I think here it's better to subclass BridgeVifDriver, as normal linux bridge doesn't this special handling. For example, you can put all your modification on BridgeVifDriver into a new class called ovsVifDriver, override plug and unplug, then in agent.properties file, add libvirt.vif.driver=ovsVifDriver. - edison su On Sept. 19, 2012, 11:30 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/ --- (Updated Sept. 19, 2012, 11:30 a.m.) Review request for cloudstack. Description --- Adds STT support on KVM host, just like in XenServer. The host os having openvswitch and brcompat kernel module will plug the VM to openvswitch port through general brctl interface calls. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java cf4de09 scripts/vm/network/vnet/setupLswitch.sh PRE-CREATION server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f Diff: https://reviews.apache.org/r/7165/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: STT isolation support for KVM
On Sept. 27, 2012, 12:34 a.m., edison su wrote: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, line 132 https://reviews.apache.org/r/7165/diff/2/?file=158452#file158452line132 Sorry for the late about reviewing your code. I think here it's better to subclass BridgeVifDriver, as normal linux bridge doesn't this special handling. For example, you can put all your modification on BridgeVifDriver into a new class called ovsVifDriver, override plug and unplug, then in agent.properties file, add libvirt.vif.driver=ovsVifDriver. While playing the code, I found that current LibvirtComputingResource has tons of code that depends on linux bridge and vlan config, so I could not think about a sensible ovs libvirt.vif.driver now. I would discard this patch for now. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/#review11960 --- On Sept. 19, 2012, 11:30 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/ --- (Updated Sept. 19, 2012, 11:30 a.m.) Review request for cloudstack. Description --- Adds STT support on KVM host, just like in XenServer. The host os having openvswitch and brcompat kernel module will plug the VM to openvswitch port through general brctl interface calls. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java cf4de09 scripts/vm/network/vnet/setupLswitch.sh PRE-CREATION server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f Diff: https://reviews.apache.org/r/7165/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: STT isolation support for KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/ --- Review request for cloudstack. Description --- Adds STT support on KVM host, just like in XenServer. The host os having openvswitch and brcompat kernel module will plug the VM to openvswitch port through general brctl interface calls. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java cf4de09 scripts/vm/network/vnet/setupLswitch.sh PRE-CREATION server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f Diff: https://reviews.apache.org/r/7165/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: STT isolation support for KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/#review11692 --- Shouldn't this go into a separate vif driver? I guess you just want to use OVS on guest network along with linux bridge for the other networks, though. - Tomoe Sugihara On Sept. 19, 2012, 11:30 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/ --- (Updated Sept. 19, 2012, 11:30 a.m.) Review request for cloudstack. Description --- Adds STT support on KVM host, just like in XenServer. The host os having openvswitch and brcompat kernel module will plug the VM to openvswitch port through general brctl interface calls. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java cf4de09 scripts/vm/network/vnet/setupLswitch.sh PRE-CREATION server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f Diff: https://reviews.apache.org/r/7165/diff/ Testing --- Thanks, Hiroaki Kawai
