Re: Review Request: kvm agent NIC unplug will always fail

2012-10-29 Thread edison su 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7612/#review12876
---

Ship it!


Ship It!

- edison su


On Oct. 16, 2012, 1:31 a.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/7612/
 ---
 
 (Updated Oct. 16, 2012, 1:31 a.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 On kvm computing host, vifdriver.unplug will always fails (throws 
 LibvirtException) and network cleanup will not be called. This was because 
 the code first undefine the computing domain, and then tries to query the 
 destroyed machine definition to fetch NIC information. IMHO, kvm plugin code 
 rounds LibvirtException too much.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
  1bc70fa 
 
 Diff: https://reviews.apache.org/r/7612/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Hiroaki Kawai

Review Request: kvm agent NIC unplug will always fail

2012-10-15 Thread Hiroaki Kawai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7612/
---

Review request for cloudstack.


Description
---

On kvm computing host, vifdriver.unplug will always fails (throws 
LibvirtException) and network cleanup will not be called. This was because the 
code first undefine the computing domain, and then tries to query the destroyed 
machine definition to fetch NIC information. IMHO, kvm plugin code rounds 
LibvirtException too much.


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 1bc70fa 

Diff: https://reviews.apache.org/r/7612/diff/


Testing
---


Thanks,

Hiroaki Kawai