Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/#review11105 --- Fixed by Wido in the maven-waf branch. Thanks for the patch :-) - Hugo Trippaers On Sept. 5, 2012, 10:38 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- (Updated Sept. 5, 2012, 10:38 a.m.) Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss
Trying to get a working RPM build of 4.0 going... I assume my latest issue is related to this. class not found: com.cloud.hypervisor.kvm.resource.LibvirtComputingResource, if someone is building RPMs isn't it safe to assume they want the kvm/libvirt pieces? What was Wido's fix? I don't see this patch applied to maven-waf, just 623f199b0378683e6f5f0c2b2b5c692b6504d16f as latest. On Thu, Sep 6, 2012 at 11:04 AM, Hugo Trippaers htrippa...@schubergphilis.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/#review11105 --- Fixed by Wido in the maven-waf branch. Thanks for the patch :-) - Hugo Trippaers On Sept. 5, 2012, 10:38 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- (Updated Sept. 5, 2012, 10:38 a.m.) Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
RE: Review Request: maven kvm hypervisor plugin build without -Dnonoss
Yah, yesterday, I thought kVM is illegal to be included in the OSS release, so I removed it from cloud.spec. I'll add it back. -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Thursday, September 06, 2012 11:05 AM To: cloudstack-dev@incubator.apache.org; Hugo Trippaers Cc: Hiroaki Kawai Subject: Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss Trying to get a working RPM build of 4.0 going... I assume my latest issue is related to this. class not found: com.cloud.hypervisor.kvm.resource.LibvirtComputingResource, if someone is building RPMs isn't it safe to assume they want the kvm/libvirt pieces? What was Wido's fix? I don't see this patch applied to maven-waf, just 623f199b0378683e6f5f0c2b2b5c692b6504d16f as latest. On Thu, Sep 6, 2012 at 11:04 AM, Hugo Trippaers htrippa...@schubergphilis.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/#review11105 --- Fixed by Wido in the maven-waf branch. Thanks for the patch :-) - Hugo Trippaers On Sept. 5, 2012, 10:38 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- (Updated Sept. 5, 2012, 10:38 a.m.) Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
RE: Review Request: maven kvm hypervisor plugin build without -Dnonoss
The rpm build on master branch is fixed, KVM is included. -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Thursday, September 06, 2012 11:05 AM To: cloudstack-dev@incubator.apache.org; Hugo Trippaers Cc: Hiroaki Kawai Subject: Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss Trying to get a working RPM build of 4.0 going... I assume my latest issue is related to this. class not found: com.cloud.hypervisor.kvm.resource.LibvirtComputingResource, if someone is building RPMs isn't it safe to assume they want the kvm/libvirt pieces? What was Wido's fix? I don't see this patch applied to maven-waf, just 623f199b0378683e6f5f0c2b2b5c692b6504d16f as latest. On Thu, Sep 6, 2012 at 11:04 AM, Hugo Trippaers htrippa...@schubergphilis.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/#review11105 --- Fixed by Wido in the maven-waf branch. Thanks for the patch :-) - Hugo Trippaers On Sept. 5, 2012, 10:38 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- (Updated Sept. 5, 2012, 10:38 a.m.) Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss
On 09/06/2012 08:05 PM, Marcus Sorensen wrote: Trying to get a working RPM build of 4.0 going... I assume my latest issue is related to this. class not found: com.cloud.hypervisor.kvm.resource.LibvirtComputingResource, if someone is building RPMs isn't it safe to assume they want the kvm/libvirt pieces? What was Wido's fix? I don't see this patch applied to maven-waf, just 623f199b0378683e6f5f0c2b2b5c692b6504d16f as latest. Sorry, I completely missed this review! The legal issue with KVM was approved like Elan posted, see LEGAL-144 as I mentioned in the commit message. I saw Elan's post on the ml, checked out the legal status and enabled KVM again since we were allowed to do so :) Wido On Thu, Sep 6, 2012 at 11:04 AM, Hugo Trippaers htrippa...@schubergphilis.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/#review11105 --- Fixed by Wido in the maven-waf branch. Thanks for the patch :-) - Hugo Trippaers On Sept. 5, 2012, 10:38 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- (Updated Sept. 5, 2012, 10:38 a.m.) Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss
On Thu, Sep 6, 2012 at 4:30 PM, Wido den Hollander w...@widodh.nl wrote: On 09/06/2012 08:05 PM, Marcus Sorensen wrote: Trying to get a working RPM build of 4.0 going... I assume my latest issue is related to this. class not found: com.cloud.hypervisor.kvm.resource.LibvirtComputingResource, if someone is building RPMs isn't it safe to assume they want the kvm/libvirt pieces? What was Wido's fix? I don't see this patch applied to maven-waf, just 623f199b0378683e6f5f0c2b2b5c692b6504d16f as latest. Sorry, I completely missed this review! The legal issue with KVM was approved like Elan posted, see LEGAL-144 as I mentioned in the commit message. I saw Elan's post on the ml, checked out the legal status and enabled KVM again since we were allowed to do so :) Wido I am not sure that this is my understanding. Doesn't the 'default build option' have to miss KVM because it currently doesn't have a license that permits it? Or did we decide to identify this as a system dependency? I know we got blessing to produce KVM-inclusive convenience binaries, but point 1 of the accepted proposal in LEGAL-144 says: Disable KVM support in the default build, as per policy. --David
RE: Review Request: maven kvm hypervisor plugin build without -Dnonoss
I'll add a switch to enable and disable kvm. -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Thursday, September 06, 2012 3:25 PM To: cloudstack-dev@incubator.apache.org Subject: Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss You can disable it in the default build, but still allow it in waf build, correct? Or at the very least it seems that the RPM build should ship building the agent with a message saying 'do x y z to enable KVM first' or some such. Nobody is going to build an RPM and not want KVM support, it's not like the citrix or Vmware resources can be used with RHEL/CentOS. On Thu, Sep 6, 2012 at 3:40 PM, David Nalley da...@gnsa.us wrote: On Thu, Sep 6, 2012 at 4:30 PM, Wido den Hollander w...@widodh.nl wrote: On 09/06/2012 08:05 PM, Marcus Sorensen wrote: Trying to get a working RPM build of 4.0 going... I assume my latest issue is related to this. class not found: com.cloud.hypervisor.kvm.resource.LibvirtComputingResource, if someone is building RPMs isn't it safe to assume they want the kvm/libvirt pieces? What was Wido's fix? I don't see this patch applied to maven-waf, just 623f199b0378683e6f5f0c2b2b5c692b6504d16f as latest. Sorry, I completely missed this review! The legal issue with KVM was approved like Elan posted, see LEGAL- 144 as I mentioned in the commit message. I saw Elan's post on the ml, checked out the legal status and enabled KVM again since we were allowed to do so :) Wido I am not sure that this is my understanding. Doesn't the 'default build option' have to miss KVM because it currently doesn't have a license that permits it? Or did we decide to identify this as a system dependency? I know we got blessing to produce KVM-inclusive convenience binaries, but point 1 of the accepted proposal in LEGAL-144 says: Disable KVM support in the default build, as per policy. --David
Review Request: maven kvm hypervisor plugin build without -Dnonoss
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Re: Review Request: maven kvm hypervisor plugin build without -Dnonoss
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/#review11062 --- Hey Hiroaki, Looks good, but i believe that was another reason why we could not include the libvirt jar as a dependency in the oss branch. Something license related, but i'll have to check the archives to check what is was. Next to that, i would like to avoid putting repositories into our poms. Ideally everything should be available from central (or from a location that we control). I known libvirt is there, but version 0.4.8 is not available yet from central. - Hugo Trippaers On Sept. 5, 2012, 10:38 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- (Updated Sept. 5, 2012, 10:38 a.m.) Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
