Review Request: typo in cloud-install-sys-tmplt

2012-09-11 Thread Hiroaki Kawai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7049/
---

Review request for cloudstack.


Description
---

cloud-install-sys-tmplt has a typo in shell script syntax.
/usr/lib64/cloud/agent/scripts/storage/secondary/cloud-install-sys-tmplt: line 
141: [: missing `]'


Diffs
-

  scripts/storage/secondary/cloud-install-sys-tmplt d744b56 

Diff: https://reviews.apache.org/r/7049/diff/


Testing
---


Thanks,

Hiroaki Kawai



Re: Review Request: typo in cloud-install-sys-tmplt

2012-09-11 Thread edison su

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7049/#review11371
---

Ship it!


Ship It!

- edison su


On Sept. 12, 2012, 12:36 a.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/7049/
 ---
 
 (Updated Sept. 12, 2012, 12:36 a.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 cloud-install-sys-tmplt has a typo in shell script syntax.
 /usr/lib64/cloud/agent/scripts/storage/secondary/cloud-install-sys-tmplt: 
 line 141: [: missing `]'
 
 
 Diffs
 -
 
   scripts/storage/secondary/cloud-install-sys-tmplt d744b56 
 
 Diff: https://reviews.apache.org/r/7049/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Hiroaki Kawai
 




Re: Review Request: typo in cloud-install-sys-tmplt

2012-09-11 Thread mice xia

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7049/#review11373
---


this is CLOUDSTACK-37, already committed in master 
b52bd1fc5a00a3e1443e0cd30707ed961ea2a6f3

- mice xia


On Sept. 12, 2012, 12:36 a.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/7049/
 ---
 
 (Updated Sept. 12, 2012, 12:36 a.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 cloud-install-sys-tmplt has a typo in shell script syntax.
 /usr/lib64/cloud/agent/scripts/storage/secondary/cloud-install-sys-tmplt: 
 line 141: [: missing `]'
 
 
 Diffs
 -
 
   scripts/storage/secondary/cloud-install-sys-tmplt d744b56 
 
 Diff: https://reviews.apache.org/r/7049/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Hiroaki Kawai
 




Re: Review Request: typo in cloud-install-sys-tmplt

2012-09-11 Thread Hiroaki Kawai


 On Sept. 12, 2012, 1:46 a.m., mice xia wrote:
  this is CLOUDSTACK-37, already committed in master 
  b52bd1fc5a00a3e1443e0cd30707ed961ea2a6f3

Fixd in master b3d4246a141854303ac9e72e3eb2b92ba01aca40, thanks. Then 
CLOUDSTACK-37 might be closed :-)


- Hiroaki


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7049/#review11373
---


On Sept. 12, 2012, 12:36 a.m., Hiroaki Kawai wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/7049/
 ---
 
 (Updated Sept. 12, 2012, 12:36 a.m.)
 
 
 Review request for cloudstack.
 
 
 Description
 ---
 
 cloud-install-sys-tmplt has a typo in shell script syntax.
 /usr/lib64/cloud/agent/scripts/storage/secondary/cloud-install-sys-tmplt: 
 line 141: [: missing `]'
 
 
 Diffs
 -
 
   scripts/storage/secondary/cloud-install-sys-tmplt d744b56 
 
 Diff: https://reviews.apache.org/r/7049/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Hiroaki Kawai