Re: [cmake-developers] Is KWStyle still maintained?

2012-02-06 Thread Nicolas Desprès
2012/2/5 David Cole david.c...@kitware.com:
 2012/2/5 Nicolas Desprès nicolas.desp...@gmail.com:
 Hi,

 I have just try to enable KWStyle check in CMake on Mac OS X 10.7.3
 but it crashes.

 With the version from the website:
 http://public.kitware.com/KWStyle/download/KWStyle-snapshot-070515.zip

 I get this when I run:
 $ make VERBOSE=1 MoreStyleChecks
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 make -f CMakeFiles/Makefile2 MoreStyleChecks
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_start
 /Users/polrop/src/cmake/_build/CMakeFiles 0
 make -f CMakeFiles/Makefile2
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/depend
 cd /Users/polrop/src/cmake/_build 
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_depends Unix
 Makefiles /Users/polrop/src/cmake
 /Users/polrop/src/cmake/Utilities/KWStyle
 /Users/polrop/src/cmake/_build
 /Users/polrop/src/cmake/_build/Utilities/KWStyle
 /Users/polrop/src/cmake/_build/Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/DependInfo.cmake
 --color=
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_report
 /Users/polrop/src/cmake/_build/CMakeFiles
 Coding Style Checker, more checks enabled
 cd /Users/polrop/src/cmake/_build/Utilities/KWStyle 
 /Users/polrop/usr/stow/kwstyle-070515/bin/KWStyle -xml
 /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
 /Users/polrop/src/cmake/_build/html -o
 /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
 /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
 /bin/sh: line 1: 22504 Floating point exception: 8
 /Users/polrop/usr/stow/kwstyle-070515/bin/KWStyle -xml
 /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
 /Users/polrop/src/cmake/_build/html -o
 /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
 /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
 make[3]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks] Error 136
 make[2]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all] Error 2
 make[1]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/rule] Error 2
 make: *** [MoreStyleChecks] Error 2

 With the cvs version: cvs -d
 :pserver:anon...@public.kitware.com:/cvsroot/KWStyle co KWStyle

 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 make -f CMakeFiles/Makefile2 MoreStyleChecks
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_start
 /Users/polrop/src/cmake/_build/CMakeFiles 0
 make -f CMakeFiles/Makefile2
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/depend
 cd /Users/polrop/src/cmake/_build 
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_depends Unix
 Makefiles /Users/polrop/src/cmake
 /Users/polrop/src/cmake/Utilities/KWStyle
 /Users/polrop/src/cmake/_build
 /Users/polrop/src/cmake/_build/Utilities/KWStyle
 /Users/polrop/src/cmake/_build/Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/DependInfo.cmake
 --color=
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_report
 /Users/polrop/src/cmake/_build/CMakeFiles
 Coding Style Checker, more checks enabled
 cd /Users/polrop/src/cmake/_build/Utilities/KWStyle 
 /Users/polrop/usr/stow/kwstyle-cvs/bin/KWStyle -xml
 /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
 /Users/polrop/src/cmake/_build/html -o
 /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
 /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
 Processing /Users/polrop/src/cmake/Source/CPack/OSXScriptLauncher.cxx


 Processing /Users/polrop/src/cmake/Source/CPack/cmCPackArchiveGenerator.cxx
 Error #30 (50) function (addOneComponentToArchive) doesn't match
 regular expression: ^(cm)?[A-Z]


 Processing /Users/polrop/src/cmake/Source/CPack/cmCPackArchiveGenerator.h
 Error #13 (0) Header mismatch: [no char] (,) :
 /Users/polrop/src/cmake/Utilities/KWStyle/Headers


 Processing /Users/polrop/src/cmake/Source/CPack/cmCPackBundleGenerator.cxx


 Processing /Users/polrop/src/cmake/Source/CPack/cmCPackBundleGenerator.h
 Error #13 (0) Header mismatch: [no char] (,) :
 

Re: [cmake-developers] Is KWStyle still maintained?

2012-02-06 Thread Nicolas Desprès
2012/2/6 David Cole david.c...@kitware.com:
 2012/2/6 Nicolas Desprès nicolas.desp...@gmail.com:
 2012/2/5 David Cole david.c...@kitware.com:
 2012/2/5 Nicolas Desprès nicolas.desp...@gmail.com:
 Hi,

 I have just try to enable KWStyle check in CMake on Mac OS X 10.7.3
 but it crashes.

 With the version from the website:
 http://public.kitware.com/KWStyle/download/KWStyle-snapshot-070515.zip

 I get this when I run:
 $ make VERBOSE=1 MoreStyleChecks
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 make -f CMakeFiles/Makefile2 MoreStyleChecks
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_start
 /Users/polrop/src/cmake/_build/CMakeFiles 0
 make -f CMakeFiles/Makefile2
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/depend
 cd /Users/polrop/src/cmake/_build 
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_depends Unix
 Makefiles /Users/polrop/src/cmake
 /Users/polrop/src/cmake/Utilities/KWStyle
 /Users/polrop/src/cmake/_build
 /Users/polrop/src/cmake/_build/Utilities/KWStyle
 /Users/polrop/src/cmake/_build/Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/DependInfo.cmake
 --color=
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_report
 /Users/polrop/src/cmake/_build/CMakeFiles
 Coding Style Checker, more checks enabled
 cd /Users/polrop/src/cmake/_build/Utilities/KWStyle 
 /Users/polrop/usr/stow/kwstyle-070515/bin/KWStyle -xml
 /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
 /Users/polrop/src/cmake/_build/html -o
 /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
 /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
 /bin/sh: line 1: 22504 Floating point exception: 8
 /Users/polrop/usr/stow/kwstyle-070515/bin/KWStyle -xml
 /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
 /Users/polrop/src/cmake/_build/html -o
 /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
 /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
 make[3]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks] Error 136
 make[2]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all] Error 2
 make[1]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/rule] Error 
 2
 make: *** [MoreStyleChecks] Error 2

 With the cvs version: cvs -d
 :pserver:anon...@public.kitware.com:/cvsroot/KWStyle co KWStyle

 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 make -f CMakeFiles/Makefile2 MoreStyleChecks
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
 -B/Users/polrop/src/cmake/_build --check-build-system
 CMakeFiles/Makefile.cmake 0
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_start
 /Users/polrop/src/cmake/_build/CMakeFiles 0
 make -f CMakeFiles/Makefile2
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/depend
 cd /Users/polrop/src/cmake/_build 
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_depends Unix
 Makefiles /Users/polrop/src/cmake
 /Users/polrop/src/cmake/Utilities/KWStyle
 /Users/polrop/src/cmake/_build
 /Users/polrop/src/cmake/_build/Utilities/KWStyle
 /Users/polrop/src/cmake/_build/Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/DependInfo.cmake
 --color=
 make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
 Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build
 /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_report
 /Users/polrop/src/cmake/_build/CMakeFiles
 Coding Style Checker, more checks enabled
 cd /Users/polrop/src/cmake/_build/Utilities/KWStyle 
 /Users/polrop/usr/stow/kwstyle-cvs/bin/KWStyle -xml
 /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
 /Users/polrop/src/cmake/_build/html -o
 /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
 /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
 Processing /Users/polrop/src/cmake/Source/CPack/OSXScriptLauncher.cxx


 Processing /Users/polrop/src/cmake/Source/CPack/cmCPackArchiveGenerator.cxx
 Error #30 (50) function (addOneComponentToArchive) doesn't match
 regular expression: ^(cm)?[A-Z]


 Processing /Users/polrop/src/cmake/Source/CPack/cmCPackArchiveGenerator.h
 Error #13 (0) Header mismatch: [no char] (,) :
 /Users/polrop/src/cmake/Utilities/KWStyle/Headers


 Processing /Users/polrop/src/cmake/Source/CPack/cmCPackBundleGenerator.cxx


 Processing 

Re: [cmake-developers] Improving CPack Documentation (and may be others as well)

2012-02-06 Thread David Cole
On Sun, Feb 5, 2012 at 6:50 PM, Eric Noulard eric.noul...@gmail.com wrote:
 2012/2/1 David Cole david.c...@kitware.com:

 There's no rush here. We won't be reviewing your changes again until
 next Tuesday at this point...

 Hi all,

 I did push the work and the branch a little further yesterday.
 I didn't get any big red on the dashboard this time and I think
 it was worth going a little further.



There is this issue on the dashboard:

  http://cdash.org/CDash/viewBuildError.php?buildid=1981062

Use empty string assignment:

  std::string s;
  s = ;

...instead of clear to avoid this problem on our (yes, I know,
ancient, but annoyingly still there) VS6 dashboards.


Thanks,
David
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Some minor look and feel fixes in ccmake.

2012-02-06 Thread Nicolas Desprès
2012/2/6 Brad King brad.k...@kitware.com:
 On 2/5/2012 11:01 AM, Nicolas Desprès wrote:

 I have pushed some minor look'n feel fixes for ccmake in a branch on
 my github fork:
 https://github.com/polrop/CMake/commits/fix-ccmake-clear

 Please consider to merge it.


 Applied, thanks.  I tweaked the second commit message:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=415ffda7

 to refer to the commit that introduced the problem.

Thx. I forgot to do it.

-- 
Nicolas Desprès
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Improving CPack Documentation (and may be others as well)

2012-02-06 Thread Eric Noulard
2012/2/6 David Cole david.c...@kitware.com:
 On Sun, Feb 5, 2012 at 6:50 PM, Eric Noulard eric.noul...@gmail.com wrote:
 2012/2/1 David Cole david.c...@kitware.com:

 There's no rush here. We won't be reviewing your changes again until
 next Tuesday at this point...

 Hi all,

 I did push the work and the branch a little further yesterday.
 I didn't get any big red on the dashboard this time and I think
 it was worth going a little further.



 There is this issue on the dashboard:

  http://cdash.org/CDash/viewBuildError.php?buildid=1981062

 Use empty string assignment:

  std::string s;
  s = ;

 ...instead of clear to avoid this problem on our (yes, I know,
 ancient, but annoyingly still there) VS6 dashboards.

OK noted.
Just fixed and pushed to next as well.

I'm subscribed to CMake dashboard and I don't think I received that alert?
Any reason for that?

-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] CTest vs. gcov

2012-02-06 Thread Rolf Eike Beer
Hi all,

I have been wrestling with uncovered files for a while. The current state 
doesn't satisfy me, so I thought to share my findings and we can hopefully 
come up with something better. If you want to look at some numbers you can 
compare the 2 nightly results here: 
http://my.cdash.org/index.php?project=Qsmtpdate=2012-02-05 [1]

voyager runs with a more or less plain 2.8.7 (default gentoo build), while eto 
runs current next with the patches described below.

I'll describe what happened and what I did now. I got aware of the nice but 
undocumented CTEST_EXTRA_COVERAGE_GLOB that allows uncovered files to show up 
on the dashboard. I enabled this and basically got the results you see for 
voyager. A small hints for those that want to try: if you place your build 
directory inside the source directory (i.e. the usual mkdir build  cd build 
 cmake ..) than things like the compiler test files may show up in the 
coverage. I added /CMakeFiles/ to CTEST_CUSTOM_COVERAGE_EXCLUDE to get rid 
of them.

Ok, now I have these uncovered files in the dashboard, but compared to what 
gcov would report the numbers of uncovered lines are insanely big. This comes 
because simply _every_ line is counted as uncovered, may it be code, comment, 
whitespace, #include or whatever. I then added 
3ea6be30819e78ddf3d97378a519dc50836049a3 to it, which simply ignored empty 
lines. This was the best compromise between effort and effect for me: it was 
only a very few lines of code, it would reduce the numbers by ~10% for my 
coding style and I had to know nothing about the language used. If you want to 
test it out you can get that commit from the next branch. David didn't like 
it, so I had to revert.

Instead he told me to just add proper coverage. Well, let's see ;) I then 
wrote some test cases calling a binary consisting of multiple files. Only a 
few of them were actually used, the others were uncovered. To my surprise 
those other files which had been reported to have no coverage and a high 
number of uncovered lines now were reported as uncovered with 0 lines in 
CDash. First I thought of a bug in gcov, but by examination of the files that 
gcov and ctest generated I found out that everything was fine there.

The problem here is that ctest does this code when generating Coverage.xml:

 covSumFile  \tFile Name=\  cmXMLSafe(fileName)
\ FullPath=\  cmXMLSafe(
 this-CTest-GetShortPathToFile(fullFileName.c_str()))
   \ Covered=\  (tested  0 ? true:false)  \\n
\t\tLOCTested  tested  /LOCTested\n
\t\tLOCUnTested  untested  /LOCUnTested\n
\t\tPercentCoverage;

So if no lines are covered then it reports 'Covered=false' which leads CDash 
to entirely ignoring the line count and not showing a link to the file. In 
contrast it does that when collecting files using CTEST_EXTRA_COVERAGE_GLOB:

covSumFile  \tFile Name=\  cmXMLSafe(fileName)
   \ FullPath=\  cmXMLSafe(i-c_str())
   \ Covered=\true\\n
   \t\tLOCTested0/LOCTested\n
   \t\tLOCUnTested  untested  /LOCUnTested\n

Covered is always set to true here. So the quick and dirty fix I used was to 
change the one line to

   \ Covered=\  (tested+untested  0 ? true:false)  \\n

which at the end gave me the results shown by eto in the CDash link above.

Ok, so much to the history behind everything, now the questions: was that the 
right approach? What does 'Covered=false' actually means? Should we 
unconditionally send true for gcov files, too? This would at least give 
consistent results. Is it at the end a CDash bug? Or should CTest be fixed 
similar to the way I did it for my local build?

Opinions? Ideas? Patches? Money?

Greetings,

Eike

1) You can also see the shiny new CDash version the admins brought to us at 
the weekend. Nice work, guys!

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

[CMake] CPACK generated DEB package can not create directories

2012-02-06 Thread Ralf Lange
Hi,
I use CPACK to generate RPM and DEB packages for my software. The RPM
package wirks fine but the DEB package can not create the neccessary
directories in the usr/lib directory. When I create the direcories by
hand, it works.
Who can help to fix this problem?

Thanks
Ralf


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

Re: [CMake] CPACK generated DEB package can not create directories

2012-02-06 Thread Eric Noulard
2012/2/6 Ralf Lange ralf.la...@longsoft.de:
 Hi,
 I use CPACK to generate RPM and DEB packages for my software. The RPM
 package wirks fine but the DEB package can not create the neccessary
 directories in the usr/lib directory. When I create the direcories by hand,
 it works.
 Who can help to fix this problem?

May be I can, but you'll have to give more details:

1) Which version of CMake/CPack are you using?

2) What do you mean by can not create the neccessary directories in
the usr/lib directory?
a) you cannot create the .deb -- what kind of error do you get from cpack?
a) you can create the .deb but cannot install it -- what kind of
error do you get from dpkg?

3) Would you be able to create a small project which reproduce the problem?

-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] CPACK generated DEB package can not create directories

2012-02-06 Thread David Cole
On Mon, Feb 6, 2012 at 5:44 AM, Ralf Lange ralf.la...@longsoft.de wrote:
 Hi,
 I use CPACK to generate RPM and DEB packages for my software. The RPM
 package wirks fine but the DEB package can not create the neccessary
 directories in the usr/lib directory. When I create the direcories by hand,
 it works.
 Who can help to fix this problem?

 Thanks
 Ralf



 --

 Powered by www.kitware.com

 Visit other Kitware open-source projects at
 http://www.kitware.com/opensource/opensource.html

 Please keep messages on-topic and check the CMake FAQ at:
 http://www.cmake.org/Wiki/CMake_FAQ

 Follow this link to subscribe/unsubscribe:
 http://www.cmake.org/mailman/listinfo/cmake


sudo?


;-)
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


[CMake] add_test( WORKING_DIRECTORY ) does not actua

2012-02-06 Thread Massaro Alessio
Hi there

The following message in cmTest.cxx doesn't seem to be accurate for Visual 
Studio 9.

 200   cm-DefineProperty
 201 (WORKING_DIRECTORY, cmProperty::TEST,
 202  The directory from which the test executable will be called.,
 203  
If this is not set it is called from the directory the test executable 
 204  is located in.);

The test process is actually run from ${PROJECT_BINARY_DIR}

I create the test project with the following:

SET (CMAKE_RUNTIME_OUTPUT_DIRECTORY
${PROJECT_BINARY_DIR}/../targets
CACHE PATH
Single Directory for all Executables.)
add_executable(${mod_name} ${src_files} ${inc_files})
add_test(NAME ${mod_name} COMMAND ${mod_name} 
--log_file=${mod_name}.xml)

The above --log_file parameter tells the exe (a Boost Test exe) to create 
${mod_name}.xml in the current directory.

I would be happy to use add_test(WORKING_DIRECTORY) but I can't figure out how 
to construct the path.

Has anyone managed to piece these two together in a simple way?

Thanks in advance!
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] CPACK generated DEB package can not create directories

2012-02-06 Thread Ralf Lange
The CMake version is 2.8.2.
The system is Debian 6.0.4 (squeez).
The kernel is 2.6.32-5-amd64.
The Desktop is Gnome 2.30.2.

CPack generates the deb package. Than I open the package using GDebi
Packet Installer. The installer ask for the superuser password and ends
without installation. The error message is:
dpkg: Error processing
of 
/home/ralf/Animation-Dev/qStopMotion/qstopmotion-buil-makefile/qstopmotion-0.9.10-Linux.deb
 (--install):
/usr/share/qstopmotion/graphics/qstopmotion_logo_transparent_75.png.dpkg-new 
can not be created (...): File or Directory not found.

(this is a translation, I use a german language system)

When I create all the directories on the command line bevor I start the
installer, than it works.

Thanks.
Ralf

Am Montag, den 06.02.2012, 12:14 +0100 schrieb Eric Noulard:
 2012/2/6 Ralf Lange ralf.la...@longsoft.de:
  Hi,
  I use CPACK to generate RPM and DEB packages for my software. The RPM
  package wirks fine but the DEB package can not create the neccessary
  directories in the usr/lib directory. When I create the direcories by hand,
  it works.
  Who can help to fix this problem?
 
 May be I can, but you'll have to give more details:
 
 1) Which version of CMake/CPack are you using?
 
 2) What do you mean by can not create the neccessary directories in
 the usr/lib directory?
 a) you cannot create the .deb -- what kind of error do you get from 
 cpack?
 a) you can create the .deb but cannot install it -- what kind of
 error do you get from dpkg?
 
 3) Would you be able to create a small project which reproduce the problem?
 


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] CPACK generated DEB package can not create directories

2012-02-06 Thread Eric Noulard
2012/2/6 Ralf Lange ralf.la...@longsoft.de:
 The CMake version is 2.8.2.
 The system is Debian 6.0.4 (squeez).
 The kernel is 2.6.32-5-amd64.
 The Desktop is Gnome 2.30.2.

Could you try, cmake 2.8.7
(may be this fix
 http://www.cmake.org/Bug/view.php?id=10325 could solve your problem)
and/or
run cpack in fakeroot like:

$ cd /home/ralf/Animation-Dev/qStopMotion/qstopmotion-buil-makefile
$ fakeroot cpack -G DEB

Then retry the installation.

 CPack generates the deb package. Than I open the package using GDebi
 Packet Installer. The installer ask for the superuser password and ends
 without installation. The error message is:
 dpkg: Error processing
 of 
 /home/ralf/Animation-Dev/qStopMotion/qstopmotion-buil-makefile/qstopmotion-0.9.10-Linux.deb
  (--install):
 /usr/share/qstopmotion/graphics/qstopmotion_logo_transparent_75.png.dpkg-new 
 can not be created (...): File or Directory not found.

is the qstopmotion this project:
http://www.qstopmotion.org/english/download_sources.html

If yes did you made some change or could I theoretically try to
reproduce the issue
using the source I can find on this site?

 When I create all the directories on the command line bevor I start the
 installer, than it works.

could you put the result of:

dpkg-deb --contents yourdebfile.deb

in a text file and send it to me?


-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


[CMake] Program Database for Edit Continue support

2012-02-06 Thread Robert Dailey
In Visual Studio 2008, CMake generates projects to use the /Zi option,
which is just Program Database in visual studio. The /ZI option enables
Program Database with Edit  Continue, allowing the edit  continue
functionality to be used. Is there a built in feature to change the debug
information format in generated VS projects?

-
Robert Dailey
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

Re: [CMake] Program Database for Edit Continue support

2012-02-06 Thread aaron . meadows
If you supply add_definitions(/ZI) it will override the /Zi default and
provide you with the edit and continue setting.

 

I verified the behavior with this cmakelists.txt:

 

With /ZI:

cmake_minimum_required (VERSION 2.8)

project(TestProj CXX)

file(WRITE  ${CMAKE_CURRENT_SOURCE_DIR}/main.cpp int main(int argc,
char** argc) { return 0; })

add_definitions(/ZI)

add_executable(TestExe main.cpp)

 

Without /ZI:

cmake_minimum_required (VERSION 2.8)

project(TestProj CXX)

file(WRITE  ${CMAKE_CURRENT_SOURCE_DIR}/main.cpp int main(int argc,
char** argc) { return 0; })

add_executable(TestExe main.cpp)

 

 

Here is the relevant difference in the generated TestExe.vcxproj:

 

87c87

   DebugInformationFormatEditAndContinue/DebugInformationFormat

---

   DebugInformationFormatProgramDatabase/DebugInformationFormat

 

 

Aaron Meadows

 

From: cmake-boun...@cmake.org [mailto:cmake-boun...@cmake.org] On Behalf
Of Robert Dailey
Sent: Monday, February 06, 2012 3:20 PM
To: CMake ML
Subject: [CMake] Program Database for Edit  Continue support

 

In Visual Studio 2008, CMake generates projects to use the /Zi option,
which is just Program Database in visual studio. The /ZI option
enables Program Database with Edit  Continue, allowing the edit 
continue functionality to be used. Is there a built in feature to change
the debug information format in generated VS projects?


 

-

Robert Dailey


This email was sent to you by Thomson Reuters, the global news and information 
company. Any views expressed in this message are those of the individual 
sender, except where the sender specifically states them to be the views of 
Thomson Reuters.--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

Re: [CMake] Making a variable a dependency...

2012-02-06 Thread Alexander Neundorf
On Saturday 04 February 2012, Oliver Smith wrote:
 My CMakeLists uses the Subversion repository information in a couple of
 places (it configures a file revision.h and it uses it for the CPack
 package name).
 
 The problem is that this variable is cached and retained until the cache
 is rebuilt, instead of being calculated or evaluated per make. So if I
 do a build, then do an svn update and pull some changes, it will build a
 new executable but it will stamp it with the revision number from when
 CMake last regenerated the make files...
 
 Is there a way to mark a variable as volatile or something so that CMake
 will always recalculate it and check if it has changed?

Would it be acceptable if cmake would rerun after every build ?
You could enforce that e.g. with a add_custom_command( POST_BUILD ... ) which 
could e.g. touch CMakeCache.txt or something.

Better ideas ?

Alex
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


[CMake] COMPILE_FLAGS property that appends instead of replaces

2012-02-06 Thread Robert Dailey
I would like to set the COMPILE_FLAGS property multiple times on the same
target through set_target_properties(), however only the last call seems to
persist. Previous flags set get overridden. Is this the correct behavior?
If so, is there a way to make this property append instead of replace on
the same target?

-
Robert Dailey
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

Re: [CMake] COMPILE_FLAGS property that appends instead of replaces

2012-02-06 Thread aaron . meadows
I believe that is the defined behavior.  Usually, people would use
add_definitions() to add the flags before creating the target.  If you
have one target per subdirectory, you don't have to worry about removing
them afterwards:

 

CMakeLists.txt:

   add_definitions(/foo)

 

   add_subdirectory(baz)

   add_subdirectory(qux)

 

baz/CMakeLists.txt

   add_definitions(/bar)

   add_executable(baz baz.cpp)

 

qux/CMakeLists.txt

   add_executable(qux qux.cpp)

 

 

baz gets the compiler flags /foo /bar, qux only gets /foo.

 

 

 

As an aside, I ran into a similar issue, but with Linker Flags in the
cache.  To overcome that, I wrote a few functions to encapsulate the
writing of flags and handle checking for duplicates.  You could
certainly do something similar with properties:

 



## Cache Set Helper Functions



function(AppendIfMissing _outVar _inVar _value)

  string(REGEX REPLACE   ; _inList ${${_inVar}})

  list(FIND _inList ${_value} _pos)

 

  if(${_pos} EQUAL -1)

set(${_outVar} ${${_inVar}} ${_value} PARENT_SCOPE)

  else()

set(${_outVar} ${${_inVar}} PARENT_SCOPE)

  endif()

endfunction(AppendIfMissing)

 

function(CheckAndAppendCacheForce _varName _value _type )

  AppendIfMissing(_outvar ${_varName} ${_value})

 

  foreach(_arg IN LISTS ARGN)

set(_desc ${_desc} ${_arg})

  endforeach()

 

  set(${_varName} ${_outvar} CACHE ${_type} ${_desc} FORCE)

endfunction(CheckAndAppendCacheForce)

 

function(CheckAndAppendCache _varName _value _type )

  AppendIfMissing(_outvar ${_varName} ${_value})

 

  foreach(_arg IN LISTS ARGN)

set(_desc ${_desc} ${_arg})

  endforeach()

 

  set(${_varName} ${_outvar} CACHE ${_type} ${_desc})

endfunction(CheckAndAppendCache)

 

 

Aaron Meadows

 

From: cmake-boun...@cmake.org [mailto:cmake-boun...@cmake.org] On Behalf
Of Robert Dailey
Sent: Monday, February 06, 2012 3:58 PM
To: CMake ML
Subject: [CMake] COMPILE_FLAGS property that appends instead of replaces

 

I would like to set the COMPILE_FLAGS property multiple times on the
same target through set_target_properties(), however only the last call
seems to persist. Previous flags set get overridden. Is this the correct
behavior? If so, is there a way to make this property append instead of
replace on the same target?


 

-

Robert Dailey


This email was sent to you by Thomson Reuters, the global news and information 
company. Any views expressed in this message are those of the individual 
sender, except where the sender specifically states them to be the views of 
Thomson Reuters.--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

Re: [CMake] COMPILE_FLAGS property that appends instead of replaces

2012-02-06 Thread Robert Dailey
Thanks.

This seems to work:


set_property( TARGET foo APPEND_STRING PROPERTY
COMPILE_FLAGS /ZI 
)

set_property( TARGET foo APPEND_STRING PROPERTY
COMPILE_FLAGS /W4 
)

Just make sure you have a space at the end of each one, so that when the
strings are appended, there is a space between each compiler flag.

-
Robert Dailey


On Mon, Feb 6, 2012 at 4:13 PM, aaron.mead...@thomsonreuters.com wrote:

 *I believe that is the defined behavior.  Usually, people would use
 add_definitions() to add the flags before creating the target.  If you have
 one target per subdirectory, you don’t have to worry about removing them
 afterwards:*

 * *

 *CMakeLists.txt:*

 *   add_definitions(/foo)*

 * *

 *   add_subdirectory(baz)*

 *   add_subdirectory(qux)*

 * *

 *baz/CMakeLists.txt*

 *   add_definitions(/bar)*

 *   add_executable(baz baz.cpp)*

 * *

 *qux/CMakeLists.txt*

 *   add_executable(qux qux.cpp)*

 * *

 * *

 *baz gets the compiler flags “/foo /bar”, qux only gets “/foo”.*

 * *

 * *

 * *

 *As an aside, I ran into a similar issue, but with Linker Flags in the
 cache.  To overcome that, I wrote a few functions to encapsulate the
 writing of flags and handle checking for duplicates.  You could certainly
 do something similar with properties:*

 * *

 **

 *## Cache Set Helper Functions*

 **

 *function(AppendIfMissing _outVar _inVar _value)*

 *  string(REGEX REPLACE   ; _inList ${${_inVar}})*

 *  list(FIND _inList ${_value} _pos)*

 * *

 *  if(${_pos} EQUAL -1)*

 *set(${_outVar} ${${_inVar}} ${_value} PARENT_SCOPE)*

 *  else()*

 *set(${_outVar} ${${_inVar}} PARENT_SCOPE)*

 *  endif()*

 *endfunction(AppendIfMissing)*

 * *

 *function(CheckAndAppendCacheForce _varName _value _type )*

 *  AppendIfMissing(_outvar ${_varName} ${_value})*

 * *

 *  foreach(_arg IN LISTS ARGN)*

 *set(_desc ${_desc} ${_arg})*

 *  endforeach()*

 * *

 *  set(${_varName} ${_outvar} CACHE ${_type} ${_desc} FORCE)*

 *endfunction(CheckAndAppendCacheForce)*

 * *

 *function(CheckAndAppendCache _varName _value _type )*

 *  AppendIfMissing(_outvar ${_varName} ${_value})*

 * *

 *  foreach(_arg IN LISTS ARGN)*

 *set(_desc ${_desc} ${_arg})*

 *  endforeach()*

 * *

 *  set(${_varName} ${_outvar} CACHE ${_type} ${_desc})*

 *endfunction(CheckAndAppendCache)*

 * *

 * *

 *Aaron Meadows*

 * *

 *From:* cmake-boun...@cmake.org [mailto:cmake-boun...@cmake.org] *On
 Behalf Of *Robert Dailey
 *Sent:* Monday, February 06, 2012 3:58 PM
 *To:* CMake ML
 *Subject:* [CMake] COMPILE_FLAGS property that appends instead of replaces
 

 ** **

 I would like to set the COMPILE_FLAGS property multiple times on the same
 target through set_target_properties(), however only the last call seems to
 persist. Previous flags set get overridden. Is this the correct behavior?
 If so, is there a way to make this property append instead of replace on
 the same target?
 

 ** **

 -

 Robert Dailey

 This email was sent to you by Thomson Reuters, the global news and
 information company. Any views expressed in this message are those of the
 individual sender, except where the sender specifically states them to be
 the views of Thomson Reuters.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

Re: [CMake] Making a variable a dependency...

2012-02-06 Thread Michael Hertling
On 02/06/2012 10:56 PM, Alexander Neundorf wrote:
 On Saturday 04 February 2012, Oliver Smith wrote:
 My CMakeLists uses the Subversion repository information in a couple of
 places (it configures a file revision.h and it uses it for the CPack
 package name).

 The problem is that this variable is cached and retained until the cache
 is rebuilt, instead of being calculated or evaluated per make. So if I
 do a build, then do an svn update and pull some changes, it will build a
 new executable but it will stamp it with the revision number from when
 CMake last regenerated the make files...

 Is there a way to mark a variable as volatile or something so that CMake
 will always recalculate it and check if it has changed?
 
 Would it be acceptable if cmake would rerun after every build ?
 You could enforce that e.g. with a add_custom_command( POST_BUILD ... ) which 
 could e.g. touch CMakeCache.txt or something.
 
 Better ideas ?

Delay the generation of the revision.h header until build phase
via a custom command; look at the following exemplary project:

# CMakeLists.txt:
CMAKE_MINIMUM_REQUIRED(VERSION 2.8 FATAL_ERROR)
PROJECT(P C)
SET(CMAKE_VERBOSE_MAKEFILE ON)
ADD_CUSTOM_COMMAND(OUTPUT dummy revision.h
COMMAND ${CMAKE_COMMAND}
-DBD=${CMAKE_BINARY_DIR}
-DWC=${CMAKE_SOURCE_DIR}
-P ${CMAKE_SOURCE_DIR}/revision.cmake)
FILE(WRITE ${CMAKE_BINARY_DIR}/main.c
#include stdio.h
#include \revision.h\
int main(void)
{
printf(\%d\\n\,REVISION); return 0;
}
)
ADD_EXECUTABLE(main main.c revision.h)

# revision.cmake:
FIND_PACKAGE(Subversion)
Subversion_WC_INFO(${WC}@HEAD P)
FILE(WRITE ${BD}/revision.h.in #define REVISION @P_WC_REVISION@\n)
CONFIGURE_FILE(${BD}/revision.h.in ${BD}/revision.h @ONLY)

A make run rebuilds the main target whenever the repository's head
revision has changed - possibly inappropriate for actual usage, just
for demonstration purposes; adapt the revision.cmake script to suit
the needs.

BTW, can anybody confirm that the above-noted example doesn't work
if the order of dummy and revision.h in the custom command is
reversed? AFAICS, revision.h is removed after being generated in
this case, so the subsequent compilation fails.

Regards,

Michael
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] [EXTERNAL] Bug fix requests for the *next* release of CMake...

2012-02-06 Thread David Thompson

Replies requested. Short replies only. Read on. Just a short reply
with bug numbers or links to the bugs is all we need here. ...


http://public.kitware.com/Bug/view.php?id=7867 (have CTest report  
compiler type/version)


David

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


[CMake] Default Generator to use

2012-02-06 Thread Sarnath K - ERS, HCLTech
Hello Friends,

How do I specify the default generator that CMAKE should use when invoked 
without the -G option?
I am on Windows.
I saw an old thread on this. But I am not sure if any support was added later 
on.

Is there a REGISTRY entry in Windows that we can set to make so that CMAKE can 
check it?

Thanks,
Best Regards,
Sarnath


::DISCLAIMER::
---

The contents of this e-mail and any attachment(s) are confidential and intended 
for the named recipient(s) only.
It shall not attach any liability on the originator or HCL or its affiliates. 
Any views or opinions presented in
this email are solely those of the author and may not necessarily reflect the 
opinions of HCL or its affiliates.
Any form of reproduction, dissemination, copying, disclosure, modification, 
distribution and / or publication of
this message without the prior written consent of the author of this e-mail is 
strictly prohibited. If you have
received this email in error please delete it and notify the sender 
immediately. Before opening any mail and
attachments please check them for viruses and defect.

---
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

Re: [CMake] How to submit patches?

2012-02-06 Thread Rolf Eike Beer
Am Montag, 6. Februar 2012, 19:12:27 schrieb Michael Pechner:
 Is this the correct forum?

cmake-develop...@cmake.org would be the right place. Or open a bug report at 
http://cmake.org/Bug and attach it there.

 What format do you want the patch in?

git format-patch

 My changes are in 2.8.4. Will that be acceptable?
 Or do you require I move my changes to 2.8.7 then generate the patch?

Current git master is the place to go ;)

Eike

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake

[Cmake-commits] CMake branch, next, updated. v2.8.7-2471-ge09c129

2012-02-06 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.

The branch, next has been updated
   via  e09c1297d8777207dacbb2c35e5b17eec9212452 (commit)
   via  c8ef6430e09c063b74708ef0cd28f533c15fd8bd (commit)
  from  17ea393aa14be17eb7de9145bffbdfd332cda4a0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e09c1297d8777207dacbb2c35e5b17eec9212452
commit e09c1297d8777207dacbb2c35e5b17eec9212452
Merge: 17ea393 c8ef643
Author: Brad King brad.k...@kitware.com
AuthorDate: Mon Feb 6 09:43:56 2012 -0500
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Mon Feb 6 09:43:56 2012 -0500

Merge topic 'warn-funny-path-names' into next

c8ef643 Allow directory names containing '=' and warn if necessary (#12934)


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c8ef6430e09c063b74708ef0cd28f533c15fd8bd
commit c8ef6430e09c063b74708ef0cd28f533c15fd8bd
Author: Brad King brad.k...@kitware.com
AuthorDate: Mon Feb 6 09:40:42 2012 -0500
Commit: Brad King brad.k...@kitware.com
CommitDate: Mon Feb 6 09:40:42 2012 -0500

Allow directory names containing '=' and warn if necessary (#12934)

The approach taken by commit 8704525f (Reject directory names containing
'=', 2011-01-14) was perhaps too heavy-handed for avoiding the obscure
cases when '=' in the path fails due to limitations of Make syntax.
Only two CMake tests:

  LinkDirectory
  OutOfSource

fail when the path contains '=' and they cover obscure cases.  Instead
of rejecting such paths outright just warn when the problem may occur.

diff --git a/Source/cmLocalUnixMakefileGenerator3.cxx 
b/Source/cmLocalUnixMakefileGenerator3.cxx
index ff48009..b10e959 100644
--- a/Source/cmLocalUnixMakefileGenerator3.cxx
+++ b/Source/cmLocalUnixMakefileGenerator3.cxx
@@ -561,6 +561,21 @@ cmLocalUnixMakefileGenerator3
 space =  ;
 }
 
+  // Warn about paths not supported by Make tools.
+  std::string::size_type pos = tgt.find_first_of(=);
+  if(pos != std::string::npos)
+{
+cmOStringStream m;
+m 
+  Make rule for\n
+  tgt  \n
+  has '=' on left hand side.  
+  The make tool may not support this.;
+cmListFileBacktrace bt;
+this-GlobalGenerator-GetCMakeInstance()
+  -IssueMessage(cmake::WARNING, m.str(), bt);
+}
+
   // Mark the rule as symbolic if requested.
   if(symbolic)
 {
diff --git a/Source/cmake.cxx b/Source/cmake.cxx
index bc3245e..1b49837 100644
--- a/Source/cmake.cxx
+++ b/Source/cmake.cxx
@@ -1946,32 +1946,8 @@ int cmake::Configure()
 
 }
 
-bool cmake::RejectUnsupportedPaths(const char* desc, std::string const path)
-{
-  // Some characters are not well-supported by native build systems.
-  std::string::size_type pos = path.find_first_of(=);
-  if(pos == std::string::npos)
-{
-return false;
-}
-  cmOStringStream e;
-  e  The path to the   desc   directory:\n
- path  \n
- contains unsupported character '  path[pos]  '.\n
- Please use a different   desc   directory name.;
-  cmListFileBacktrace bt;
-  this-IssueMessage(cmake::FATAL_ERROR, e.str(), bt);
-  return true;
-}
-
 int cmake::ActualConfigure()
 {
-  if(this-RejectUnsupportedPaths(source, this-cmHomeDirectory) ||
- this-RejectUnsupportedPaths(binary, this-HomeOutputDirectory))
-{
-return 1;
-}
-
   // Construct right now our path conversion table before it's too late:
   this-UpdateConversionPathTable();
   this-CleanupCommandsAndMacros();
diff --git a/Source/cmake.h b/Source/cmake.h
index 6744ca1..435d38b 100644
--- a/Source/cmake.h
+++ b/Source/cmake.h
@@ -435,8 +435,6 @@ protected:
 
   ///! Find the full path to one of the cmake programs like ctest, cpack, etc.
   std::string FindCMakeProgram(const char* name) const;
-
-  bool RejectUnsupportedPaths(const char* desc, std::string const path);
 private:
   cmake(const cmake);  // Not implemented.
   void operator=(const cmake);  // Not implemented.

---

Summary of changes:
 Source/cmLocalUnixMakefileGenerator3.cxx |   15 +++
 Source/cmake.cxx |   24 
 Source/cmake.h   |2 --
 3 files changed, 15 insertions(+), 26 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits


[Cmake-commits] CMake branch, next, updated. v2.8.7-2476-g1036a1f

2012-02-06 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.

The branch, next has been updated
   via  1036a1f6c298baeb29018a5838de813a9b2c7392 (commit)
   via  415ffda7a8ca0dfea2e00353a65fb31d8fadfb75 (commit)
   via  1dd43c4c9d6d921b38288802d0560f92c90a0c08 (commit)
   via  34cc537132e843d07c3bdeb0ccaa06e82f9aef88 (commit)
   via  a1979dc0e95a6b86495b669076f892cd362bda9f (commit)
  from  e09c1297d8777207dacbb2c35e5b17eec9212452 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1036a1f6c298baeb29018a5838de813a9b2c7392
commit 1036a1f6c298baeb29018a5838de813a9b2c7392
Merge: e09c129 415ffda
Author: Brad King brad.k...@kitware.com
AuthorDate: Mon Feb 6 10:25:17 2012 -0500
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Mon Feb 6 10:25:17 2012 -0500

Merge topic 'fix-ccmake-clear' into next

415ffda ccmake: Extend clear line.
1dd43c4 ccmake: Factor clear line.
34cc537 KWSys Nightly Date Stamp
a1979dc KWSys Nightly Date Stamp


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=415ffda7a8ca0dfea2e00353a65fb31d8fadfb75
commit 415ffda7a8ca0dfea2e00353a65fb31d8fadfb75
Author: Nicolas Despres nicolas.desp...@gmail.com
AuthorDate: Sun Feb 5 16:56:47 2012 +0100
Commit: Brad King brad.k...@kitware.com
CommitDate: Mon Feb 6 10:23:50 2012 -0500

ccmake: Extend clear line.

When configuring or generating the 'ng' of the end of the second line
is not cleared.  This patch fixes this.

The problem was introduced by commit fd632195 (ccmake: Align 'g' and 'q'
key instructions, 2011-01-07) which adjusted the length of lines that
need clearing.

diff --git a/Source/CursesDialog/cmCursesMainForm.cxx 
b/Source/CursesDialog/cmCursesMainForm.cxx
index 6b7d89e..4fee0bb 100644
--- a/Source/CursesDialog/cmCursesMainForm.cxx
+++ b/Source/CursesDialog/cmCursesMainForm.cxx
@@ -410,7 +410,7 @@ void cmCursesMainForm::PrintKeys(int process /* = 0 */)
   if (process)
 {
 const char* clearLine =
- ;
+  ;
 strcpy(firstLine, clearLine);
 strcpy(secondLine, clearLine);
 strcpy(thirdLine, clearLine);

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1dd43c4c9d6d921b38288802d0560f92c90a0c08
commit 1dd43c4c9d6d921b38288802d0560f92c90a0c08
Author: Nicolas Despres nicolas.desp...@gmail.com
AuthorDate: Sun Feb 5 15:09:37 2012 +0100
Commit: Nicolas Despres nicolas.desp...@gmail.com
CommitDate: Sun Feb 5 15:09:37 2012 +0100

ccmake: Factor clear line.

diff --git a/Source/CursesDialog/cmCursesMainForm.cxx 
b/Source/CursesDialog/cmCursesMainForm.cxx
index 6c7627f..6b7d89e 100644
--- a/Source/CursesDialog/cmCursesMainForm.cxx
+++ b/Source/CursesDialog/cmCursesMainForm.cxx
@@ -409,12 +409,11 @@ void cmCursesMainForm::PrintKeys(int process /* = 0 */)
   char thirdLine[512]=;
   if (process)
 {
-sprintf(firstLine,
-   );
-sprintf(secondLine,
-   );
-sprintf(thirdLine,
-   );
+const char* clearLine =
+ ;
+strcpy(firstLine, clearLine);
+strcpy(secondLine, clearLine);
+strcpy(thirdLine, clearLine);
 }
   else
 {

---

Summary of changes:
 Source/CursesDialog/cmCursesMainForm.cxx |   11 +--
 Source/kwsys/kwsysDateStamp.cmake|2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits


[Cmake-commits] CMake branch, next, updated. v2.8.7-2478-g8236bb9

2012-02-06 Thread Eric Noulard
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.

The branch, next has been updated
   via  8236bb990d1b08cd7933fd13d2e3c08519750742 (commit)
   via  5a948cd22b448bf03ec939d46ef289eba9b9407c (commit)
  from  1036a1f6c298baeb29018a5838de813a9b2c7392 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8236bb990d1b08cd7933fd13d2e3c08519750742
commit 8236bb990d1b08cd7933fd13d2e3c08519750742
Merge: 1036a1f 5a948cd
Author: Eric Noulard eric.noul...@gmail.com
AuthorDate: Mon Feb 6 11:23:10 2012 -0500
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Mon Feb 6 11:23:10 2012 -0500

Merge topic 'ImproveCPackDoc-reloaded' into next

5a948cd Fix non existent std::string::clear on VS6


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5a948cd22b448bf03ec939d46ef289eba9b9407c
commit 5a948cd22b448bf03ec939d46ef289eba9b9407c
Author: Eric NOULARD eric.noul...@gmail.com
AuthorDate: Mon Feb 6 17:20:54 2012 +0100
Commit: Eric NOULARD eric.noul...@gmail.com
CommitDate: Mon Feb 6 17:20:54 2012 +0100

Fix non existent std::string::clear on VS6

diff --git a/Source/cmDocumentation.cxx b/Source/cmDocumentation.cxx
index dde4953..02f69f1 100644
--- a/Source/cmDocumentation.cxx
+++ b/Source/cmDocumentation.cxx
@@ -786,7 +786,7 @@ int cmDocumentation::getDocumentedModulesListInDir(
 // No else if no section is found (undocumented module)
 }
   // No else cannot read first line (ignore this kind of error)
-  line.clear();
+  line = ;
   }
 }
   if (nbDocumentedModules0)
@@ -887,7 +887,7 @@ int cmDocumentation::GetStructuredDocFromFile(
docCtxIdx++;
docContextStack[docCtxIdx]=SDOC_SECTION;
/* drop the rest of the line */
-   line.clear();
+   line = ;
newCtx = true;
 }
 else if (mkword.substr(0,3)==end)

---

Summary of changes:
 Source/cmDocumentation.cxx |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits


[Cmake-commits] CMake branch, next, updated. v2.8.7-2480-ge6c7ef0

2012-02-06 Thread Rolf Eike Beer
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.

The branch, next has been updated
   via  e6c7ef0bdc9a55b84de56ab9e35f7daf1e3b2a23 (commit)
   via  176132a82bd1343796ea24e1a00a8961f891f025 (commit)
  from  8236bb990d1b08cd7933fd13d2e3c08519750742 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e6c7ef0bdc9a55b84de56ab9e35f7daf1e3b2a23
commit e6c7ef0bdc9a55b84de56ab9e35f7daf1e3b2a23
Merge: 8236bb9 176132a
Author: Rolf Eike Beer e...@sf-mail.de
AuthorDate: Mon Feb 6 13:34:46 2012 -0500
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Mon Feb 6 13:34:46 2012 -0500

Merge topic 'ctest-no-coverage-for-empty-lines' into next

176132a Revert CTest: do not add coverage for empty lines


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=176132a82bd1343796ea24e1a00a8961f891f025
commit 176132a82bd1343796ea24e1a00a8961f891f025
Author: Rolf Eike Beer e...@sf-mail.de
AuthorDate: Mon Feb 6 19:33:39 2012 +0100
Commit: Rolf Eike Beer e...@sf-mail.de
CommitDate: Mon Feb 6 19:33:39 2012 +0100

Revert CTest: do not add coverage for empty lines

This reverts commit 3ea6be30819e78ddf3d97378a519dc50836049a3.

Although it's an improvement, David doesn't like it.

diff --git a/Source/CTest/cmCTestCoverageHandler.cxx 
b/Source/CTest/cmCTestCoverageHandler.cxx
index 130eb6a..0b1c9fe 100644
--- a/Source/CTest/cmCTestCoverageHandler.cxx
+++ b/Source/CTest/cmCTestCoverageHandler.cxx
@@ -591,24 +591,14 @@ int cmCTestCoverageHandler::ProcessHandler()
   continue;
   }
 int untested = 0;
-int lineNr = 0;
 std::string line;
 cmCTestLog(this-CTest, HANDLER_VERBOSE_OUTPUT,
   Actually performing coverage for:   i-c_str()  std::endl);
 while (cmSystemTools::GetLineFromStream(ifs, line))
   {
-  covLogFile  \t\tLine Number=\  lineNr  \ Count=\;
-  lineNr ++;
-  if ( line.empty() )
-{
-covLogFile  -1\;
-}
-  else
-{
-covLogFile  0\  cmXMLSafe(line);
-untested ++;
-}
-  covLogFile  /Line  std::endl;
+  covLogFile  \t\tLine Number=\  untested  \ Count=\0\
+ cmXMLSafe(line)  /Line  std::endl;
+  untested ++;
   }
 covLogFile  \t\t/Report\n\t/File  std::endl;
 

---

Summary of changes:
 Source/CTest/cmCTestCoverageHandler.cxx |   16 +++-
 1 files changed, 3 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits


[Cmake-commits] CMake branch, next, updated. v2.8.7-2483-gd3704dd

2012-02-06 Thread David Cole
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.

The branch, next has been updated
   via  d3704dd6d8e8714b23fae3fe57cbe1d06a4a846f (commit)
   via  495f8998458f06fac250d62ba948e21c2429565f (commit)
   via  e130d3ece47d4ceee45473567935c629da72d1eb (commit)
  from  e6c7ef0bdc9a55b84de56ab9e35f7daf1e3b2a23 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d3704dd6d8e8714b23fae3fe57cbe1d06a4a846f
commit d3704dd6d8e8714b23fae3fe57cbe1d06a4a846f
Merge: e6c7ef0 495f899
Author: David Cole david.c...@kitware.com
AuthorDate: Mon Feb 6 13:50:58 2012 -0500
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Mon Feb 6 13:50:58 2012 -0500

Merge topic 'update-mini5-release-qt' into next

495f899 Update version of Qt for dashmacmini5 produced release binaries
e130d3e KWSys Nightly Date Stamp


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=495f8998458f06fac250d62ba948e21c2429565f
commit 495f8998458f06fac250d62ba948e21c2429565f
Author: David Cole david.c...@kitware.com
AuthorDate: Mon Feb 6 13:48:53 2012 -0500
Commit: David Cole david.c...@kitware.com
CommitDate: Mon Feb 6 13:48:53 2012 -0500

Update version of Qt for dashmacmini5 produced release binaries

Use 4.8.0

diff --git a/Utilities/Release/dashmacmini5_release.cmake 
b/Utilities/Release/dashmacmini5_release.cmake
index 9bb3a98..bd93a87 100644
--- a/Utilities/Release/dashmacmini5_release.cmake
+++ b/Utilities/Release/dashmacmini5_release.cmake
@@ -14,7 +14,7 @@ CMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.5
 CMAKE_SKIP_BOOTSTRAP_TEST:STRING=TRUE
 CPACK_SYSTEM_NAME:STRING=Darwin64-universal
 BUILD_QtDialog:BOOL=TRUE
-QT_QMAKE_EXECUTABLE:FILEPATH=/Users/kitware/Support/qt-4.7.4/install/bin/qmake
+QT_QMAKE_EXECUTABLE:FILEPATH=/Users/kitware/Support/qt-4.8.0/install/bin/qmake
 )
 get_filename_component(path ${CMAKE_CURRENT_LIST_FILE} PATH)
 include(${path}/release_cmake.cmake)

---

Summary of changes:
 Source/kwsys/kwsysDateStamp.cmake|2 +-
 Utilities/Release/dashmacmini5_release.cmake |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits


[Cmake-commits] CMake branch, master, updated. v2.8.7-271-g45bba99

2012-02-06 Thread KWSys Robot
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.

The branch, master has been updated
   via  45bba995381bd88895eb2e15ac9cdf91dc5c5080 (commit)
  from  e130d3ece47d4ceee45473567935c629da72d1eb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=45bba995381bd88895eb2e15ac9cdf91dc5c5080
commit 45bba995381bd88895eb2e15ac9cdf91dc5c5080
Author: KWSys Robot kwro...@kitware.com
AuthorDate: Tue Feb 7 00:05:07 2012 -0500
Commit: KWSys Robot kwro...@kitware.com
CommitDate: Tue Feb 7 00:05:07 2012 -0500

KWSys Nightly Date Stamp

diff --git a/Source/kwsys/kwsysDateStamp.cmake 
b/Source/kwsys/kwsysDateStamp.cmake
index 57aba08..2cbfe26 100644
--- a/Source/kwsys/kwsysDateStamp.cmake
+++ b/Source/kwsys/kwsysDateStamp.cmake
@@ -18,4 +18,4 @@ SET(KWSYS_DATE_STAMP_YEAR  2012)
 SET(KWSYS_DATE_STAMP_MONTH 02)
 
 # KWSys version date day component.  Format is DD.
-SET(KWSYS_DATE_STAMP_DAY   06)
+SET(KWSYS_DATE_STAMP_DAY   07)

---

Summary of changes:
 Source/kwsys/kwsysDateStamp.cmake |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits