Re: [cmake-developers] Suspicious Clang versions
s...@rogue-research.com wrote: http://open.cdash.org/testDetails.php?test=201937829build=2986379 (MacOS 10.8) shows 3.4.0. But since even 3.4 does not seem to be released I wonder what's going on there? That one is the open source clang, which I build from svn. It's not from Xcode. It's my 'bleeding edge' build machine. clang is always getting stricter and getting new warnings, so this help us fix them before a CMake/VTK/ITK release. Ok, then I assume that this is complaining about something in my test files. Could you tell me what went wrong here, please? http://open.cdash.org/testDetails.php?test=203511533build=2997654 Eike -- signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Targets for FindGTK2.cmake
On 12/08/13 15:36, Stephen Kelly wrote: The difference is that if GTK2_USE_IMPORTED_TARGETS the GTK_${_var}_LIBRARY will link the target (and it's dependencies) otherwise it will link only the library (without dependencies) using the DEBUG or RELEASE version, depending on what was found. Are there also GTK_${_var}_LIBRARIES variables? Conventionally, the *LIBRARIES variables are for user-use and the *LIBRARY variables are not... Not at the moment, but perhaps it might be useful to add them... What do you think? * CMake 2.8.12 will ignore IMPORTED_LINK_INTERFACE_LIBRARIES_${_config}, so you don't need to set it. The only reason to want to set it is if you want people to backport this updated module. I don't recommend setting it. Does this mean that setting the INTERFACE_LINK_LIBRARIES is enough? Again I took this from FindQT4... Yes, I didn't remove it from there yet. I do intend to though probably after CMake 2.8.12. [...] No need to remove the IMPORTED_LINK_INTERFACE_LIBRARIES_${_config} if you don't want to. Then, I think I'll leave it there for now... I'm not sure if it is possible to squash commits/rebase topics published and merged to next. It's possible, but a bit tricky. If you rebase, the result of the rebasing needs to be the exact same as what is already in next. When fixing up a branch, that means making fixup commits, then pushing them, then squashing the fixes with a rebase, then force pushing. You can test the merge to stage/next locally too. I tried locally but I get merge conflicts, so I'm not sure if I'm doing it right... If it is not an issue, I'd just leave the extra commit. * If GObject depends on glib, then the line _GTK2_ADD_TARGET_DEPENDS(ATK gobject glib) does not need to specify glib. I would minimise those dependency listings. atk explicitly requires glib (glib.h is included in some headers) therefore I thought it was better to make this explicit here as well. *shrug*. I've seen the same argument presented before, but I don't agree with it. As you wish. I'm not expert, I'm just saying what I thought when I wrote it, so if you think it is better in the other way I can change it. * fontconfig seems to be only a compile dependency but not a link dependency. * freetype seems to be a link dependency (I assume, as it is added to GTK2_LIBRARIES), but the library does not seem to be in the link interface of the Cairo library. ${FREETYPE_LIBRARIES} can just be added to the INTERFACE_LINK_LIBRARIES, but I think it might make sense to create an imported target for it too anyway (in FindFreetype.cmake)? To be honest I'm not completely sure here... On windows (with the GtkMM installer) I'm having some issues with freetype, when linking ${GTK2_LIBRARIES}, but it links when I use the libraries one by one. It would be interesting to get more information on this. I did a few more tests, and it looks like that, at least on my system and on windows, FREETYPE_LIBRARIES are not required, they are linked to some other libraries (i.e. cairo) but they don't need to be linked explicitly On the other hand, the FREETYPE_INCLUDE_DIR is required, because some public header includes freetype headers. On window using gtkmm installer, find_package(Freetype) freetype is not found, FREETYPE_FOUND is FALSE, FREETYPE_LIBRARY is FREETYPE_LIBRARY-NOTFOUND, but FREETYPE_INCLUDE_DIR is set correctly (the headers are installed, but the .lib file is missing) I'm not sure if this is a bug in FindFreetype (FREETYPE_INCLUDE_DIR should be unset if freetype was not found?) On the other hand, fixing this means that building gtk programs will fail. Perhaps FindGTK2 should NOT use FindFreetype and should look for the headers only internally (like for fontconfig) Regards, Daniele -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] CTestTestMemcheckDummy* failures during dynamic analysis
On 08/13/2013 05:30 PM, Rolf Eike Beer wrote: *Dynamic analysis tests failing or not run* CTestTestMemcheckDummyPurify (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977143) CTestTestMemcheckDummyValgrind (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977144) CTestTestMemcheckDummyValgrindIgnoreMemcheck (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977146) CTestTestMemcheckDummyValgrindPrePost (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977145) Can someone explain those to me? I don't understand what's going wrong there. In those submissions the CTestTestMemcheckDummy* tests are running under a real valgrind tool. From a quick glance it looks like the valgrind tool is inserting its report into the output so it doesn't match the expectation regex. Can the regex be extended to tolerate this? -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Targets for FindGTK2.cmake
Daniele E. Domenichelli wrote: On 12/08/13 15:36, Stephen Kelly wrote: The difference is that if GTK2_USE_IMPORTED_TARGETS the GTK_${_var}_LIBRARY will link the target (and it's dependencies) otherwise it will link only the library (without dependencies) using the DEBUG or RELEASE version, depending on what was found. Are there also GTK_${_var}_LIBRARIES variables? Conventionally, the *LIBRARIES variables are for user-use and the *LIBRARY variables are not... Not at the moment, but perhaps it might be useful to add them... What do you think? My personal view is that you should recommend people to use the target names directly and not the variables :), but I know that view is not universally shared. I tried locally but I get merge conflicts, so I'm not sure if I'm doing it right... If it is not an issue, I'd just leave the extra commit. Brad can squash up your branch before merging to master if he wants to. * If GObject depends on glib, then the line _GTK2_ADD_TARGET_DEPENDS(ATK gobject glib) does not need to specify glib. I would minimise those dependency listings. atk explicitly requires glib (glib.h is included in some headers) therefore I thought it was better to make this explicit here as well. *shrug*. I've seen the same argument presented before, but I don't agree with it. As you wish. I'm not expert, I'm just saying what I thought when I wrote it, so if you think it is better in the other way I can change it. I think that's your call as the maintainer or Brads call. * fontconfig seems to be only a compile dependency but not a link dependency. * freetype seems to be a link dependency (I assume, as it is added to GTK2_LIBRARIES), but the library does not seem to be in the link interface of the Cairo library. ${FREETYPE_LIBRARIES} can just be added to the INTERFACE_LINK_LIBRARIES, but I think it might make sense to create an imported target for it too anyway (in FindFreetype.cmake)? To be honest I'm not completely sure here... On windows (with the GtkMM installer) I'm having some issues with freetype, when linking ${GTK2_LIBRARIES}, but it links when I use the libraries one by one. It would be interesting to get more information on this. I did a few more tests, and it looks like that, at least on my system and on windows, FREETYPE_LIBRARIES are not required, they are linked to some other libraries (i.e. cairo) but they don't need to be linked explicitly On the other hand, the FREETYPE_INCLUDE_DIR is required, because some public header includes freetype headers. Can you confirm that the things used in those cases from the headers are only defines, enum values, inline functions etc, and not anything that becomes part of the ABI (such as inheriting from a type etc)? Or, otherwise, can you determine why the freetype header is in the public headers? On window using gtkmm installer, find_package(Freetype) freetype is not found, FREETYPE_FOUND is FALSE, FREETYPE_LIBRARY is FREETYPE_LIBRARY-NOTFOUND, but FREETYPE_INCLUDE_DIR is set correctly (the headers are installed, but the .lib file is missing) I'm not sure if this is a bug in FindFreetype (FREETYPE_INCLUDE_DIR should be unset if freetype was not found?) Perhaps. If so, maybe that's something FPHSA should do? Seems like a separate topic though. Do you mean that the windows gtk installer does not install the .lib file at all, but does install the include files (because it only uses defines/enums and doesn't need to link to the thing?)? On the other hand, fixing this means that building gtk programs will fail. Perhaps FindGTK2 should NOT use FindFreetype and should look for the headers only internally (like for fontconfig) It seems so, yes. Btw, was there any effort to get the gtk upstream to produce cmake config files with IMPORTED targets? Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] CTestTestMemcheckDummy* failures during dynamic analysis
Am 14.08.2013 14:58, schrieb Brad King: On 08/13/2013 05:30 PM, Rolf Eike Beer wrote: *Dynamic analysis tests failing or not run* CTestTestMemcheckDummyPurify (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977143) CTestTestMemcheckDummyValgrind (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977144) CTestTestMemcheckDummyValgrindIgnoreMemcheck (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977146) CTestTestMemcheckDummyValgrindPrePost (http://open.cdash.org/viewDynamicAnalysisFile.php?id=2977145) Can someone explain those to me? I don't understand what's going wrong there. In those submissions the CTestTestMemcheckDummy* tests are running under a real valgrind tool. From a quick glance it looks like the valgrind tool is inserting its report into the output so it doesn't match the expectation regex. Can the regex be extended to tolerate this? The memcheck output is at the beginning at the output, but the test is only matching against the end, i.e. it ignores everything trailing. Or does valgrind add trailing newlines there? Eike -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Version number updates for 2.8.12
Hi, I pushed a branch updating the version number of new policies and a version number generated in export files a few months ago. I just left it as a reminder to bump merge the bumps at RC time. The branch was deleted soon after though. Is the release branch going to get a similar change for the RC1? Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 09:14 AM, Stephen Kelly wrote: I pushed a branch updating the version number of new policies and a version number generated in export files a few months ago. I just left it as a reminder to bump merge the bumps at RC time. The branch was deleted soon after though. Is the release branch going to get a similar change for the RC1? The policies should have been added with 2.8.12 as their version originally. The way to test that in other projects is to add if(POLICY CMP0023) cmake_policy(SET CMP0023 NEW) endif() to your code instead of depending on cmake_minimum_required to set it. I should have caught that during review but forgot. I added a commit to update the versions: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec I'll have to re-create the release branch tomorrow after this is tested. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
Brad King wrote: I added a commit to update the versions: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec I'll have to re-create the release branch tomorrow after this is tested. You missed the version in Source/cmExportInstallFileGenerator.cxx See commit 574fec97fd011 Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 11:00 AM, Brad King wrote: On 08/14/2013 10:59 AM, Stephen Kelly wrote: Brad King wrote: I added a commit to update the versions: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec I'll have to re-create the release branch tomorrow after this is tested. You missed the version in Source/cmExportInstallFileGenerator.cxx See commit 574fec97fd011 Please extend the topic to fix that. I'll squash it later. That version doesn't need to be 2.8.12, does it? It needs only to be a version new enough to understand the generated content. The current value should be okay, no? -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
Brad King wrote: On 08/14/2013 10:59 AM, Stephen Kelly wrote: Brad King wrote: I added a commit to update the versions: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec I'll have to re-create the release branch tomorrow after this is tested. You missed the version in Source/cmExportInstallFileGenerator.cxx See commit 574fec97fd011 Please extend the topic to fix that. I'll squash it later. That breaks the ExportImport unit test, because is is used in a version_greater check and the version bump to 2.8.12 is only in the release branch. We sort-of discussed this before: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6442 Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
Brad King wrote: On 08/14/2013 11:00 AM, Brad King wrote: On 08/14/2013 10:59 AM, Stephen Kelly wrote: Brad King wrote: I added a commit to update the versions: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec I'll have to re-create the release branch tomorrow after this is tested. You missed the version in Source/cmExportInstallFileGenerator.cxx See commit 574fec97fd011 Please extend the topic to fix that. I'll squash it later. That version doesn't need to be 2.8.12, does it? It needs only to be a version new enough to understand the generated content. The current value should be okay, no? Yes. It's not very pretty though for the final release to tell people that they should install '2.8.11.20130626 or later' instead of '2.8.12 or later', which is what we really intend to communicate. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 11:09 AM, Stephen Kelly wrote: That breaks the ExportImport unit test, because is is used in a version_greater check and the version bump to 2.8.12 is only in the release branch. As I hinted in my sibling response this check can remain on a 2.8.11.date version. We sort-of discussed this before: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6442 I think the if(POLICY) testing approach is cleaner than the advice I gave there. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 11:14 AM, Stephen Kelly wrote: It's not very pretty though for the final release to tell people that they should install '2.8.11.20130626 or later' instead of '2.8.12 or later', which is what we really intend to communicate. Okay, I'll bump that version at the same time as the CMakeVersion.cmake information when creating the release branch. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014356]: QAxServer and QAxContainer are broken in FindQt4.cmake
The following issue has been SUBMITTED. == http://www.gccxml.org/Bug/view.php?id=14356 == Reported By:Alex Assigned To: == Project:CMake Issue ID: 14356 Category: Modules Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-08-14 11:43 EDT Last Modified: 2013-08-14 11:43 EDT == Summary:QAxServer and QAxContainer are broken in FindQt4.cmake Description: FindQt4.cmake: macro (_QT4_ADJUST_LIB_VARS _camelCaseBasename) ... set(QT_${basename}_FOUND 1) ... endmacro () if(QT_QAXSERVER_FOUND) _QT4_ADJUST_LIB_VARS(QAxServer) ... endif() if(QT_QAXCONTAINER_FOUND) _QT4_ADJUST_LIB_VARS(QAxContainer) endif() Macro _QT4_ADJUST_LIB_VARS is the only place where QT_QAXSERVER_FOUND and QT_QAXCONTAINER_FOUND (and other _FOUND variables) are set so these two variables will be always in false state making QAxServer and QAxContainer disabled. == Issue History Date ModifiedUsername FieldChange == 2013-08-14 11:43 Alex New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
We should (maybe I will if I get time to spend on it) write a test that executes something like this command: $ git grep -E [0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9].*cmPolicies Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); Source/cmPolicies.cxx:2,8,11,20130724, cmPolicies::WARN); And make sure the results are empty-ish... Then if somebody does this later on, it will be a test failure. D -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 01:02 PM, David Cole wrote: We should (maybe I will if I get time to spend on it) write a test that executes something like this command: $ git grep -E [0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9].*cmPolicies Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); Source/cmPolicies.cxx:2,8,11,20130724, cmPolicies::WARN); And make sure the results are empty-ish... Then if somebody does this later on, it will be a test failure. Robert and I are adding a check like git grep 2.8.11.20.. to the release process to look for cases that need a version comparison update (where 2.8.11 is the existing release). That will catch Source/cmPolicies.cxx lines too. If you can add a test to catch the cmPolicies entries earlier that would be even better. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please review CXXFeatures.cmake
On 08/13/2013 01:54 PM, Rolf Eike Beer wrote: Brad King wrote: On Win64-vs10-Tv90 it is building with VS 10 but the compiler is VS 9. I'll switch that over to use CMAKE_CXX_COMPILER_VERSION as suggested below, the error will probably go away then. That worked. For Win32-mingw-gcc-4.5 and Win32-msys-gcc-4.5, does the MinGW port of the compiler support all the same features? It is GNU 4.5.0. I would have expected it so. The problem was the if(WIN32) condition for testing /Qstd=c++11 for the Intel compiler. It triggered on MinGW and of course that GNU compiler doesn't have the flag. Fixed: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=51ce1aeb While at it I added logging of the try_compile output: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cabd6f87 This should help local investigations of the remaining failures. Perhaps you can also teach the test to print out the CMakeFiles/CMakeOutput.log and CMakeFiles/CMakeError.log content at the end when it got unexpected results. For Windows-icl-11.1-*, why do the expected results not just match for this version? That is a question I wanted to bring up, too. Can you log into that machine and get me the intermediate results of the try_compile calls? It seems to have worked last night anyway. It also worked for me with local testing of the above-linked changes. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please review CXXFeatures.cmake
Am Mittwoch, 14. August 2013, 14:02:35 schrieb Brad King: On 08/13/2013 01:54 PM, Rolf Eike Beer wrote: Brad King wrote: On Win64-vs10-Tv90 it is building with VS 10 but the compiler is VS 9. I'll switch that over to use CMAKE_CXX_COMPILER_VERSION as suggested below, the error will probably go away then. That worked. For Win32-mingw-gcc-4.5and Win32-msys-gcc-4.5, does the MinGW port of the compiler support all the same features? It is GNU 4.5.0. I would have expected it so. The problem was the if(WIN32) condition for testing /Qstd=c++11 for the Intel compiler. It triggered on MinGW and of course that GNU compiler doesn't have the flag. Fixed: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=51ce1aeb Ah, stupid mistake. While at it I added logging of the try_compile output: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cabd6f87 This should help local investigations of the remaining failures. Perhaps you can also teach the test to print out the CMakeFiles/CMakeOutput.log and CMakeFiles/CMakeError.log content at the end when it got unexpected results. Will look into it. For Windows-icl-11.1-*, why do the expected results not just match for this version? That is a question I wanted to bring up, too. Can you log into that machine and get me the intermediate results of the try_compile calls? It seems to have worked last night anyway. It also worked for me with local testing of the above-linked changes. Freaky. Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014357]: Defining an override macro/function of add_library more than once causes a segmentation fault.
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14357 == Reported By:Jason Howlett Assigned To: == Project:CMake Issue ID: 14357 Category: CMake Reproducibility:always Severity: crash Priority: normal Status: new == Date Submitted: 2013-08-14 15:28 EDT Last Modified: 2013-08-14 15:28 EDT == Summary:Defining an override macro/function of add_library more than once causes a segmentation fault. Description: If a macro or function override of add_library is created in more than one scope, either directly or through an include of a common file, cmake seg faults during calls to add_library in the second scope. The call to _add_library in the override resolves to the second 'instance' of the add_library override, resulting in an infinite recursion. Steps to Reproduce: Uncompress the attached test project, go to the build directory, and run cmake .. == Issue History Date ModifiedUsername FieldChange == 2013-08-14 15:28 Jason Howlett New Issue 2013-08-14 15:28 Jason Howlett File Added: cmake_crash_test.zip == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014358]: FortranCInterface fails to find generated test program when cross-compiling
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14358 == Reported By:Michel Zou Assigned To: == Project:CMake Issue ID: 14358 Category: Modules Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-08-14 18:14 EDT Last Modified: 2013-08-14 18:14 EDT == Summary:FortranCInterface fails to find generated test program when cross-compiling Description: Here is the initial bugreport on the mailing list left with no reply: http://www.cmake.org/pipermail/cmake/2012-March/049459.html Steps to Reproduce: Use the FortranCInterface module AND use a fortran cross compiler: in CMakeLists: include ( FortranCInterface ) FortranCInterface_HEADER ( FortranCInterface.h ) in foo.h: #include FortranCInterface.h #define F77_FUNC(name,NAME) FortranCInterface_GLOBAL(name,NAME) #define BAR_F77 F77_FUNC(bar,BAR) void BAR_F77(int *x); ... Additional Information: See the attached patch proposed in the thread against current master. Tested with and without cross-compilation on Linux. == Issue History Date ModifiedUsername FieldChange == 2013-08-14 18:14 Michel Zou New Issue 2013-08-14 18:14 Michel Zou File Added: cmake-fortrancinterface-cross-compilation.patch == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014359]: [FindSWIG] SWIG detection fails when cross-compiling
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14359 == Reported By:Michel Zou Assigned To: == Project:CMake Issue ID: 14359 Category: Modules Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-08-14 18:49 EDT Last Modified: 2013-08-14 18:49 EDT == Summary:[FindSWIG] SWIG detection fails when cross-compiling Description: The detection of swig fails when cross-compiling, here's why: When cross-compiling, we do not want find_path to find files in the host tree, so we set the root path to the target libs and includes: set ( CMAKE_FIND_ROOT_PATH /usr/i386-mingw32 ) set ( CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY ) but we never want cmake to find utils (like swig, awk, bc, etc...) in the target tree but in the host prefix: set ( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER ) Swig uses 'swig -swiglib' to determine the location of it's internal library: execute_process(COMMAND ${SWIG_EXECUTABLE} -swiglib OUTPUT_VARIABLE SWIG_swiglib_output) Then it uses find-path to check the library macros presence: find_path(SWIG_DIR swig.swg PATHS ${SWIG_swiglib_output}) But with CMAKE_FIND_ROOT_PATH_MODE_INCLUDE set to ONLY, the path cannot be found in the host paths, and the required SWIG_DIR is not found ; the detection fails: -- Could NOT find SWIG (missing: SWIG_DIR) Steps to Reproduce: Try to find swig while crosscompiling: - in CMakeLists: find_package(SWIG) - in ToolChain-i386-mingw32: set ( CMAKE_SYSTEM_NAME Windows ) set ( CMAKE_C_COMPILER i386-mingw32-gcc ) set ( CMAKE_FIND_ROOT_PATH /usr/i386-mingw32 ) set ( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER ) set ( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY ) set ( CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY ) Additional Information: We could also search in the host paths by passing CMAKE_FIND_ROOT_PATH_BOTH to find_file: find_path(SWIG_DIR swig.swg PATHS ${SWIG_swiglib_output} CMAKE_FIND_ROOT_PATH_BOTH) See the embedded path, tested with and without cross-compilation. Regards, M. == Issue History Date ModifiedUsername FieldChange == 2013-08-14 18:49 Michel Zou New Issue 2013-08-14 18:49 Michel Zou File Added: cmake-swig-cross-compilation.patch == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [CMake] Visual Studio 10 compiler identification unknown
On 2013-08-06 13:09, Jochen Issing wrote: On 2013-08-06 12:19, Jorge Perez wrote: I have the same problem with Win64 + Visual Studio 2010 professional. It works from command line running cmake from /Visual Studio Command Prompt /but I'm not able to configure using the gui even if I start it from the VS command prompt./ / /That's how it started for me - now it is always failing when using Visual Studio 10, but now I can not even find my stdlib headers (e.g. stdio.h) within the Visual Studio 10 installation/ path. I'll keep you updated if I find anything new... So, in the end it was a broken VS2010 installation caused by registry errors maybe caused by installation of a VS preview. I fixed it by copying the files from a working installation onto my machine. Dirty, but works. Thanks for your patience, -- jochen / / // 2013/8/5 Jochen Issing i...@nesono.com mailto:i...@nesono.com On 05.08.2013, at 17:42, Jochen Issing i...@nesono.com mailto:i...@nesono.com wrote: On 05.08.2013, at 17:17, Bill Hoffman bill.hoff...@kitware.com mailto:bill.hoff...@kitware.com wrote: On 8/5/2013 10:32 AM, i...@nesono.com mailto:i...@nesono.com wrote: Hi All, I hope this is not an old and boring question to you, but I did not find any help in the web to the following problem: I try to create a Visual Studio 10 solution on Windows 8 with having Visual Studio being installed alongside Visual Studio 11. Somehow, cmake does not find the right compilers: -- The C compiler identification is unknown -- The CXX compiler identification is unknown ... What is in the CMakeError.log and CMakeOutput.log files? They should be in the CMakeFiles directory. Sorry for not being able to copy paste here, but I have this: C compiler identification failed... The output was: 1 for both CC and CXX and log contains: The system is: Windows - 6.2 - AMD64 -Bill -- Powered by www.kitware.com http://www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake -- Powered by www.kitware.com http://www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake -- Powered by www.kitware.com http://www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For
[CMake] Find modules for SDL2
Hello, I have written find modules for SDL2, SDL2_image and SDL2_net (see attachment). I have tested them on Linux and Windows/MinGW with self-compiled SDL2 libraries. I did neither test with Visual Studio nor on OS X. Feel free to use them if they are helpful for you (they are licensed under the standard license of CMake find modules). My question: Is it good to create new find modules for SDL2, or should the existing SDL find modules be updated to search for SDL2? If existing modules should be used: How to handle the case when both SDL and SDL2 are found? If new modules should be created: Shall I create a topic branch for the new modules and create the missing ones (e.g., SDL2_mixer)? Kind regards Benjamin# - Find SDL2 library and headers # # Find module for SDL 2.0 (http://www.libsdl.org/). # It defines the following variables: # SDL2_INCLUDE_DIRS - The location of the headers, e.g., SDL.h. # SDL2_LIBRARIES - The libraries to link against to use SDL2. # SDL2_FOUND - If false, do not try to use SDL2. # SDL2_VERSION_STRING - Human-readable string containing the version of SDL2. # # This module responds to the the flag: # SDL2_BUILDING_LIBRARY #If this is defined, then no SDL2_main will be linked in because #only applications need main(). #Otherwise, it is assumed you are building an application and this #module will attempt to locate and set the the proper link flags #as part of the returned SDL2_LIBRARIES variable. # # Also defined, but not for general use are: # SDL2_INCLUDE_DIR - The directory that contains SDL.h. # SDL2_LIBRARY - The location of the SDL2 library. # SDL2MAIN_LIBRARY - The location of the SDL2main library. # #= # Copyright 2013 Benjamin Eikel # # Distributed under the OSI-approved BSD License (the License); # see accompanying file Copyright.txt for details. # # This software is distributed WITHOUT ANY WARRANTY; without even the # implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. # See the License for more information. #= # (To distribute this file outside of CMake, substitute the full # License text for the above reference.) find_package(PkgConfig QUIET) pkg_check_modules(PC_SDL2 QUIET sdl2) find_path(SDL2_INCLUDE_DIR NAMES SDL.h HINTS ${PC_SDL2_INCLUDEDIR} ${PC_SDL2_INCLUDE_DIRS} PATH_SUFFIXES SDL2 ) find_library(SDL2_LIBRARY NAMES SDL2 HINTS ${PC_SDL2_LIBDIR} ${PC_SDL2_LIBRARY_DIRS} PATH_SUFFIXES x64 x86 ) if(NOT SDL2_BUILDING_LIBRARY) find_library(SDL2MAIN_LIBRARY NAMES SDL2main HINTS ${PC_SDL2_LIBDIR} ${PC_SDL2_LIBRARY_DIRS} PATH_SUFFIXES x64 x86 ) endif() if(SDL2_INCLUDE_DIR AND EXISTS ${SDL2_INCLUDE_DIR}/SDL_version.h) file(STRINGS ${SDL2_INCLUDE_DIR}/SDL_version.h SDL2_VERSION_MAJOR_LINE REGEX ^#define[ \t]+SDL_MAJOR_VERSION[ \t]+[0-9]+$) file(STRINGS ${SDL2_INCLUDE_DIR}/SDL_version.h SDL2_VERSION_MINOR_LINE REGEX ^#define[ \t]+SDL_MINOR_VERSION[ \t]+[0-9]+$) file(STRINGS ${SDL2_INCLUDE_DIR}/SDL_version.h SDL2_VERSION_PATCH_LINE REGEX ^#define[ \t]+SDL_PATCHLEVEL[ \t]+[0-9]+$) string(REGEX REPLACE ^#define[ \t]+SDL_MAJOR_VERSION[ \t]+([0-9]+)$ \\1 SDL2_VERSION_MAJOR ${SDL2_VERSION_MAJOR_LINE}) string(REGEX REPLACE ^#define[ \t]+SDL_MINOR_VERSION[ \t]+([0-9]+)$ \\1 SDL2_VERSION_MINOR ${SDL2_VERSION_MINOR_LINE}) string(REGEX REPLACE ^#define[ \t]+SDL_PATCHLEVEL[ \t]+([0-9]+)$ \\1 SDL2_VERSION_PATCH ${SDL2_VERSION_PATCH_LINE}) set(SDL2_VERSION_STRING ${SDL2_VERSION_MAJOR}.${SDL2_VERSION_MINOR}.${SDL2_VERSION_PATCH}) unset(SDL2_VERSION_MAJOR_LINE) unset(SDL2_VERSION_MINOR_LINE) unset(SDL2_VERSION_PATCH_LINE) unset(SDL2_VERSION_MAJOR) unset(SDL2_VERSION_MINOR) unset(SDL2_VERSION_PATCH) endif() set(SDL2_INCLUDE_DIRS ${SDL2_INCLUDE_DIR}) set(SDL2_LIBRARIES ${SDL2MAIN_LIBRARY} ${SDL2_LIBRARY}) include(FindPackageHandleStandardArgs) find_package_handle_standard_args(SDL2 REQUIRED_VARS SDL2_INCLUDE_DIR SDL2_LIBRARY VERSION_VAR SDL2_VERSION_STRING) mark_as_advanced(SDL2_INCLUDE_DIR SDL2_LIBRARY) # - Find SDL2_image library and headers # # Find module for SDL_image 2.0 (http://www.libsdl.org/projects/SDL_image/). # It defines the following variables: # SDL2_IMAGE_INCLUDE_DIRS - The location of the headers, e.g., SDL_image.h. # SDL2_IMAGE_LIBRARIES - The libraries to link against to use SDL2_image. # SDL2_IMAGE_FOUND - If false, do not try to use SDL2_image. # SDL2_IMAGE_VERSION_STRING #Human-readable string containing the version of SDL2_image. # # Also defined, but not for general use are: # SDL2_IMAGE_INCLUDE_DIR - The directory that contains SDL_image.h. # SDL2_IMAGE_LIBRARY - The location of the SDL2_image library. # #= #
[CMake] (no subject)
I have tried to compile CMAKE gui using pre built binaries but I keep getting this error and no one so far has been able to help me out. Please please help me in this regard! CMake Warning at /OpenCV2.3/cmake/OpenCVConfig.cmake:153 (message): Found OpenCV 2.4.3 Windows Super Pack but it has not binaries compatible with your configuration. You should manually point CMake variable OpenCV_DIR to your build of OpenCV library. Call Stack (most recent call first): CMakeLists.txt:2 (find_package) CMake Error at CMakeLists.txt:2 (find_package): Found package configuration file: /OpenCV2.3/cmake/OpenCVConfig.cmake but it set OpenCV_FOUND to FALSE so package OpenCV is considered to be NOT FOUND. Configuring incomplete, errors occurred! -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[CMake] Fwd: (no subject)
I did forget the list. Sorry. -- Forwarded message -- From: Eric Noulard eric.noul...@gmail.com Date: 2013/8/14 Subject: Re: [CMake] (no subject) To: Ruqayya Raza ruqayyar...@gmail.com 2013/8/14 Ruqayya Raza ruqayyar...@gmail.com I have tried to compile CMAKE gui using pre built binaries but I keep getting this error and no one so far has been able to help me out. Please please help me in this regard! You seem to be trying to compile OpenCV and not CMake I suggest you ask your question through Open Support mean: http://opencv.org/support.html CMake Warning at /OpenCV2.3/cmake/OpenCVConfig.cmake:153 (message): Found OpenCV 2.4.3 Windows Super Pack but it has not binaries compatible with your configuration. You should manually point CMake variable OpenCV_DIR to your build of OpenCV library. Call Stack (most recent call first): CMakeLists.txt:2 (find_package) CMake Error at CMakeLists.txt:2 (find_package): Found package configuration file: /OpenCV2.3/cmake/OpenCVConfig.cmake but it set OpenCV_FOUND to FALSE so package OpenCV is considered to be NOT FOUND. Configuring incomplete, errors occurred! -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake -- Erk L'élection n'est pas la démocratie -- http://www.le-message.org -- Erk L'élection n'est pas la démocratie -- http://www.le-message.org -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[CMake] FindOpenSSL always uses system libs
If you have a (linux or solaris) system with openssl installed in /usr and a second copy installed elsewhere (e.g., /opt) and you want a cmake project to find the elsewhere version, no matter what you try it finds the system copy. (In other words, OPENSSL_ROOT_DIR has no effect.) Are we missing something or is this a bug in FindOpenSSL? We've tested cmake 2.8.5, 2.8.8, and 2.8.11 without any luck. Thanks, Jeff. Example: jsipek@poseidon:/tmp/ssltest$ cat CMakeLists.txt cmake_minimum_required(VERSION 2.8.5) project(test) find_package(OpenSSL REQUIRED) jsipek@poseidon:/tmp/ssltest$ rm CMakeCache.txt OPENSSL_ROOT_DIR=/tmp/ossl/ cmake . -DOPENSSL_ROOT_DIR=/tmp/ossl/ -- The C compiler identification is GNU 4.6.3 -- The CXX compiler identification is GNU 4.6.3 -- Check for working C compiler: /usr/gnu/bin/gcc -- Check for working C compiler: /usr/gnu/bin/gcc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/gnu/bin/c++ -- Check for working CXX compiler: /usr/gnu/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Found OpenSSL: /usr/lib/libssl.so;/usr/lib/libcrypto.so (found version 0.9.8x) -- Configuring done -- Generating done -- Build files have been written to: /tmp/ssltest jsipek@poseidon:/tmp/ssltest$ find /tmp/ossl/lib/ /tmp/ossl/lib/ /tmp/ossl/lib/engines /tmp/ossl/lib/pkgconfig /tmp/ossl/lib/pkgconfig/libcrypto.pc /tmp/ossl/lib/pkgconfig/libssl.pc /tmp/ossl/lib/pkgconfig/openssl.pc /tmp/ossl/lib/libcrypto.a /tmp/ossl/lib/libssl.a -- mainframe, n.: An obsolete device still used by thousands of obsolete companies serving billions of obsolete customers and making huge obsolete profits for their obsolete shareholders. And this year's run twice as fast as last year's. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] FindOpenSSL always uses system libs
Hi, On Wed, Aug 14, 2013 at 8:06 PM, Josef 'Jeff' Sipek jef...@josefsipek.netwrote: If you have a (linux or solaris) system with openssl installed in /usr and a second copy installed elsewhere (e.g., /opt) and you want a cmake project to find the elsewhere version, no matter what you try it finds the system copy. (In other words, OPENSSL_ROOT_DIR has no effect.) Are we missing something or is this a bug in FindOpenSSL? We've tested cmake 2.8.5, 2.8.8, and 2.8.11 without any luck. Yes this is a bug in the module, on Windows it sets a variable called _OPENSSL_HINTS_AND_PATHS, but on *nix it only sets _OPENSSL_HINTS based on the OPENSSL_ROOT_DIR variable. The code further down that looks for headers and libs only uses _OPENSSL_HINTS_AND_PATHS with the HINTS keyword and nothing else in the file uses _OPENSSL_HINTS. Andreas -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[CMake] syntax error?
Is the following a syntax error? if (NOT(MSVC AND (MSVC_VERSION EQUAL 1600))) ... I'm using cmake from git master as of today and it gives me a warning CMake Warning (dev) in .../CMakeLists.txt: Syntax Warning in cmake code at /.../CMakeLists.txt:309:10 -- Clinton Stimpson Elemental Technologies, Inc Computational Simulation Software, LLC www.csimsoft.com -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[CMake] DeployQt5.cmake
Hi all, tl;dr: DeployQt5.cmake attached, grab, goto ## BUG read, test, report back. I took the DeployQt4.cmake module as a reference and made it work with Qt5. The only real difference is searching for plugins. Previously, FindQt4.cmake would export all known plugins as path type variables in cmake. The new official Qt5 cmake files don't. Instead, they only export known directories for the new Qt5 base modules (Qt5Core, Qt5Widgets, ...) Now, it's working fine for me and my project. Usage is just like Qt4, but I could post my example, if you people are interested. ## BUG There may be bugs. One odd bug that I found is that sometimes already deployed plugins are detected as the main executable, instead of the real executable. This seems to happen when cmake is spawned a second time (i.e. CMakeLists.txt changed or something.) The workaround for now is to ``rm -rf bundle.app make install''. I'll try fixing that once I feel motivated, but as this bug is only happening very rarely and can easily be worked around, as well as me being too lazy, I didn't exactly look into that yet. This module may wash your cat or drown your fish, no warranties whatsoever. ## /BUG Lastly, indentation. It's messed up, I know. I'll also fix that once everything is working and tested. Please report back and post any sort of comments. Best regards, Mihai # - Functions to help assemble a standalone Qt5 executable. # A collection of CMake utility functions useful for deploying # Qt5 executables. # # The following functions are provided by this module: # write_qt5_conf # resolve_qt5_paths # fixup_qt5_executable # install_qt5_plugin_path # install_qt5_plugin # install_qt5_executable # Requires CMake 2.6 or greater because it uses function and # PARENT_SCOPE. Also depends on BundleUtilities.cmake. # # WRITE_QT5_CONF(qt_conf_dir qt_conf_contents) # Writes a qt.conf file with the qt_conf_contents into qt_conf_dir. # # RESOLVE_QT5_PATHS(paths_var [executable_path]) # Loop through paths_var list and if any don't exist resolve them # relative to the executable_path (if supplied) or the CMAKE_INSTALL_PREFIX. # # FIXUP_QT5_EXECUTABLE(executable [qtplugins libs dirs plugins_dir request_qt_conf]) # Copies Qt plugins, writes a Qt configuration file (if needed) and fixes up a # Qt5 executable using BundleUtilities so it is standalone and can be # drag-and-drop copied to another machine as long as all of the system # libraries are compatible. # # executable should point to the executable to be fixed-up. # # qtplugins should contain a list of the names or paths of any Qt plugins # to be installed. # # libs will be passed to BundleUtilities and should be a list of any already # installed plugins, libraries or executables to also be fixed-up. # # dirs will be passed to BundleUtilities and should contain and directories # to be searched to find library dependencies. # # plugins_dir allows an custom plugins directory to be used. # # request_qt_conf will force a qt.conf file to be written even if not needed. # # INSTALL_QT5_PLUGIN_PATH(plugin executable copy installed_plugin_path_var plugins_dir component configurations) # Install (or copy) a resolved plugin to the default plugins directory # (or plugins_dir) relative to executable and store the result in # installed_plugin_path_var. # # If copy is set to TRUE then the plugins will be copied rather than # installed. This is to allow this module to be used at CMake time rather than # install time. # # If component is set then anything installed will use this COMPONENT. # # INSTALL_QT5_PLUGIN(plugin executable copy installed_plugin_path_var plugins_dir component) # Install (or copy) an unresolved plugin to the default plugins directory # (or plugins_dir) relative to executable and store the result in # installed_plugin_path_var. See documentation of INSTALL_QT5_PLUGIN_PATH. # # INSTALL_QT5_EXECUTABLE(executable [qtplugins libs dirs plugins_dir request_qt_conf component]) # Installs Qt plugins, writes a Qt configuration file (if needed) and fixes up # a Qt5 executable using BundleUtilities so it is standalone and can be # drag-and-drop copied to another machine as long as all of the system # libraries are compatible. The executable will be fixed-up at install time. # component is the COMPONENT used for bundle fixup and plugin installation. # See documentation of FIXUP_QT5_BUNDLE. #= # Copyright 2011 Mike McQuaid m...@mikemcquaid.com # Copyright 2013 Mihai Moldovan io...@ionic.de # CMake - Cross Platform Makefile Generator # Copyright 2000-2011 Kitware, Inc., Insight Software Consortium # All rights reserved. # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions # are met: # # * Redistributions of source code must retain the above copyright # notice, this list of conditions and the following disclaimer. # # *
Re: [CMake] syntax error?
I'm using cmake from git master as of today and it gives me a warning CMake Warning (dev) in .../CMakeLists.txt: Syntax Warning in cmake code at /.../CMakeLists.txt:309:10 I do not get an error with this CMakeLists.txt: cmake_minimum_required(VERSION 2.8) project(xyz NONE) message(MSVC='${MSVC}') message(MSVC_VERSION='${MSVC_VERSION}') if (NOT (MSVC AND (MSVC_VERSION EQUAL 1600))) message(true) else() message(false) endif() I tried with 2.8.11.2 and 'nightly' -- does anybody else see a problem with this? Is it possibly something in 'master' that has already been fixed in 'nightly'? However, MSVC is empty unless I remove the NONE from project... HTH, D -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] syntax error?
On Wednesday, August 14, 2013 04:25:10 PM David Cole wrote: I'm using cmake from git master as of today and it gives me a warning CMake Warning (dev) in .../CMakeLists.txt: Syntax Warning in cmake code at /.../CMakeLists.txt:309:10 I do not get an error with this CMakeLists.txt: cmake_minimum_required(VERSION 2.8) project(xyz NONE) message(MSVC='${MSVC}') message(MSVC_VERSION='${MSVC_VERSION}') if (NOT (MSVC AND (MSVC_VERSION EQUAL 1600))) message(true) else() message(false) endif() I tried with 2.8.11.2 and 'nightly' -- does anybody else see a problem with this? Is it possibly something in 'master' that has already been fixed in 'nightly'? However, MSVC is empty unless I remove the NONE from project... HTH, D Ah, you introduced a space after the NOT to silence the warning. I'm not sure why it is picky about that space not being there. -- Clinton Stimpson Elemental Technologies, Inc Computational Simulation Software, LLC www.csimsoft.com -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] Fwd: How to have generated source compiled multiple ways?
On Tue, 2013-08-13 at 00:24 +0200, Eric Noulard wrote: OK, maybe I'm misunderstanding but if the SerializeTarget is considered always out of date because it was defined with add_custom_target() then won't that cause the two libraries to always rebuild, since something they depend on is always out of date? Maybe I'm thinking of it too much like make. This is puzzling but as far as I understand it, since SerializeTarget has no output it cannot trigger the rebuilt of a target (nioether Lib1 nor Lib2), however whenever you need (or ask) to build Lib1 or Lib2 then SerializeTarget has to be executed and consequently the add_custom_command will be if the generated.c file is out of date. OK, I was thinking it was like a .PHONY rule in make, but it looks like it's rather just like a normal empty rule (if it has no commands). That works. Thanks! -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3869-gb7b12bd
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via b7b12bd365f045770f2faae85152e47986753af7 (commit) via 8eb1b5adbbde51406a9187645fe83eea950cf08a (commit) from 6a7367dc1ab8686e080eb990eff887a41b568042 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b7b12bd365f045770f2faae85152e47986753af7 commit b7b12bd365f045770f2faae85152e47986753af7 Merge: 6a7367d 8eb1b5a Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 02:44:00 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 02:44:00 2013 -0400 Merge topic 'cxx11' into next 8eb1b5a CXXFeatures: add means to ignore compiler flag detection in test http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8eb1b5adbbde51406a9187645fe83eea950cf08a commit 8eb1b5adbbde51406a9187645fe83eea950cf08a Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 08:43:31 2013 +0200 Commit: Rolf Eike Beer e...@sf-mail.de CommitDate: Wed Aug 14 08:43:31 2013 +0200 CXXFeatures: add means to ignore compiler flag detection in test diff --git a/Tests/Module/FindCXXFeatures/CMakeLists.txt b/Tests/Module/FindCXXFeatures/CMakeLists.txt index be2df14..d655bbb 100644 --- a/Tests/Module/FindCXXFeatures/CMakeLists.txt +++ b/Tests/Module/FindCXXFeatures/CMakeLists.txt @@ -24,6 +24,7 @@ set(_all_cxx_features unset(_expected_features) unset(_expected_cxx11_flag) unset(_compiler_unknown_features) +unset(_compiler_unknown_flag) if (CMAKE_CXX_COMPILER_ID STREQUAL GNU) # no idea since when this is supported, but it is at least @@ -195,8 +196,10 @@ elseif (CMAKE_CXX_COMPILER_ID STREQUAL HP) long_long) endif () elseif (CMAKE_CXX_COMPILER_ID STREQUAL Clang) +if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 2.1) +set(_expected_cxx11_flag -std=c++0x) +endif () if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 2.9) - set(_expected_cxx11_flag -std=c++0x) list(APPEND _expected_features auto class_override_final @@ -210,8 +213,12 @@ elseif (CMAKE_CXX_COMPILER_ID STREQUAL Clang) static_assert variadic_templates) endif () +if (CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 3.0.0) +# FreeBSD 9.0 and 10.0 both identify as Clang 3.0, but one has -std=c++0x, +# the other has -stc=c++11. +set(_compiler_unknown_flag TRUE) +endif () if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3) - # FIXME: I've seen both :( FreeBSD 9.0 has 0x, 10.0 has 11 set(_expected_cxx11_flag -std=c++11) list(APPEND _expected_features defaulted_functions @@ -225,11 +232,11 @@ elseif (CMAKE_CXX_COMPILER_ID STREQUAL Clang) lambda nullptr) endif () - else () message(STATUS CTEST_FULL_OUTPUT) message(WARNING Your C++ compiler configuration is not in the list of known configurations) set(_compiler_unknown_features TRUE) +set(_compiler_unknown_flag TRUE) endif () find_package(CXXFeatures) @@ -250,9 +257,13 @@ foreach (flag IN LISTS _all_cxx_features) endif () endforeach (flag) -# variables must be expanded here so it still works if both are empty -if (NOT ${CXX11_COMPILER_FLAGS} STREQUAL ${_expected_cxx11_flag} AND NOT _compiler_unknown_features) -message(SEND_ERROR Found C++11 flag '${CXX11_COMPILER_FLAGS}' but expected '${_expected_cxx11_flag}') +# Variables must be expanded here so it still works if both are empty. +if (NOT ${CXX11_COMPILER_FLAGS} STREQUAL ${_expected_cxx11_flag}) +if (_compiler_unknown_flag) +message(WARNINGFound C++11 flag '${CXX11_COMPILER_FLAGS}' but expected '${_expected_cxx11_flag}') +else () +message(SEND_ERROR Found C++11 flag '${CXX11_COMPILER_FLAGS}' but expected '${_expected_cxx11_flag}') +endif () endif () set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${CXX11_COMPILER_FLAGS}) add_executable(FindCXXFeatures cxxfeatures.cxx) --- Summary of changes: Tests/Module/FindCXXFeatures/CMakeLists.txt | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v2.8.11.2-761-g3c61aec
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via 3c61aec95059b908f98cba17610afcfa34575691 (commit) via 36eef302c0b8ecb992c5d4b01562bcaef543b6fc (commit) from 5353165a6c3e63f3144d641230f4e3fbb73c9153 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3c61aec95059b908f98cba17610afcfa34575691 commit 3c61aec95059b908f98cba17610afcfa34575691 Merge: 5353165 36eef30 Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 08:48:14 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 08:48:14 2013 -0400 Merge topic 'fix-genex-segfault' 36eef30 Genex: Fix segfault when parsing ends with parameter expectation. --- Summary of changes: Source/cmGeneratorExpressionParser.cxx | 20 +++- Tests/GeneratorExpression/CMakeLists.txt|2 ++ Tests/GeneratorExpression/check-part3.cmake |2 ++ 3 files changed, 23 insertions(+), 1 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v2.8.11.2-763-gdd29191
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via dd29191ad958e45059a4fe26810ad0f38bc12967 (commit) via d05a9bd1e6fdeed447cb7b18db6b90353831504a (commit) from 3c61aec95059b908f98cba17610afcfa34575691 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dd29191ad958e45059a4fe26810ad0f38bc12967 commit dd29191ad958e45059a4fe26810ad0f38bc12967 Merge: 3c61aec d05a9bd Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 08:48:18 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 08:48:18 2013 -0400 Merge topic 'cygwin-RunCMake-tests' d05a9bd Cygwin: Avoid legacy warnings in RunCMake.* tests --- Summary of changes: Tests/RunCMake/CMP0004/CMP0004-NEW.cmake |2 +- Tests/RunCMake/CMP0004/CMP0004-OLD.cmake |2 +- Tests/RunCMake/CMP0004/CMP0004-policy-genex.cmake |2 +- Tests/RunCMake/CMP0004/CMakeLists.txt |2 +- Tests/RunCMake/CMP0019/CMakeLists.txt |2 +- Tests/RunCMake/CTest/CMakeLists.txt|2 +- Tests/RunCMake/CompatibleInterface/CMakeLists.txt |2 +- Tests/RunCMake/CompilerChange/CMakeLists.txt |2 +- Tests/RunCMake/Configure/CMakeLists.txt|2 +- .../RunCMake/ExportWithoutLanguage/CMakeLists.txt |2 +- Tests/RunCMake/ExternalData/CMakeLists.txt |2 +- Tests/RunCMake/FPHSA/CMakeLists.txt|2 +- Tests/RunCMake/File_Generate/CMakeLists.txt|2 +- Tests/RunCMake/GeneratorExpression/CMakeLists.txt |2 +- Tests/RunCMake/GeneratorToolset/CMakeLists.txt |2 +- Tests/RunCMake/IncompatibleQt/CMakeLists.txt |2 +- Tests/RunCMake/Languages/CMakeLists.txt|2 +- Tests/RunCMake/ObjectLibrary/CMakeLists.txt|2 +- .../PositionIndependentCode/CMakeLists.txt |2 +- .../RunCMake/SolutionGlobalSections/CMakeLists.txt |2 +- Tests/RunCMake/TargetPolicies/CMakeLists.txt |2 +- .../CMakeLists.txt |2 +- Tests/RunCMake/VisibilityPreset/CMakeLists.txt |2 +- Tests/RunCMake/add_dependencies/CMakeLists.txt |2 +- Tests/RunCMake/alias_targets/CMakeLists.txt|2 +- Tests/RunCMake/build_command/CMakeLists.txt|2 +- Tests/RunCMake/find_package/CMakeLists.txt |2 +- .../RunCMake/get_filename_component/CMakeLists.txt |2 +- Tests/RunCMake/if/CMakeLists.txt |2 +- Tests/RunCMake/include/CMakeLists.txt |2 +- Tests/RunCMake/include_directories/CMakeLists.txt |2 +- .../include_external_msproject/CMakeLists.txt |2 +- Tests/RunCMake/list/CMakeLists.txt |2 +- .../RunCMake/target_link_libraries/CMakeLists.txt |2 +- Tests/RunCMake/try_compile/CMakeLists.txt |2 +- Tests/RunCMake/variable_watch/CMakeLists.txt |2 +- 36 files changed, 36 insertions(+), 36 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3875-gb1ddad2
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via b1ddad2f65231591d4506d1259de36a0fee72728 (commit) via 07c16eece543523ea775efae749f93c3b6b892b5 (commit) from ec8b23207d6d50492c86fac3a41dffc93a0ff052 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b1ddad2f65231591d4506d1259de36a0fee72728 commit b1ddad2f65231591d4506d1259de36a0fee72728 Merge: ec8b232 07c16ee Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 09:51:47 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 09:51:47 2013 -0400 Merge topic 'fix-new-policy-versions' into next 07c16ee Update version introducing CMP0021, CMP0022, and CMP0023 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eece543523ea775efae749f93c3b6b892b5 commit 07c16eece543523ea775efae749f93c3b6b892b5 Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 09:44:00 2013 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Wed Aug 14 09:44:00 2013 -0400 Update version introducing CMP0021, CMP0022, and CMP0023 These policies will be first released in 2.8.12. diff --git a/Source/cmPolicies.cxx b/Source/cmPolicies.cxx index 0ba673e..a823f05 100644 --- a/Source/cmPolicies.cxx +++ b/Source/cmPolicies.cxx @@ -543,7 +543,7 @@ cmPolicies::cmPolicies() the INCLUDE_DIRECTORIES target property. The NEW behavior for this policy is to issue a FATAL_ERROR if INCLUDE_DIRECTORIES contains a relative path., -2,8,11,20130516, cmPolicies::WARN); +2,8,12,0, cmPolicies::WARN); this-DefinePolicy( CMP0022, CMP0022, @@ -574,7 +574,7 @@ cmPolicies::cmPolicies() The NEW behavior for this policy is to use the INTERFACE_LINK_LIBRARIES property for in-build targets, and ignore the old properties matching (IMPORTED_)?LINK_INTERFACE_LIBRARIES(_CONFIG)?., -2,8,11,20130516, cmPolicies::WARN); +2,8,12,0, cmPolicies::WARN); this-DefinePolicy( CMP0023, CMP0023, @@ -600,7 +600,7 @@ cmPolicies::cmPolicies() target_link_libraries signatures to be mixed. The NEW behavior for this policy is to not to allow mixing of the keyword and plain signatures., -2,8,11,20130724, cmPolicies::WARN); +2,8,12,0, cmPolicies::WARN); } cmPolicies::~cmPolicies() --- Summary of changes: Source/cmPolicies.cxx |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v2.8.11.2-765-gd7c1dfb
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via d7c1dfb8f88d45d3d91bee0fbb21829d02ae43c2 (commit) via 07c16eece543523ea775efae749f93c3b6b892b5 (commit) from dd29191ad958e45059a4fe26810ad0f38bc12967 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d7c1dfb8f88d45d3d91bee0fbb21829d02ae43c2 commit d7c1dfb8f88d45d3d91bee0fbb21829d02ae43c2 Merge: dd29191 07c16ee Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 11:20:44 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 11:20:44 2013 -0400 Merge topic 'fix-new-policy-versions' 07c16ee Update version introducing CMP0021, CMP0022, and CMP0023 --- Summary of changes: Source/cmPolicies.cxx |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3877-g2470c74
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 2470c74a479aa4fb41f31db3c27cc0fb9330b3dc (commit) via d7c1dfb8f88d45d3d91bee0fbb21829d02ae43c2 (commit) from b1ddad2f65231591d4506d1259de36a0fee72728 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2470c74a479aa4fb41f31db3c27cc0fb9330b3dc commit 2470c74a479aa4fb41f31db3c27cc0fb9330b3dc Merge: b1ddad2 d7c1dfb Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 11:20:00 2013 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Wed Aug 14 11:20:00 2013 -0400 Merge branch 'master' into next --- Summary of changes: hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3880-ge6ccd6d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via e6ccd6d772f294cf80775e7abbb4afda07de (commit) via 51ce1aeba8bced872731e51b8911b97d08b2f5f7 (commit) via cabd6f87c048c5c63a5145652729606ec36612da (commit) from 2470c74a479aa4fb41f31db3c27cc0fb9330b3dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e6ccd6d772f294cf80775e7abbb4afda07de commit e6ccd6d772f294cf80775e7abbb4afda07de Merge: 2470c74 51ce1ae Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 13:55:30 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 13:55:30 2013 -0400 Merge topic 'cxx11' into next 51ce1ae CXXFeatures: check for /Qstd=c++11 only with Intel on Windows cabd6f8 CXXFeatures: log check outputs to CMake(Output|Error).log http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=51ce1aeba8bced872731e51b8911b97d08b2f5f7 commit 51ce1aeba8bced872731e51b8911b97d08b2f5f7 Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 13:41:59 2013 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Wed Aug 14 13:42:04 2013 -0400 CXXFeatures: check for /Qstd=c++11 only with Intel on Windows The WIN32 condition is true for GNU compilers built for MinGW so narrow the condition to work only for the Intel compiler. diff --git a/Modules/FindCXXFeatures.cmake b/Modules/FindCXXFeatures.cmake index 0f2fb9d..70a7deb 100644 --- a/Modules/FindCXXFeatures.cmake +++ b/Modules/FindCXXFeatures.cmake @@ -59,7 +59,7 @@ elseif (CMAKE_CXX_COMPILER_ID MATCHES (Borland|Watcom)) # No C++11 flag for those compilers, but check_cxx_compiler_flag() # can't detect because they either will not always complain (Borland) # or will hang (Watcom). -elseif (WIN32) +elseif (CMAKE_CXX_COMPILER_ID STREQUAL Intel AND WIN32) # The Intel compiler on Windows may use these flags. test_set_flag(/Qstd=c++11 CXX11) if (NOT CXX11_COMPILER_FLAGS) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cabd6f87c048c5c63a5145652729606ec36612da commit cabd6f87c048c5c63a5145652729606ec36612da Author: Brad King brad.k...@kitware.com AuthorDate: Wed Aug 14 13:39:08 2013 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Wed Aug 14 13:39:08 2013 -0400 CXXFeatures: log check outputs to CMake(Output|Error).log diff --git a/Modules/FindCXXFeatures.cmake b/Modules/FindCXXFeatures.cmake index 294e19a..0f2fb9d 100644 --- a/Modules/FindCXXFeatures.cmake +++ b/Modules/FindCXXFeatures.cmake @@ -88,11 +88,13 @@ function(cxx_check_feature FEATURE_NAME) set(_SRCFILE_FAIL_COMPILE ${_SRCFILE_BASE}_fail_compile.cxx) try_compile(${RESULT_VAR} ${_bindir} ${_SRCFILE} -COMPILE_DEFINITIONS ${CXX11_COMPILER_FLAGS}) +COMPILE_DEFINITIONS ${CXX11_COMPILER_FLAGS} +OUTPUT_VARIABLE _SRCFILE_COMPILE_PASS_OUTPUT) if (${RESULT_VAR} AND EXISTS ${_SRCFILE_FAIL_COMPILE}) try_compile(_TMP_RESULT ${_bindir}_fail_compile ${_SRCFILE_FAIL_COMPILE} -COMPILE_DEFINITIONS ${CXX11_COMPILER_FLAGS}) +COMPILE_DEFINITIONS ${CXX11_COMPILER_FLAGS} +OUTPUT_VARIABLE _SRCFILE_COMPILE_FAIL_OUTPUT) if (_TMP_RESULT) set(${RESULT_VAR} FALSE) else () @@ -102,8 +104,16 @@ function(cxx_check_feature FEATURE_NAME) if (${RESULT_VAR}) message(STATUS Checking C++ support for ${_LOG_NAME}: works) +file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log + Checking C++ support for ${_LOG_NAME} passed.\n + Compile pass output:\n${_SRCFILE_COMPILE_PASS_OUTPUT}\n + Compile fail output:\n${_SRCFILE_COMPILE_FAIL_OUTPUT}\n) else () message(STATUS Checking C++ support for ${_LOG_NAME}: not supported) +file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log + Checking C++ support for ${_LOG_NAME} failed.\n + Compile pass output:\n${_SRCFILE_COMPILE_PASS_OUTPUT}\n + Compile fail output:\n${_SRCFILE_COMPILE_FAIL_OUTPUT}\n) endif () set(${RESULT_VAR} ${${RESULT_VAR}} CACHE INTERNAL C++ support for ${_LOG_NAME}) endfunction(cxx_check_feature) --- Summary of changes: Modules/FindCXXFeatures.cmake | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3882-g54ccc95
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 54ccc9526e2478a751d0efe654d4148425401948 (commit) via 2a7fecc4097708bf2bd5c4d712dca8da2495dbdc (commit) from e6ccd6d772f294cf80775e7abbb4afda07de (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=54ccc9526e2478a751d0efe654d4148425401948 commit 54ccc9526e2478a751d0efe654d4148425401948 Merge: e6ccd6d 2a7fecc Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 14:30:11 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 14:30:11 2013 -0400 Merge topic 'remove-local-typedef' into next 2a7fecc remove unused local typedef http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2a7fecc4097708bf2bd5c4d712dca8da2495dbdc commit 2a7fecc4097708bf2bd5c4d712dca8da2495dbdc Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 20:28:28 2013 +0200 Commit: Rolf Eike Beer e...@sf-mail.de CommitDate: Wed Aug 14 20:28:28 2013 +0200 remove unused local typedef Fixes this warning from g++ 4.8: CMake/Source/cmDocumentation.cxx:835:23: warning: typedef 'sdoc_t' locally defined but not used [-Wunused-local-typedefs] SDOC_UNKNOWN} sdoc_t; ^ diff --git a/Source/cmDocumentation.cxx b/Source/cmDocumentation.cxx index 4edacbb..b19d847 100644 --- a/Source/cmDocumentation.cxx +++ b/Source/cmDocumentation.cxx @@ -829,10 +829,10 @@ int cmDocumentation::GetStructuredDocFromFile( std::vectorcmDocumentationEntry commands, cmake* cm) { -typedef enum sdoce { +enum sdoce { SDOC_NONE, SDOC_MODULE, SDOC_MACRO, SDOC_FUNCTION, SDOC_VARIABLE, SDOC_SECTION, -SDOC_UNKNOWN} sdoc_t; +SDOC_UNKNOWN}; int nbDocItemFound = 0; int docCtxIdx = 0; std::vectorint docContextStack(60); --- Summary of changes: Source/cmDocumentation.cxx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3884-g4453820
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 44538208d95136ca2562f997601ab2c05b503168 (commit) via 3ec4446af4f0cc1b7525d5b9a8e8c14277422e06 (commit) from 54ccc9526e2478a751d0efe654d4148425401948 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=44538208d95136ca2562f997601ab2c05b503168 commit 44538208d95136ca2562f997601ab2c05b503168 Merge: 54ccc95 3ec4446 Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 16:42:31 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 16:42:31 2013 -0400 Merge topic 'cxx11' into next 3ec4446 CXXFeatures: include compiler log when test fails http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3ec4446af4f0cc1b7525d5b9a8e8c14277422e06 commit 3ec4446af4f0cc1b7525d5b9a8e8c14277422e06 Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 22:42:11 2013 +0200 Commit: Rolf Eike Beer e...@sf-mail.de CommitDate: Wed Aug 14 22:42:11 2013 +0200 CXXFeatures: include compiler log when test fails diff --git a/Tests/Module/FindCXXFeatures/CMakeLists.txt b/Tests/Module/FindCXXFeatures/CMakeLists.txt index d655bbb..e70bfdd 100644 --- a/Tests/Module/FindCXXFeatures/CMakeLists.txt +++ b/Tests/Module/FindCXXFeatures/CMakeLists.txt @@ -241,6 +241,8 @@ endif () find_package(CXXFeatures) +unset(_send_logs) + foreach (flag IN LISTS _all_cxx_features) list(FIND _expected_features ${flag} _flag_index) set(_full_flag CXXFeatures_${flag}_FOUND) @@ -253,6 +255,7 @@ foreach (flag IN LISTS _all_cxx_features) else () if (NOT _flag_index EQUAL -1) message(SEND_ERROR Expected C++ feature '${flag}' not detected) +set(_send_logs TRUE) endif () endif () endforeach (flag) @@ -263,6 +266,7 @@ if (NOT ${CXX11_COMPILER_FLAGS} STREQUAL ${_expected_cxx11_flag}) message(WARNINGFound C++11 flag '${CXX11_COMPILER_FLAGS}' but expected '${_expected_cxx11_flag}') else () message(SEND_ERROR Found C++11 flag '${CXX11_COMPILER_FLAGS}' but expected '${_expected_cxx11_flag}') +set(_send_logs TRUE) endif () endif () set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${CXX11_COMPILER_FLAGS}) @@ -272,3 +276,14 @@ enable_testing() if (NOT CROSS_COMPILING) add_test(NAME FindCXXFeatures COMMAND FindCXXFeatures) endif () + +if (_send_logs) +if (EXISTS ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log) +file(READ ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log _output_log) +message(STATUS -=-=-= Compiler output log:\n${_output_log}\n) +endif () +if (EXISTS ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log) +file(READ ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log _error_log) +message(STATUS -=-=-= Compiler error log:\n${_error_log}\n) +endif () +endif () --- Summary of changes: Tests/Module/FindCXXFeatures/CMakeLists.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3886-gf61423a
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via f61423ae410adaf8b21852449ec59f04887465a4 (commit) via b3c778a4a69a3d9c61861ccc82171687857c1c07 (commit) from 44538208d95136ca2562f997601ab2c05b503168 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f61423ae410adaf8b21852449ec59f04887465a4 commit f61423ae410adaf8b21852449ec59f04887465a4 Merge: 4453820 b3c778a Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 16:48:51 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 16:48:51 2013 -0400 Merge topic 'cxx11' into next b3c778a CXXFeatures: allow C++11 flag to be vary if compiler has unexpected features http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b3c778a4a69a3d9c61861ccc82171687857c1c07 commit b3c778a4a69a3d9c61861ccc82171687857c1c07 Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 22:47:47 2013 +0200 Commit: Rolf Eike Beer e...@sf-mail.de CommitDate: Wed Aug 14 22:47:47 2013 +0200 CXXFeatures: allow C++11 flag to be vary if compiler has unexpected features This is especially useful for Clang or the Clang g++ plugin. diff --git a/Tests/Module/FindCXXFeatures/CMakeLists.txt b/Tests/Module/FindCXXFeatures/CMakeLists.txt index e70bfdd..ea346ba 100644 --- a/Tests/Module/FindCXXFeatures/CMakeLists.txt +++ b/Tests/Module/FindCXXFeatures/CMakeLists.txt @@ -251,6 +251,7 @@ foreach (flag IN LISTS _all_cxx_features) message(STATUS Compiler C++ support flag ${_full_flag} set) if (_flag_index EQUAL -1 AND NOT _compiler_unknown_features) message(WARNING C++ feature '${flag}' was detected, but not expected) +set(_compiler_unknown_flag) endif () else () if (NOT _flag_index EQUAL -1) --- Summary of changes: Tests/Module/FindCXXFeatures/CMakeLists.txt |1 + 1 files changed, 1 insertions(+), 0 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.11.2-3888-gd67a550
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via d67a550dbe04d29aade5d5ecf4d92bd5ab91e6c7 (commit) via 9dad4759708aea82c479457e3a499259af8b8b2a (commit) from f61423ae410adaf8b21852449ec59f04887465a4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d67a550dbe04d29aade5d5ecf4d92bd5ab91e6c7 commit d67a550dbe04d29aade5d5ecf4d92bd5ab91e6c7 Merge: f61423a 9dad475 Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 16:53:07 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Wed Aug 14 16:53:07 2013 -0400 Merge topic 'cxx11' into next 9dad475 CXXFeatures: try to prevent failure with g++ 2.9 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9dad4759708aea82c479457e3a499259af8b8b2a commit 9dad4759708aea82c479457e3a499259af8b8b2a Author: Rolf Eike Beer e...@sf-mail.de AuthorDate: Wed Aug 14 22:52:47 2013 +0200 Commit: Rolf Eike Beer e...@sf-mail.de CommitDate: Wed Aug 14 22:52:47 2013 +0200 CXXFeatures: try to prevent failure with g++ 2.9 diff --git a/Tests/Module/FindCXXFeatures/CMakeLists.txt b/Tests/Module/FindCXXFeatures/CMakeLists.txt index ea346ba..7f03457 100644 --- a/Tests/Module/FindCXXFeatures/CMakeLists.txt +++ b/Tests/Module/FindCXXFeatures/CMakeLists.txt @@ -65,6 +65,11 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL GNU) static_assert variadic_templates) endif () +# At least on one AIX dashboard machine the detection fails with +# gcc 2.9, looks like that didn't properly detect the flags. +if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3) +set(_compiler_unknown_flag) +endif () elseif (CMAKE_CXX_COMPILER_ID STREQUAL MSVC) if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 17) list(APPEND _expected_features --- Summary of changes: Tests/Module/FindCXXFeatures/CMakeLists.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v2.8.11.2-766-gb4e5ba1
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via b4e5ba171705eeedca0fc14150226303e2069942 (commit) from d7c1dfb8f88d45d3d91bee0fbb21829d02ae43c2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b4e5ba171705eeedca0fc14150226303e2069942 commit b4e5ba171705eeedca0fc14150226303e2069942 Author: Kitware Robot kwro...@kitware.com AuthorDate: Thu Aug 15 00:01:05 2013 -0400 Commit: Kitware Robot kwro...@kitware.com CommitDate: Thu Aug 15 00:01:05 2013 -0400 CMake Nightly Date Stamp diff --git a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake index 582079a..b9a95ee 100644 --- a/Source/CMakeVersion.cmake +++ b/Source/CMakeVersion.cmake @@ -2,5 +2,5 @@ set(CMake_VERSION_MAJOR 2) set(CMake_VERSION_MINOR 8) set(CMake_VERSION_PATCH 11) -set(CMake_VERSION_TWEAK 20130814) +set(CMake_VERSION_TWEAK 20130815) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits