[Cmake-commits] CMake branch, master, updated. v3.6.1-504-g55d9bfa

2016-08-01 Thread Kitware Robot 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  55d9bfa9dd42912432eea3297507187084a7d154 (commit)
  from  5f99e61cadada755ad8c19ec1f114079c660b400 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=55d9bfa9dd42912432eea3297507187084a7d154
commit 55d9bfa9dd42912432eea3297507187084a7d154
Author: Kitware Robot <kwro...@kitware.com>
AuthorDate: Tue Aug 2 00:01:04 2016 -0400
Commit: Kitware Robot <kwro...@kitware.com>
CommitDate: Tue Aug 2 00:01:04 2016 -0400

CMake Nightly Date Stamp

diff --git a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake
index 8e548e5..f203b3c 100644
--- a/Source/CMakeVersion.cmake
+++ b/Source/CMakeVersion.cmake
@@ -1,5 +1,5 @@
 # CMake version number components.
 set(CMake_VERSION_MAJOR 3)
 set(CMake_VERSION_MINOR 6)
-set(CMake_VERSION_PATCH 20160801)
+set(CMake_VERSION_PATCH 20160802)
 #set(CMake_VERSION_RC 1)

---

Summary of changes:
 Source/CMakeVersion.cmake |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[cmake-developers] Problem with openCV with CUDA installation using CMAKE on PASCAL Architecture

2016-08-01 Thread 마수드 
Hello

  First of all I apologize for the quality of my English as I am not a native 
speaker. It is not actually my first time facing this problem and I am really 
tired of searching for it on blogs this time.
I have had a graphic card with MAXWEll architecture (listed in CUDA enabled 
cards on INVidia list) and could not generate the files without errors using 
CMAKE. I gave up then and used an older card with KEPLER architecture.
That time, opencv with CUDA was successfully generated by CMAKE and was easily 
compiled with Visual C++ 2012 . I had no problem using OPENCV libraries for GPU.
Now, I am back to the same problem for some reasons and have to use a newer 
card (GEFORCE GTX 1070, CUDA enabled) which is a graphic card with PASCAL 
architecture and I cannot find it  where CUDA generation options are listed in 
CMAKE 3.6.1.
Once, I did not change any parameters including CUDA_ARCH_BIN 1.0 2.0 , so on 
and could successfully generate without errors selecting  KEPLER option, it is 
a PASCAL architecture though. I could even successfully re-build opencv files 
from generated files by CMAKE. However GPU functions were not working and I 
faced this error : “OpenCV Error : Gpu API call (Invalid device symbol) in 
unknown function”. I searched a lot online and felt that PASCAL Architecture 
and KEPLER are not the same that such an error shows up. FYI, I have 
successfully done devicequery function on my PC now which confirms the 
successful installation of CUDA  toolkit and required files here.
In another effort, I tried to manually change the default values listed for 
CUDA_ARCH_BIN and wrote only 6.0 6.1 6.2 6.3 and repeated them for 
CUDA_ARCH_PTX. I left CUDA generation empty and received many warnings ,not 
errors. I tried to rebuild those CMAKE generated files in Visual C and got many 
failures consequently.

Kindly let me know what to do so that I can get the right cmake files generated 
for PASCAL architecture only.

Looking forward to hearing from you,
Masoud
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [CMake] FindLibXml2.cmake: rename "LIBXML2_DEFINITIONS"

2016-08-01 Thread Yaron Cohen-Tal 
Ok, looking at other "FindXXX.cmake" modules I see that you're right, it
indeed always denotes what should be added to the "COMPILE_FLAGS" target
property, rather than "COMPILE_DEFINITIONS" property. I understand if u
don't want to rename it coz it'll break current usage, but just wanna note,
it's very confusing and I bet we're not the only ones who use it wrong (I
mean not only with libxml2 of course, but in general).

Thanx.

On Mon, Aug 1, 2016 at 7:08 PM, Chuck Atkins 
wrote:

> Hi Yaron,
>
>
> I think it should b renamed to "LIBXML2_COMPILE_FLAGS".
>>
>
> Xxx_DEFINITIONS is one of the standard variable names for a given
> FindXxx.cmake find module, see
> https://cmake.org/cmake/help/v3.6/manual/cmake-developer.7.html#standard-variable-names
> .
>
>
>
>> If u wish, I can submit a patch.
>>
>
> Thank you for the enthusiasm!   If you would like to improve on the
> FindLibXML2 module, which really hasn't been touched in several years aside
> from formatting changes, rather than mess with the varible names I would
> instead suggest you look at creating an imported target for what get's
> found.  That would certainly help bring the find module up to more modern
> CMake conventions and would be greatly appreciated!
>
> - Chuck
>
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

[Cmake-commits] CMake branch, next, updated. v3.6.1-1025-g62452bb

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  62452bbd410a93493f9d6d5f668a5f4a3062d941 (commit)
   via  bdd9b1c73c8c43e45561a000cb9f5c61349528b7 (commit)
  from  5b6200ee7c0c1b5930fb8b40f544b9611c43a35e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=62452bbd410a93493f9d6d5f668a5f4a3062d941
commit 62452bbd410a93493f9d6d5f668a5f4a3062d941
Merge: 5b6200e bdd9b1c
Author: Brad King 
AuthorDate: Mon Aug 1 15:30:04 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 15:30:04 2016 -0400

Merge topic 'doc-CMAKE_INSTALL_PREFIX-default' into next

bdd9b1c7 Help: Fix CMAKE_INSTALL_PREFIX documented default on Windows


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bdd9b1c73c8c43e45561a000cb9f5c61349528b7
commit bdd9b1c73c8c43e45561a000cb9f5c61349528b7
Author: Brad King 
AuthorDate: Mon Aug 1 15:28:14 2016 -0400
Commit: Brad King 
CommitDate: Mon Aug 1 15:29:11 2016 -0400

Help: Fix CMAKE_INSTALL_PREFIX documented default on Windows

Fixes #16211.

diff --git a/Help/variable/CMAKE_INSTALL_PREFIX.rst 
b/Help/variable/CMAKE_INSTALL_PREFIX.rst
index 3f3347f..86f1944 100644
--- a/Help/variable/CMAKE_INSTALL_PREFIX.rst
+++ b/Help/variable/CMAKE_INSTALL_PREFIX.rst
@@ -5,7 +5,7 @@ Install directory used by :command:`install`.
 
 If ``make install`` is invoked or ``INSTALL`` is built, this directory is
 prepended onto all install directories.  This variable defaults to
-``/usr/local`` on UNIX and ``c:/Program Files`` on Windows.
+``/usr/local`` on UNIX and ``c:/Program Files/${PROJECT_NAME}`` on Windows.
 
 On UNIX one can use the ``DESTDIR`` mechanism in order to relocate the
 whole installation.  ``DESTDIR`` means DESTination DIRectory.  It is

---

Summary of changes:
 Help/variable/CMAKE_INSTALL_PREFIX.rst |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

Re: [CMake] Ninja generator bug when handling Windows .dll without associated import .lib

2016-08-01 Thread Brad King 
On 07/21/2016 12:27 PM, Kamen Lilov wrote:
> When a Windows .DLL is generated, the Microsoft linker may sometimes
> decide that no import library needs to be built. This happens often in
> one of our projects, we have many .dll’s that tie themselves into our
> infrastructure during static class initialization and export no
> functions (although they do work and get called via class method
> pointers from elsewhere)
> 
> The Ninja CMake generator seems to always emit a dependency on an
> associated import library along with the .dll file.

That output needs to be listed or it will not be re-built when missing.

The way to tell CMake to build a .dll with no .lib is to specify the
add_library command's MODULE library type.  This specifies that it is
a loaded module and not something that is linked.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

[Cmake-commits] CMake branch, next, updated. v3.6.1-1023-g5b6200e

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  5b6200ee7c0c1b5930fb8b40f544b9611c43a35e (commit)
   via  5f99e61cadada755ad8c19ec1f114079c660b400 (commit)
  from  91237c3208e4bccd1f587d639c3540146e6d0505 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5b6200ee7c0c1b5930fb8b40f544b9611c43a35e
commit 5b6200ee7c0c1b5930fb8b40f544b9611c43a35e
Merge: 91237c3 5f99e61
Author: Brad King 
AuthorDate: Mon Aug 1 15:16:03 2016 -0400
Commit: Brad King 
CommitDate: Mon Aug 1 15:16:03 2016 -0400

Merge branch 'master' into next


---

Summary of changes:


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, master, updated. v3.6.1-503-g5f99e61

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  5f99e61cadada755ad8c19ec1f114079c660b400 (commit)
   via  82388543d2b7984fb98583817a3683f789c84cdd (commit)
   via  ca684ccb467d35cbebf7374746509788a5eb917d (commit)
  from  b1cd292335d4d760d2bbd5062e21fdb6d24fcbd8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5f99e61cadada755ad8c19ec1f114079c660b400
commit 5f99e61cadada755ad8c19ec1f114079c660b400
Merge: b1cd292 8238854
Author: Brad King 
AuthorDate: Mon Aug 1 15:15:39 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 15:15:39 2016 -0400

Merge topic 'emacs-mode-compilation-warning'

82388543 cmake-mode.el: Replace use of obsolete function (since Emacs 24.3).
ca684ccb cmake-mode.el: Fix byte-compilation warnings.


---

Summary of changes:
 Auxiliary/cmake-mode.el |   17 +
 1 file changed, 9 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1021-g91237c3

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  91237c3208e4bccd1f587d639c3540146e6d0505 (commit)
   via  82388543d2b7984fb98583817a3683f789c84cdd (commit)
  from  b76fd38ba8d4718faa0e0766823bbaefaa3af5c5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=91237c3208e4bccd1f587d639c3540146e6d0505
commit 91237c3208e4bccd1f587d639c3540146e6d0505
Merge: b76fd38 8238854
Author: Brad King 
AuthorDate: Mon Aug 1 15:14:07 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 15:14:07 2016 -0400

Merge topic 'emacs-mode-compilation-warning' into next

82388543 cmake-mode.el: Replace use of obsolete function (since Emacs 24.3).


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=82388543d2b7984fb98583817a3683f789c84cdd
commit 82388543d2b7984fb98583817a3683f789c84cdd
Author: Jostein Kjønigsen 
AuthorDate: Mon Jul 25 10:13:38 2016 +0200
Commit: Brad King 
CommitDate: Mon Aug 1 15:13:43 2016 -0400

cmake-mode.el: Replace use of obsolete function (since Emacs 24.3).

diff --git a/Auxiliary/cmake-mode.el b/Auxiliary/cmake-mode.el
index b35d369..f29b59b 100644
--- a/Auxiliary/cmake-mode.el
+++ b/Auxiliary/cmake-mode.el
@@ -271,7 +271,7 @@ optional argument topic will be appended to the argument 
list."
 (save-selected-window
   (select-window (display-buffer buffer 'not-this-window))
   (cmake-mode)
-  (toggle-read-only t))
+  (read-only-mode 1))
 )
   )
 

---

Summary of changes:


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1019-gb76fd38

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  b76fd38ba8d4718faa0e0766823bbaefaa3af5c5 (commit)
   via  b8ef638e8d7bccb3109e87770f9ac6a4b3482726 (commit)
   via  ca684ccb467d35cbebf7374746509788a5eb917d (commit)
  from  55ac87c6778b86f37338db13a2acbf052fc7c8e4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b76fd38ba8d4718faa0e0766823bbaefaa3af5c5
commit b76fd38ba8d4718faa0e0766823bbaefaa3af5c5
Merge: 55ac87c b8ef638
Author: Brad King 
AuthorDate: Mon Aug 1 15:13:31 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 15:13:31 2016 -0400

Merge topic 'emacs-mode-compilation-warning' into next

b8ef638e cmake-model.el: Replace use of obsolete function (since Emacs 
24.3).
ca684ccb cmake-mode.el: Fix byte-compilation warnings.


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b8ef638e8d7bccb3109e87770f9ac6a4b3482726
commit b8ef638e8d7bccb3109e87770f9ac6a4b3482726
Author: Jostein Kjønigsen 
AuthorDate: Mon Jul 25 10:13:38 2016 +0200
Commit: Jostein Kjønigsen 
CommitDate: Tue Jul 26 14:41:02 2016 +0200

cmake-model.el: Replace use of obsolete function (since Emacs 24.3).

diff --git a/Auxiliary/cmake-mode.el b/Auxiliary/cmake-mode.el
index b35d369..f29b59b 100644
--- a/Auxiliary/cmake-mode.el
+++ b/Auxiliary/cmake-mode.el
@@ -271,7 +271,7 @@ optional argument topic will be appended to the argument 
list."
 (save-selected-window
   (select-window (display-buffer buffer 'not-this-window))
   (cmake-mode)
-  (toggle-read-only t))
+  (read-only-mode 1))
 )
   )
 

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ca684ccb467d35cbebf7374746509788a5eb917d
commit ca684ccb467d35cbebf7374746509788a5eb917d
Author: Jostein Kjønigsen 
AuthorDate: Mon Jul 25 09:56:49 2016 +0200
Commit: Jostein Kjønigsen 
CommitDate: Tue Jul 26 14:41:02 2016 +0200

cmake-mode.el: Fix byte-compilation warnings.

diff --git a/Auxiliary/cmake-mode.el b/Auxiliary/cmake-mode.el
index 20def8b..b35d369 100644
--- a/Auxiliary/cmake-mode.el
+++ b/Auxiliary/cmake-mode.el
@@ -114,6 +114,14 @@ set the path with these commands:
 ;--
 
 ;;
+;; Indentation increment.
+;;
+(defcustom cmake-tab-width 2
+  "Number of columns to indent cmake blocks"
+  :type 'integer
+  :group 'cmake)
+
+;;
 ;; Line indentation function.
 ;;
 (defun cmake-indent ()
@@ -225,13 +233,6 @@ the indentation.  Otherwise it retains the same position 
on the line"
 ;;
 (defvar cmake-mode-hook nil)
 
-;;
-;; Indentation increment.
-;;
-(defcustom cmake-tab-width 2
-  "Number of columns to indent cmake blocks"
-  :type 'integer)
-
 ;--
 
 ;; For compatibility with Emacs < 24

---

Summary of changes:
 Auxiliary/cmake-mode.el |   17 +
 1 file changed, 9 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

Re: [cmake-developers] [PATCH] Fix FindOpenCL on Mac OS

2016-08-01 Thread jerry . c . t 
Hi,

> The version is not listed as a required variable, so that's why it
> passes through. If you pass in a version into your find_package call, it
> should bail out if no version is specified.
Sadly not. The current version in master does not fail when invoked with 
"find_package(OpenCL 1.2 REQUIRED)". My first email shows exactly the 
output. You see that it says "Required is at least version "1.2""
while also saying "Found OpenCL:..." while also no version was found. The
patch now fails if invoked for example with find_package(OpenCL 2.0 REQUIRED).
It seems that find_package_handle_standard does not work as expected when
OpenCL_VERSION_STRING is empty.

> I assume this was from testing, not
> because that changed something on macOS?
You are right _DIR and _DIRS are working.
I think I only changed it because for example FindGLUT uses it, for the 
library the singular variant LIBRARY is used and I
don't understand the difference of _DIR and _DIRS :)

Jerry 

On 01.08.2016 14:32, Matthäus G. Chajdas wrote:
> Hi Jerry,
> 
> thanks for giving it a spin :)
> 
> I don't have a Mac to test myself - as your changes are confined to
> macOS, they look safe to me.
> 
> The version is not listed as a required variable, so that's why it
> passes through. If you pass in a version into your find_package call, it
> should bail out if no version is specified.
> 
> I only got one minor nit-pick: Why did you change the line
> INTERFACE_INCLUDE_DIRECTORIES "${OpenCL_INCLUDE_DIR}")
> to use _DIR instead of _DIRS? I assume this was from testing, not
> because that changed something on macOS?
> 
> Other than that, the patch looks good to me. I'll apply it this week.
> 
> Cheers,
>   Matthäus
> 
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.6.1-1016-g55ac87c

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  55ac87c6778b86f37338db13a2acbf052fc7c8e4 (commit)
   via  b1cd292335d4d760d2bbd5062e21fdb6d24fcbd8 (commit)
  from  7140cb5ba763f473ac0717b4dd080337916259e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=55ac87c6778b86f37338db13a2acbf052fc7c8e4
commit 55ac87c6778b86f37338db13a2acbf052fc7c8e4
Merge: 7140cb5 b1cd292
Author: Brad King 
AuthorDate: Mon Aug 1 15:04:47 2016 -0400
Commit: Brad King 
CommitDate: Mon Aug 1 15:04:47 2016 -0400

Merge branch 'master' into next


---

Summary of changes:


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, master, updated. v3.6.1-500-gb1cd292

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  b1cd292335d4d760d2bbd5062e21fdb6d24fcbd8 (commit)
   via  cd7ed47c4ad5b9c2c7539a6f77bbe11a8510a718 (commit)
   via  bca8be583eda435202f7a0eb6e288646ce70570f (commit)
   via  7decbe8ffb66a1a02b9ffab027f33558fa36873a (commit)
   via  2b57b139201f7fa1959702db0a8c18482452f903 (commit)
   via  8ac4e2cfa283d6a27ba11c9ce6e2cea44457b5cb (commit)
   via  3b3bd880a3de1d6348d746c15b6bc3b32757343a (commit)
   via  481f8cf1cc73f99d06ed75752715f2f9fbb8f0ba (commit)
   via  ffa44a39c9d7e092f8c86a4648b976ccc64da4d6 (commit)
   via  29eeb9a8fd9a6417b99e7fbd8b406f72fc83f35f (commit)
  from  5ec03c93fc92149708b4ec9d19384a015d845f8e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b1cd292335d4d760d2bbd5062e21fdb6d24fcbd8
commit b1cd292335d4d760d2bbd5062e21fdb6d24fcbd8
Merge: 5ec03c9 cd7ed47
Author: Brad King 
AuthorDate: Mon Aug 1 15:04:37 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 15:04:37 2016 -0400

Merge topic 'vim-syntax-updates'

cd7ed47c Aux: highlight commands using Function
bca8be58 Aux: sort the highlighting list
7decbe8f Aux: highlight CMAKE_{CMAKE,CPACK}_COMMAND variables
2b57b139 Aux: highlight modules using Include
8ac4e2cf Aux: highlight conditiona and repeat commands differently
3b3bd880 Aux: highlight deprecated commands as warnings
481f8cf1 Aux: remove unused highlight links
ffa44a39 Aux: highlight Lua-style comments
29eeb9a8 Aux: check spelling in comments


---

Summary of changes:
 Auxiliary/cmake-syntax.vim |   32 ++--
 1 file changed, 22 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1014-g7140cb5

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  7140cb5ba763f473ac0717b4dd080337916259e1 (commit)
   via  cd7ed47c4ad5b9c2c7539a6f77bbe11a8510a718 (commit)
   via  bca8be583eda435202f7a0eb6e288646ce70570f (commit)
   via  7decbe8ffb66a1a02b9ffab027f33558fa36873a (commit)
   via  2b57b139201f7fa1959702db0a8c18482452f903 (commit)
   via  8ac4e2cfa283d6a27ba11c9ce6e2cea44457b5cb (commit)
   via  3b3bd880a3de1d6348d746c15b6bc3b32757343a (commit)
   via  481f8cf1cc73f99d06ed75752715f2f9fbb8f0ba (commit)
   via  ffa44a39c9d7e092f8c86a4648b976ccc64da4d6 (commit)
   via  29eeb9a8fd9a6417b99e7fbd8b406f72fc83f35f (commit)
  from  1cc3c5f70e71d12671fdad6d6c7b3bebfef33741 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7140cb5ba763f473ac0717b4dd080337916259e1
commit 7140cb5ba763f473ac0717b4dd080337916259e1
Merge: 1cc3c5f cd7ed47
Author: Brad King 
AuthorDate: Mon Aug 1 15:04:12 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 15:04:12 2016 -0400

Merge topic 'vim-syntax-updates' into next

cd7ed47c Aux: highlight commands using Function
bca8be58 Aux: sort the highlighting list
7decbe8f Aux: highlight CMAKE_{CMAKE,CPACK}_COMMAND variables
2b57b139 Aux: highlight modules using Include
8ac4e2cf Aux: highlight conditiona and repeat commands differently
3b3bd880 Aux: highlight deprecated commands as warnings
481f8cf1 Aux: remove unused highlight links
ffa44a39 Aux: highlight Lua-style comments
29eeb9a8 Aux: check spelling in comments


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cd7ed47c4ad5b9c2c7539a6f77bbe11a8510a718
commit cd7ed47c4ad5b9c2c7539a6f77bbe11a8510a718
Author: Ben Boeckel 
AuthorDate: Fri Jul 22 12:32:59 2016 -0400
Commit: Ben Boeckel 
CommitDate: Fri Jul 22 12:33:23 2016 -0400

Aux: highlight commands using Function

These are closer to functions than anything else. Also change the other
groups which were highlighted with Function to other groups.

diff --git a/Auxiliary/cmake-syntax.vim b/Auxiliary/cmake-syntax.vim
index 35eae63..9ffc1e8 100644
--- a/Auxiliary/cmake-syntax.vim
+++ b/Auxiliary/cmake-syntax.vim
@@ -443,7 +443,7 @@ syn keyword cmakeTodo
 \ TODO FIXME XXX
 \ contained
 
-hi def link cmakeCommand Statement
+hi def link cmakeCommand Function
 hi def link cmakeCommandConditional Conditional
 hi def link cmakeCommandDeprecated WarningMsg
 hi def link cmakeCommandRepeat Repeat
@@ -451,10 +451,10 @@ hi def link cmakeComment Comment
 hi def link cmakeEnvironment Special
 hi def link cmakeEscaped Special
 hi def link cmakeGeneratorExpression WarningMsg
-hi def link cmakeGeneratorExpressions Function
+hi def link cmakeGeneratorExpressions Keyword
 hi def link cmakeLuaComment Comment
 hi def link cmakeModule Include
-hi def link cmakeProperty Function
+hi def link cmakeProperty Constant
 hi def link cmakeRegistry Underlined
 hi def link cmakeString String
 hi def link cmakeTodo TODO

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bca8be583eda435202f7a0eb6e288646ce70570f
commit bca8be583eda435202f7a0eb6e288646ce70570f
Author: Ben Boeckel 
AuthorDate: Fri Jul 22 12:32:40 2016 -0400
Commit: Ben Boeckel 
CommitDate: Fri Jul 22 12:32:40 2016 -0400

Aux: sort the highlighting list

diff --git a/Auxiliary/cmake-syntax.vim b/Auxiliary/cmake-syntax.vim
index a41e9d5..35eae63 100644
--- a/Auxiliary/cmake-syntax.vim
+++ b/Auxiliary/cmake-syntax.vim
@@ -450,15 +450,15 @@ hi def link cmakeCommandRepeat Repeat
 hi def link cmakeComment Comment
 hi def link cmakeEnvironment Special
 hi def link cmakeEscaped Special
+hi def link cmakeGeneratorExpression WarningMsg
+hi def link cmakeGeneratorExpressions Function
 hi def link cmakeLuaComment Comment
 hi def link cmakeModule Include
+hi def link cmakeProperty Function
 hi def link cmakeRegistry Underlined
 hi def link cmakeString String
 hi def link cmakeTodo TODO
-hi def link cmakeGeneratorExpression WarningMsg
 hi def link cmakeVariable Identifier
-hi def link cmakeGeneratorExpressions Function
-hi def link cmakeProperty Function
 hi def link cmakeVariableValue Type
 
 hi def link cmakeKWExternalProject ModeMsg

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7decbe8ffb66a1a02b9ffab027f33558fa36873a
commit 7decbe8ffb66a1a02b9ffab027f33558fa36873a
Author: Ben Boeckel 
AuthorDate: Fri Jul 22 12:32:05 2016 -0400
Commit: Ben

[Cmake-commits] CMake branch, next, updated. v3.6.1-1004-g1cc3c5f

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  1cc3c5f70e71d12671fdad6d6c7b3bebfef33741 (commit)
   via  5ec03c93fc92149708b4ec9d19384a015d845f8e (commit)
   via  88e1c54a7cd3213d87143558a8fddf39e7fdccc0 (commit)
   via  bfac78d07479eb652405ee51548c401176ce (commit)
   via  2711c35a8d42e43c7600ef23bf586f2e068292e8 (commit)
   via  8427b8e11c9a98fb7f7875a1153ab4998e61d4c1 (commit)
   via  8b9cd61337501b6adb36fcd70e13ad59d1a63b34 (commit)
   via  963c4e4b909dd573f10aab21362c342431e6496d (commit)
   via  99f5a32c7ab6011ab826f11e4d48f018dfb758a6 (commit)
   via  db713223a85eb7140c7a6800e4de6173f3d4b326 (commit)
   via  09a86b392e6eb7ffa1c697b225c436e07d21d7da (commit)
  from  a135841da3110538f92f9aa51923e51157f31f1b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1cc3c5f70e71d12671fdad6d6c7b3bebfef33741
commit 1cc3c5f70e71d12671fdad6d6c7b3bebfef33741
Merge: a135841 5ec03c9
Author: Brad King 
AuthorDate: Mon Aug 1 15:00:11 2016 -0400
Commit: Brad King 
CommitDate: Mon Aug 1 15:00:11 2016 -0400

Merge branch 'master' into next


---

Summary of changes:
 Source/CMakeVersion.cmake |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, master, updated. v3.6.1-490-g5ec03c9

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  5ec03c93fc92149708b4ec9d19384a015d845f8e (commit)
   via  ad453f0502fe5d95ca1f050cdf52c2d32a892988 (commit)
   via  6f108f84d08a4cc12ef5bafc93d5aad903ba687a (commit)
  from  88e1c54a7cd3213d87143558a8fddf39e7fdccc0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5ec03c93fc92149708b4ec9d19384a015d845f8e
commit 5ec03c93fc92149708b4ec9d19384a015d845f8e
Merge: 88e1c54 ad453f0
Author: Brad King 
AuthorDate: Mon Aug 1 14:59:53 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 14:59:53 2016 -0400

Merge topic 'wix-disabled-components'

ad453f05 CPackWIX: Support CPACK_COMPONENT__DISABLED
6f108f84 CPackComponent: Document the *_HIDDEN and *_DISABLED variables


---

Summary of changes:
 Help/release/dev/wix-disabled-components.rst   |6 ++
 Modules/CPackComponent.cmake   |   10 +-
 Source/CPack/WiX/cmWIXFeaturesSourceWriter.cxx |4 
 3 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 Help/release/dev/wix-disabled-components.rst


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, master, updated. v3.6.1-477-g8427b8e

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  8427b8e11c9a98fb7f7875a1153ab4998e61d4c1 (commit)
   via  ea6475334aff57633ad7bb80c013c8953328a909 (commit)
  from  8b9cd61337501b6adb36fcd70e13ad59d1a63b34 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8427b8e11c9a98fb7f7875a1153ab4998e61d4c1
commit 8427b8e11c9a98fb7f7875a1153ab4998e61d4c1
Merge: 8b9cd61 ea64753
Author: Brad King 
AuthorDate: Mon Aug 1 14:59:41 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 14:59:41 2016 -0400

Merge topic 'aliased-target-properties'

ea647533 Do not report ALIASED_TARGET as always set (#15783)


---

Summary of changes:
 Source/cmGetPropertyCommand.cxx  |2 +-
 Tests/AliasTarget/CMakeLists.txt |   13 ++---
 2 files changed, 7 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, master, updated. v3.6.1-484-gbfac78d

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  bfac78d07479eb652405ee51548c401176ce (commit)
   via  624b72159be327505c01f4d68ef6e67ac5f4335e (commit)
  from  2711c35a8d42e43c7600ef23bf586f2e068292e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bfac78d07479eb652405ee51548c401176ce
commit bfac78d07479eb652405ee51548c401176ce
Merge: 2711c35 624b721
Author: Brad King 
AuthorDate: Mon Aug 1 14:59:47 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 14:59:47 2016 -0400

Merge topic 'more-virtual-override'

624b7215 Source/CPack: Add CM_OVERRIDE on MacOS cmCPackGenerator overrides


---

Summary of changes:
 Source/CPack/cmCPackBundleGenerator.h   |8 
 Source/CPack/cmCPackDragNDropGenerator.h|   10 +-
 Source/CPack/cmCPackOSXX11Generator.h   |8 
 Source/CPack/cmCPackPKGGenerator.h  |6 +++---
 Source/CPack/cmCPackPackageMakerGenerator.h |8 
 Source/CPack/cmCPackProductBuildGenerator.h |6 +++---
 6 files changed, 23 insertions(+), 23 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, master, updated. v3.6.1-482-g2711c35

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  2711c35a8d42e43c7600ef23bf586f2e068292e8 (commit)
   via  f951d0adb4f7ca185804fba530a3dbc9b81f1cc5 (commit)
   via  c63380b1955422d7116f7ea90c238ab8619e9bc4 (commit)
   via  134d5c1f7c82698b79d88ba92a7bd98b81dceaec (commit)
   via  2b909c08f526536d4dd84dfe68edf22682ae88ca (commit)
  from  8427b8e11c9a98fb7f7875a1153ab4998e61d4c1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2711c35a8d42e43c7600ef23bf586f2e068292e8
commit 2711c35a8d42e43c7600ef23bf586f2e068292e8
Merge: 8427b8e f951d0a
Author: Brad King 
AuthorDate: Mon Aug 1 14:59:44 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 14:59:44 2016 -0400

Merge topic 'app-framework-bundle-extension'

f951d0ad Add tests for BUNDLE_EXTENSION
c63380b1 Update documentation about bundle extensions
134d5c1f Honor BUNDLE_EXTENSION also for Frameworks (#14742)
2b909c08 Honor BUNDLE_EXTENSION also for App Bundles (#16148)


---

Summary of changes:
 Help/prop_tgt/BUNDLE_EXTENSION.rst |7 ++--
 .../release/dev/app-framework-bundle-extension.rst |5 +++
 Source/cmGeneratorTarget.cxx   |   22 +--
 Source/cmGlobalXCodeGenerator.cxx  |   10 +
 Source/cmInstallTargetGenerator.cxx|   13 ++-
 Tests/RunCMake/XcodeProject/RunCMakeTest.cmake |   20 --
 .../XcodeProject/XcodeBundles-install-check.cmake  |8 
 Tests/RunCMake/XcodeProject/XcodeBundles.cmake |   40 
 8 files changed, 113 insertions(+), 12 deletions(-)
 create mode 100644 Help/release/dev/app-framework-bundle-extension.rst
 create mode 100644 Tests/RunCMake/XcodeProject/XcodeBundles-install-check.cmake


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, master, updated. v3.6.1-487-g88e1c54

2016-08-01 Thread Brad King 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
   via  88e1c54a7cd3213d87143558a8fddf39e7fdccc0 (commit)
   via  7a649111cdea2b10f2ec57084416be619867fbfb (commit)
   via  5d0d980d9949daf596e10715d686adc95c1c232b (commit)
  from  bfac78d07479eb652405ee51548c401176ce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=88e1c54a7cd3213d87143558a8fddf39e7fdccc0
commit 88e1c54a7cd3213d87143558a8fddf39e7fdccc0
Merge: bfac78d 7a64911
Author: Brad King 
AuthorDate: Mon Aug 1 14:59:50 2016 -0400
Commit: CMake Topic Stage 
CommitDate: Mon Aug 1 14:59:50 2016 -0400

Merge topic 'use-string-append'

7a649111 Use string(APPEND) in Tests
5d0d980d Use string(APPEND) in Modules


---

Summary of changes:
 .../BasicConfigVersion-AnyNewerVersion.cmake.in|2 +-
 Modules/BasicConfigVersion-ExactVersion.cmake.in   |2 +-
 .../BasicConfigVersion-SameMajorVersion.cmake.in   |2 +-
 Modules/CMakeBackwardCompatibilityCXX.cmake|2 +-
 Modules/CMakeCommonLanguageInclude.cmake   |6 +-
 Modules/CMakeCompilerIdDetection.cmake |8 +--
 Modules/CMakeDetermineCompilerId.cmake |6 +-
 Modules/CMakeDetermineFortranCompiler.cmake|6 +-
 Modules/CMakePackageConfigHelpers.cmake|8 +--
 Modules/CMakeParseImplicitLinkInfo.cmake   |   44 +++---
 Modules/CMakePrintHelpers.cmake|   12 ++--
 Modules/CPack.cmake|2 +-
 Modules/CPackComponent.cmake   |   10 +--
 Modules/CPackIFW.cmake |4 +-
 Modules/CPackRPM.cmake |   64 ++--
 Modules/CTestUseLaunchers.cmake|2 +-
 Modules/CheckIncludeFile.cmake |2 +-
 Modules/CheckIncludeFileCXX.cmake  |2 +-
 Modules/CheckIncludeFiles.cmake|8 +--
 Modules/CheckPrototypeDefinition.cmake |4 +-
 Modules/CheckStructHasMember.cmake |2 +-
 Modules/CheckSymbolExists.cmake|8 +--
 Modules/CheckTypeSize.cmake|   10 +--
 .../Compiler/AppleClang-DetermineCompiler.cmake|2 +-
 Modules/Dart.cmake |2 +-
 Modules/DeployQt4.cmake|4 +-
 Modules/ExternalData.cmake |   16 ++---
 Modules/ExternalProject.cmake  |   16 ++---
 Modules/FeatureSummary.cmake   |   12 ++--
 Modules/FindBoost.cmake|   48 +++
 Modules/FindCUDA.cmake |4 +-
 Modules/FindCUDA/make2cmake.cmake  |2 +-
 Modules/FindCUDA/run_nvcc.cmake|2 +-
 Modules/FindCups.cmake |2 +-
 Modules/FindEXPAT.cmake|2 +-
 Modules/FindFreetype.cmake |2 +-
 Modules/FindMPI.cmake  |8 +--
 Modules/FindPHP4.cmake |8 +--
 Modules/FindPackageHandleStandardArgs.cmake|   18 +++---
 Modules/FindPkgConfig.cmake|2 +-
 Modules/FindQt4.cmake  |2 +-
 Modules/FindSDL_sound.cmake|4 +-
 Modules/FindZLIB.cmake |2 +-
 Modules/FindwxWidgets.cmake|2 +-
 Modules/FindwxWindows.cmake|2 +-
 Modules/FortranCInterface.cmake|8 +--
 Modules/GenerateExportHeader.cmake |2 +-
 Modules/GetPrerequisites.cmake |2 +-
 Modules/MatlabTestsRedirect.cmake  |2 +-
 Modules/Platform/BlueGeneQ-base.cmake  |2 +-
 Modules/Platform/Linux-Intel-Fortran.cmake |2 +-
 Modules/Platform/Windows-MSVC.cmake|2 +-
 Modules/Qt4Macros.cmake|4 +-
 Modules/UseJava.cmake  |6 +-
 Modules/UseSWIG.cmake  |   12 ++--
 Modules/Use_wxWindows.cmake|2 +-
 Modules/UsewxWidgets.cmake |2 +-
 Modules/WriteCompilerDetectionHeader.cmake |   56 -
 Tests/AliasTarget/CMakeLists.txt   |2 +-

Re: [CMake] FindLibXml2.cmake: rename "LIBXML2_DEFINITIONS"

2016-08-01 Thread Chuck Atkins 
Hi Yaron,


I think it should b renamed to "LIBXML2_COMPILE_FLAGS".
>

Xxx_DEFINITIONS is one of the standard variable names for a given
FindXxx.cmake find module, see
https://cmake.org/cmake/help/v3.6/manual/cmake-developer.7.html#standard-variable-names
.



> If u wish, I can submit a patch.
>

Thank you for the enthusiasm!   If you would like to improve on the
FindLibXML2 module, which really hasn't been touched in several years aside
from formatting changes, rather than mess with the varible names I would
instead suggest you look at creating an imported target for what get's
found.  That would certainly help bring the find module up to more modern
CMake conventions and would be greatly appreciated!

- Chuck
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [cmake-developers] [PATCH] Fix FindOpenCL on Mac OS

2016-08-01 Thread Matthäus G . Chajdas 
Hi Jerry,

thanks for giving it a spin :)

I don't have a Mac to test myself - as your changes are confined to
macOS, they look safe to me.

The version is not listed as a required variable, so that's why it
passes through. If you pass in a version into your find_package call, it
should bail out if no version is specified.

I only got one minor nit-pick: Why did you change the line
INTERFACE_INCLUDE_DIRECTORIES "${OpenCL_INCLUDE_DIR}")
to use _DIR instead of _DIRS? I assume this was from testing, not
because that changed something on macOS?

Other than that, the patch looks good to me. I'll apply it this week.

Cheers,
  Matthäus

Am 01.08.2016 um 09:58 schrieb jerry@web.de:
> Hi,
> 
> I tried the FindOpenCL.cmake with the imported target OpenCL::OpenCL and 
> found out that it does not work on MacOS.
> 
> The first problem is that it does not detect the version. In line 56 the path 
> needs to be changed from ${OpenCL_INCLUDE_DIR}/OpenCL/cl.h" to 
> “${OpenCL_INCLUDE_DIR}/Headers/cl.h“ because OpenCL_INCLUDE_DIR points to the 
> root of the OpenCL framework directory and the Headers are located under 
> Headers.
> 
> Also there seems to be a bug in find_package_handle_standard_args (?). 
> Because without the change above - when there is no version found - the 
> variable OpenCL_VERSION_STRING is empty. But an empty version string does not 
> let cmake fail. This is the output
> 
> -- Looking for CL_VERSION_2_0
> -- Looking for CL_VERSION_2_0 - not found
> -- Looking for CL_VERSION_1_2
> -- Looking for CL_VERSION_1_2 - not found
> -- Looking for CL_VERSION_1_1
> -- Looking for CL_VERSION_1_1 - not found
> -- Looking for CL_VERSION_1_0
> -- Looking for CL_VERSION_1_0 - not found
> -- Found OpenCL: /System/Library/Frameworks/OpenCL.framework (Required is at 
> least version "1.2") 
> 
> The other problems are with the imported locations in line 147ff. With the 
> current solution the linker step fails because OpenCL_LIBRARY points to the 
> root of the framework directory - i.e. 
> /System/Library/Frameworks/OpenCL.framework. Long time ago there was a bug 
> report [1] but the proposed solution was to have an if/else statement to 
> handle the special case of Apple frameworks. So I based my solution on [2] 
> and [3]. This works fine with Makefile and Ninja generators but the Xcode 
> generator still fails. The problem now is that with Xcode 7 Apple switched 
> the way how framework libraries work [5]. The final solution is based on [4] 
> where the Apple framework case is changed to an INTERFACE IMPORTED library 
> and the framework is stored in INTERFACE_LINK_LIBRARIES. This way cmake 
> resolves the library path to -framework OpenCL.
> 
> So with this patch I provide my final solution. Is it correct (it works at 
> least for me now on Win, Linux and Apple)? 
> 
> What’s with this empty version bug? I don’t found a solution for this.
> 
> jerry
> 
> [1] https://cmake.org/Bug/view.php?id=14105
> [2] https://github.com/Kitware/CMake/blob/master/Modules/FindGLUT.cmake
> [3] https://github.com/rpavlik/cmake-modules/blob/master/FindSDL2.cmake
> [4] http://public.kitware.com/pipermail/cmake/2016-April/063179.html
> [5] 
> http://public.kitware.com/pipermail/cmake-developers/2015-August/026110.html
> 
> 
> 

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Strange behaviour with check_library_exists on Windows

2016-08-01 Thread Sergei Nikulov 
2016-07-28 17:10 GMT+03:00 Sergei Nikulov :
> 2016-07-28 16:58 GMT+03:00 Sergei Nikulov :
>> 2016-07-28 15:03 GMT+03:00 Ben Boeckel :
>>> On Thu, Jul 28, 2016 at 13:33:35 +0300, Sergei Nikulov wrote:
 -- Looking for CertFreeCertificateContext in crypt32;
 -- Looking for CertFreeCertificateContext in crypt32; - found
 crypt32 found
>>>
>>> These are tested using try_compile. Is there anything interesting under
>>> CMakeFiles/CMakeTmp/* when you configure with --debug-trycompile? It
>>> should contain the example files used and output from the compiler.
>>>
>>
>> Ben,
>>
>> So looks like name mangling differs for different targets.
>
> Yes.
> Here the explanation
> http://stackoverflow.com/questions/28062446/x64-dll-export-function-names
>

Hello Ben,

Should I submit issue regarding this findings?

Thank you.

-- 
Best Regards,
Sergei Nikulov
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] [PATCH] Fix FindOpenCL on Mac OS

2016-08-01 Thread jerry . c . t 
Hi,

I tried the FindOpenCL.cmake with the imported target OpenCL::OpenCL and found 
out that it does not work on MacOS.

The first problem is that it does not detect the version. In line 56 the path 
needs to be changed from ${OpenCL_INCLUDE_DIR}/OpenCL/cl.h" to 
“${OpenCL_INCLUDE_DIR}/Headers/cl.h“ because OpenCL_INCLUDE_DIR points to the 
root of the OpenCL framework directory and the Headers are located under 
Headers.

Also there seems to be a bug in find_package_handle_standard_args (?). Because 
without the change above - when there is no version found - the variable 
OpenCL_VERSION_STRING is empty. But an empty version string does not let cmake 
fail. This is the output

-- Looking for CL_VERSION_2_0
-- Looking for CL_VERSION_2_0 - not found
-- Looking for CL_VERSION_1_2
-- Looking for CL_VERSION_1_2 - not found
-- Looking for CL_VERSION_1_1
-- Looking for CL_VERSION_1_1 - not found
-- Looking for CL_VERSION_1_0
-- Looking for CL_VERSION_1_0 - not found
-- Found OpenCL: /System/Library/Frameworks/OpenCL.framework (Required is at 
least version "1.2") 

The other problems are with the imported locations in line 147ff. With the 
current solution the linker step fails because OpenCL_LIBRARY points to the 
root of the framework directory - i.e. 
/System/Library/Frameworks/OpenCL.framework. Long time ago there was a bug 
report [1] but the proposed solution was to have an if/else statement to handle 
the special case of Apple frameworks. So I based my solution on [2] and [3]. 
This works fine with Makefile and Ninja generators but the Xcode generator 
still fails. The problem now is that with Xcode 7 Apple switched the way how 
framework libraries work [5]. The final solution is based on [4] where the 
Apple framework case is changed to an INTERFACE IMPORTED library and the 
framework is stored in INTERFACE_LINK_LIBRARIES. This way cmake resolves the 
library path to -framework OpenCL.

So with this patch I provide my final solution. Is it correct (it works at 
least for me now on Win, Linux and Apple)? 

What’s with this empty version bug? I don’t found a solution for this.

jerry

[1] https://cmake.org/Bug/view.php?id=14105
[2] https://github.com/Kitware/CMake/blob/master/Modules/FindGLUT.cmake
[3] https://github.com/rpavlik/cmake-modules/blob/master/FindSDL2.cmake
[4] http://public.kitware.com/pipermail/cmake/2016-April/063179.html
[5] http://public.kitware.com/pipermail/cmake-developers/2015-August/026110.html>From eb93a70536b2f26c33916bf18d65d612a068e5a5 Mon Sep 17 00:00:00 2001
From: jerry 
Date: Mon, 1 Aug 2016 09:49:11 +0200
Subject: [PATCH] Fix FindOpenCL on Mac OS

---
 Modules/FindOpenCL.cmake | 15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Modules/FindOpenCL.cmake b/Modules/FindOpenCL.cmake
index feda315..891798b 100644
--- a/Modules/FindOpenCL.cmake
+++ b/Modules/FindOpenCL.cmake
@@ -53,7 +53,7 @@ function(_FIND_OPENCL_VERSION)
 if(APPLE)
   CHECK_SYMBOL_EXISTS(
 CL_VERSION_${VERSION}
-"${OpenCL_INCLUDE_DIR}/OpenCL/cl.h"
+"${OpenCL_INCLUDE_DIR}/Headers/cl.h"
 OPENCL_VERSION_${VERSION})
 else()
   CHECK_SYMBOL_EXISTS(
@@ -145,8 +145,15 @@ mark_as_advanced(
   OpenCL_LIBRARY)
 
 if(OpenCL_FOUND AND NOT TARGET OpenCL::OpenCL)
-  add_library(OpenCL::OpenCL UNKNOWN IMPORTED)
+  if(OpenCL_LIBRARY MATCHES "/([^/]+)\\.framework$")
+add_library(OpenCL::OpenCL INTERFACE IMPORTED)
+set_target_properties(OpenCL::OpenCL PROPERTIES
+  INTERFACE_LINK_LIBRARIES "${OpenCL_LIBRARY}")
+  else()
+add_library(OpenCL::OpenCL UNKNOWN IMPORTED)
+set_target_properties(OpenCL::OpenCL PROPERTIES
+  IMPORTED_LOCATION "${OpenCL_LIBRARY}")
+  endif()
   set_target_properties(OpenCL::OpenCL PROPERTIES
-IMPORTED_LOCATION "${OpenCL_LIBRARY}"
-INTERFACE_INCLUDE_DIRECTORIES "${OpenCL_INCLUDE_DIRS}")
+INTERFACE_INCLUDE_DIRECTORIES "${OpenCL_INCLUDE_DIR}")
 endif()
-- 
2.7.4

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers