[cmake-developers] CTest XML outputs unsafe content
Hi there,
I'm maintaining a CTest output parser for Bamboo. It was reported to me
that CMake 3.3.1 produced parsing issues in my plugin. After digging into
CMake source code, it seems that a bug was introduced with the replacement
of direct use of cmXMLSafe and std::ostream in favor of cmXMLwriter.
cmXMLWriter is, I assume wrongly, output Safe content without (quotes,
etc.) escaping.
This simple modification corrects this to have pre-3.3 area behavior :
index c38c0de..7b71bae 100644
--- a/Source/cmXMLWriter.h
+++ b/Source/cmXMLWriter.h
@@ -94,12 +94,12 @@ private:
static cmXMLSafe SafeContent(const char* value)
{
-return cmXMLSafe(value).Quotes(false);
+return cmXMLSafe(value);
}
static cmXMLSafe SafeContent(std::string const value)
{
-return cmXMLSafe(value).Quotes(false);
+return cmXMLSafe(value);
}
template typename T
Regards,
--
nǝıɥʇɐƜ
0001-escape-quotes.patch
Description: Binary data
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [patch] Qt plugins are missing when deploying
I added two plugins qnativewifi and qtga that where missing in FindQt4.cmake and thus where not deployed with DeployQt4.cmake although they were mentioned in the plugins parameters. This is a patch is against current master but could well be back ported to earlier versions since this file has slightly changed thanks -- nǝıɥʇɐƜ 0001-Added-nativewifi-and-qtga-plugins.patch Description: Binary data -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[CMake] Missing Qt4 plugins
I have filled a issue in CMake's bugtraker http://public.kitware.com/Bug/view.php?id=14930 FindQt4.cmake is missing some platform dependent bearer plugins and the qtga image format plugin. By setting them like this : set( QT_BEARER_PLUGINS qcorewlanbearer qgenericbearer qnativewifibearer qconnmanbearer qnmbearer) set( QT_IMAGEFORMATS_PLUGINS qgif qjpeg qmng qico qsvg qtiff qtga ) Before including DeployQt4 and using the install_qt4_executable macro can solve this. HTH others :-) -- nǝıɥʇɐƜ -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] ctest question
2007/9/25, Juan Sanchez [EMAIL PROTECTED]:
Hi Alan,
I also have floating point results I want to account for. I'm thinking
about writing a diff script for numerical results which uses an absolute
and relative error tolerance. This would account for the difference in
transcendentals and other math functions between processors and math
libraries. I always disable 80 bit extended precision on linux since
the results are non-deterministic with respect to compiler settings.
diff with numerical precision concerns is ndiff :
http://www.math.utah.edu/~beebe/software/ndiff
HTH
Regards,
Juan
Alan W. Irwin wrote:
On 2007-09-24 10:05-0500 Juan Sanchez wrote:
Hello Alan,
From your example, what in this statement that causes the test to run
when I type make test?
ADD_TEST(my_first_test diff -q goldenfile testfile)
All it says is to run diff. How do I tell it to generate the testfile
from another executable? How do I tell this executable to run only when
I type make test and not a moment before?
Hi Juan:
In the above simple example diff is run only when you run ctest (or I
guess make test although I don't use that). So you could do something like
ADD_TEST(my_first_test ${CMAKE_CURRENT_BINARY_DIR}/create_testfile; diff -q
goldenfile testfile)
subject to escaping of ; which I can never get right until I experiment.
(This general command-line approach of separating commands with ; only
works on Unix, I believe.)
Then the create_testfile executable is run at ctest time to create testfile
and then diff is run immediately afterwards (which appears to be what you
want).
A better approach would be to put everything you want including the diff
into a configurable script, e.g.,
ADD_TEST(my_first_test ${CMAKE_CURRENT_BINARY_DIR}/test1.sh)
Note, in this case, the script is configured using CONFIGURE_FILE at
cmake time (basically by substituting CMake-defined variables when needed),
but run only at ctest time.
Our tests don't use diff (because postscript PLplot results are slightly
platform/compiler version dependent because of floating-point rounding
issues), but we do use a configurable scripting approach to generate our
test plots, see
http://plplot.svn.sourceforge.net/viewvc/plplot/trunk/test/CMakeLists.txt?view=log
I don't recommend you wade through _all_ of that CMake logic and bash script
logic since it is so specific to our PLplot needs (and also its pretty
voluminous/hierarchical since it deals with hundreds of test plots), but I
have given you the above starting reference in case you have trouble
configuring test scripts for yourself using CONFIGURE_FILE.
Alan
__
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__
Linux-powered Science
__
--
Juan Sanchez
[EMAIL PROTECTED]
800-538-8450 Ext. 54395
512-602-4395
___
CMake mailing list
CMake@cmake.org
http://www.cmake.org/mailman/listinfo/cmake
--
Mathieu
___
CMake mailing list
CMake@cmake.org
http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] ctest question
2007/9/25, Juan Sanchez [EMAIL PROTECTED]:
Hi Alan,
I also have floating point results I want to account for. I'm thinking
about writing a diff script for numerical results which uses an absolute
and relative error tolerance. This would account for the difference in
transcendentals and other math functions between processors and math
libraries. I always disable 80 bit extended precision on linux since
the results are non-deterministic with respect to compiler settings.
diff with numerical precision concerns is ndiff :
http://www.math.utah.edu/~beebe/software/ndiff
HTH
Regards,
Juan
Alan W. Irwin wrote:
On 2007-09-24 10:05-0500 Juan Sanchez wrote:
Hello Alan,
From your example, what in this statement that causes the test to run
when I type make test?
ADD_TEST(my_first_test diff -q goldenfile testfile)
All it says is to run diff. How do I tell it to generate the testfile
from another executable? How do I tell this executable to run only when
I type make test and not a moment before?
Hi Juan:
In the above simple example diff is run only when you run ctest (or I
guess make test although I don't use that). So you could do something like
ADD_TEST(my_first_test ${CMAKE_CURRENT_BINARY_DIR}/create_testfile; diff -q
goldenfile testfile)
subject to escaping of ; which I can never get right until I experiment.
(This general command-line approach of separating commands with ; only
works on Unix, I believe.)
Then the create_testfile executable is run at ctest time to create testfile
and then diff is run immediately afterwards (which appears to be what you
want).
A better approach would be to put everything you want including the diff
into a configurable script, e.g.,
ADD_TEST(my_first_test ${CMAKE_CURRENT_BINARY_DIR}/test1.sh)
Note, in this case, the script is configured using CONFIGURE_FILE at
cmake time (basically by substituting CMake-defined variables when needed),
but run only at ctest time.
Our tests don't use diff (because postscript PLplot results are slightly
platform/compiler version dependent because of floating-point rounding
issues), but we do use a configurable scripting approach to generate our
test plots, see
http://plplot.svn.sourceforge.net/viewvc/plplot/trunk/test/CMakeLists.txt?view=log
I don't recommend you wade through _all_ of that CMake logic and bash script
logic since it is so specific to our PLplot needs (and also its pretty
voluminous/hierarchical since it deals with hundreds of test plots), but I
have given you the above starting reference in case you have trouble
configuring test scripts for yourself using CONFIGURE_FILE.
Alan
__
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__
Linux-powered Science
__
--
Juan Sanchez
[EMAIL PROTECTED]
800-538-8450 Ext. 54395
512-602-4395
___
CMake mailing list
CMake@cmake.org
http://www.cmake.org/mailman/listinfo/cmake
--
Mathieu
___
CMake mailing list
CMake@cmake.org
http://www.cmake.org/mailman/listinfo/cmake
[CMake] CTest update with dart
Hi, I've succesfully installed a Dart server to use with CTest for a continuous build dashboard. However, The update stage which updates from a svn repository doesn't recover prior revision numbers to populate the update.xml file and thus when parsed by the Dart server the URL to see the diffs introduced by the new revision contain the same number... I use Dart 1.0.7 (for the record), CMake 2.4.6 on linux and subversion. Is this known or should I fill up a bug report ? -- Mathieu ___ CMake mailing list CMake@cmake.org http://www.cmake.org/mailman/listinfo/cmake
