Re: [CMake] FindLibXml2.cmake: rename "LIBXML2_DEFINITIONS"

[Yaron Cohen-Tal]

Ok, looking at other "FindXXX.cmake" modules I see that you're right, it
indeed always denotes what should be added to the "COMPILE_FLAGS" target
property, rather than "COMPILE_DEFINITIONS" property. I understand if u
don't want to rename it coz it'll break current usage, but just wanna note,
it's very confusing and I bet we're not the only ones who use it wrong (I
mean not only with libxml2 of course, but in general).

Thanx.

On Mon, Aug 1, 2016 at 7:08 PM, Chuck Atkins 
wrote:

> Hi Yaron,
>
>
> I think it should b renamed to "LIBXML2_COMPILE_FLAGS".
>>
>
> Xxx_DEFINITIONS is one of the standard variable names for a given
> FindXxx.cmake find module, see
> https://cmake.org/cmake/help/v3.6/manual/cmake-developer.7.html#standard-variable-names
> .
>
>
>
>> If u wish, I can submit a patch.
>>
>
> Thank you for the enthusiasm!   If you would like to improve on the
> FindLibXML2 module, which really hasn't been touched in several years aside
> from formatting changes, rather than mess with the varible names I would
> instead suggest you look at creating an imported target for what get's
> found.  That would certainly help bring the find module up to more modern
> CMake conventions and would be greatly appreciated!
>
> - Chuck
>
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] FindLibXml2.cmake: rename "LIBXML2_DEFINITIONS"

[Chuck Atkins]

Hi Yaron,


I think it should b renamed to "LIBXML2_COMPILE_FLAGS".
>

Xxx_DEFINITIONS is one of the standard variable names for a given
FindXxx.cmake find module, see
https://cmake.org/cmake/help/v3.6/manual/cmake-developer.7.html#standard-variable-names
.



> If u wish, I can submit a patch.
>

Thank you for the enthusiasm!   If you would like to improve on the
FindLibXML2 module, which really hasn't been touched in several years aside
from formatting changes, rather than mess with the varible names I would
instead suggest you look at creating an imported target for what get's
found.  That would certainly help bring the find module up to more modern
CMake conventions and would be greatly appreciated!

- Chuck
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

[CMake] FindLibXml2.cmake: rename "LIBXML2_DEFINITIONS"

[Yaron Cohen-Tal]

Hi,

In FindLibXml2.cmake, the name of the variable "LIBXML2_DEFINITIONS" is
confusing coz it describes actually what should be added to the
"COMPILE_FLAGS" property, not "COMPILE_DEFINITIONS". I think it should b
renamed to "LIBXML2_COMPILE_FLAGS". If u wish, I can submit a patch.

Thanx,
Yaron
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake