Re: [CMake] target_include_directories SYSTEM adds -isystem to Clang, but not GCC

2015-12-09 Thread Gregor Jasny via CMake
On 08/12/15 20:21, digitalriptide wrote:
> Thank you Gregor! I have tried the Makefile generator, but on OS X -isystem
> still seems to be missing with GCC. The -isystem flag appears with Clang,
> however. I have installed CMake 3.4.1 and GCC 5.3.0, both through MacPorts.
> I can provide a sample project, if that would help.

Please file a bug report and attach your test case. That way it does not
get lost.

Thanks,
Gregor

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake


Re: [CMake] target_include_directories SYSTEM adds -isystem to Clang, but not GCC

2015-12-08 Thread digitalriptide
Thank you Gregor! I have tried the Makefile generator, but on OS X -isystem
still seems to be missing with GCC. The -isystem flag appears with Clang,
however. I have installed CMake 3.4.1 and GCC 5.3.0, both through MacPorts.
I can provide a sample project, if that would help.

On Fri, Nov 20, 2015 at 8:28 AM, Gregor Jasny  wrote:

> On 15/11/15 21:13, digitalriptide wrote:
>
>> Did this fix make it into 3.4? After upgrading to 3.4, GCC still seems
>> to lack -isystem flags on OS X. Is there anything extra I need to do?
>>
>
> It should be fixed for the Makefile and Ninja generators but not Xcode.
> My proposed fix broke older Xcode versions so that I had to revert it
> back. I did not find time to pick this up again.
>
> Thanks,
> Gregor
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] target_include_directories SYSTEM adds -isystem to Clang, but not GCC

2015-11-20 Thread Gregor Jasny via CMake

On 15/11/15 21:13, digitalriptide wrote:

Did this fix make it into 3.4? After upgrading to 3.4, GCC still seems
to lack -isystem flags on OS X. Is there anything extra I need to do?


It should be fixed for the Makefile and Ninja generators but not Xcode.
My proposed fix broke older Xcode versions so that I had to revert it 
back. I did not find time to pick this up again.


Thanks,
Gregor
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake


Re: [CMake] target_include_directories SYSTEM adds -isystem to Clang, but not GCC

2015-11-15 Thread digitalriptide
Did this fix make it into 3.4? After upgrading to 3.4, GCC still seems to
lack -isystem flags on OS X. Is there anything extra I need to do?

Thank you!!

On Thu, Aug 20, 2015 at 8:12 AM, Gregor Jasny  wrote:

> Hello,
>
> On 17/08/15 01:01, digitalriptide wrote:
>
>> When I add SYSTEM to target_include_directories, for example using
>> target_include_directories( my_target SYSTEM PUBLIC ${MY_LIBRARIES} )
>> in Clang, CMake prepends -isystem to the relavent -I/my/library/path
>> type flags. With GCC, however, I see no -isystem added.
>>
>> For reference, this is CMake 3.2.3 on OS X with Apple LLVM version 6.0
>> and GCC 5 provided via MacPorts.
>>
>> Should SYSTEM add -isystem with GCC?
>>
>
> this is a know bug: http://www.cmake.org/Bug/view.php?id=15687
>
> I plan to work on it during the next days so that it may be fixed with
> CMake 3.4.
>
> Thanks,
> Gregor
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] target_include_directories SYSTEM adds -isystem to Clang, but not GCC

2015-08-20 Thread Gregor Jasny via CMake

Hello,

On 17/08/15 01:01, digitalriptide wrote:

When I add SYSTEM to target_include_directories, for example using
target_include_directories( my_target SYSTEM PUBLIC ${MY_LIBRARIES} )
in Clang, CMake prepends -isystem to the relavent -I/my/library/path
type flags. With GCC, however, I see no -isystem added.

For reference, this is CMake 3.2.3 on OS X with Apple LLVM version 6.0
and GCC 5 provided via MacPorts.

Should SYSTEM add -isystem with GCC?


this is a know bug: http://www.cmake.org/Bug/view.php?id=15687

I plan to work on it during the next days so that it may be fixed with 
CMake 3.4.


Thanks,
Gregor
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake


[CMake] target_include_directories SYSTEM adds -isystem to Clang, but not GCC

2015-08-16 Thread digitalriptide
Dear CMake Community,

When I add SYSTEM to target_include_directories, for example using
target_include_directories( my_target SYSTEM PUBLIC ${MY_LIBRARIES} )
in Clang, CMake prepends -isystem to the relavent -I/my/library/path type
flags. With GCC, however, I see no -isystem added.

For reference, this is CMake 3.2.3 on OS X with Apple LLVM version 6.0 and
GCC 5 provided via MacPorts.

Should SYSTEM add -isystem with GCC?

Thank you for any tips!
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake