Re: [cmake-developers] [PATCH v3 6/7] Use Windows version of Directory::Load for MinGW too
On 07/20/2016 10:27 AM, Brad King wrote: > On 07/06/2016 03:12 PM, Dāvis Mosāns wrote: >> Otherwise it would use POSIX functions which works only for ASCII paths. > > Thanks. Applied to KWSys first with minor tweaks: > > http://review.source.kitware.com/21349 After being rewritten by another contributor there the change is now in KWSys master. I've updated CMake's copy to get it: KWSys 2016-08-01 (560bcdbb) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6bc3073e -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH v3 6/7] Use Windows version of Directory::Load for MinGW too
On 07/06/2016 03:12 PM, Dāvis Mosāns wrote: > Otherwise it would use POSIX functions which works only for ASCII paths. Thanks. Applied to KWSys first with minor tweaks: http://review.source.kitware.com/21349 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [PATCH v3 6/7] Use Windows version of Directory::Load for MinGW too
Otherwise it would use POSIX functions which works only for ASCII paths. --- Source/kwsys/Directory.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/kwsys/Directory.cxx b/Source/kwsys/Directory.cxx index c549792..659c559 100644 --- a/Source/kwsys/Directory.cxx +++ b/Source/kwsys/Directory.cxx @@ -86,7 +86,7 @@ void Directory::Clear() // First microsoft compilers -#if defined(_MSC_VER) || defined(__WATCOMC__) +#if defined(_WIN32) || defined(__WATCOMC__) #include #include #include -- 2.9.0 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
