Re: [cmake-developers] Please comment on ios-universal topic
On 10-Dec-15 13:55, Gregor Jasny wrote: Hello, On 09/12/15 10:21, Ruslan Baratov wrote: IOS_INSTALL_COMBINED_BINARY Just to clarify you want to leave only one variable IOS_INSTALL_COMBINED_BINARY for the device + simulator on iOS platforms. Other platforms (in future) will be controlled by using *_ARCHITECTURES variables, right? Right. Any objections to that property name? Thanks, Gregor TL;DR I'm finding it a little bit confusing but can't propose any better alternatives so I have no objections :) Some thoughts: * arm64 + armv7 is a universal binary, arm64 + armv7 + i386 - well, still universal binary too :) * OSX_ARCHITECTURES affect architectures on iOS. Probably it should be IOS_ARCHITECTURES or just ARCHITECTURES (though MACOSX_BUNDLE works same way) * OSX_ARCHITECTURES=armv7 -> build armv7, OSX_ARCHITECTURES=armv7,arm64 -> build universal armv7+arm64, but OSX_ARCHITECTURES=armv7,arm64,i386 doesn't build armv7+arm64+i386 binary * hard to say anything about future improvements, like if it will be easier to implement universal binary in build directory on Android, then *_ARCHITECTURES looks better. but if it will be easier to build one architecture then add extra code to add more on install then INSTALL_UNIVERSAL_BINARY for all platforms looks better Ruslo -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please comment on ios-universal topic
On 09-Dec-15 04:51, Gregor Jasny wrote: Hello, On 02/12/15 13:44, Bartosz Kosiorek wrote: I would like to propose to rename property name to INSTALL_IOS_UNIVERSAL_LIBS. My thoughts about the property name: I added the necessary functionality to also combine Frameworks and App Bundles. So the _LIBS suffix now got misleading. And I think that providing a different property for libraries, frameworks and app bundles is not really helpful. To combine all targets one could set the CMAKE_ prefixed variable, to combine only some, one could set the property on the target itself. Deploying applications which support both armv7 (32bit) and armv8 (64bit) is already working by setting both architectures in the OSX_ARCHITECTURES property because both are covered by the device SDK. So technically we already support UNIVERSAL libraries. What we don't support is combining device and simulator builds. So how about replacing UNIVERSAL with COMBINED? IOS_INSTALL_COMBINED_BINARY Just to clarify you want to leave only one variable IOS_INSTALL_COMBINED_BINARY for the device + simulator on iOS platforms. Other platforms (in future) will be controlled by using *_ARCHITECTURES variables, right? Ruslo -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please comment on ios-universal topic
Hello, On 09/12/15 10:21, Ruslan Baratov wrote: IOS_INSTALL_COMBINED_BINARY Just to clarify you want to leave only one variable IOS_INSTALL_COMBINED_BINARY for the device + simulator on iOS platforms. Other platforms (in future) will be controlled by using *_ARCHITECTURES variables, right? Right. Any objections to that property name? Thanks, Gregor -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please comment on ios-universal topic
Hello, On 02/12/15 13:44, Bartosz Kosiorek wrote: > I would like to propose to rename property name to INSTALL_IOS_UNIVERSAL_LIBS. My thoughts about the property name: I added the necessary functionality to also combine Frameworks and App Bundles. So the _LIBS suffix now got misleading. And I think that providing a different property for libraries, frameworks and app bundles is not really helpful. To combine all targets one could set the CMAKE_ prefixed variable, to combine only some, one could set the property on the target itself. Deploying applications which support both armv7 (32bit) and armv8 (64bit) is already working by setting both architectures in the OSX_ARCHITECTURES property because both are covered by the device SDK. So technically we already support UNIVERSAL libraries. What we don't support is combining device and simulator builds. So how about replacing UNIVERSAL with COMBINED? IOS_INSTALL_COMBINED_BINARY I'm not sure if dropping the IOS bundle currently makes sense. At the moment just iOS (and watchOS, tvOS) is the odd platfrom which requires work-arounds. Thanks, Gregor -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Please comment on ios-universal topic
Hello, During the last days I worked on the iOS Universal Install topic which now would benefit from a review. Especially the core changes could need a third pair of eyes: https://cmake.org/gitweb?p=stage/cmake.git;a=commit;h=8fb23b42cfc2fb7490e8645fff328add9c231713 I will now concentrate on adding more tests during the next days. Thank you, Gregor -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
