Re: [cmake-developers] [CMake] CMake 2.8.12-rc2 FindHDF5 issues

2013-09-19 Thread Clinton Stimpson 
On Thursday, September 19, 2013 01:47:23 PM Brad King wrote:
 On 09/17/2013 06:16 PM, Clinton Stimpson wrote:
  I've narrowed it down to a regression caused by 04d4dc33.
 
 The following should fix this:
 
  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0f05961f
 
 See the commit message for an explanation.
 
 Please test and let me know.
 
 Thanks,
 -Brad

It fixed my simple test case.

-- 
Clinton Stimpson
Elemental Technologies, Inc
Computational Simulation Software, LLC
www.csimsoft.com
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [CMake] CMake 2.8.12-rc2 FindHDF5 issues

2013-09-19 Thread Brad King 
On 09/17/2013 06:16 PM, Clinton Stimpson wrote:
 I've narrowed it down to a regression caused by 04d4dc33.

The following should fix this:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0f05961f

See the commit message for an explanation.

Please test and let me know.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [CMake] CMake 2.8.12-rc2 FindHDF5 issues

2013-09-19 Thread Orion Poplawski 

On 09/19/2013 11:47 AM, Brad King wrote:

On 09/17/2013 06:16 PM, Clinton Stimpson wrote:

I've narrowed it down to a regression caused by 04d4dc33.


The following should fix this:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0f05961f

See the commit message for an explanation.

Please test and let me know.

Thanks,
-Brad



I can build netcdf with it now - thanks.

--
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane   or...@nwra.com
Boulder, CO 80301   http://www.nwra.com
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [CMake] CMake 2.8.12-rc2 FindHDF5 issues

2013-09-17 Thread Clinton Stimpson 
On Tuesday, September 17, 2013 04:01:30 PM Orion Poplawski wrote:
 On 09/16/2013 09:58 PM, clin...@elemtech.com wrote:
  Same here... and this looks like a regression:
  
  A simple CMakeLists.txt like this can reproduce it.
  
  set(CMAKE_BUILD_TYPE Debug)
  find_package(HDF5 COMPONENTS C HL REQUIRED)
  add_executable(foo foo.cpp)
  target_link_libraries(foo ${HDF5_LIBRARIES})
  
  FindHDF5.cmake misuses CMAKE_BUILD_TYPE and CMAKE_CONFIGURATION_TYPES when
  assembling the HDF5_LIBRARIES variable.  If I clear out the
  CMAKE_BUILD_TYPE variable, then the problem goes away.
  
  Clint
 
 cmake 2.8.11.2:
 
 -- Found HDF5:
 debug;/usr/lib64/libz.so;debug;/usr/lib64/libdl.so;debug;/usr/lib64/libm.so;
 debug;/usr/lib64/libhdf5_hl.so;debug;/usr/lib64/libhdf5.so;optimized;/usr/li
 b64/libz.so;optimized;/usr/lib64/libdl.so;optimized;/usr/lib64/libm.so;optim
 ized;/usr/lib64/libhdf5_hl.so;optimized;/usr/lib64/libhdf5.so
 
 cmake 2.8.12-rc2:
 
 -- Found HDF5:
 debug;HDF5_hdf5_LIBRARY_DEBUG-NOTFOUND;debug;HDF5_z_LIBRARY_DEBUG-NOTFOUND;d
 ebug;HDF5_dl_LIBRARY_DEBUG-NOTFOUND;debug;HDF5_m_LIBRARY_DEBUG-NOTFOUND;debu
 g;HDF5_hdf5_hl_LIBRARY_DEBUG-NOTFOUND;debug;HDF5_hdf5_LIBRARY_DEBUG-NOTFOUND
 ;optimized;/usr/lib64/libz.so;optimized;/usr/lib64/libdl.so;optimized;/usr/l
 ib64/libm.so;optimized;/usr/lib64/libhdf5_hl.so;optimized;/usr/lib64/libhdf5
 .so
 
 
 In comparing the CMakeCache:
[ snip ]
 
 As Rolf noted, FindHDF5 has not changed.

Right, it hasn't changed.

I've narrowed it down to a regression caused by 04d4dc33.
Will Dicharry, is this something you can look at?  You are the maintainer for 
both FindHDF5 and SelectLibraryConfigurations.  A change in 
SelectLibraryConfigurations caused a break in FindHDF5.

Clint

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers