[jira] [Comment Edited] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708005#comment-17708005 ] Stefan Miklosovic edited comment on CASSANDRA-18332 at 4/3/23 3:14 PM: --- [~jmckenzie] I have added build for 4.1 as well. I think these are all already-known flakes. https://issues.apache.org/jira/browse/CASSANDRA-18047 https://issues.apache.org/jira/browse/CASSANDRA-16677 was (Author: smiklosovic): [~jmckenzie] I have added build for 4.1 as well. I think these are all already-known flakes. https://issues.apache.org/jira/browse/CASSANDRA-18047 https://issues.apache.org/jira/browse/CASSANDRA-16678 > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708005#comment-17708005 ] Stefan Miklosovic edited comment on CASSANDRA-18332 at 4/3/23 3:13 PM: --- [~jmckenzie] I have added build for 4.1 as well. I think these are all already-known flakes. https://issues.apache.org/jira/browse/CASSANDRA-18047 https://issues.apache.org/jira/browse/CASSANDRA-16678 was (Author: smiklosovic): [~jmckenzie] I have added build for 4.1 as well. I think these are all already-known flakes. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707506#comment-17707506 ] Stefan Miklosovic edited comment on CASSANDRA-18332 at 4/3/23 3:10 PM: --- 4.0 j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/80d2d0e8-6253-43af-b90f-d75c8cb05726 4.0 j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/0b2d215a-8de2-4f69-8b67-314a0eb04bc4 4.1 j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2046/workflows/217c1c59-b4cf-4c49-bab6-3cbe0e889cb6 4.1 j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2046/workflows/29c65922-91fc-4a29-8e73-e60901cc4e94 was (Author: smiklosovic): 4.0 j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/80d2d0e8-6253-43af-b90f-d75c8cb05726 4.0 j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/0b2d215a-8de2-4f69-8b67-314a0eb04bc4 > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707593#comment-17707593 ] Josh McKenzie edited comment on CASSANDRA-18332 at 4/1/23 10:58 PM: bq. If I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? Correct. The logging level change is material and the other is more or less just trivial hygiene. Edit: looks like just 1 flake on both [JDK8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/80d2d0e8-6253-43af-b90f-d75c8cb05726/jobs/18359/tests] and [JDK11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/0b2d215a-8de2-4f69-8b67-314a0eb04bc4/jobs/18335/tests], same test. I'll circle back to that test on Monday and see how it holds up under clean multiplexing on 4.0 on circle; if it's got issues I'll go ahead and create a JIRA for it. You good w/me going through merge up process Monday otherwise [~smiklosovic]? was (Author: jmckenzie): bq. If I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? Correct. The logging level change is material and the other is more or less just trivial hygiene. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707379#comment-17707379 ] Stefan Miklosovic edited comment on CASSANDRA-18332 at 3/31/23 6:00 PM: If I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? was (Author: smiklosovic): As I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706113#comment-17706113 ] Josh McKenzie edited comment on CASSANDRA-18332 at 3/28/23 7:05 PM: Oof; I should have double checked that instead of just assuming. Kicked off workflows again; I'll circle back once I get a cleaner more representative run. (edit: I'm assuming it's env flaking since there's lib finding errors, timeouts, etc - nothing I could attribute to any of the changes in this diff) was (Author: jmckenzie): Oof; I should have double checked that instead of just assuming. Kicked off workflows again; I'll circle back once I get a cleaner more representative run. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
