[jira] [Comment Edited] (CASSANDRA-19600) Resolve the oldest hints just from descriptors and current writer if available

2024-05-02 Thread Stefan Miklosovic (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842943#comment-17842943
 ] 

Stefan Miklosovic edited comment on CASSANDRA-19600 at 5/2/24 11:46 AM:


I realized that it would be cool to add a test for this feature. We are not 
specifically testing persistent window with this change we did. I have the test 
done, I just need to multiplex it. 

I will commit this tomorrow.


was (Author: smiklosovic):
I realized that it would be cool to add a test for this feature. We are not 
specifically testing persistent window with this changed we did. I have the 
test done, I just need to multiplex it. 

I will commit this tomorrow.

> Resolve the oldest hints just from descriptors and current writer if available
> --
>
> Key: CASSANDRA-19600
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19600
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Core
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should not resolve hints from buffers as these are just very short-lived / 
> transient data structures and resolving "the oldest hints" from buffers too 
> just does not make sense when we should just look into descriptors and 
> current writer's descriptor at most.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-19600) Resolve the oldest hints just from descriptors and current writer if available

2024-05-02 Thread Stefan Miklosovic (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842897#comment-17842897
 ] 

Stefan Miklosovic edited comment on CASSANDRA-19600 at 5/2/24 10:55 AM:


trunk's build seems to be rather flaky. j17 looks fine, j11 is struggling a 
little bit. I will go over it to be sure it is indeed all just flakes or we had 
a bad luck with Circle. Otherwise looks like the changes we did have nothing in 
common with the failed test results, I do not see anything suspicious.

[CASSANDRA-19600-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19600-trunk]
{noformat}
java17_pre-commit_tests 
  ✓ j17_build4m 50s
  ✓ j17_cqlsh_dtests_py3117m 1s
  ✓ j17_cqlsh_dtests_py311_vnode  7m 9s
  ✓ j17_cqlsh_dtests_py386m 50s
  ✓ j17_cqlsh_dtests_py38_vnode  7m 22s
  ✓ j17_cqlshlib_cython_tests8m 31s
  ✓ j17_cqlshlib_tests   6m 45s
  ✓ j17_dtests  36m 46s
  ✓ j17_dtests_vnode 35m 7s
  ✓ j17_unit_tests   14m 6s
  ✓ j17_utests_latest   13m 44s
  ✓ j17_utests_oa   13m 51s
  ✕ j17_dtests_latest   36m 31s
  configuration_test.TestConfiguration test_change_durable_writes
  ✕ j17_jvm_dtests  28m 32s
  
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest 
testEndpointVerificationEnabledIpNotInSAN TIMEOUTED
  ✕ j17_jvm_dtests_latest_vnode 23m 30s
  junit.framework.TestSuite 
org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest 
TIMEOUTED
java17_separate_tests
java11_pre-commit_tests 
  ✓ j11_build8m 27s
  ✓ j11_cqlsh_dtests_py311  10m 12s
  ✓ j11_cqlsh_dtests_py311_vnode 9m 24s
  ✓ j11_cqlsh_dtests_py38 8m 1s
  ✓ j11_cqlsh_dtests_py38_vnode  8m 20s
  ✓ j11_cqlshlib_cython_tests   11m 34s
  ✓ j11_cqlshlib_tests7m 7s
  ✓ j11_dtests  41m 45s
  ✓ j11_dtests_vnode37m 37s
  ✓ j11_jvm_dtests  26m 58s
  ✓ j11_unit_tests  17m 56s
  ✓ j11_utests_latest   19m 24s
  ✓ j11_utests_oa   18m 38s
  ✓ j17_cqlsh_dtests_py311   7m 24s
  ✓ j17_cqlsh_dtests_py311_vnode 7m 26s
  ✓ j17_cqlsh_dtests_py387m 12s
  ✓ j17_cqlsh_dtests_py38_vnode   7m 8s
  ✓ j17_cqlshlib_cython_tests7m 39s
  ✓ j17_cqlshlib_tests   8m 45s
  ✓ j17_dtests_vnode36m 59s
  ✓ j17_unit_tests  13m 34s
  ✓ j17_utests_latest   18m 34s
  ✓ j17_utests_oa   14m 45s
  ✕ j11_dtests_latest   41m 59s
  configuration_test.TestConfiguration test_change_durable_writes
  topology_test.TestTopology test_resumable_decommission
  ✕ j11_jvm_dtests_latest_vnode 24m 24s
  org.apache.cassandra.distributed.test.tcm.SplitBrainTest 
testSplitBrainStartup TIMEOUTED
  ✕ j11_simulator_dtests10m 51s
  org.apache.cassandra.simulator.test.HarrySimulatorTest test
  org.apache.cassandra.simulator.test.ShortPaxosSimulationTest 
simulationTest
  ✕ j11_utests_system_keyspace_directory13m 55s
  org.apache.cassandra.transport.CQLUserAuditTest queryInsert
  org.apache.cassandra.transport.CQLUserAuditTest prepareStmt
  org.apache.cassandra.transport.CQLUserAuditTest loginSuccessfulTest
  org.apache.cassandra.transport.CQLUserAuditTest queryBatch
  org.apache.cassandra.transport.CQLUserAuditTest querySimpleSelect
  ✕ j17_dtests  40m 21s
  sslnodetonode_test.TestNodeToNodeSSLEncryption 
test_ssl_client_auth_required_succeed
  transient_replication_test.TestTransientReplication test_srp
  ttl_test.TestRecoverNegativeExpirationDate 
test_recover_negative_expiration_date_sstables_with_scrub
  user_functions_test.TestUserFunctions test_default_aggregate
  write_failures_test.TestWriteFailures test_mutation_quorum
  sslnodetonode_test.TestNodeToNodeSSLEncryption 
test_ssl_wrong_hostname_no_validation

[jira] [Comment Edited] (CASSANDRA-19600) Resolve the oldest hints just from descriptors and current writer if available

2024-05-02 Thread Stefan Miklosovic (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842897#comment-17842897
 ] 

Stefan Miklosovic edited comment on CASSANDRA-19600 at 5/2/24 9:21 AM:
---

trunk's build seems to be rather flaky. j17 looks fine, j11 is struggling a 
little bit. I will go over it to be sure it is indeed all just flakes or we had 
a bad luck with Circle. Otherwise looks like the changes we did have nothing in 
common with the failed test results, I do not see anything suspicious.

[CASSANDRA-19600-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19600-trunk]
{noformat}
java17_pre-commit_tests 
  ✓ j17_build4m 50s
  ✓ j17_cqlsh_dtests_py3117m 1s
  ✓ j17_cqlsh_dtests_py311_vnode  7m 9s
  ✓ j17_cqlsh_dtests_py386m 50s
  ✓ j17_cqlsh_dtests_py38_vnode  7m 22s
  ✓ j17_cqlshlib_cython_tests8m 31s
  ✓ j17_cqlshlib_tests   6m 45s
  ✓ j17_dtests  36m 46s
  ✓ j17_dtests_vnode 35m 7s
  ✓ j17_unit_tests   14m 6s
  ✓ j17_utests_latest   13m 44s
  ✓ j17_utests_oa   13m 51s
  ✕ j17_dtests_latest   36m 31s
  configuration_test.TestConfiguration test_change_durable_writes
  ✕ j17_jvm_dtests  28m 32s
  
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest 
testEndpointVerificationEnabledIpNotInSAN TIMEOUTED
  ✕ j17_jvm_dtests_latest_vnode 23m 30s
  junit.framework.TestSuite 
org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest 
TIMEOUTED
java17_separate_tests
java11_pre-commit_tests 
  ✓ j11_build8m 27s
  ✓ j11_cqlsh_dtests_py311  10m 12s
  ✓ j11_cqlsh_dtests_py311_vnode 9m 24s
  ✓ j11_cqlsh_dtests_py38 8m 1s
  ✓ j11_cqlsh_dtests_py38_vnode  8m 20s
  ✓ j11_cqlshlib_cython_tests   11m 34s
  ✓ j11_cqlshlib_tests7m 7s
  ✓ j11_dtests  41m 45s
  ✓ j11_dtests_vnode37m 37s
  ✓ j11_jvm_dtests  26m 58s
  ✓ j11_unit_tests  17m 56s
  ✓ j11_utests_latest   19m 24s
  ✓ j11_utests_oa   18m 38s
  ✓ j17_cqlsh_dtests_py311   7m 24s
  ✓ j17_cqlsh_dtests_py311_vnode 7m 26s
  ✓ j17_cqlsh_dtests_py387m 12s
  ✓ j17_cqlsh_dtests_py38_vnode   7m 8s
  ✓ j17_cqlshlib_cython_tests7m 39s
  ✓ j17_cqlshlib_tests   8m 45s
  ✓ j17_dtests_vnode36m 59s
  ✓ j17_unit_tests  13m 34s
  ✓ j17_utests_latest   18m 34s
  ✓ j17_utests_oa   14m 45s
  ✕ j11_dtests_latest   41m 59s
  configuration_test.TestConfiguration test_change_durable_writes
  topology_test.TestTopology test_resumable_decommission
  ✕ j11_jvm_dtests_latest_vnode 24m 24s
  org.apache.cassandra.distributed.test.tcm.SplitBrainTest 
testSplitBrainStartup TIMEOUTED
  ✕ j11_simulator_dtests10m 51s
  org.apache.cassandra.simulator.test.HarrySimulatorTest test
  org.apache.cassandra.simulator.test.ShortPaxosSimulationTest 
simulationTest
  ✕ j11_utests_system_keyspace_directory13m 55s
  org.apache.cassandra.transport.CQLUserAuditTest queryInsert
  org.apache.cassandra.transport.CQLUserAuditTest prepareStmt
  org.apache.cassandra.transport.CQLUserAuditTest loginSuccessfulTest
  org.apache.cassandra.transport.CQLUserAuditTest queryBatch
  org.apache.cassandra.transport.CQLUserAuditTest querySimpleSelect
  ✕ j17_dtests  40m 21s
  sslnodetonode_test.TestNodeToNodeSSLEncryption 
test_ssl_client_auth_required_succeed
  transient_replication_test.TestTransientReplication test_srp
  ttl_test.TestRecoverNegativeExpirationDate 
test_recover_negative_expiration_date_sstables_with_scrub
  user_functions_test.TestUserFunctions test_default_aggregate
  write_failures_test.TestWriteFailures test_mutation_quorum
  sslnodetonode_test.TestNodeToNodeSSLEncryption 
test_ssl_wrong_hostname_no_validation