[jira] [Commented] (CASSANDRA-10694) Deletion info is dropped on updated rows when notifying secondary index
[
https://issues.apache.org/jira/browse/CASSANDRA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004756#comment-15004756
]
Tyler Hobbs commented on CASSANDRA-10694:
-
Thanks, committed to 3.0 as {{c2320c92fdae6815b8952ba98b1e8e5239b5be2a}} and
merged to 3.1 and trunk.
There were some dtest failures on 3.0 and 3.1, but repeated manual runs of
relevant tests showed there weren't any issues. I'm not sure what was up with
all of the failed connections in the 3.1 dtests.
> Deletion info is dropped on updated rows when notifying secondary index
> ---
>
> Key: CASSANDRA-10694
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10694
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
>Reporter: Tyler Hobbs
>Assignee: Tyler Hobbs
> Fix For: 3.0.1, 3.1
>
> Attachments: index-deletion.patch
>
>
> In {{SecondaryIndexManager.onUpdated()}}, we fail to copy the
> {{DeletionInfo}} from the existing and new rows before notifying the index of
> the update. This leads the index to believe a new, live row has been
> inserted instead of a single-row deletion. It looks like this has been a
> problem since 3.0.0-beta1.
> I've attached a simple patch that fixes the issue. I'm working on a full
> patch with tests, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10694) Deletion info is dropped on updated rows when notifying secondary index
[
https://issues.apache.org/jira/browse/CASSANDRA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004043#comment-15004043
]
Sam Tunnicliffe commented on CASSANDRA-10694:
-
+1 (pending CI)
> Deletion info is dropped on updated rows when notifying secondary index
> ---
>
> Key: CASSANDRA-10694
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10694
> Project: Cassandra
> Issue Type: Bug
> Components: index
>Reporter: Tyler Hobbs
>Assignee: Tyler Hobbs
> Fix For: 3.0.1, 3.1
>
> Attachments: index-deletion.patch
>
>
> In {{SecondaryIndexManager.onUpdated()}}, we fail to copy the
> {{DeletionInfo}} from the existing and new rows before notifying the index of
> the update. This leads the index to believe a new, live row has been
> inserted instead of a single-row deletion. It looks like this has been a
> problem since 3.0.0-beta1.
> I've attached a simple patch that fixes the issue. I'm working on a full
> patch with tests, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10694) Deletion info is dropped on updated rows when notifying secondary index
[
https://issues.apache.org/jira/browse/CASSANDRA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002956#comment-15002956
]
Tyler Hobbs commented on CASSANDRA-10694:
-
Patch with unit tests:
||branch||testall||dtest||
|[CASSANDRA-10694|https://github.com/thobbs/cassandra/tree/CASSANDRA-10694]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10694-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10694-dtest]|
|[CASSANDRA-10694-3.1|https://github.com/thobbs/cassandra/tree/CASSANDRA-10694-3.1]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10694-3.1-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10694-3.1-dtest]|
|[CASSANDRA-10694-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-10694-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10694-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10694-trunk-dtest]|
> Deletion info is dropped on updated rows when notifying secondary index
> ---
>
> Key: CASSANDRA-10694
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10694
> Project: Cassandra
> Issue Type: Bug
> Components: index
>Reporter: Tyler Hobbs
>Assignee: Tyler Hobbs
> Fix For: 3.0.1, 3.1
>
> Attachments: index-deletion.patch
>
>
> In {{SecondaryIndexManager.onUpdated()}}, we fail to copy the
> {{DeletionInfo}} from the existing and new rows before notifying the index of
> the update. This leads the index to believe a new, live row has been
> inserted instead of a single-row deletion. It looks like this has been a
> problem since 3.0.0-beta1.
> I've attached a simple patch that fixes the issue. I'm working on a full
> patch with tests, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10694) Deletion info is dropped on updated rows when notifying secondary index
[
https://issues.apache.org/jira/browse/CASSANDRA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002558#comment-15002558
]
Tyler Hobbs commented on CASSANDRA-10694:
-
Like CASSANDRA-10690, this also doesn't visibly affect the built-in secondary
indexes due to stale entry handling, although it would eventually have an
impact on performance if a lot of deletions are performed on indexed data.
However, for custom secondary indexes, this is problematic.
> Deletion info is dropped on updated rows when notifying secondary index
> ---
>
> Key: CASSANDRA-10694
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10694
> Project: Cassandra
> Issue Type: Bug
> Components: index
>Reporter: Tyler Hobbs
>Assignee: Tyler Hobbs
> Fix For: 3.0.1, 3.1
>
> Attachments: index-deletion.patch
>
>
> In {{SecondaryIndexManager.onUpdated()}}, we fail to copy the
> {{DeletionInfo}} from the existing and new rows before notifying the index of
> the update. This leads the index to believe a new, live row has been
> inserted instead of a single-row deletion. It looks like this has been a
> problem since 3.0.0-beta1.
> I've attached a simple patch that fixes the issue. I'm working on a full
> patch with tests, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
