[jira] [Commented] (CASSANDRA-11437) Make number of cores used for copy tasks visible
[
https://issues.apache.org/jira/browse/CASSANDRA-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241796#comment-15241796
]
Jim Witschey commented on CASSANDRA-11437:
--
Sorry for the delay, and thank you for the ping. I'm +1, looks great. I ran it
locally and on a parameterized job here:
http://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/67/
> Make number of cores used for copy tasks visible
>
>
> Key: CASSANDRA-11437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11437
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Stefania
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
>
> As per this conversation with [~Stefania]:
> https://github.com/riptano/cassandra-dtest/pull/869#issuecomment-200597829
> we don't currently have a way to verify that the test environment variable
> {{CQLSH_COPY_TEST_NUM_CORES}} actually affects the behavior of {{COPY}} in
> the intended way. If this were added, we could make our tests of the one-core
> edge case a little stricter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11437) Make number of cores used for copy tasks visible
[
https://issues.apache.org/jira/browse/CASSANDRA-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238351#comment-15238351
]
Stefania commented on CASSANDRA-11437:
--
[~mambocab], gentle ping to make sure this hasn't gone unnoticed. The dtest
patch was reviewed, the C* patch still needs review, it consists of 2
{{printdebug}} calls that enable detecting the number of cores in the tests.
> Make number of cores used for copy tasks visible
>
>
> Key: CASSANDRA-11437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11437
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
>Reporter: Jim Witschey
>Assignee: Stefania
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
>
> As per this conversation with [~Stefania]:
> https://github.com/riptano/cassandra-dtest/pull/869#issuecomment-200597829
> we don't currently have a way to verify that the test environment variable
> {{CQLSH_COPY_TEST_NUM_CORES}} actually affects the behavior of {{COPY}} in
> the intended way. If this were added, we could make our tests of the one-core
> edge case a little stricter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11437) Make number of cores used for copy tasks visible
[
https://issues.apache.org/jira/browse/CASSANDRA-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229584#comment-15229584
]
Stefania commented on CASSANDRA-11437:
--
Here is the C* patch for trunk:
|[patch|https://github.com/stef1927/cassandra/commits/11437]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11437-dtest/]|
Here is the dtest pull request:
https://github.com/riptano/cassandra-dtest/pull/917
[~mambocab] would you like to be the reviewer?
> Make number of cores used for copy tasks visible
>
>
> Key: CASSANDRA-11437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11437
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Jim Witschey
>Assignee: Stefania
>Priority: Minor
> Labels: lhf
>
> As per this conversation with [~Stefania]:
> https://github.com/riptano/cassandra-dtest/pull/869#issuecomment-200597829
> we don't currently have a way to verify that the test environment variable
> {{CQLSH_COPY_TEST_NUM_CORES}} actually affects the behavior of {{COPY}} in
> the intended way. If this were added, we could make our tests of the one-core
> edge case a little stricter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11437) Make number of cores used for copy tasks visible
[
https://issues.apache.org/jira/browse/CASSANDRA-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215243#comment-15215243
]
Stefania commented on CASSANDRA-11437:
--
Let's fix this after CASSANDRA-11320 is committed, a static {{printdebug()}}
method would be really handy and 11320 introduces it.
> Make number of cores used for copy tasks visible
>
>
> Key: CASSANDRA-11437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11437
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Stefania
>Priority: Minor
>
> As per this conversation with [~Stefania]:
> https://github.com/riptano/cassandra-dtest/pull/869#issuecomment-200597829
> we don't currently have a way to verify that the test environment variable
> {{CQLSH_COPY_TEST_NUM_CORES}} actually affects the behavior of {{COPY}} in
> the intended way. If this were added, we could make our tests of the one-core
> edge case a little stricter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
