[jira] [Commented] (CASSANDRA-13759) remove collection creating on normal pending repair check

2017-08-13 Thread Dave Brosius (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124829#comment-16124829
 ] 

Dave Brosius commented on CASSANDRA-13759:
--

Ah yeah, fooled myself. This is no good... Closing

> remove collection creating on normal pending repair check
> -
>
> Key: CASSANDRA-13759
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13759
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dave Brosius
>Assignee: Dave Brosius
>Priority: Trivial
> Fix For: 4.x
>
> Attachments: 13759.txt
>
>
> in normal case where there's only 1 sstable for repair, don't build id 
> collection just used for error logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-13759) remove collection creating on normal pending repair check

2017-08-12 Thread Jeff Jirsa (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124797#comment-16124797
 ] 

Jeff Jirsa commented on CASSANDRA-13759:


I suspect you've dropped the {{if}} clause that checks for multiple ids among 
the set of sstables, and I'm not sure we need to use a {{Set}} at all here. 
Will push up a proposed change in the morning when I'm at a real laptop.

> remove collection creating on normal pending repair check
> -
>
> Key: CASSANDRA-13759
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13759
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dave Brosius
>Assignee: Dave Brosius
>Priority: Trivial
> Fix For: 4.x
>
> Attachments: 13759.txt
>
>
> in normal case where there's only 1 sstable for repair, don't build id 
> collection just used for error logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org