[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709688#comment-17709688 ] Josh McKenzie commented on CASSANDRA-18262: --- Created CASSANDRA-18435 to track the things that came up. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709533#comment-17709533 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - I think I see great ideas here but I believe they are off-topic for this ticket. Shall we open another one/ones and discussion thread to explore them? Now about the checkstyle, I also realized that we make it harder for people who might try just to run in their environment with non-LTS JDK versions for testing. They can try to build with ant -Djava.supported=13 jar where 13 can be substituted with other version, it is just for the sake of the example. We saw how JDK 8 and newer versions required different checkstyle versions. I guess people can hit a need of different checkstyle version between different non-LTS versions which we do not actively monitor and we do not plan to add in CI. With the currently committed patch we run checkstyle even with those non-LTS versions. At the same time we see people proactively looking into Cassandra so we can make hopefully quicker and easier the next upgrades when the next LTS version lands (example - CASSANDRA-18395) > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709527#comment-17709527 ] Josh McKenzie commented on CASSANDRA-18262: --- bq. People have just Java 11 installed globally and that's it. They are not going to switch back and forth every time. I've been doing this for a long while without issue; even have a script to switch worktrees and a local git ignored setenv.sh that gets sourced to set up the correct environment for whatever I'm working on + python env. So I guess my n=1 anecdote here is: not _everyone_ has just Java 11 installed globally and that's it. If we're the odd project out w/requirements or recommendations for running an older JDK, we can do things to make it easier for folks (automation, scripting, documentation) to minimize the disruption / lift required from them to get working on our project. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709361#comment-17709361
]
Maxim Muzafarov commented on CASSANDRA-18262:
-
[~smiklosovic]
I use the SDKMAN locally to switch between different JDKs and to run tests
locally against different JDKs. I have added the "minimally supported jdk
version" to the {{.sdkmanrc}} file in the project root. If a directory contains
the {{.sdkmanrc}} file, it will set the Java version based on the contents of
the file when the directory is checkouted (sdkman_auto_env=true is required
here).
https://sdkman.io/usage#env
Here is a feature request for IntelliJ IDEA to achieve it, I hope it will
eventually be completed:
https://youtrack.jetbrains.com/issue/IDEA-246351/Use-SDKMANs-.sdkmanrc-file-to-determine-the-Java-version-for-the-project
It is also a common practice for other projects, e.g. Spring Framework has it:
https://github.com/spring-projects/spring-framework/blob/main/.sdkmanrc
I think it might also make it easier for the Cassandra project to get the right
answer for "what is a minimally supported version".
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709337#comment-17709337 ] Brandon Williams commented on CASSANDRA-18262: -- To add some fuel to this fire, running checkstyle on both j8 and j11 in jenkins causes CASSANDRA-18423. There may be some other way around that though. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709281#comment-17709281 ] Stefan Miklosovic commented on CASSANDRA-18262: --- [~e.dimitrova] _In my opinion, instead of adding checks to accommodate that development we should tell people they should switch to JDK whatever version we are on now and this will speed the review process too._ This is just too demanding. People are developing various things. But here there is this super specific project where one just _has to_ have Java 8 installed. People have just Java 11 installed globally and that's it. They are not going to switch back and forth every time. Settings targets in ide seems to be ideal here. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709280#comment-17709280 ] Stefan Miklosovic commented on CASSANDRA-18262: --- [~mmuzaf] would it be possible to tweak idea config files so it would configure "target" to Java 8? That way, even they are in fact on Java 11, they would be targeting Java 8 so they could not use Java 11 api's even by mistake, no? File -> Project Structure -> Project -> Language Level -> 8 Or Settings -> Build, Execution, Deployment -> Project bytecode version -> 8. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709098#comment-17709098 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - bq. "Running tests or checks for jdk versions other than the minimum supported jdk version forces someone to do their development, not on that minimum version". I do not see this statement anywhere, I see: bq. one reason could be that people are developing locally against Java 11 already. when they shouldn't be developing against other versions ;-) > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709092#comment-17709092 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - bq. "Running tests or checks for jdk versions other than the minimum supported jdk version forces someone to do their development, not on that minimum version". I do not see anyone here saying that... > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708954#comment-17708954 ] Maxim Muzafarov commented on CASSANDRA-18262: - I feel something strange about the statement "Running tests or checks for jdk versions other than the minimum supported jdk version forces someone to do their development, not on that minimum version". We do JUnit tests for j11, j17 now, right? Why shouldn't we do source (or other) checks for these versions using the same logic? I would say that if we not follow these assumptions, we should remove j11,j17 from the running configuration of CI, just to avoid anyone getting confused (which is bad). The checkstyle is just the source code test, I don't think we should force it to run only on j11 if other tests also run on j11 and j17. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708941#comment-17708941
]
Josh McKenzie commented on CASSANDRA-18262:
---
bq. Why would you be developing and checking against 11 if you ship with 8 to
get to the point that you broke 8 only when you get to CI?
This is a really good point. This has kind of been nagging at me for years
without bubbling up to the surface.
Is there any reason to develop locally on any JDK other than the oldest one
supported, since we can't use new language features anyway? Is the thought that
the newer JDKs would potentially build faster or run local tests faster to
tighten the feedback loops working on code/
Currently our documentation
[link|https://cassandra.apache.org/_/development/index.html] kind of hand-waves
at the situation as being up to the individual developer:
{quote}
Prerequisites
Building Cassandra from source is the first important step in contributing to
the Apache Cassandra project. You will need to install Java (JDK 8 or 11,
depending on which version you want to build Cassandra against, best is to
install both and then switch between them when needed), Git, and Ant (including
ant-optional).
{quote}
It seems to me that we could have stronger verbiage along the lines of "We
recommend you build and run locally on the oldest supported JDK version X as
newer language features cannot be supported due to compilation requirements."
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708885#comment-17708885 ] Stefan Miklosovic commented on CASSANDRA-18262: --- I yet have to see folks using Java 11 APIs. I do not think we are actively encouraging them. The only case when Java 11 API was used was the usage of String.isBlank(). I have never seen any other usages of Java 11 and I think that it is more or less given that it has to eventually compile to Java 8. People are probably just used to take shortcuts like this out of convenience. That is something different from them using what Java 11 has to offer when it comes to its new apis. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708878#comment-17708878
]
Ekaterina Dimitrova commented on CASSANDRA-18262:
-
{quote}bq. Checkstyle run on Java 11 detects issues in the code regardless of
Java version and it does not have to have anything in common with Java 8.
{quote}
valid point, yes, but we should not encourage development on newer versions as
you mentioned before. It is one thing to proactively test, it is another to
move to development on newer versions and slow down development
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708871#comment-17708871 ] Stefan Miklosovic commented on CASSANDRA-18262: --- _so if they develop against 11 you will never get 8 compilation issues?_ We definitely minimize the number of issues they might get. Checkstyle run on Java 11 detects issues in the code regardless of Java version and it does not have to have anything in common with Java 8. Illegal imports will be illegal if one is on Java 8 or Java 11, no? As I mentioned, the only thing it would not detect is them using API which are not in Java 8 but that is the problem which exists anyway and is not solvable, currently, by checkstyle as such. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708869#comment-17708869
]
Ekaterina Dimitrova commented on CASSANDRA-18262:
-
{quote}My take is that it is better to have backlog full of checkstyle-valid
patches waiting to be reviewed rather than smaller amount of patches
potentially containing compilation issues in them.
{quote}
so if they develop against 11 you will never get 8 compilation issues?:)
I think we are running in circles here. I made a point that was actually
decided long ago. Let’s agree to disagree. I will be happy with a ML dev thread
as[~jmckenzie] already suggested to change the current agreements
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708864#comment-17708864 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - Bq. That is reasonable because we are not supporting Java 17 officially yet. If we officially support Java 11 (right?), why would we restrict them to develop on it with one caveat that it has to compile to Java 8. But having checkstyle triggered on 11 seems like totally innocent thing. Because we agreed on incrementally adding JDK versions and people who are working to fix 11 builds running on 17 will have to figure out every time profile which might be even incorrect, but they don’t know as it was not reviewed:) > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708862#comment-17708862 ] Stefan Miklosovic commented on CASSANDRA-18262: --- _I do not question that. I say it is confusing if you check against JDK11 stuff to realize you broke 8 after you put the effort to check yourself against 11._ I do not think we do any difference in our checkstyle rules between Java 8 and Java 11. The checkstyle itself is "version agnostic". It is more about what Java that checkstyle is triggered on. _Isn’t it demotivating people to wait months for their work to be reviewed?_ My take is that it is better to have backlog full of checkstyle-valid patches waiting to be reviewed rather than smaller amount of patches potentially containing compilation issues in them. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708860#comment-17708860 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - By the way we can probably just use the flag for no-checkstyle for builds other than the one we deliver in CI and leave locally checkstyle to be run with all builds? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708856#comment-17708856
]
Ekaterina Dimitrova commented on CASSANDRA-18262:
-
{quote}bq. They would love to offer valid code before asking somebody to
review, definitely
{quote}
I do not question that. I say it is confusing if you check against JDK11 stuff
to realize you broke 8 after you put the effort to check yourself against 11.
{quote}bq. do not get why having too many patches in backlog is necessarily bad
thing.
{quote}
Isn’t it better to have too many patches committed?:) Isn’t it demotivating
people to wait months for their work to be reviewed?
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708853#comment-17708853 ] Stefan Miklosovic commented on CASSANDRA-18262: --- _I think we have too much Patch Available backlog to encourage people to develop and submit patches on other versions, to find out things need to be reworked only with CI and reviews. _ This might be resolved just by enabling checkstyle while they are on Java 11? I do not get why having too many patches in backlog is necessarily bad thing. _Honestly, considering the build goes from 1 minute to 3 from what I see in the comments, I fear most people probably even use the option to skip checkstyle many times locally_ But that is entirely on them. My perception is different. They would love to offer valid code before asking somebody to review, definitely. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708848#comment-17708848 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - By the way I had similar discussion with[~mck] around adding intellij idea target for JDK17 and I was told we should not encourage development against other versions. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708844#comment-17708844 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - People might be developing against Java 19 in their forks, but IMHO we should focus on what Cassandra is delivered on. I think we have too much Patch Available backlog to encourage people to develop and submit patches on other versions, to find out things need to be reworked only with CI and reviews. Honestly, considering the build goes from 1 minute to 3 from what I see in the comments, I fear most people probably even use the option to skip checkstyle many times locally > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708835#comment-17708835 ] Stefan Miklosovic commented on CASSANDRA-18262: --- one reason could be that people are developing locally against Java 11 already. Then they ask a committer to build a CI for them and then we realize that it does not work. Like here https://github.com/apache/cassandra/pull/2253/commits/db57b0c5e38b232b59bc72ddbb2b1a0933b87459 Talking to him privately, he was developing on Java 11 so checkstyle was not triggered. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708831#comment-17708831 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - Why would you be developing and checking against 11 if you ship with 8 to get to the point that you broke 8 only when you get to CI? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708820#comment-17708820
]
Josh McKenzie commented on CASSANDRA-18262:
---
{quote}it was decided(not by me) that we run it with the lowest version that we
release our builds with and we skip with the later ones.
{quote}
... when was this? I can see the argument for it (shouldn't be different
between any of the branches and _was_ somewhat slow), but Maxim's point
resonates with me:
{quote}Instead of tying the code-checking tool to a specific version, we should
make it work for every jdk we support. This has its advantages: you can run
checkstyle locally and check the sources without switching jdks
{quote}
Working on another JDK locally and not realizing it's not linting is a pretty
subtle and annoying thing IMO. I'm +1 to it running on all branches if it's
what, the 30 seconds per branch on formal builds to validate?
Maybe worth bringing to the dev list to get a quick consensus check and/or ping
[~mck] and [~brandon.williams] since they've both been maintaining build stuff
recently.
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708601#comment-17708601 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - bq. Ekaterina Dimitrova, If I have been able to allay your concerns, we can update the title of the issue to reflect exactly what we have done. You are reading my mind, I noticed we also discuss still eclipse-warnings in the description, the ticket definitely can be updated to reflect its latest goals. We do that very often. Thank you :-) > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708600#comment-17708600 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - bq. As I understand your concerns, you are talking about removing the "if="java.version.8", rather than replacing it with "if="java.version.11", right? Correct Your table is correct, but it was decided(not by me) that we run it with the lowest version that we release our builds with and we skip with the later ones. So in this case it will be j11 - checks perform and j17 - skipped. As the code should be J11 compatible I do not think this is a problem and this was a way to reduce the builds time and de-duplicate the work? When we switch to J17 being our build - this is where we will run it, yes. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708595#comment-17708595 ] Maxim Muzafarov commented on CASSANDRA-18262: - [~e.dimitrova], If I have been able to allay your concerns, we can update the title of the issue to reflect exactly what we have done. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708590#comment-17708590
]
Maxim Muzafarov commented on CASSANDRA-18262:
-
As I understand your concerns, you are talking about removing the
{_}"if="java.version.8"{_}, rather than replacing it with
{_}"if="java.version.11"{_}, right?
The problem with the code checking tool is that it only does its checks for j8
(as it was before the patch), we want to switch to j11 and say "From now on,
the minimum version required for Cassandra is j11" but the checkstyle was
skipped for j11. If we will do the same kind of switch to j17, we will face the
same, so the problem itself doesn't go away in our case.
Instead of tying the code-checking tool to a specific version, we should make
it work for every jdk we support. This has its advantages: you can run
checkstyle locally and check the sources without switching jdks, we won't face
this problem in the future, and the patch doesn't prevent us from removing j8.
In summary, removing the _"if="java.version.8"_ condition from the ant task
seems to be the right thing to do.
So, the checkstyle:
|| ||before the patch||after the patch||
|j8|checks perform|checks perform|
|j11|skipped|checks perform|
|j17|skipped|checks perform|
If we drop j8 here, everything will still work.
Am I missing something?
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708558#comment-17708558 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - Actually I am wondering whether we do not want to switch back to 8 and when the time to drop 8 comes(CASSANDRA-18255), we switch to 11 but otherwise what was done in preparation for that switch stands. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708549#comment-17708549 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - bq. What is the reason for running checkstyle only for j11? This is in preparation to drop JDK8 support and start delivering cassandra JDK11 builds which can run with 11 and 17. I figured the issue. bq. > the last one Wrong link, look here - https://github.com/apache/cassandra/commit/e98258a132d6d27c8431e6971693a224953fdd89 The check For JDK version was removed, instead of checking we are on 11. Patch here - https://github.com/ekaterinadimitrova2/cassandra/commit/cd3be5421d3d631f8b76ec1f0ab86e4c418db5fd Can you, please, check it? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708524#comment-17708524 ] Maxim Muzafarov commented on CASSANDRA-18262: - I have checked the commits you mentioned and it seems it's everything looks correct [first|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2] > [second|https://github.com/apache/cassandra/commit/7ad746cc839199ac9b8d7ba9a6f2b2f980ea3461] > [the last one|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2] I could be wrong, we should be able to run checkstyle locally regardless of the jdk version used, right? So, I'm able to build the project locally with all the jdk versions we support, and the sources are also checked with an appropriate checkstyle (the version of the library is automatically selected, leaving the configuration the same as it is backwards compatible). If we are going to remove j8, so no changes are required in the checkstyle part to be taken. What is the reason for running checkstyle only for j11? I can't catch the idea of it. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708510#comment-17708510 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - My bad, checkstyle actually runs with all JDKs as [~mmuzaf]' s patch was rebased on top of the initial patch, not the one committed [here|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2] We should change that. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708509#comment-17708509 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - Thank you for the quick response! Yes, you can enable it to work with any of the JDKs, but when you run ant jar checkstyle is currently triggered always only with JDK8. So yes, CI will run it only with JDK8, the idea of this ticket was to switch checkstyle and eclipse-warnings (that one was left to another ticket due to complications) to run in CI with JDK11 in preparation to drop JDK8. Looking back, I think I see where the confusion came from. The initial patch [~brandon.williams] has posted [here|https://github.com/driftx/cassandra/commit/8b2c533beb9d3205052c2a7bb4df4c44a580bc61] was enabling the checkstyle run with all JDK versions in CI and he changed that to only 11 pre-commit as per our agreement. The switch happened [here|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2] but it got reverted [here|https://github.com/apache/cassandra/commit/7ad746cc839199ac9b8d7ba9a6f2b2f980ea3461] > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708507#comment-17708507 ] Maxim Muzafarov commented on CASSANDRA-18262: - [~e.dimitrova] Hello, the checkstyle work for j8 and j11 (j17) depending on which jdk the source code gets compiled, hence no switch is required in sources, I guess. Did you mean we should switch it on Jenkins jobs or CircleCI? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708493#comment-17708493 ] Ekaterina Dimitrova commented on CASSANDRA-18262: - Thanks for all the investigations and work [~mmuzaf]. Just to confirm, this upgraded the versions but the patch didn't actually switch to running checkstyle only with 11, instead of 8 when we do ant jar? https://github.com/apache/cassandra/pull/2249/files#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021R315 Do we plan to do the switch in a different ticket as this one was closed? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706522#comment-17706522 ] Stefan Miklosovic commented on CASSANDRA-18262: --- +1 > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706433#comment-17706433 ] Brandon Williams commented on CASSANDRA-18262: -- The latest looks good to me, I'm +1. [~smiklosovic] are you? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706361#comment-17706361 ] Brandon Williams commented on CASSANDRA-18262: -- Ah, thanks for the investigation, Maxim! Switched j8 to 8.45.1 and started circle [here|https://app.circleci.com/pipelines/github/driftx/cassandra/936/workflows/ef89c19c-09ff-472b-a639-8535d690cfb5]. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706362#comment-17706362 ] Maxim Muzafarov commented on CASSANDRA-18262: - I have updated the PR: https://github.com/apache/cassandra/pull/2249/files Build for j11 + checkstyle 10.8.1 - Total time: 3 minutes 0 seconds https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/122/workflows/7a4c0d73-4e06-4712-9406-16913af0a3bc/jobs/4579/parallel-runs/0/steps/0-103 Build for j8 + checkstyle 8.45.1 - Total time: 3 minutes 36 seconds https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/122/workflows/806289bd-954c-4282-837f-966d6ea9faf1/jobs/4578/parallel-runs/0/steps/0-103 > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706358#comment-17706358 ] Stefan Miklosovic commented on CASSANDRA-18262: --- That sounds reasonable. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706354#comment-17706354 ] Maxim Muzafarov commented on CASSANDRA-18262: - I have checked versions 9.0, and 9.3 and they fail to build Cassandra on CircleCI with OutOfMemory (the build runs with 2CPU, 4Gb RAM) with limited resources. I have also found that it is related to the checkstyle itself, for instance, the following was fixed in 9.3 (but not all of OOMs): [https://github.com/checkstyle/checkstyle/issues/10934] I have tested 8.45.1 for j8, and it passes: [https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/120/workflows/b0de5483-5e6f-4d21-88db-b34241584048/jobs/4395] Considering the fact we are moving away from j8, I suggest using 8.45.1 for j8 and 10.8.1 for j11, and j17. This will give us a chance to move forward. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706349#comment-17706349 ] Brandon Williams commented on CASSANDRA-18262: -- You can see how much circle has in the 'log environment information' step, looks like ~68G. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706346#comment-17706346 ] Stefan Miklosovic commented on CASSANDRA-18262: --- Maybe Jenkins / or computers have more RAM available so it does not show in Circle where container has less? Dunno ... > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706341#comment-17706341 ] Brandon Williams commented on CASSANDRA-18262: -- I see, I thought you meant locally. So the weirdness is localized to circle...hmm. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706338#comment-17706338 ] Stefan Miklosovic commented on CASSANDRA-18262: --- It is in the links. ~3 mins vs ~5. It really fails with 9.3 instead of 8.x. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706303#comment-17706303 ] Brandon Williams commented on CASSANDRA-18262: -- bq. Maybe mere bumping to checkstyle version 9.x causes this? This must be a circle-ism though, it works fine for me locally and on jenkins. bq. Also, the build with the bump is significantly slower than without. This is weird, can you show us? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706232#comment-17706232 ] Stefan Miklosovic commented on CASSANDRA-18262: --- The patch looks good but I do not think that the error in Circle will go away anytime soon. I am getting same error https://app.circleci.com/pipelines/github/instaclustr/cassandra/2039/workflows/bd8fd40e-e623-4c28-a9a2-a34bcdb237f9/jobs/17730 > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706166#comment-17706166
]
Maxim Muzafarov commented on CASSANDRA-18262:
-
I have tested locally with j17:
{code:bash}
maxmuzaf@Maxims-MBP cassandra % sdk current java
Using java version 17.0.6-zulu{code}
{code:bash}
maxmuzaf@Maxims-MBP cassandra % ant realclean && ant artifacts
...
init-checkstyle:
[echo] checkstyle.version=10.8.1
checkstyle:
[checkstyle] Running Checkstyle 10.8.1 on 2201 files
build:
...
checkstyle-test:
[checkstyle] Running Checkstyle 10.8.1 on 1547 files
build-test:
[echo] Non default JDK version used: 17
...
BUILD SUCCESSFUL
Total time: 1 minute 42 seconds
{code}
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706134#comment-17706134 ] Brandon Williams commented on CASSANDRA-18262: -- +1 from me. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706132#comment-17706132 ] Maxim Muzafarov commented on CASSANDRA-18262: - Here is the build on Jenkins: https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2394/ ||jdk||cassandra-18262||trunk|| |jdk_1.8_latest|2 minutes 24 seconds|5 minutes 22 seconds| |jdk_1.8_latest,cassandra-arm64|3 minutes 55 seconds|6 minutes 57 seconds| |jdk_11_latest,cassandra|5 minutes 48 seconds|2 minutes 24 seconds (checkstyle skipped)| |jdk_11_latest,cassandra-arm64|4 minutes 25 seconds|2 minutes 39 seconds (checkstyle skipped)| > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706096#comment-17706096 ] Brandon Williams commented on CASSANDRA-18262: -- I noticed it too and have retried a couple times with no luck, circle seems to be having issues today, I'm confident this patch is good. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706095#comment-17706095
]
Maxim Muzafarov commented on CASSANDRA-18262:
-
I have noticed that for j8 the build has failed with an error below, however,
the checkstyle seems to be passed.
{code}
checkstyle-test:
[checkstyle] Running Checkstyle 9.3 on 1547 files
build-test:
_build-test:
[javac] Compiling 1546 source files to
/home/cassandra/cassandra/build/test/classes
[javac] Note: Processing compiler hints annotations
[javac] Note: Processing compiler hints annotations
[javac] Note: Processing compiler hints annotations
[javac] Note: Writing compiler command file at META-INF/hotspot_compiler
[javac] Note: Done processing compiler hints annotations
[javac]
[javac]
[javac] The system is out of resources.
[javac] Consult the following stack trace for details.
[javac] java.lang.OutOfMemoryError: GC overhead limit exceeded
[javac] at com.sun.tools.javac.util.Name.append(Name.java:88)
[javac] at
com.sun.tools.javac.code.Symbol$TypeSymbol.formFullName(Symbol.java:687)
[javac] at
com.sun.tools.javac.code.Symbol$ClassSymbol.(Symbol.java:950)
BUILD FAILED
/home/cassandra/cassandra/build.xml:1002: The following error occurred while
executing this line:
/home/cassandra/cassandra/build.xml:1015: Error starting modern compiler
Total time: 4 minutes 12 seconds
{code}
> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706023#comment-17706023 ] Brandon Williams commented on CASSANDRA-18262: -- This looks good, and has dropped checkstyle-test time to 30s on both j8 and j11 for me. Maybe we should consider upgrading checkstyle to 9.3 in the other branches in another ticket. Here's a CI run: ||Branch||CI|| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18262-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/935/workflows/4fb67fee-7b3d-4a5b-9ea2-36e610405346], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/935/workflows/32191ea8-c700-45d8-8bca-7902b126e02b]| > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706012#comment-17706012 ] Maxim Muzafarov commented on CASSANDRA-18262: - [~brandon.williams] I just thought that switching for different JDKs require tiny management of the classpath, so it might be good to consider different checkstyle versions for each jdk to check the project. I have prepared changes here: https://github.com/apache/cassandra/pull/2249/files I've tested it locally with jdk8 and jdk 11, and it seems to work, but I'm not sure if it's still OK to do it this way. This way there is no need to block this issue and wait for the JDK 8 removal. Can you take I look? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700383#comment-17700383 ] Brandon Williams commented on CASSANDRA-18262: -- bq. upgraded checkstyle to 10.8.1 That's what I did above, which depends on the JDK8 drop. > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700375#comment-17700375 ] Josh McKenzie commented on CASSANDRA-18262: --- bq. I noticed checkstyle added testing for JDK17 only in v9.3 we are still on 8 series. Should we upgrade it? If we're already working on adding support for new JDK's, for something doing static analysis what's our downside of updating to the latest while we're here (pending the JDK8 drop of course)? > Switch checkstyle running only with JDK8 to be run with JDK11 > - > > Key: CASSANDRA-18262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18262 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0 > > > Currently we run checkstyle, eclipse warnings (and probably anything else?) > only with JDK8. > In preparation to remove JDK8 we need to switch those to run with JDK11. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
