[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708105#comment-17708105 ] Josh McKenzie commented on CASSANDRA-18332: --- Committed. Thanks for the review and assist on CI [~smiklosovic] [cassandra-4.0 commit|https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=f6fce7ab51e41dfd8d9584ce4c8dd35e0ed61598] [cassandra-4.1 merge|https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=085765a07c9eb87e05a700ba4395c9df672a60c1] [trunk merge|https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=e96c20e8150fd81716d203aa40301c09db0bc04a] > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.9, 5.0, 4.1.2 > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708008#comment-17708008 ] Brandon Williams commented on CASSANDRA-18332: -- bq. if it's got issues I'll go ahead and create a JIRA for it. That's CASSANDRA-18366 > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708005#comment-17708005 ] Stefan Miklosovic commented on CASSANDRA-18332: --- [~jmckenzie] I have added build for 4.1 as well. I think these are all already-known flakes. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707593#comment-17707593 ] Josh McKenzie commented on CASSANDRA-18332: --- bq. If I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? Correct. The logging level change is material and the other is more or less just trivial hygiene. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707506#comment-17707506 ] Stefan Miklosovic commented on CASSANDRA-18332: --- 4.0 j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/80d2d0e8-6253-43af-b90f-d75c8cb05726 4.0 j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2044/workflows/0b2d215a-8de2-4f69-8b67-314a0eb04bc4 > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707379#comment-17707379 ] Stefan Miklosovic commented on CASSANDRA-18332: --- As I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706113#comment-17706113 ] Josh McKenzie commented on CASSANDRA-18332: --- Oof; I should have double checked that instead of just assuming. Kicked off workflows again; I'll circle back once I get a cleaner more representative run. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705662#comment-17705662 ] Stefan Miklosovic commented on CASSANDRA-18332: --- Ah this is literally the same thing as I looked closer :D +1 but CI looks quite flaky / errorneous. Are we happy? > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705659#comment-17705659 ] Josh McKenzie commented on CASSANDRA-18332: --- You _are_ a committer you know, [~smiklosovic]. Just need that +1 from someone who knows what they're doing in this space and is a committer, and I think you fit the bill. :D > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705482#comment-17705482 ] Stefan Miklosovic commented on CASSANDRA-18332: --- It would be awesome if this ended up in 4.0.9. We should release it pretty soon. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700765#comment-17700765 ] Josh McKenzie commented on CASSANDRA-18332: --- ||Item|Link| |PR|[link|https://github.com/apache/cassandra/pull/2219]| |JDK8 CI|[link|https://app.circleci.com/pipelines/github/jmckenzie-dev/cassandra/334/workflows/4aad53f0-a6e6-407b-ace3-668b5f0db512]| |JDK11 CI|[link|https://app.circleci.com/pipelines/github/jmckenzie-dev/cassandra/334/workflows/dfc6f82d-18d0-45cb-8a98-a982a0259da0]| [~benedict] - almost identical to the 4.1+ patch (CASSANDRA-17205) with the following 2 changes: 1) Ordering on constructor of checking for illegal state on {{parentRef}} to immediately after acquisition rather than after initializing the {{Counter}} potentially unnecessarily 2) Up log level from {{warn}} to {{error}} on {{StrongLeakDetector.run}} Any chance you have a few minutes to glance over it on review? I'll pull it forward with just the logging changes on merge up; since it's a 1 token log level change I'm not too concerned about re-running CI for that if you're good with it. > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org