[jira] [Commented] (CASSANDRA-18627) Fix calculation of pending compactions in pending repair manager
[
https://issues.apache.org/jira/browse/CASSANDRA-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737322#comment-17737322
]
Josh McKenzie commented on CASSANDRA-18627:
---
Hm. To anyone wandering past and curious, I'm not convinced this actually
_fixes_ anything since the only call sites in the {{PendingRepairManager}}
actually don't pass in any additional sstables or bytes (just 0), so the
compaction strategies don't have any estimated extra sstables or bytes to
calculate anything from. I'll need to dig a bit into where those values make
their way into this scope to then be passed on to compaction to determine where
and why they're vestigial in this way.
> Fix calculation of pending compactions in pending repair manager
>
>
> Key: CASSANDRA-18627
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18627
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair, Local/Compaction
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 5.x
>
>
> In CASSANDRA-17931, we failed to correctly take into account the
> additionalSSTables and additionalBytes passed in in one of our calls to
> {code}PendingRepairManager.getEstimatedRemainingTasks{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18627) Fix calculation of pending compactions in pending repair manager
[
https://issues.apache.org/jira/browse/CASSANDRA-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737310#comment-17737310
]
Josh McKenzie commented on CASSANDRA-18627:
---
||Item|Link||
|PR|[link|https://github.com/apache/cassandra/pull/2450]|
|JDK8
CI|[link|https://app.circleci.com/pipelines/github/jmckenzie-dev/cassandra/337/workflows/4a26c29b-dca6-4b14-bc7c-8b7c9977a977]|
|JDK11
CI|[link|https://app.circleci.com/pipelines/github/jmckenzie-dev/cassandra/337/workflows/2eb8052f-4f63-4099-a96c-e19fafe6634b]|
> Fix calculation of pending compactions in pending repair manager
>
>
> Key: CASSANDRA-18627
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18627
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair, Local/Compaction
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
>
> In CASSANDRA-17931, we failed to correctly take into account the
> additionalSSTables and additionalBytes passed in in one of our calls to
> {code}PendingRepairManager.getEstimatedRemainingTasks{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
