[jira] [Updated] (CASSANDRA-13340) Bugs handling range tombstones in the sstable iterators
[ https://issues.apache.org/jira/browse/CASSANDRA-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-13340: - Resolution: Fixed Fix Version/s: (was: 3.11.x) (was: 3.0.x) 3.11.0 3.0.13 Status: Resolved (was: Ready to Commit) Committed (with nits fixed), thanks. > Bugs handling range tombstones in the sstable iterators > --- > > Key: CASSANDRA-13340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13340 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Critical > Fix For: 3.0.13, 3.11.0 > > > There is 2 bugs in the way sstable iterators handle range tombstones: > # empty range tombstones can be returned due to a strict comparison that > shouldn't be. > # the sstable reversed iterator can actually return completely bogus results > when range tombstones are spanning multiple index blocks. > The 2 bugs are admittedly separate but as they both impact the same area of > code and are both range tombstones related, I suggest just fixing both here > (unless something really really mind). > Marking the ticket critical mostly for the 2nd bug: it can truly make use > return bad results on reverse queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13340) Bugs handling range tombstones in the sstable iterators
[ https://issues.apache.org/jira/browse/CASSANDRA-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov updated CASSANDRA-13340: Status: Ready to Commit (was: Patch Available) > Bugs handling range tombstones in the sstable iterators > --- > > Key: CASSANDRA-13340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13340 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Critical > Fix For: 3.0.x, 3.11.x > > > There is 2 bugs in the way sstable iterators handle range tombstones: > # empty range tombstones can be returned due to a strict comparison that > shouldn't be. > # the sstable reversed iterator can actually return completely bogus results > when range tombstones are spanning multiple index blocks. > The 2 bugs are admittedly separate but as they both impact the same area of > code and are both range tombstones related, I suggest just fixing both here > (unless something really really mind). > Marking the ticket critical mostly for the 2nd bug: it can truly make use > return bad results on reverse queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13340) Bugs handling range tombstones in the sstable iterators
[ https://issues.apache.org/jira/browse/CASSANDRA-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua McKenzie updated CASSANDRA-13340: Reviewer: Branimir Lambov > Bugs handling range tombstones in the sstable iterators > --- > > Key: CASSANDRA-13340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13340 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Critical > Fix For: 3.0.x, 3.11.x > > > There is 2 bugs in the way sstable iterators handle range tombstones: > # empty range tombstones can be returned due to a strict comparison that > shouldn't be. > # the sstable reversed iterator can actually return completely bogus results > when range tombstones are spanning multiple index blocks. > The 2 bugs are admittedly separate but as they both impact the same area of > code and are both range tombstones related, I suggest just fixing both here > (unless something really really mind). > Marking the ticket critical mostly for the 2nd bug: it can truly make use > return bad results on reverse queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13340) Bugs handling range tombstones in the sstable iterators
[ https://issues.apache.org/jira/browse/CASSANDRA-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-13340: - Status: Patch Available (was: Open) Attaching fix for both issue with unit test below. I tried to explain the problems it solves and how it solves it in the patches. | [13340-3.0|https://github.com/pcmanus/cassandra/commits/13340-3.0] | [utests|http://cassci.datastax.com/job/pcmanus-13340-3.0-testall] | [dtests|http://cassci.datastax.com/job/pcmanus-13340-3.0-dtest] | | [13340-3.11|https://github.com/pcmanus/cassandra/commits/13340-3.11] | [utests|http://cassci.datastax.com/job/pcmanus-13340-3.11-testall] | [dtests|http://cassci.datastax.com/job/pcmanus-13340-3.11-dtest] | > Bugs handling range tombstones in the sstable iterators > --- > > Key: CASSANDRA-13340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13340 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Critical > Fix For: 3.0.x, 3.11.x > > > There is 2 bugs in the way sstable iterators handle range tombstones: > # empty range tombstones can be returned due to a strict comparison that > shouldn't be. > # the sstable reversed iterator can actually return completely bogus results > when range tombstones are spanning multiple index blocks. > The 2 bugs are admittedly separate but as they both impact the same area of > code and are both range tombstones related, I suggest just fixing both here > (unless something really really mind). > Marking the ticket critical mostly for the 2nd bug: it can truly make use > return bad results on reverse queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346)